o2system / database

src/Sql/Abstracts/AbstractQueryBuilder.php

Spacing +89 added lines, -89 removed lines

@@ -100,7 +100,7 @@ 
      */

     public function __construct(AbstractConnection &$conn)

     {

-        $this->conn =& $conn;

+        $this->conn = & $conn;

         $this->builderCache = new Query\BuilderCache();

         $this->cacheMode = $this->conn->getConfig('cacheEnable');

     }

@@ -281,7 +281,7 @@ 
         $alias = empty($alias)

             ? strtolower($type) . '_' . $field

             : $alias;

-        $sqlStatement = sprintf($SqlAggregateFunctions[ $type ], $field)

+        $sqlStatement = sprintf($SqlAggregateFunctions[$type], $field)

             . ' AS '

             . $this->conn->escapeIdentifiers($alias);

 

@@ -336,11 +336,11 @@ 
 

                         for ($i = 0; $i < $countFieldAlias; $i++) {

                             if ($i == 0) {

-                                $fieldAlias[ $i ] = $fieldAlias[ $i ] . "'+";

+                                $fieldAlias[$i] = $fieldAlias[$i] . "'+";

                             } elseif ($i == ($countFieldAlias - 1)) {

-                                $fieldAlias[ $i ] = "'+" . $fieldAlias[ $i ];

+                                $fieldAlias[$i] = "'+" . $fieldAlias[$i];

                             } else {

-                                $fieldAlias[ $i ] = "'+" . $fieldAlias[ $i ] . "'+";

+                                $fieldAlias[$i] = "'+" . $fieldAlias[$i] . "'+";

                             }

                         }

 

@@ -492,7 +492,7 @@ 
 

         $this->select(

             sprintf(

-                $SqlScalarFunctions[ $type ],

+                $SqlScalarFunctions[$type],

                 $field,

                 $this->conn->escapeIdentifiers($alias)

             )

@@ -697,7 +697,7 @@ 
 

             if (is_array($field)) {

                 $fieldName = key($field);

-                $fieldAlias = $field[ $fieldName ];

+                $fieldAlias = $field[$fieldName];

             } elseif (strpos($field, ' AS ') !== false) {

                 $xField = explode(' AS ', $field);

                 $xField = array_map('trim', $xField);

@@ -904,7 +904,7 @@ 
     public function dateDiff(array $fields, $alias)

     {

         $dateTimeStart = key($fields);

-        $dateTimeEnd = $fields[ $dateTimeStart ];

+        $dateTimeEnd = $fields[$dateTimeStart];

 

         if (preg_match("/^[0-9]{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2][0-9]|3[0-1])$/", $dateTimeStart)) {

             $dateTimeStart = $this->conn->escape($dateTimeStart);

@@ -1098,14 +1098,14 @@ 
             // Split multiple conditions

             if (preg_match_all('/\sAND\s|\sOR\s/i', $condition, $joints, PREG_OFFSET_CAPTURE)) {

                 $conditions = [];

-                $joints = $joints[ 0 ];

+                $joints = $joints[0];

                 array_unshift($joints, ['', 0]);

 

                 for ($i = count($joints) - 1, $pos = strlen($condition); $i >= 0; $i--) {

-                    $joints[ $i ][ 1 ] += strlen($joints[ $i ][ 0 ]); // offset

-                    $conditions[ $i ] = substr($condition, $joints[ $i ][ 1 ], $pos - $joints[ $i ][ 1 ]);

-                    $pos = $joints[ $i ][ 1 ] - strlen($joints[ $i ][ 0 ]);

-                    $joints[ $i ] = $joints[ $i ][ 0 ];

+                    $joints[$i][1] += strlen($joints[$i][0]); // offset

+                    $conditions[$i] = substr($condition, $joints[$i][1], $pos - $joints[$i][1]);

+                    $pos = $joints[$i][1] - strlen($joints[$i][0]);

+                    $joints[$i] = $joints[$i][0];

                 }

             } else {

                 $conditions = [$condition];

@@ -1114,17 +1114,17 @@ 
 

             $condition = ' ON ';

             for ($i = 0, $c = count($conditions); $i < $c; $i++) {

-                $operator = $this->getOperator($conditions[ $i ]);

-                $condition .= $joints[ $i ];

+                $operator = $this->getOperator($conditions[$i]);

+                $condition .= $joints[$i];

                 $condition .= preg_match(

                     "/(\(*)?([\[\]\w\.'-]+)" . preg_quote($operator) . "(.*)/i",

-                    $conditions[ $i ],

+                    $conditions[$i],

                     $match

                 )

-                    ? $match[ 1 ] . $this->conn->protectIdentifiers(

-                        $match[ 2 ]

-                    ) . $operator . $this->conn->protectIdentifiers($match[ 3 ])

-                    : $conditions[ $i ];

+                    ? $match[1] . $this->conn->protectIdentifiers(

+                        $match[2]

+                    ) . $operator . $this->conn->protectIdentifiers($match[3])

+                    : $conditions[$i];

             }

         }

 

@@ -1188,23 +1188,23 @@ 
                 : '';

 

             $operator = [

-                '\s*(?:<|>|!)?=\s*',             // =, <=, >=, !=

-                '\s*<>?\s*',                     // <, <>

-                '\s*>\s*',                       // >

-                '\s+IS NULL',                    // IS NULL

-                '\s+IS NOT NULL',                // IS NOT NULL

-                '\s+EXISTS\s*\(.*\)',        // EXISTS(Sql)

-                '\s+NOT EXISTS\s*\(.*\)',    // NOT EXISTS(Sql)

-                '\s+BETWEEN\s+',                 // BETWEEN value AND value

-                '\s+IN\s*\(.*\)',            // IN(list)

-                '\s+NOT IN\s*\(.*\)',        // NOT IN (list)

-                '\s+LIKE\s+\S.*(' . $likeEscapeString . ')?',    // LIKE 'expr'[ ESCAPE '%s']

+                '\s*(?:<|>|!)?=\s*', // =, <=, >=, !=

+                '\s*<>?\s*', // <, <>

+                '\s*>\s*', // >

+                '\s+IS NULL', // IS NULL

+                '\s+IS NOT NULL', // IS NOT NULL

+                '\s+EXISTS\s*\(.*\)', // EXISTS(Sql)

+                '\s+NOT EXISTS\s*\(.*\)', // NOT EXISTS(Sql)

+                '\s+BETWEEN\s+', // BETWEEN value AND value

+                '\s+IN\s*\(.*\)', // IN(list)

+                '\s+NOT IN\s*\(.*\)', // NOT IN (list)

+                '\s+LIKE\s+\S.*(' . $likeEscapeString . ')?', // LIKE 'expr'[ ESCAPE '%s']

                 '\s+NOT LIKE\s+\S.*(' . $likeEscapeString . ')?' // NOT LIKE 'expr'[ ESCAPE '%s']

             ];

         }

 

         return preg_match('/' . implode('|', $operator) . '/i', $string, $match)

-            ? $match[ 0 ]

+            ? $match[0]

             : false;

     }

 

@@ -1274,8 +1274,8 @@ 
                 $fieldName = substr(

                         $fieldName,

                         0,

-                        $match[ 0 ][ 1 ]

-                    ) . ($match[ 1 ][ 0 ] === '='

+                        $match[0][1]

+                    ) . ($match[1][0] === '='

                         ? ' IS NULL'

                         : ' IS NOT NULL');

             } elseif ($fieldValue instanceof AbstractQueryBuilder) {

@@ -1331,7 +1331,7 @@ 
     public function bind($field, $value)

     {

         if ( ! array_key_exists($field, $this->builderCache->binds)) {

-            $this->builderCache->binds[ $field ] = $value;

+            $this->builderCache->binds[$field] = $value;

 

             return $field;

         }

@@ -1342,7 +1342,7 @@ 
             ++$count;

         }

 

-        $this->builderCache->binds[ $field . '_' . $count ] = $value;

+        $this->builderCache->binds[$field . '_' . $count] = $value;

 

         return $field . '_' . $count;

     }

@@ -1875,8 +1875,8 @@ 
 

             // Do we have a seed value?

             $fields = ctype_digit((string)$fields)

-                ? sprintf($this->SqlOrderByRandomKeywords[ 1 ], $fields)

-                : $this->SqlOrderByRandomKeywords[ 0 ];

+                ? sprintf($this->SqlOrderByRandomKeywords[1], $fields)

+                : $this->SqlOrderByRandomKeywords[0];

         } elseif (empty($fields)) {

             return $this;

         } elseif ($direction !== '') {

@@ -1904,8 +1904,8 @@ 
                         PREG_OFFSET_CAPTURE

                     ))

                     ? [

-                        'field'     => ltrim(substr($fields, 0, $match[ 0 ][ 1 ])),

-                        'direction' => ' ' . $match[ 1 ][ 0 ],

+                        'field'     => ltrim(substr($fields, 0, $match[0][1])),

+                        'direction' => ' ' . $match[1][0],

                         'escape'    => true,

                     ]

                     : ['field' => trim($fields), 'direction' => $direction, 'escape' => true];

@@ -2076,13 +2076,13 @@ 
         }

 

         $numrows = 0;

-        if($result = $this->conn->query($sqlStatement, $this->builderCache->binds)) {

-            if($result->count()) {

+        if ($result = $this->conn->query($sqlStatement, $this->builderCache->binds)) {

+            if ($result->count()) {

                 $numrows = $result->first()->numrows;

             }

         }

 

-        if($reset) {

+        if ($reset) {

             $this->builderCache->reset();

         }

 

@@ -2196,13 +2196,13 @@ 
         }

 

         $numrows = 0;

-        if($result = $this->conn->query($sqlStatement, $this->builderCache->binds)) {

-            if($result->count()) {

+        if ($result = $this->conn->query($sqlStatement, $this->builderCache->binds)) {

+            if ($result->count()) {

                 $numrows = $result->first()->numrows;

             }

         }

 

-        if($reset) {

+        if ($reset) {

             $this->builderCache->reset();

         }

 

@@ -2347,7 +2347,7 @@ 
         if (count($this->builderCache->sets)) {

             $sqlStatement = $this->platformInsertStatement(

                 $this->conn->protectIdentifiers(

-                    $this->builderCache->from[ 0 ],

+                    $this->builderCache->from[0],

                     true,

                     $escape,

                     false

@@ -2396,7 +2396,7 @@ 
         foreach ($field as $key => $value) {

             if ($key === 'birthday' || $key === 'date') {

                 if (is_array($value)) {

-                    $value = $value[ 'year' ] . '-' . $value[ 'month' ] . '-' . $value[ 'date' ];

+                    $value = $value['year'] . '-' . $value['month'] . '-' . $value['date'];

                 } elseif (is_object($value)) {

                     $value = $value->year . '-' . $value->month . '-' . $value->date;

                 }

@@ -2404,9 +2404,9 @@ 
                 $value = call_user_func_array($this->arrayObjectConversionMethod, [$value]);

             }

 

-            $this->builderCache->binds[ $key ] = $value;

-            $this->builderCache->sets[ $this->conn->protectIdentifiers($key, false,

-                $escape) ] = ':' . $key;

+            $this->builderCache->binds[$key] = $value;

+            $this->builderCache->sets[$this->conn->protectIdentifiers($key, false,

+                $escape)] = ':' . $key;

         }

 

         return $this;

@@ -2433,7 +2433,7 @@ 
         foreach (get_object_vars($object) as $key => $value) {

             // There are some built in keys we need to ignore for this conversion

             if ( ! is_object($value) && ! is_array($value) && $key !== '_parent_name') {

-                $array[ $key ] = $value;

+                $array[$key] = $value;

             }

         }

 

@@ -2481,7 +2481,7 @@ 
         $affectedRows = 0;

         for ($i = 0, $total = count($sets); $i < $total; $i += $batchSize) {

             $Sql = $this->platformInsertBatchStatement(

-                $this->conn->protectIdentifiers($this->builderCache->from[ 0 ], true, $escape, false),

+                $this->conn->protectIdentifiers($this->builderCache->from[0], true, $escape, false),

                 $this->builderCache->keys,

                 array_slice($this->builderCache->sets, $i, $batchSize)

             );

@@ -2582,8 +2582,8 @@ 
             // There are some built in keys we need to ignore for this conversion

             if ($field !== '_parent_name') {

                 $i = 0;

-                foreach ($out[ $field ] as $data) {

-                    $array[ $i++ ][ $field ] = $data;

+                foreach ($out[$field] as $data) {

+                    $array[$i++][$field] = $data;

                 }

             }

         }

@@ -2628,7 +2628,7 @@ 
         if (count($this->builderCache->sets)) {

             $sqlStatement = $this->platformReplaceStatement(

                 $this->conn->protectIdentifiers(

-                    $this->builderCache->from[ 0 ],

+                    $this->builderCache->from[0],

                     true,

                     $escape,

                     false

@@ -2691,7 +2691,7 @@ 
         $affectedRows = 0;

         for ($i = 0, $total = count($sets); $i < $total; $i += $batchSize) {

             $Sql = $this->platformReplaceStatement(

-                $this->conn->protectIdentifiers($this->builderCache->from[ 0 ], true, $escape, false),

+                $this->conn->protectIdentifiers($this->builderCache->from[0], true, $escape, false),

                 $this->builderCache->keys,

                 array_slice($this->builderCache->sets, $i, $batchSize)

             );

@@ -2737,7 +2737,7 @@ 
         if (count($this->builderCache->sets) && count($this->builderCache->from)) {

             $sqlStatement = $this->platformUpdateStatement(

                 $this->conn->protectIdentifiers(

-                    $this->builderCache->from[ 0 ],

+                    $this->builderCache->from[0],

                     true,

                     $escape,

                     false

@@ -2798,7 +2798,7 @@ 
         $affectedRows = 0;

         for ($i = 0, $total = count($this->builderCache->sets); $i < $total; $i += $batchSize) {

             $sql = $this->platformUpdateBatchStatement(

-                $this->builderCache->from[ 0 ],

+                $this->builderCache->from[0],

                 array_slice($this->builderCache->sets, $i, $batchSize),

                 $this->conn->protectIdentifiers($index, false, $escape, false)

             );

@@ -2810,7 +2810,7 @@ 
                 $affectedRows += $this->conn->getAffectedRows();

             }

 

-            $this->builderCache[ 'where' ] = [];

+            $this->builderCache['where'] = [];

         }

 

         if ( ! $this->testMode) {

@@ -2854,7 +2854,7 @@ 
 

                 $bind = $this->bind($key, $value);

 

-                $row[ $this->conn->protectIdentifiers($key, false, $escape) ] = ':' . $bind;

+                $row[$this->conn->protectIdentifiers($key, false, $escape)] = ':' . $bind;

             }

 

             if ($indexSet === false) {

@@ -2905,7 +2905,7 @@ 
 

         $sqlStatement = $this->platformDeleteStatement(

             $this->conn->protectIdentifiers(

-                $this->builderCache->from[ 0 ],

+                $this->builderCache->from[0],

                 true,

                 $this->conn->protectIdentifiers,

                 false

@@ -3084,10 +3084,10 @@ 
                 // The reason we protect identifiers here rather than in the select() function

                 // is because until the user calls the from() function we don't know if there are aliases

                 foreach ($this->builderCache->select as $selectKey => $selectField) {

-                    $noEscape = isset($this->builderCache->noEscape [ $selectKey ])

-                        ? $this->builderCache->noEscape [ $selectKey ]

+                    $noEscape = isset($this->builderCache->noEscape [$selectKey])

+                        ? $this->builderCache->noEscape [$selectKey]

                         : null;

-                    $this->builderCache->select [ $selectKey ] = $this->conn->protectIdentifiers(

+                    $this->builderCache->select [$selectKey] = $this->conn->protectIdentifiers(

                         $selectField,

                         false,

                         $noEscape

@@ -3206,28 +3206,28 @@ 
         if (count($this->builderCache->{$cacheKey}) > 0) {

             for ($i = 0, $c = count($this->builderCache->{$cacheKey}); $i < $c; $i++) {

                 // Is this condition already compiled?

-                if (is_string($this->builderCache->{$cacheKey}[ $i ])) {

+                if (is_string($this->builderCache->{$cacheKey}[$i])) {

                     continue;

-                } elseif ($this->builderCache->{$cacheKey}[ $i ][ 'escape' ] === false) {

-                    $this->builderCache->{$cacheKey}[ $i ]

-                        = $this->builderCache->{$cacheKey}[ $i ][ 'condition' ];

+                } elseif ($this->builderCache->{$cacheKey}[$i]['escape'] === false) {

+                    $this->builderCache->{$cacheKey}[$i]

+                        = $this->builderCache->{$cacheKey}[$i]['condition'];

                     continue;

                 }

 

                 // Split multiple conditions

                 $conditions = preg_split(

                     '/((?:^|\s+)AND\s+|(?:^|\s+)OR\s+)/i',

-                    $this->builderCache->{$cacheKey}[ $i ][ 'condition' ],

+                    $this->builderCache->{$cacheKey}[$i]['condition'],

                     -1,

                     PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY

                 );

 

                 for ($ci = 0, $cc = count($conditions); $ci < $cc; $ci++) {

-                    if (($op = $this->getOperator($conditions[ $ci ])) === false

+                    if (($op = $this->getOperator($conditions[$ci])) === false

                         OR

                         ! preg_match(

                             '/^(\(?)(.*)(' . preg_quote($op, '/') . ')\s*(.*(?<!\)))?(\)?)$/i',

-                            $conditions[ $ci ],

+                            $conditions[$ci],

                             $matches

                         )

                     ) {

@@ -3243,16 +3243,16 @@ 
                     //  5 => ')'        /* optional */

                     // );

 

-                    if ( ! empty($matches[ 4 ])) {

+                    if ( ! empty($matches[4])) {

                         //$this->isLiteral($matches[4]) OR $matches[4] = $this->protectIdentifiers(trim($matches[4]));

-                        $matches[ 4 ] = ' ' . $matches[ 4 ];

+                        $matches[4] = ' ' . $matches[4];

                     }

 

-                    $conditions[ $ci ] = $matches[ 1 ] . $this->conn->protectIdentifiers(trim($matches[ 2 ]))

-                        . ' ' . trim($matches[ 3 ]) . $matches[ 4 ] . $matches[ 5 ];

+                    $conditions[$ci] = $matches[1] . $this->conn->protectIdentifiers(trim($matches[2]))

+                        . ' ' . trim($matches[3]) . $matches[4] . $matches[5];

                 }

 

-                $this->builderCache->{$cacheKey}[ $i ] = implode('', $conditions);

+                $this->builderCache->{$cacheKey}[$i] = implode('', $conditions);

             }

 

             if ($cacheKey === 'having') {

@@ -3291,17 +3291,17 @@ 
         if (count($this->builderCache->groupBy) > 0) {

             for ($i = 0, $c = count($this->builderCache->groupBy); $i < $c; $i++) {

                 // Is it already compiled?

-                if (is_string($this->builderCache->groupBy[ $i ])) {

+                if (is_string($this->builderCache->groupBy[$i])) {

                     continue;

                 }

 

-                $this->builderCache->groupBy[ $i ] = ($this->builderCache->groupBy[ $i ][ 'escape' ]

+                $this->builderCache->groupBy[$i] = ($this->builderCache->groupBy[$i]['escape']

                     === false OR

                     $this->isLiteral(

-                        $this->builderCache->groupBy[ $i ][ 'field' ]

+                        $this->builderCache->groupBy[$i]['field']

                     ))

-                    ? $this->builderCache->groupBy[ $i ][ 'field' ]

-                    : $this->conn->protectIdentifiers($this->builderCache->groupBy[ $i ][ 'field' ]);

+                    ? $this->builderCache->groupBy[$i]['field']

+                    : $this->conn->protectIdentifiers($this->builderCache->groupBy[$i]['field']);

             }

 

             return "\n" . sprintf(

@@ -3346,7 +3346,7 @@ 
                 : ["'"];

         }

 

-        return in_array($string[ 0 ], $stringArray, true);

+        return in_array($string[0], $stringArray, true);

     }

 

     //--------------------------------------------------------------------

@@ -3404,18 +3404,18 @@ 
     {

         if (is_array($this->builderCache->orderBy) && count($this->builderCache->orderBy) > 0) {

             for ($i = 0, $c = count($this->builderCache->orderBy); $i < $c; $i++) {

-                if ($this->builderCache->orderBy[ $i ][ 'escape' ] !== false

+                if ($this->builderCache->orderBy[$i]['escape'] !== false

                     && ! $this->isLiteral(

-                        $this->builderCache->orderBy[ $i ][ 'field' ]

+                        $this->builderCache->orderBy[$i]['field']

                     )

                 ) {

-                    $this->builderCache->orderBy[ $i ][ 'field' ] = $this->conn->protectIdentifiers(

-                        $this->builderCache->orderBy[ $i ][ 'field' ]

+                    $this->builderCache->orderBy[$i]['field'] = $this->conn->protectIdentifiers(

+                        $this->builderCache->orderBy[$i]['field']

                     );

                 }

 

-                $this->builderCache->orderBy[ $i ] = $this->builderCache->orderBy[ $i ][ 'field' ]

-                    . $this->builderCache->orderBy[ $i ][ 'direction' ];

+                $this->builderCache->orderBy[$i] = $this->builderCache->orderBy[$i]['field']

+                    . $this->builderCache->orderBy[$i]['direction'];

             }

 

             return $this->builderCache->orderBy = "\n" . sprintf(