glances.outputs.glances_sparklines

Complexity

Total Complexity

13

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	Sparkline.percents()	0	3	1
A	Sparkline.__init__()	0	12	1
A	Sparkline.post_char()	0	3	1
A	Sparkline.size()	0	7	3
A	Sparkline.pre_char()	0	3	1
A	Sparkline.__str__()	0	3	1
A	Sparkline.get()	0	8	3
A	Sparkline.available()	0	3	1

# -*- coding: utf-8 -*-
#
# This file is part of Glances.
#
# Copyright (C) 2019 Nicolargo <nicolas@nicolargo.com>
#
# Glances is free software; you can redistribute it and/or modify
# it under the terms of the GNU Lesser General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# Glances is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.

"""Manage sparklines for Glances output."""

from __future__ import unicode_literals
from __future__ import division
import sys

import missing from __future__ import absolute_import

from math import modf

import missing from __future__ import absolute_import

Unused modf imported from math

from glances.logger import logger

import missing from __future__ import absolute_import

from glances.compat import nativestr

import missing from __future__ import absolute_import

sparklines_module = True

The name sparklines_module does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

try:
    from sparklines import sparklines

import missing from __future__ import absolute_import

except ImportError as e:

The name e does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    logger.warning("Sparklines module not found ({})".format(e))

Use formatting in logging functions and pass the parameters as arguments

    sparklines_module = False

The name sparklines_module does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

try:
    '┌┬┐╔╦╗╒╤╕╓╥╖│║─═├┼┤╠╬╣╞╪╡╟╫╢└┴┘╚╩╝╘╧╛╙╨╜'.encode(sys.stdout.encoding)
except (UnicodeEncodeError, TypeError):
    logger.warning("UTF-8 is mandatory for sparklines ({})".format(e))

Use formatting in logging functions and pass the parameters as arguments

The variable e does not seem to be defined.

    sparklines_module = False

The name sparklines_module does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

class Sparkline(object):

Too many instance attributes (9/7)

    r"""Manage sparklines (see https://pypi.org/project/sparklines/)."""

    def __init__(self, size, pre_char='[', post_char=']', empty_char=' ', with_text=True):

This line is too long as per the coding-style (90/80).

Too many arguments (6/5)

        # If the sparklines python module available ?
        self.__available = sparklines_module
        # Sparkline size
        self.__size = size
        # Sparkline current percents list
        self.__percent = []
        # Char used for the decoration
        self.__pre_char = pre_char
        self.__post_char = post_char
        self.__empty_char = empty_char
        self.__with_text = with_text

    @property
    def available(self):

This method should have a docstring.

        return self.__available

    @property
    def size(self, with_decoration=False):

This method should have a docstring.

        # Return the sparkine size, with or without decoration
        if with_decoration:
            return self.__size
        if self.__with_text:
            return self.__size - 6

    @property
    def percents(self):

This method should have a docstring.

        return self.__percent

    @percents.setter
    def percents(self, value):
        self.__percent = value

    @property
    def pre_char(self):

This method should have a docstring.

        return self.__pre_char

    @property
    def post_char(self):

This method should have a docstring.

        return self.__post_char

    def get(self):
        """Return the sparkline."""
        ret = sparklines(self.percents)[0]
        if self.__with_text:
            percents_without_none = [x for x in self.percents if x is not None]
            if len(percents_without_none) > 0:

Do not use len(SEQUENCE) as condition value

                ret = '{}{:5.1f}%'.format(ret, percents_without_none[-1])
        return nativestr(ret)

    def __str__(self):
        """Return the sparkline."""
        return self.get()