OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\Drivers\ClickatellCentral

Complexity

Total Complexity

5

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	send()	0	16	4

<?php

declare(strict_types=1);

/**
 * SPDX-FileCopyrightText: 2024 Christian Schrötter <cs@fnx.li>
 * SPDX-License-Identifier: AGPL-3.0-or-later
 */

namespace OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\Drivers;

use Exception;
use OCA\TwoFactorGateway\Exception\MessageTransmissionException;
use OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\AProvider;
use OCP\Http\Client\IClient;
use OCP\Http\Client\IClientService;

/**
 * @method string getApi()
 * @method static setApi(string $api)
 * @method string getUser()
 * @method static setUser(string $user)
 * @method string getPassword()
 * @method static setPassword(string $password)
 */
class ClickatellCentral extends AProvider {
	public const SCHEMA = [
		'id' => 'clickatell_central',
		'name' => 'Clickatell Central',
		'fields' => [
			['field' => 'api',      'prompt' => 'Please enter your central.clickatell.com API-ID:'],
			['field' => 'user',     'prompt' => 'Please enter your central.clickatell.com username:'],
			['field' => 'password', 'prompt' => 'Please enter your central.clickatell.com password:'],
		],
	];

	private IClient $client;

	public function __construct(
		IClientService $clientService,
	) {
		$this->client = $clientService->newClient();
	}

	#[\Override]
	public function send(string $identifier, string $message) {
		try {
			$response = $this->client->get(vsprintf('https://api.clickatell.com/http/sendmsg?user=%s&password=%s&api_id=%u&to=%s&text=%s', [
				urlencode($this->getUser()),
				urlencode($this->getPassword()),
				$this->getApi(),
				urlencode($identifier),
				urlencode($message),
			]));
		} catch (Exception $ex) {
			throw new MessageTransmissionException();
		}

		if ($response->getStatusCode() !== 200 || substr($response->getBody(), 0, 4) !== 'ID: ') {

It seems like $response->getBody() can also be of type null and resource; however, parameter $string of substr() does only seem to accept string, maybe add an additional type check?

			throw new MessageTransmissionException($response->getBody());

It seems like $response->getBody() can also be of type resource; however, parameter $message of OCA\TwoFactorGateway\Exception\MessageTransmissionException::__construct() does only seem to accept string, maybe add an additional type check?

		}
	}
}