nextcloud /
twofactor_gateway
| Conditions | 25 |
| Paths | 22 |
| Total Lines | 103 |
| Code Lines | 66 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 650 |
| Changes | 2 | ||
| Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 51 | #[\Override] |
||
| 52 | public function send(string $identifier, string $message, array $extra = []): void { |
||
| 53 | $client = $this->clientService->newClient(); |
||
| 54 | // determine type of gateway |
||
| 55 | |||
| 56 | // test for native signal-cli JSON RPC. |
||
| 57 | $response = $client->post( |
||
| 58 | $this->getUrl() . '/api/v1/rpc', |
||
| 59 | [ |
||
| 60 | 'http_errors' => false, |
||
| 61 | 'json' => [ |
||
| 62 | 'jsonrpc' => '2.0', |
||
| 63 | 'method' => 'version', |
||
| 64 | 'id' => 'version_' . $this->timeFactory->getTime(), |
||
| 65 | ], |
||
| 66 | ]); |
||
| 67 | if ($response->getStatusCode() === 200 || $response->getStatusCode() === 201) { |
||
| 68 | // native signal-cli JSON RPC. |
||
| 69 | |||
| 70 | // Groups have to be detected and passed with the "group-id" parameter. We assume a group is given as base64 encoded string |
||
| 71 | $groupId = base64_decode($identifier, strict: true); |
||
| 72 | $isGroup = $groupId !== false && base64_encode($groupId) === $identifier; |
||
| 73 | $recipientKey = $isGroup ? 'group-id' : 'recipient'; |
||
| 74 | $params = [ |
||
| 75 | 'message' => $message, |
||
| 76 | $recipientKey => $identifier, |
||
| 77 | 'account' => $this->getAccount(), // mandatory for native RPC API |
||
| 78 | ]; |
||
| 79 | $response = $response = $client->post( |
||
|
Unused Code
introduced
by
|
|||
| 80 | $this->getUrl() . '/api/v1/rpc', |
||
| 81 | [ |
||
| 82 | 'json' => [ |
||
| 83 | 'jsonrpc' => '2.0', |
||
| 84 | 'method' => 'send', |
||
| 85 | 'id' => 'code_' . $this->timeFactory->getTime(), |
||
| 86 | 'params' => $params, |
||
| 87 | ], |
||
| 88 | ]); |
||
| 89 | $body = $response->getBody(); |
||
| 90 | $json = json_decode($body, true); |
||
| 91 | $statusCode = $response->getStatusCode(); |
||
| 92 | // The 201 "created" is probably a bug. |
||
| 93 | if ($statusCode < 200 || $statusCode >= 300 || is_null($json) || !is_array($json) || ($json['jsonrpc'] ?? null) != '2.0' || !isset($json['result']['timestamp'])) { |
||
| 94 | throw new MessageTransmissionException("error reported by Signal gateway, status=$statusCode, body=$body}"); |
||
| 95 | } |
||
| 96 | } else { |
||
| 97 | // Try gateway in the style of https://gitlab.com/morph027/signal-cli-dbus-rest-api |
||
| 98 | $response = $client->get($this->getUrl() . '/v1/about'); |
||
| 99 | if ($response->getStatusCode() === 200) { |
||
| 100 | // Not so "ńew style" gateway, see |
||
| 101 | // https://gitlab.com/morph027/signal-cli-dbus-rest-api |
||
| 102 | // https://gitlab.com/morph027/python-signal-cli-rest-api |
||
| 103 | // https://github.com/bbernhard/signal-cli-rest-api |
||
| 104 | $body = $response->getBody(); |
||
| 105 | $json = json_decode($body, true); |
||
| 106 | $versions = $json['versions'] || []; |
||
| 107 | if (is_array($versions) && in_array('v2', $versions)) { |
||
| 108 | $json = [ |
||
| 109 | 'recipients' => $identifier, |
||
| 110 | 'message' => $message, |
||
| 111 | ]; |
||
| 112 | $account = $this->getAccount(); |
||
| 113 | if ($account != self::ACCOUNT_UNNECESSARY) { |
||
| 114 | $json['account'] = $account; |
||
| 115 | } |
||
| 116 | $response = $client->post( |
||
| 117 | $this->getUrl() . '/v2/send', |
||
| 118 | [ |
||
| 119 | 'json' => $json, |
||
| 120 | ] |
||
| 121 | ); |
||
| 122 | } else { |
||
| 123 | $response = $client->post( |
||
| 124 | $this->getUrl() . '/v1/send/' . $identifier, |
||
| 125 | [ |
||
| 126 | 'json' => [ 'message' => $message ], |
||
| 127 | ] |
||
| 128 | ); |
||
| 129 | } |
||
| 130 | $body = (string)$response->getBody(); |
||
| 131 | $json = json_decode($body, true); |
||
| 132 | $status = $response->getStatusCode(); |
||
| 133 | if ($status !== 201 || is_null($json) || !is_array($json) || !isset($json['timestamp'])) { |
||
| 134 | throw new MessageTransmissionException("error reported by Signal gateway, status=$status, body=$body}"); |
||
| 135 | } |
||
| 136 | } else { |
||
| 137 | // Try old deprecated gateway https://gitlab.com/morph027/signal-web-gateway |
||
| 138 | $response = $client->post( |
||
| 139 | $this->getUrl() . '/v1/send/' . $identifier, |
||
| 140 | [ |
||
| 141 | 'body' => [ |
||
| 142 | 'to' => $identifier, |
||
| 143 | 'message' => $message, |
||
| 144 | ], |
||
| 145 | 'json' => [ 'message' => $message ], |
||
| 146 | ] |
||
| 147 | ); |
||
| 148 | $body = (string)$response->getBody(); |
||
| 149 | $json = json_decode($body, true); |
||
| 150 | |||
| 151 | $status = $response->getStatusCode(); |
||
| 152 | if ($status !== 200 || is_null($json) || !is_array($json) || !isset($json['success']) || $json['success'] !== true) { |
||
| 153 | throw new MessageTransmissionException("error reported by Signal gateway, status=$status, body=$body}"); |
||
| 154 | } |
||
| 182 |
Loading history...