Inspection of "Merge pull request #24053 from nextcloud/bugfix/no..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 29b974...81070c )

by Julius

created 2020-11-12 20:43 UTC

Status

Indentation +50 added lines, -50 removed lines patch added patch discarded remove patch

@@ -36,59 +36,59 @@
 block discarded – undo
 
 class Version18000Date20191014105105 extends SimpleMigrationStep {
 
-	/** @var IDBConnection */
-	protected $connection;
+    /** @var IDBConnection */
+    protected $connection;
 
-	public function __construct(IDBConnection $connection) {
-		$this->connection = $connection;
-	}
+    public function __construct(IDBConnection $connection) {
+        $this->connection = $connection;
+    }
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
-		$table = $schema->createTable('direct_edit');
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
+        $table = $schema->createTable('direct_edit');
 
-		$table->addColumn('id', Types::BIGINT, [
-			'autoincrement' => true,
-			'notnull' => true,
-		]);
-		$table->addColumn('editor_id', Types::STRING, [
-			'notnull' => true,
-			'length' => 64,
-		]);
-		$table->addColumn('token', Types::STRING, [
-			'notnull' => true,
-			'length' => 64,
-		]);
-		$table->addColumn('file_id', Types::BIGINT, [
-			'notnull' => true,
-		]);
-		$table->addColumn('user_id', Types::STRING, [
-			'notnull' => false,
-			'length' => 64,
-		]);
-		$table->addColumn('share_id', Types::BIGINT, [
-			'notnull' => false
-		]);
-		$table->addColumn('timestamp', Types::BIGINT, [
-			'notnull' => true,
-			'length' => 20,
-			'unsigned' => true,
-		]);
-		$table->addColumn('accessed', Types::BOOLEAN, [
-			'notnull' => false,
-			'default' => false
-		]);
+        $table->addColumn('id', Types::BIGINT, [
+            'autoincrement' => true,
+            'notnull' => true,
+        ]);
+        $table->addColumn('editor_id', Types::STRING, [
+            'notnull' => true,
+            'length' => 64,
+        ]);
+        $table->addColumn('token', Types::STRING, [
+            'notnull' => true,
+            'length' => 64,
+        ]);
+        $table->addColumn('file_id', Types::BIGINT, [
+            'notnull' => true,
+        ]);
+        $table->addColumn('user_id', Types::STRING, [
+            'notnull' => false,
+            'length' => 64,
+        ]);
+        $table->addColumn('share_id', Types::BIGINT, [
+            'notnull' => false
+        ]);
+        $table->addColumn('timestamp', Types::BIGINT, [
+            'notnull' => true,
+            'length' => 20,
+            'unsigned' => true,
+        ]);
+        $table->addColumn('accessed', Types::BOOLEAN, [
+            'notnull' => false,
+            'default' => false
+        ]);
 
-		$table->setPrimaryKey(['id']);
-		$table->addIndex(['token']);
+        $table->setPrimaryKey(['id']);
+        $table->addIndex(['token']);
 
-		return $schema;
-	}
+        return $schema;
+    }
 }

Please login to merge, or discard this patch.

core/Migrations/Version20000Date20201111081915.php 1 patch

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -32,30 +32,30 @@
 block discarded – undo
 use OCP\Migration\SimpleMigrationStep;
 
 class Version20000Date20201111081915 extends SimpleMigrationStep {
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
-
-		$result = $this->ensureColumnIsNullable($schema, 'direct_edit', 'accessed');
-
-		return $result ? $schema : null;
-	}
-
-	protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
-		$table = $schema->getTable($tableName);
-		$column = $table->getColumn($columnName);
-
-		if ($column->getNotnull()) {
-			$column->setNotnull(false);
-			return true;
-		}
-
-		return false;
-	}
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
+
+        $result = $this->ensureColumnIsNullable($schema, 'direct_edit', 'accessed');
+
+        return $result ? $schema : null;
+    }
+
+    protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
+        $table = $schema->getTable($tableName);
+        $column = $table->getColumn($columnName);
+
+        if ($column->getNotnull()) {
+            $column->setNotnull(false);
+            return true;
+        }
+
+        return false;
+    }
 }

Please login to merge, or discard this patch.

apps/user_status/lib/Migration/Version0001Date20200602134824.php 1 patch

Indentation +54 added lines, -54 removed lines patch added patch discarded remove patch

@@ -37,61 +37,61 @@
 block discarded – undo
  */
 class Version0001Date20200602134824 extends SimpleMigrationStep {
 
-	/**
-	 * @param IOutput $output
-	 * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 * @since 20.0.0
-	 */
-	public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
+    /**
+     * @param IOutput $output
+     * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     * @since 20.0.0
+     */
+    public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
 
-		$statusTable = $schema->createTable('user_status');
-		$statusTable->addColumn('id', Types::BIGINT, [
-			'autoincrement' => true,
-			'notnull' => true,
-			'length' => 20,
-			'unsigned' => true,
-		]);
-		$statusTable->addColumn('user_id', Types::STRING, [
-			'notnull' => true,
-			'length' => 255,
-		]);
-		$statusTable->addColumn('status', Types::STRING, [
-			'notnull' => true,
-			'length' => 255,
-		]);
-		$statusTable->addColumn('status_timestamp', Types::INTEGER, [
-			'notnull' => true,
-			'length' => 11,
-			'unsigned' => true,
-		]);
-		$statusTable->addColumn('is_user_defined', Types::BOOLEAN, [
-			'notnull' => false,
-		]);
-		$statusTable->addColumn('message_id', Types::STRING, [
-			'notnull' => false,
-			'length' => 255,
-		]);
-		$statusTable->addColumn('custom_icon', Types::STRING, [
-			'notnull' => false,
-			'length' => 255,
-		]);
-		$statusTable->addColumn('custom_message', Types::TEXT, [
-			'notnull' => false,
-		]);
-		$statusTable->addColumn('clear_at', Types::INTEGER, [
-			'notnull' => false,
-			'length' => 11,
-			'unsigned' => true,
-		]);
+        $statusTable = $schema->createTable('user_status');
+        $statusTable->addColumn('id', Types::BIGINT, [
+            'autoincrement' => true,
+            'notnull' => true,
+            'length' => 20,
+            'unsigned' => true,
+        ]);
+        $statusTable->addColumn('user_id', Types::STRING, [
+            'notnull' => true,
+            'length' => 255,
+        ]);
+        $statusTable->addColumn('status', Types::STRING, [
+            'notnull' => true,
+            'length' => 255,
+        ]);
+        $statusTable->addColumn('status_timestamp', Types::INTEGER, [
+            'notnull' => true,
+            'length' => 11,
+            'unsigned' => true,
+        ]);
+        $statusTable->addColumn('is_user_defined', Types::BOOLEAN, [
+            'notnull' => false,
+        ]);
+        $statusTable->addColumn('message_id', Types::STRING, [
+            'notnull' => false,
+            'length' => 255,
+        ]);
+        $statusTable->addColumn('custom_icon', Types::STRING, [
+            'notnull' => false,
+            'length' => 255,
+        ]);
+        $statusTable->addColumn('custom_message', Types::TEXT, [
+            'notnull' => false,
+        ]);
+        $statusTable->addColumn('clear_at', Types::INTEGER, [
+            'notnull' => false,
+            'length' => 11,
+            'unsigned' => true,
+        ]);
 
-		$statusTable->setPrimaryKey(['id']);
-		$statusTable->addUniqueIndex(['user_id'], 'user_status_uid_ix');
-		$statusTable->addIndex(['clear_at'], 'user_status_clr_ix');
+        $statusTable->setPrimaryKey(['id']);
+        $statusTable->addUniqueIndex(['user_id'], 'user_status_uid_ix');
+        $statusTable->addIndex(['clear_at'], 'user_status_clr_ix');
 
-		return $schema;
-	}
+        return $schema;
+    }
 }

Please login to merge, or discard this patch.

apps/user_status/lib/Migration/Version1000Date20201111130204.php 1 patch

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -33,30 +33,30 @@
 block discarded – undo
 
 class Version1000Date20201111130204 extends SimpleMigrationStep {
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
-
-		$result = $this->ensureColumnIsNullable($schema, 'user_status', 'is_user_defined');
-
-		return $result ? $schema : null;
-	}
-
-	protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
-		$table = $schema->getTable($tableName);
-		$column = $table->getColumn($columnName);
-
-		if ($column->getNotnull()) {
-			$column->setNotnull(false);
-			return true;
-		}
-
-		return false;
-	}
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
+
+        $result = $this->ensureColumnIsNullable($schema, 'user_status', 'is_user_defined');
+
+        return $result ? $schema : null;
+    }
+
+    protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
+        $table = $schema->getTable($tableName);
+        $column = $table->getColumn($columnName);
+
+        if ($column->getNotnull()) {
+            $column->setNotnull(false);
+            return true;
+        }
+
+        return false;
+    }
 }

Please login to merge, or discard this patch.

		@@ -36,59 +36,59 @@
		block discarded – undo
36	36
37	37	class Version18000Date20191014105105 extends SimpleMigrationStep {
38	38
39		- /** @var IDBConnection */
40		- protected $connection;
	39	+ /** @var IDBConnection */
	40	+ protected $connection;
41	41
42		- public function __construct(IDBConnection $connection) {
43		- $this->connection = $connection;
44		- }
	42	+ public function __construct(IDBConnection $connection) {
	43	+ $this->connection = $connection;
	44	+ }
45	45
46		- /**
47		- * @param IOutput $output
48		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
49		- * @param array $options
50		- * @return null\|ISchemaWrapper
51		- */
52		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
53		- /** @var ISchemaWrapper $schema */
54		- $schema = $schemaClosure();
55		- $table = $schema->createTable('direct_edit');
	46	+ /**
	47	+ * @param IOutput $output
	48	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	49	+ * @param array $options
	50	+ * @return null\|ISchemaWrapper
	51	+ */
	52	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
	53	+ /** @var ISchemaWrapper $schema */
	54	+ $schema = $schemaClosure();
	55	+ $table = $schema->createTable('direct_edit');
56	56
57		- $table->addColumn('id', Types::BIGINT, [
58		- 'autoincrement' => true,
59		- 'notnull' => true,
60		- ]);
61		- $table->addColumn('editor_id', Types::STRING, [
62		- 'notnull' => true,
63		- 'length' => 64,
64		- ]);
65		- $table->addColumn('token', Types::STRING, [
66		- 'notnull' => true,
67		- 'length' => 64,
68		- ]);
69		- $table->addColumn('file_id', Types::BIGINT, [
70		- 'notnull' => true,
71		- ]);
72		- $table->addColumn('user_id', Types::STRING, [
73		- 'notnull' => false,
74		- 'length' => 64,
75		- ]);
76		- $table->addColumn('share_id', Types::BIGINT, [
77		- 'notnull' => false
78		- ]);
79		- $table->addColumn('timestamp', Types::BIGINT, [
80		- 'notnull' => true,
81		- 'length' => 20,
82		- 'unsigned' => true,
83		- ]);
84		- $table->addColumn('accessed', Types::BOOLEAN, [
85		- 'notnull' => false,
86		- 'default' => false
87		- ]);
	57	+ $table->addColumn('id', Types::BIGINT, [
	58	+ 'autoincrement' => true,
	59	+ 'notnull' => true,
	60	+ ]);
	61	+ $table->addColumn('editor_id', Types::STRING, [
	62	+ 'notnull' => true,
	63	+ 'length' => 64,
	64	+ ]);
	65	+ $table->addColumn('token', Types::STRING, [
	66	+ 'notnull' => true,
	67	+ 'length' => 64,
	68	+ ]);
	69	+ $table->addColumn('file_id', Types::BIGINT, [
	70	+ 'notnull' => true,
	71	+ ]);
	72	+ $table->addColumn('user_id', Types::STRING, [
	73	+ 'notnull' => false,
	74	+ 'length' => 64,
	75	+ ]);
	76	+ $table->addColumn('share_id', Types::BIGINT, [
	77	+ 'notnull' => false
	78	+ ]);
	79	+ $table->addColumn('timestamp', Types::BIGINT, [
	80	+ 'notnull' => true,
	81	+ 'length' => 20,
	82	+ 'unsigned' => true,
	83	+ ]);
	84	+ $table->addColumn('accessed', Types::BOOLEAN, [
	85	+ 'notnull' => false,
	86	+ 'default' => false
	87	+ ]);
88	88
89		- $table->setPrimaryKey(['id']);
90		- $table->addIndex(['token']);
	89	+ $table->setPrimaryKey(['id']);
	90	+ $table->addIndex(['token']);
91	91
92		- return $schema;
93		- }
	92	+ return $schema;
	93	+ }
94	94	}

		@@ -32,30 +32,30 @@
		block discarded – undo
32	32	use OCP\Migration\SimpleMigrationStep;
33	33
34	34	class Version20000Date20201111081915 extends SimpleMigrationStep {
35		- /**
36		- * @param IOutput $output
37		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
38		- * @param array $options
39		- * @return null\|ISchemaWrapper
40		- */
41		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
42		- /** @var ISchemaWrapper $schema */
43		- $schema = $schemaClosure();
44		-
45		- $result = $this->ensureColumnIsNullable($schema, 'direct_edit', 'accessed');
46		-
47		- return $result ? $schema : null;
48		- }
49		-
50		- protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
51		- $table = $schema->getTable($tableName);
52		- $column = $table->getColumn($columnName);
53		-
54		- if ($column->getNotnull()) {
55		- $column->setNotnull(false);
56		- return true;
57		- }
58		-
59		- return false;
60		- }
	35	+ /**
	36	+ * @param IOutput $output
	37	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	38	+ * @param array $options
	39	+ * @return null\|ISchemaWrapper
	40	+ */
	41	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
	42	+ /** @var ISchemaWrapper $schema */
	43	+ $schema = $schemaClosure();
	44	+
	45	+ $result = $this->ensureColumnIsNullable($schema, 'direct_edit', 'accessed');
	46	+
	47	+ return $result ? $schema : null;
	48	+ }
	49	+
	50	+ protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
	51	+ $table = $schema->getTable($tableName);
	52	+ $column = $table->getColumn($columnName);
	53	+
	54	+ if ($column->getNotnull()) {
	55	+ $column->setNotnull(false);
	56	+ return true;
	57	+ }
	58	+
	59	+ return false;
	60	+ }
61	61	}

		@@ -37,61 +37,61 @@
		block discarded – undo
37	37	*/
38	38	class Version0001Date20200602134824 extends SimpleMigrationStep {
39	39
40		- /**
41		- * @param IOutput $output
42		- * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
43		- * @param array $options
44		- * @return null\|ISchemaWrapper
45		- * @since 20.0.0
46		- */
47		- public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
48		- /** @var ISchemaWrapper $schema */
49		- $schema = $schemaClosure();
	40	+ /**
	41	+ * @param IOutput $output
	42	+ * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	43	+ * @param array $options
	44	+ * @return null\|ISchemaWrapper
	45	+ * @since 20.0.0
	46	+ */
	47	+ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
	48	+ /** @var ISchemaWrapper $schema */
	49	+ $schema = $schemaClosure();
50	50
51		- $statusTable = $schema->createTable('user_status');
52		- $statusTable->addColumn('id', Types::BIGINT, [
53		- 'autoincrement' => true,
54		- 'notnull' => true,
55		- 'length' => 20,
56		- 'unsigned' => true,
57		- ]);
58		- $statusTable->addColumn('user_id', Types::STRING, [
59		- 'notnull' => true,
60		- 'length' => 255,
61		- ]);
62		- $statusTable->addColumn('status', Types::STRING, [
63		- 'notnull' => true,
64		- 'length' => 255,
65		- ]);
66		- $statusTable->addColumn('status_timestamp', Types::INTEGER, [
67		- 'notnull' => true,
68		- 'length' => 11,
69		- 'unsigned' => true,
70		- ]);
71		- $statusTable->addColumn('is_user_defined', Types::BOOLEAN, [
72		- 'notnull' => false,
73		- ]);
74		- $statusTable->addColumn('message_id', Types::STRING, [
75		- 'notnull' => false,
76		- 'length' => 255,
77		- ]);
78		- $statusTable->addColumn('custom_icon', Types::STRING, [
79		- 'notnull' => false,
80		- 'length' => 255,
81		- ]);
82		- $statusTable->addColumn('custom_message', Types::TEXT, [
83		- 'notnull' => false,
84		- ]);
85		- $statusTable->addColumn('clear_at', Types::INTEGER, [
86		- 'notnull' => false,
87		- 'length' => 11,
88		- 'unsigned' => true,
89		- ]);
	51	+ $statusTable = $schema->createTable('user_status');
	52	+ $statusTable->addColumn('id', Types::BIGINT, [
	53	+ 'autoincrement' => true,
	54	+ 'notnull' => true,
	55	+ 'length' => 20,
	56	+ 'unsigned' => true,
	57	+ ]);
	58	+ $statusTable->addColumn('user_id', Types::STRING, [
	59	+ 'notnull' => true,
	60	+ 'length' => 255,
	61	+ ]);
	62	+ $statusTable->addColumn('status', Types::STRING, [
	63	+ 'notnull' => true,
	64	+ 'length' => 255,
	65	+ ]);
	66	+ $statusTable->addColumn('status_timestamp', Types::INTEGER, [
	67	+ 'notnull' => true,
	68	+ 'length' => 11,
	69	+ 'unsigned' => true,
	70	+ ]);
	71	+ $statusTable->addColumn('is_user_defined', Types::BOOLEAN, [
	72	+ 'notnull' => false,
	73	+ ]);
	74	+ $statusTable->addColumn('message_id', Types::STRING, [
	75	+ 'notnull' => false,
	76	+ 'length' => 255,
	77	+ ]);
	78	+ $statusTable->addColumn('custom_icon', Types::STRING, [
	79	+ 'notnull' => false,
	80	+ 'length' => 255,
	81	+ ]);
	82	+ $statusTable->addColumn('custom_message', Types::TEXT, [
	83	+ 'notnull' => false,
	84	+ ]);
	85	+ $statusTable->addColumn('clear_at', Types::INTEGER, [
	86	+ 'notnull' => false,
	87	+ 'length' => 11,
	88	+ 'unsigned' => true,
	89	+ ]);
90	90
91		- $statusTable->setPrimaryKey(['id']);
92		- $statusTable->addUniqueIndex(['user_id'], 'user_status_uid_ix');
93		- $statusTable->addIndex(['clear_at'], 'user_status_clr_ix');
	91	+ $statusTable->setPrimaryKey(['id']);
	92	+ $statusTable->addUniqueIndex(['user_id'], 'user_status_uid_ix');
	93	+ $statusTable->addIndex(['clear_at'], 'user_status_clr_ix');
94	94
95		- return $schema;
96		- }
	95	+ return $schema;
	96	+ }
97	97	}

		@@ -33,30 +33,30 @@
		block discarded – undo
33	33
34	34	class Version1000Date20201111130204 extends SimpleMigrationStep {
35	35
36		- /**
37		- * @param IOutput $output
38		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
39		- * @param array $options
40		- * @return null\|ISchemaWrapper
41		- */
42		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
43		- /** @var ISchemaWrapper $schema */
44		- $schema = $schemaClosure();
45		-
46		- $result = $this->ensureColumnIsNullable($schema, 'user_status', 'is_user_defined');
47		-
48		- return $result ? $schema : null;
49		- }
50		-
51		- protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
52		- $table = $schema->getTable($tableName);
53		- $column = $table->getColumn($columnName);
54		-
55		- if ($column->getNotnull()) {
56		- $column->setNotnull(false);
57		- return true;
58		- }
59		-
60		- return false;
61		- }
	36	+ /**
	37	+ * @param IOutput $output
	38	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	39	+ * @param array $options
	40	+ * @return null\|ISchemaWrapper
	41	+ */
	42	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
	43	+ /** @var ISchemaWrapper $schema */
	44	+ $schema = $schemaClosure();
	45	+
	46	+ $result = $this->ensureColumnIsNullable($schema, 'user_status', 'is_user_defined');
	47	+
	48	+ return $result ? $schema : null;
	49	+ }
	50	+
	51	+ protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool {
	52	+ $table = $schema->getTable($tableName);
	53	+ $column = $table->getColumn($columnName);
	54	+
	55	+ if ($column->getNotnull()) {
	56	+ $column->setNotnull(false);
	57	+ return true;
	58	+ }
	59	+
	60	+ return false;
	61	+ }
62	62	}

nextcloud / server

Push — master ( 29b974...81070c )

Status

Category

Indentation +50 added lines, -50 removed lines patch added patch discarded remove patch

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

Indentation +54 added lines, -54 removed lines patch added patch discarded remove patch

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch