nextcloud / server

apps/settings/templates/settings/personal/personal.info.php

Braces +5 added lines, -2 removed lines

@@ -53,11 +53,14 @@
 		<div class="personal-settings-setting-box personal-settings-setting-box-detail">
 			<div id="vue-details-section"></div>
 		</div>
-	<?php else: ?>
+	<?php else {
+    : ?>
 		<div class="personal-settings-setting-box personal-settings-setting-box-detail--without-profile">
 			<div id="vue-details-section"></div>
 		</div>
-	<?php endif; ?>
+	<?php endif;
+}
+?>
 	<div class="personal-settings-setting-box">
 		<div id="vue-displayname-section"></div>
 	</div>

Indentation +3 added lines, -3 removed lines

@@ -9,9 +9,9 @@
 /** @var array $_ */
 
 script('settings', [
-	'usersettings',
-	'templates',
-	'vue-settings-personal-info',
+    'usersettings',
+    'templates',
+    'vue-settings-personal-info',
 ]);
 ?>
 <?php if (!$_['isFairUseOfFreePushService']) : ?>

lib/public/Group/Events/GroupChangedEvent.php

Indentation +54 added lines, -54 removed lines

@@ -32,63 +32,63 @@
  * @since 26.0.0
  */
 class GroupChangedEvent extends Event {
-	private IGroup $group;
-	private string $feature;
-	/** @var mixed */
-	private $value;
-	/** @var mixed */
-	private $oldValue;
+    private IGroup $group;
+    private string $feature;
+    /** @var mixed */
+    private $value;
+    /** @var mixed */
+    private $oldValue;
 
-	/**
-	 * @since 26.0.0
-	 */
-	public function __construct(IGroup $group,
-		string $feature,
-		$value,
-		$oldValue = null) {
-		parent::__construct();
-		$this->group = $group;
-		$this->feature = $feature;
-		$this->value = $value;
-		$this->oldValue = $oldValue;
-	}
+    /**
+     * @since 26.0.0
+     */
+    public function __construct(IGroup $group,
+        string $feature,
+        $value,
+        $oldValue = null) {
+        parent::__construct();
+        $this->group = $group;
+        $this->feature = $feature;
+        $this->value = $value;
+        $this->oldValue = $oldValue;
+    }
 
-	/**
-	 *
-	 * @since 26.0.0
-	 *
-	 * @return IGroup
-	 */
-	public function getGroup(): IGroup {
-		return $this->group;
-	}
+    /**
+     *
+     * @since 26.0.0
+     *
+     * @return IGroup
+     */
+    public function getGroup(): IGroup {
+        return $this->group;
+    }
 
-	/**
-	 *
-	 * @since 26.0.0
-	 *
-	 * @return string
-	 */
-	public function getFeature(): string {
-		return $this->feature;
-	}
+    /**
+     *
+     * @since 26.0.0
+     *
+     * @return string
+     */
+    public function getFeature(): string {
+        return $this->feature;
+    }
 
-	/**
-	 * @since 26.0.0
-	 *
-	 * @return mixed
-	 */
-	public function getValue() {
-		return $this->value;
-	}
+    /**
+     * @since 26.0.0
+     *
+     * @return mixed
+     */
+    public function getValue() {
+        return $this->value;
+    }
 
-	/**
-	 *
-	 * @since 26.0.0
-	 *
-	 * @return mixed
-	 */
-	public function getOldValue() {
-		return $this->oldValue;
-	}
+    /**
+     *
+     * @since 26.0.0
+     *
+     * @return mixed
+     */
+    public function getOldValue() {
+        return $this->oldValue;
+    }
 }

apps/contactsinteraction/lib/Db/RecentContactMapper.php

Spacing +1 added lines, -1 removed lines

@@ -116,7 +116,7 @@
 			return null;
 		}
 
-		return (int)$row['last_contact'];
+		return (int) $row['last_contact'];
 	}
 
 	public function cleanUp(int $olderThan): void {

Indentation +105 added lines, -105 removed lines

@@ -17,109 +17,109 @@
  * @template-extends QBMapper<RecentContact>
  */
 class RecentContactMapper extends QBMapper {
-	public const TABLE_NAME = 'recent_contact';
-
-	public function __construct(IDBConnection $db) {
-		parent::__construct($db, self::TABLE_NAME);
-	}
-
-	/**
-	 * @return RecentContact[]
-	 */
-	public function findAll(string $uid): array {
-		$qb = $this->db->getQueryBuilder();
-
-		$select = $qb
-			->select('*')
-			->from($this->getTableName())
-			->where($qb->expr()->eq('actor_uid', $qb->createNamedParameter($uid)));
-
-		return $this->findEntities($select);
-	}
-
-	/**
-	 * @throws DoesNotExistException
-	 */
-	public function find(string $uid, int $id): RecentContact {
-		$qb = $this->db->getQueryBuilder();
-
-		$select = $qb
-			->select('*')
-			->from($this->getTableName())
-			->where($qb->expr()->eq('id', $qb->createNamedParameter($id, $qb::PARAM_INT)))
-			->andWhere($qb->expr()->eq('actor_uid', $qb->createNamedParameter($uid)));
-
-		return $this->findEntity($select);
-	}
-
-	/**
-	 * @return RecentContact[]
-	 */
-	public function findMatch(IUser $user,
-		?string $uid,
-		?string $email,
-		?string $cloudId): array {
-		$qb = $this->db->getQueryBuilder();
-
-		$additionalWheres = [];
-		if ($uid !== null) {
-			$additionalWheres[] = $qb->expr()->eq('uid', $qb->createNamedParameter($uid));
-		}
-		if ($email !== null) {
-			$additionalWheres[] = $qb->expr()->eq('email', $qb->createNamedParameter($email));
-		}
-		if ($cloudId !== null) {
-			$additionalWheres[] = $qb->expr()->eq('federated_cloud_id', $qb->createNamedParameter($cloudId));
-		}
-
-		$select = $qb
-			->select('*')
-			->from($this->getTableName())
-			->where($qb->expr()->eq('actor_uid', $qb->createNamedParameter($user->getUID())));
-
-		if (!empty($additionalWheres)) {
-			$select->andWhere($select->expr()->orX(...$additionalWheres));
-		}
-		return $this->findEntities($select);
-	}
-
-	public function findLastUpdatedForUserId(string $uid): ?int {
-		$qb = $this->db->getQueryBuilder();
-
-		$select = $qb
-			->select('last_contact')
-			->from($this->getTableName())
-			->where($qb->expr()->eq('actor_uid', $qb->createNamedParameter($uid)))
-			->orderBy('last_contact', 'DESC')
-			->setMaxResults(1);
-
-		$cursor = $select->executeQuery();
-		$row = $cursor->fetchAssociative();
-
-		if ($row === false) {
-			return null;
-		}
-
-		return (int)$row['last_contact'];
-	}
-
-	public function cleanUp(int $olderThan): void {
-		$qb = $this->db->getQueryBuilder();
-
-		$delete = $qb
-			->delete($this->getTableName())
-			->where($qb->expr()->lt('last_contact', $qb->createNamedParameter($olderThan)));
-
-		$delete->executeStatement();
-	}
-
-	public function deleteByUserId(string $uid): void {
-		$qb = $this->db->getQueryBuilder();
-
-		$delete = $qb
-			->delete($this->getTableName())
-			->where($qb->expr()->eq('actor_uid', $qb->createNamedParameter($uid)));
-
-		$delete->executeStatement();
-	}
+    public const TABLE_NAME = 'recent_contact';
+
+    public function __construct(IDBConnection $db) {
+        parent::__construct($db, self::TABLE_NAME);
+    }
+
+    /**
+     * @return RecentContact[]
+     */
+    public function findAll(string $uid): array {
+        $qb = $this->db->getQueryBuilder();
+
+        $select = $qb
+            ->select('*')
+            ->from($this->getTableName())
+            ->where($qb->expr()->eq('actor_uid', $qb->createNamedParameter($uid)));
+
+        return $this->findEntities($select);
+    }
+
+    /**
+     * @throws DoesNotExistException
+     */
+    public function find(string $uid, int $id): RecentContact {
+        $qb = $this->db->getQueryBuilder();
+
+        $select = $qb
+            ->select('*')
+            ->from($this->getTableName())
+            ->where($qb->expr()->eq('id', $qb->createNamedParameter($id, $qb::PARAM_INT)))
+            ->andWhere($qb->expr()->eq('actor_uid', $qb->createNamedParameter($uid)));
+
+        return $this->findEntity($select);
+    }
+
+    /**
+     * @return RecentContact[]
+     */
+    public function findMatch(IUser $user,
+        ?string $uid,
+        ?string $email,
+        ?string $cloudId): array {
+        $qb = $this->db->getQueryBuilder();
+
+        $additionalWheres = [];
+        if ($uid !== null) {
+            $additionalWheres[] = $qb->expr()->eq('uid', $qb->createNamedParameter($uid));
+        }
+        if ($email !== null) {
+            $additionalWheres[] = $qb->expr()->eq('email', $qb->createNamedParameter($email));
+        }
+        if ($cloudId !== null) {
+            $additionalWheres[] = $qb->expr()->eq('federated_cloud_id', $qb->createNamedParameter($cloudId));
+        }
+
+        $select = $qb
+            ->select('*')
+            ->from($this->getTableName())
+            ->where($qb->expr()->eq('actor_uid', $qb->createNamedParameter($user->getUID())));
+
+        if (!empty($additionalWheres)) {
+            $select->andWhere($select->expr()->orX(...$additionalWheres));
+        }
+        return $this->findEntities($select);
+    }
+
+    public function findLastUpdatedForUserId(string $uid): ?int {
+        $qb = $this->db->getQueryBuilder();
+
+        $select = $qb
+            ->select('last_contact')
+            ->from($this->getTableName())
+            ->where($qb->expr()->eq('actor_uid', $qb->createNamedParameter($uid)))
+            ->orderBy('last_contact', 'DESC')
+            ->setMaxResults(1);
+
+        $cursor = $select->executeQuery();
+        $row = $cursor->fetchAssociative();
+
+        if ($row === false) {
+            return null;
+        }
+
+        return (int)$row['last_contact'];
+    }
+
+    public function cleanUp(int $olderThan): void {
+        $qb = $this->db->getQueryBuilder();
+
+        $delete = $qb
+            ->delete($this->getTableName())
+            ->where($qb->expr()->lt('last_contact', $qb->createNamedParameter($olderThan)));
+
+        $delete->executeStatement();
+    }
+
+    public function deleteByUserId(string $uid): void {
+        $qb = $this->db->getQueryBuilder();
+
+        $delete = $qb
+            ->delete($this->getTableName())
+            ->where($qb->expr()->eq('actor_uid', $qb->createNamedParameter($uid)));
+
+        $delete->executeStatement();
+    }
 }

lib/private/Authentication/Events/LoginFailed.php

Indentation +13 added lines, -13 removed lines

@@ -28,21 +28,21 @@
 use OCP\EventDispatcher\Event;
 
 class LoginFailed extends Event {
-	private string $loginName;
-	private ?string $password;
+    private string $loginName;
+    private ?string $password;
 
-	public function __construct(string $loginName, ?string $password) {
-		parent::__construct();
+    public function __construct(string $loginName, ?string $password) {
+        parent::__construct();
 
-		$this->loginName = $loginName;
-		$this->password = $password;
-	}
+        $this->loginName = $loginName;
+        $this->password = $password;
+    }
 
-	public function getLoginName(): string {
-		return $this->loginName;
-	}
+    public function getLoginName(): string {
+        return $this->loginName;
+    }
 
-	public function getPassword(): ?string {
-		return $this->password;
-	}
+    public function getPassword(): ?string {
+        return $this->password;
+    }
 }

apps/admin_audit/lib/BackgroundJobs/Rotate.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
 	}
 
 	protected function run($argument): void {
-		$default = $this->config->getSystemValue('datadirectory', \OC::$SERVERROOT . '/data') . '/audit.log';
+		$default = $this->config->getSystemValue('datadirectory', \OC::$SERVERROOT.'/data').'/audit.log';
 		$this->filePath = $this->config->getAppValue('admin_audit', 'logfile', $default);
 
 		if ($this->filePath === '') {

Indentation +20 added lines, -20 removed lines

@@ -13,30 +13,30 @@
 use OCP\Log\RotationTrait;
 
 class Rotate extends TimedJob {
-	use RotationTrait;
+    use RotationTrait;
 
-	public function __construct(
-		ITimeFactory $time,
-		private IConfig $config,
-	) {
-		parent::__construct($time);
+    public function __construct(
+        ITimeFactory $time,
+        private IConfig $config,
+    ) {
+        parent::__construct($time);
 
-		$this->setInterval(60 * 60 * 3);
-	}
+        $this->setInterval(60 * 60 * 3);
+    }
 
-	protected function run($argument): void {
-		$default = $this->config->getSystemValue('datadirectory', \OC::$SERVERROOT . '/data') . '/audit.log';
-		$this->filePath = $this->config->getAppValue('admin_audit', 'logfile', $default);
+    protected function run($argument): void {
+        $default = $this->config->getSystemValue('datadirectory', \OC::$SERVERROOT . '/data') . '/audit.log';
+        $this->filePath = $this->config->getAppValue('admin_audit', 'logfile', $default);
 
-		if ($this->filePath === '') {
-			// default log file, nothing to do
-			return;
-		}
+        if ($this->filePath === '') {
+            // default log file, nothing to do
+            return;
+        }
 
-		$this->maxSize = $this->config->getSystemValue('log_rotate_size', 100 * 1024 * 1024);
+        $this->maxSize = $this->config->getSystemValue('log_rotate_size', 100 * 1024 * 1024);
 
-		if ($this->shouldRotateBySize()) {
-			$this->rotate();
-		}
-	}
+        if ($this->shouldRotateBySize()) {
+            $this->rotate();
+        }
+    }
 }

lib/public/Migration/IMigrationStep.php

Indentation +39 added lines, -39 removed lines

@@ -34,47 +34,47 @@
  * @since 13.0.0
  */
 interface IMigrationStep {
-	/**
-	 * Human-readable name of the migration step
-	 *
-	 * @return string
-	 * @since 14.0.0
-	 */
-	public function name(): string;
+    /**
+     * Human-readable name of the migration step
+     *
+     * @return string
+     * @since 14.0.0
+     */
+    public function name(): string;
 
-	/**
-	 * Human-readable description of the migration step
-	 *
-	 * @return string
-	 * @since 14.0.0
-	 */
-	public function description(): string;
+    /**
+     * Human-readable description of the migration step
+     *
+     * @return string
+     * @since 14.0.0
+     */
+    public function description(): string;
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @psalm-param Closure():ISchemaWrapper $schemaClosure
-	 * @param array $options
-	 * @since 13.0.0
-	 */
-	public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $options);
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @psalm-param Closure():ISchemaWrapper $schemaClosure
+     * @param array $options
+     * @since 13.0.0
+     */
+    public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $options);
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @psalm-param Closure():ISchemaWrapper $schemaClosure
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 * @since 13.0.0
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options);
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @psalm-param Closure():ISchemaWrapper $schemaClosure
+     * @param array $options
+     * @return null|ISchemaWrapper
+     * @since 13.0.0
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options);
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @psalm-param Closure():ISchemaWrapper $schemaClosure
-	 * @param array $options
-	 * @since 13.0.0
-	 */
-	public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options);
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @psalm-param Closure():ISchemaWrapper $schemaClosure
+     * @param array $options
+     * @since 13.0.0
+     */
+    public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options);
 }

lib/public/Migration/SimpleMigrationStep.php

Indentation +47 added lines, -47 removed lines

@@ -35,55 +35,55 @@
  * @since 13.0.0
  */
 abstract class SimpleMigrationStep implements IMigrationStep {
-	/**
-	 * Human-readable name of the migration step
-	 *
-	 * @return string
-	 * @since 14.0.0
-	 */
-	public function name(): string {
-		return '';
-	}
+    /**
+     * Human-readable name of the migration step
+     *
+     * @return string
+     * @since 14.0.0
+     */
+    public function name(): string {
+        return '';
+    }
 
-	/**
-	 * Human-readable description of the migration step
-	 *
-	 * @return string
-	 * @since 14.0.0
-	 */
-	public function description(): string {
-		return '';
-	}
+    /**
+     * Human-readable description of the migration step
+     *
+     * @return string
+     * @since 14.0.0
+     */
+    public function description(): string {
+        return '';
+    }
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @psalm-param Closure():ISchemaWrapper $schemaClosure
-	 * @param array $options
-	 * @since 13.0.0
-	 */
-	public function preSchemaChange(IOutput $output, \Closure $schemaClosure, array $options) {
-	}
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @psalm-param Closure():ISchemaWrapper $schemaClosure
+     * @param array $options
+     * @since 13.0.0
+     */
+    public function preSchemaChange(IOutput $output, \Closure $schemaClosure, array $options) {
+    }
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @psalm-param Closure():ISchemaWrapper $schemaClosure
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 * @since 13.0.0
-	 */
-	public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
-		return null;
-	}
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @psalm-param Closure():ISchemaWrapper $schemaClosure
+     * @param array $options
+     * @return null|ISchemaWrapper
+     * @since 13.0.0
+     */
+    public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
+        return null;
+    }
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @psalm-param Closure():ISchemaWrapper $schemaClosure
-	 * @param array $options
-	 * @since 13.0.0
-	 */
-	public function postSchemaChange(IOutput $output, \Closure $schemaClosure, array $options) {
-	}
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @psalm-param Closure():ISchemaWrapper $schemaClosure
+     * @param array $options
+     * @since 13.0.0
+     */
+    public function postSchemaChange(IOutput $output, \Closure $schemaClosure, array $options) {
+    }
 }

lib/private/AppFramework/Middleware/PublicShare/PublicShareMiddleware.php

Spacing +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
 
 		$controllerClassPath = explode('\\', get_class($controller));
 		$controllerShortClass = end($controllerClassPath);
-		$bruteforceProtectionAction = $controllerShortClass . '::' . $methodName;
+		$bruteforceProtectionAction = $controllerShortClass.'::'.$methodName;
 		$this->throttler->sleepDelayOrThrowOnMax($this->request->getRemoteAddress(), $bruteforceProtectionAction);
 
 		if (!$this->isLinkSharingEnabled()) {

Indentation +103 added lines, -103 removed lines

@@ -20,107 +20,107 @@
 
 class PublicShareMiddleware extends Middleware {
 
-	public function __construct(
-		private IRequest $request,
-		private ISession $session,
-		private IConfig $config,
-		private IThrottler $throttler,
-	) {
-	}
-
-	public function beforeController($controller, $methodName) {
-		if (!($controller instanceof PublicShareController)) {
-			return;
-		}
-
-		$controllerClassPath = explode('\\', get_class($controller));
-		$controllerShortClass = end($controllerClassPath);
-		$bruteforceProtectionAction = $controllerShortClass . '::' . $methodName;
-		$this->throttler->sleepDelayOrThrowOnMax($this->request->getRemoteAddress(), $bruteforceProtectionAction);
-
-		if (!$this->isLinkSharingEnabled()) {
-			throw new NotFoundException('Link sharing is disabled');
-		}
-
-		// We require the token parameter to be set
-		$token = $this->request->getParam('token');
-		if ($token === null) {
-			throw new NotFoundException();
-		}
-
-		// Set the token
-		$controller->setToken($token);
-
-		if (!$controller->isValidToken()) {
-			$this->throttle($bruteforceProtectionAction, $token);
-
-			$controller->shareNotFound();
-			throw new NotFoundException();
-		}
-
-		// No need to check for authentication when we try to authenticate
-		if ($methodName === 'authenticate' || $methodName === 'showAuthenticate') {
-			return;
-		}
-
-		// If authentication succeeds just continue
-		if ($controller->isAuthenticated()) {
-			return;
-		}
-
-		// If we can authenticate to this controller do it else we throw a 404 to not leak any info
-		if ($controller instanceof AuthPublicShareController) {
-			$this->session->set('public_link_authenticate_redirect', json_encode($this->request->getParams()));
-			throw new NeedAuthenticationException();
-		}
-
-		$this->throttle($bruteforceProtectionAction, $token);
-		throw new NotFoundException();
-	}
-
-	public function afterException($controller, $methodName, \Exception $exception) {
-		if (!($controller instanceof PublicShareController)) {
-			throw $exception;
-		}
-
-		if ($exception instanceof NotFoundException) {
-			return new TemplateResponse(Application::APP_ID, 'sharenotfound', [
-				'message' => $exception->getMessage(),
-			], 'guest', Http::STATUS_NOT_FOUND);
-		}
-
-		if ($controller instanceof AuthPublicShareController && $exception instanceof NeedAuthenticationException) {
-			return $controller->getAuthenticationRedirect($this->getFunctionForRoute($this->request->getParam('_route')));
-		}
-
-		throw $exception;
-	}
-
-	private function getFunctionForRoute(string $route): string {
-		$tmp = explode('.', $route);
-		return array_pop($tmp);
-	}
-
-	/**
-	 * Check if link sharing is allowed
-	 */
-	private function isLinkSharingEnabled(): bool {
-		// Check if the shareAPI is enabled
-		if ($this->config->getAppValue('core', 'shareapi_enabled', 'yes') !== 'yes') {
-			return false;
-		}
-
-		// Check whether public sharing is enabled
-		if ($this->config->getAppValue('core', 'shareapi_allow_links', 'yes') !== 'yes') {
-			return false;
-		}
-
-		return true;
-	}
-
-	private function throttle($bruteforceProtectionAction, $token): void {
-		$ip = $this->request->getRemoteAddress();
-		$this->throttler->sleepDelayOrThrowOnMax($ip, $bruteforceProtectionAction);
-		$this->throttler->registerAttempt($bruteforceProtectionAction, $ip, ['token' => $token]);
-	}
+    public function __construct(
+        private IRequest $request,
+        private ISession $session,
+        private IConfig $config,
+        private IThrottler $throttler,
+    ) {
+    }
+
+    public function beforeController($controller, $methodName) {
+        if (!($controller instanceof PublicShareController)) {
+            return;
+        }
+
+        $controllerClassPath = explode('\\', get_class($controller));
+        $controllerShortClass = end($controllerClassPath);
+        $bruteforceProtectionAction = $controllerShortClass . '::' . $methodName;
+        $this->throttler->sleepDelayOrThrowOnMax($this->request->getRemoteAddress(), $bruteforceProtectionAction);
+
+        if (!$this->isLinkSharingEnabled()) {
+            throw new NotFoundException('Link sharing is disabled');
+        }
+
+        // We require the token parameter to be set
+        $token = $this->request->getParam('token');
+        if ($token === null) {
+            throw new NotFoundException();
+        }
+
+        // Set the token
+        $controller->setToken($token);
+
+        if (!$controller->isValidToken()) {
+            $this->throttle($bruteforceProtectionAction, $token);
+
+            $controller->shareNotFound();
+            throw new NotFoundException();
+        }
+
+        // No need to check for authentication when we try to authenticate
+        if ($methodName === 'authenticate' || $methodName === 'showAuthenticate') {
+            return;
+        }
+
+        // If authentication succeeds just continue
+        if ($controller->isAuthenticated()) {
+            return;
+        }
+
+        // If we can authenticate to this controller do it else we throw a 404 to not leak any info
+        if ($controller instanceof AuthPublicShareController) {
+            $this->session->set('public_link_authenticate_redirect', json_encode($this->request->getParams()));
+            throw new NeedAuthenticationException();
+        }
+
+        $this->throttle($bruteforceProtectionAction, $token);
+        throw new NotFoundException();
+    }
+
+    public function afterException($controller, $methodName, \Exception $exception) {
+        if (!($controller instanceof PublicShareController)) {
+            throw $exception;
+        }
+
+        if ($exception instanceof NotFoundException) {
+            return new TemplateResponse(Application::APP_ID, 'sharenotfound', [
+                'message' => $exception->getMessage(),
+            ], 'guest', Http::STATUS_NOT_FOUND);
+        }
+
+        if ($controller instanceof AuthPublicShareController && $exception instanceof NeedAuthenticationException) {
+            return $controller->getAuthenticationRedirect($this->getFunctionForRoute($this->request->getParam('_route')));
+        }
+
+        throw $exception;
+    }
+
+    private function getFunctionForRoute(string $route): string {
+        $tmp = explode('.', $route);
+        return array_pop($tmp);
+    }
+
+    /**
+     * Check if link sharing is allowed
+     */
+    private function isLinkSharingEnabled(): bool {
+        // Check if the shareAPI is enabled
+        if ($this->config->getAppValue('core', 'shareapi_enabled', 'yes') !== 'yes') {
+            return false;
+        }
+
+        // Check whether public sharing is enabled
+        if ($this->config->getAppValue('core', 'shareapi_allow_links', 'yes') !== 'yes') {
+            return false;
+        }
+
+        return true;
+    }
+
+    private function throttle($bruteforceProtectionAction, $token): void {
+        $ip = $this->request->getRemoteAddress();
+        $this->throttler->sleepDelayOrThrowOnMax($ip, $bruteforceProtectionAction);
+        $this->throttler->registerAttempt($bruteforceProtectionAction, $ip, ['token' => $token]);
+    }
 }

lib/private/Files/Cache/Wrapper/CacheJail.php

Spacing +3 added lines, -3 removed lines

@@ -79,7 +79,7 @@ 
 		if ($path === '') {
 			return $this->getRoot();
 		} else {
-			return $this->getRoot() . '/' . ltrim($path, '/');
+			return $this->getRoot().'/'.ltrim($path, '/');
 		}
 	}
 
@@ -98,7 +98,7 @@ 
 		$rootLength = strlen($root) + 1;
 		if ($path === $root) {
 			return '';
-		} elseif (substr($path, 0, $rootLength) === $root . '/') {
+		} elseif (substr($path, 0, $rootLength) === $root.'/') {
 			return substr($path, $rootLength);
 		} else {
 			return null;
@@ -317,7 +317,7 @@ 
 					new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_OR,
 						[
 							new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'path', $this->getGetUnjailedRoot()),
-							new SearchComparison(ISearchComparison::COMPARE_LIKE_CASE_SENSITIVE, 'path', SearchComparison::escapeLikeParameter($this->getGetUnjailedRoot()) . '/%'),
+							new SearchComparison(ISearchComparison::COMPARE_LIKE_CASE_SENSITIVE, 'path', SearchComparison::escapeLikeParameter($this->getGetUnjailedRoot()).'/%'),
 						],
 					)
 				]

Indentation +304 added lines, -304 removed lines

@@ -22,308 +22,308 @@
  */
 class CacheJail extends CacheWrapper {
 
-	protected string $unjailedRoot;
-
-	public function __construct(
-		?ICache $cache,
-		protected string $root,
-		?CacheDependencies $dependencies = null,
-	) {
-		parent::__construct($cache, $dependencies);
-
-		$this->unjailedRoot = $root;
-		$parent = $cache;
-		while ($parent instanceof CacheWrapper) {
-			if ($parent instanceof CacheJail) {
-				$this->unjailedRoot = $parent->getSourcePath($this->unjailedRoot);
-			}
-			$parent = $parent->getCache();
-		}
-	}
-
-	/**
-	 * @return string
-	 */
-	protected function getRoot() {
-		return $this->root;
-	}
-
-	/**
-	 * Get the root path with any nested jails resolved
-	 *
-	 * @return string
-	 */
-	public function getGetUnjailedRoot() {
-		return $this->unjailedRoot;
-	}
-
-	/**
-	 * @return string
-	 */
-	protected function getSourcePath(string $path) {
-		if ($path === '') {
-			return $this->getRoot();
-		} else {
-			return $this->getRoot() . '/' . ltrim($path, '/');
-		}
-	}
-
-	/**
-	 * @param string $path
-	 * @param null|string $root
-	 * @return null|string the jailed path or null if the path is outside the jail
-	 */
-	protected function getJailedPath(string $path, ?string $root = null) {
-		if ($root === null) {
-			$root = $this->getRoot();
-		}
-		if ($root === '') {
-			return $path;
-		}
-		$rootLength = strlen($root) + 1;
-		if ($path === $root) {
-			return '';
-		} elseif (substr($path, 0, $rootLength) === $root . '/') {
-			return substr($path, $rootLength);
-		} else {
-			return null;
-		}
-	}
-
-	protected function formatCacheEntry($entry) {
-		if (isset($entry['path'])) {
-			$entry['path'] = $this->getJailedPath($entry['path']);
-		}
-		return $entry;
-	}
-
-	/**
-	 * get the stored metadata of a file or folder
-	 *
-	 * @param string|int $file
-	 * @return ICacheEntry|false
-	 */
-	public function get($file) {
-		if (is_string($file) || $file == '') {
-			$file = $this->getSourcePath($file);
-		}
-		return parent::get($file);
-	}
-
-	/**
-	 * insert meta data for a new file or folder
-	 *
-	 * @param string $file
-	 * @param array $data
-	 *
-	 * @return int file id
-	 * @throws \RuntimeException
-	 */
-	public function insert($file, array $data) {
-		return $this->getCache()->insert($this->getSourcePath($file), $data);
-	}
-
-	/**
-	 * update the metadata in the cache
-	 *
-	 * @param int $id
-	 * @param array $data
-	 */
-	public function update($id, array $data) {
-		$this->getCache()->update($id, $data);
-	}
-
-	/**
-	 * get the file id for a file
-	 *
-	 * @param string $file
-	 * @return int
-	 */
-	public function getId($file) {
-		return $this->getCache()->getId($this->getSourcePath($file));
-	}
-
-	/**
-	 * get the id of the parent folder of a file
-	 *
-	 * @param string $file
-	 * @return int
-	 */
-	public function getParentId($file) {
-		return $this->getCache()->getParentId($this->getSourcePath($file));
-	}
-
-	/**
-	 * check if a file is available in the cache
-	 *
-	 * @param string $file
-	 * @return bool
-	 */
-	public function inCache($file) {
-		return $this->getCache()->inCache($this->getSourcePath($file));
-	}
-
-	/**
-	 * remove a file or folder from the cache
-	 *
-	 * @param string $file
-	 */
-	public function remove($file) {
-		$this->getCache()->remove($this->getSourcePath($file));
-	}
-
-	/**
-	 * Move a file or folder in the cache
-	 *
-	 * @param string $source
-	 * @param string $target
-	 */
-	public function move($source, $target) {
-		$this->getCache()->move($this->getSourcePath($source), $this->getSourcePath($target));
-	}
-
-	/**
-	 * Get the storage id and path needed for a move
-	 *
-	 * @param string $path
-	 * @return array [$storageId, $internalPath]
-	 */
-	protected function getMoveInfo($path) {
-		return [$this->getNumericStorageId(), $this->getSourcePath($path)];
-	}
-
-	/**
-	 * remove all entries for files that are stored on the storage from the cache
-	 */
-	public function clear() {
-		$this->getCache()->remove($this->getRoot());
-	}
-
-	/**
-	 * @param string $file
-	 *
-	 * @return int Cache::NOT_FOUND, Cache::PARTIAL, Cache::SHALLOW or Cache::COMPLETE
-	 */
-	public function getStatus($file) {
-		return $this->getCache()->getStatus($this->getSourcePath($file));
-	}
-
-	/**
-	 * update the folder size and the size of all parent folders
-	 *
-	 * @param array|ICacheEntry|null $data (optional) meta data of the folder
-	 */
-	public function correctFolderSize(string $path, $data = null, bool $isBackgroundScan = false): void {
-		$cache = $this->getCache();
-		if ($cache instanceof Cache) {
-			$cache->correctFolderSize($this->getSourcePath($path), $data, $isBackgroundScan);
-		}
-	}
-
-	/**
-	 * get the size of a folder and set it in the cache
-	 *
-	 * @param string $path
-	 * @param array|null|ICacheEntry $entry (optional) meta data of the folder
-	 * @return int|float
-	 */
-	public function calculateFolderSize($path, $entry = null) {
-		$cache = $this->getCache();
-		if ($cache instanceof Cache) {
-			return $cache->calculateFolderSize($this->getSourcePath($path), $entry);
-		} else {
-			return 0;
-		}
-	}
-
-	/**
-	 * get all file ids on the files on the storage
-	 *
-	 * @return int[]
-	 */
-	public function getAll() {
-		// not supported
-		return [];
-	}
-
-	/**
-	 * find a folder in the cache which has not been fully scanned
-	 *
-	 * If multiply incomplete folders are in the cache, the one with the highest id will be returned,
-	 * use the one with the highest id gives the best result with the background scanner, since that is most
-	 * likely the folder where we stopped scanning previously
-	 *
-	 * @return string|false the path of the folder or false when no folder matched
-	 */
-	public function getIncomplete() {
-		// not supported
-		return false;
-	}
-
-	/**
-	 * get the path of a file on this storage by it's id
-	 *
-	 * @param int $id
-	 * @return string|null
-	 */
-	public function getPathById($id) {
-		$path = $this->getCache()->getPathById($id);
-		if ($path === null) {
-			return null;
-		}
-
-		return $this->getJailedPath($path);
-	}
-
-	/**
-	 * Move a file or folder in the cache
-	 *
-	 * Note that this should make sure the entries are removed from the source cache
-	 *
-	 * @param \OCP\Files\Cache\ICache $sourceCache
-	 * @param string $sourcePath
-	 * @param string $targetPath
-	 */
-	public function moveFromCache(\OCP\Files\Cache\ICache $sourceCache, $sourcePath, $targetPath) {
-		if ($sourceCache === $this) {
-			return $this->move($sourcePath, $targetPath);
-		}
-		return $this->getCache()->moveFromCache($sourceCache, $sourcePath, $this->getSourcePath($targetPath));
-	}
-
-	public function getQueryFilterForStorage(): ISearchOperator {
-		return $this->addJailFilterQuery($this->getCache()->getQueryFilterForStorage());
-	}
-
-	protected function addJailFilterQuery(ISearchOperator $filter): ISearchOperator {
-		if ($this->getGetUnjailedRoot() !== '' && $this->getGetUnjailedRoot() !== '/') {
-			return new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_AND,
-				[
-					$filter,
-					new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_OR,
-						[
-							new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'path', $this->getGetUnjailedRoot()),
-							new SearchComparison(ISearchComparison::COMPARE_LIKE_CASE_SENSITIVE, 'path', SearchComparison::escapeLikeParameter($this->getGetUnjailedRoot()) . '/%'),
-						],
-					)
-				]
-			);
-		} else {
-			return $filter;
-		}
-	}
-
-	public function getCacheEntryFromSearchResult(ICacheEntry $rawEntry): ?ICacheEntry {
-		if ($this->getGetUnjailedRoot() === '' || str_starts_with($rawEntry->getPath(), $this->getGetUnjailedRoot())) {
-			$rawEntry = $this->getCache()->getCacheEntryFromSearchResult($rawEntry);
-			if ($rawEntry) {
-				$jailedPath = $this->getJailedPath($rawEntry->getPath());
-				if ($jailedPath !== null) {
-					return $this->formatCacheEntry(clone $rawEntry) ?: null;
-				}
-			}
-		}
-
-		return null;
-	}
+    protected string $unjailedRoot;
+
+    public function __construct(
+        ?ICache $cache,
+        protected string $root,
+        ?CacheDependencies $dependencies = null,
+    ) {
+        parent::__construct($cache, $dependencies);
+
+        $this->unjailedRoot = $root;
+        $parent = $cache;
+        while ($parent instanceof CacheWrapper) {
+            if ($parent instanceof CacheJail) {
+                $this->unjailedRoot = $parent->getSourcePath($this->unjailedRoot);
+            }
+            $parent = $parent->getCache();
+        }
+    }
+
+    /**
+     * @return string
+     */
+    protected function getRoot() {
+        return $this->root;
+    }
+
+    /**
+     * Get the root path with any nested jails resolved
+     *
+     * @return string
+     */
+    public function getGetUnjailedRoot() {
+        return $this->unjailedRoot;
+    }
+
+    /**
+     * @return string
+     */
+    protected function getSourcePath(string $path) {
+        if ($path === '') {
+            return $this->getRoot();
+        } else {
+            return $this->getRoot() . '/' . ltrim($path, '/');
+        }
+    }
+
+    /**
+     * @param string $path
+     * @param null|string $root
+     * @return null|string the jailed path or null if the path is outside the jail
+     */
+    protected function getJailedPath(string $path, ?string $root = null) {
+        if ($root === null) {
+            $root = $this->getRoot();
+        }
+        if ($root === '') {
+            return $path;
+        }
+        $rootLength = strlen($root) + 1;
+        if ($path === $root) {
+            return '';
+        } elseif (substr($path, 0, $rootLength) === $root . '/') {
+            return substr($path, $rootLength);
+        } else {
+            return null;
+        }
+    }
+
+    protected function formatCacheEntry($entry) {
+        if (isset($entry['path'])) {
+            $entry['path'] = $this->getJailedPath($entry['path']);
+        }
+        return $entry;
+    }
+
+    /**
+     * get the stored metadata of a file or folder
+     *
+     * @param string|int $file
+     * @return ICacheEntry|false
+     */
+    public function get($file) {
+        if (is_string($file) || $file == '') {
+            $file = $this->getSourcePath($file);
+        }
+        return parent::get($file);
+    }
+
+    /**
+     * insert meta data for a new file or folder
+     *
+     * @param string $file
+     * @param array $data
+     *
+     * @return int file id
+     * @throws \RuntimeException
+     */
+    public function insert($file, array $data) {
+        return $this->getCache()->insert($this->getSourcePath($file), $data);
+    }
+
+    /**
+     * update the metadata in the cache
+     *
+     * @param int $id
+     * @param array $data
+     */
+    public function update($id, array $data) {
+        $this->getCache()->update($id, $data);
+    }
+
+    /**
+     * get the file id for a file
+     *
+     * @param string $file
+     * @return int
+     */
+    public function getId($file) {
+        return $this->getCache()->getId($this->getSourcePath($file));
+    }
+
+    /**
+     * get the id of the parent folder of a file
+     *
+     * @param string $file
+     * @return int
+     */
+    public function getParentId($file) {
+        return $this->getCache()->getParentId($this->getSourcePath($file));
+    }
+
+    /**
+     * check if a file is available in the cache
+     *
+     * @param string $file
+     * @return bool
+     */
+    public function inCache($file) {
+        return $this->getCache()->inCache($this->getSourcePath($file));
+    }
+
+    /**
+     * remove a file or folder from the cache
+     *
+     * @param string $file
+     */
+    public function remove($file) {
+        $this->getCache()->remove($this->getSourcePath($file));
+    }
+
+    /**
+     * Move a file or folder in the cache
+     *
+     * @param string $source
+     * @param string $target
+     */
+    public function move($source, $target) {
+        $this->getCache()->move($this->getSourcePath($source), $this->getSourcePath($target));
+    }
+
+    /**
+     * Get the storage id and path needed for a move
+     *
+     * @param string $path
+     * @return array [$storageId, $internalPath]
+     */
+    protected function getMoveInfo($path) {
+        return [$this->getNumericStorageId(), $this->getSourcePath($path)];
+    }
+
+    /**
+     * remove all entries for files that are stored on the storage from the cache
+     */
+    public function clear() {
+        $this->getCache()->remove($this->getRoot());
+    }
+
+    /**
+     * @param string $file
+     *
+     * @return int Cache::NOT_FOUND, Cache::PARTIAL, Cache::SHALLOW or Cache::COMPLETE
+     */
+    public function getStatus($file) {
+        return $this->getCache()->getStatus($this->getSourcePath($file));
+    }
+
+    /**
+     * update the folder size and the size of all parent folders
+     *
+     * @param array|ICacheEntry|null $data (optional) meta data of the folder
+     */
+    public function correctFolderSize(string $path, $data = null, bool $isBackgroundScan = false): void {
+        $cache = $this->getCache();
+        if ($cache instanceof Cache) {
+            $cache->correctFolderSize($this->getSourcePath($path), $data, $isBackgroundScan);
+        }
+    }
+
+    /**
+     * get the size of a folder and set it in the cache
+     *
+     * @param string $path
+     * @param array|null|ICacheEntry $entry (optional) meta data of the folder
+     * @return int|float
+     */
+    public function calculateFolderSize($path, $entry = null) {
+        $cache = $this->getCache();
+        if ($cache instanceof Cache) {
+            return $cache->calculateFolderSize($this->getSourcePath($path), $entry);
+        } else {
+            return 0;
+        }
+    }
+
+    /**
+     * get all file ids on the files on the storage
+     *
+     * @return int[]
+     */
+    public function getAll() {
+        // not supported
+        return [];
+    }
+
+    /**
+     * find a folder in the cache which has not been fully scanned
+     *
+     * If multiply incomplete folders are in the cache, the one with the highest id will be returned,
+     * use the one with the highest id gives the best result with the background scanner, since that is most
+     * likely the folder where we stopped scanning previously
+     *
+     * @return string|false the path of the folder or false when no folder matched
+     */
+    public function getIncomplete() {
+        // not supported
+        return false;
+    }
+
+    /**
+     * get the path of a file on this storage by it's id
+     *
+     * @param int $id
+     * @return string|null
+     */
+    public function getPathById($id) {
+        $path = $this->getCache()->getPathById($id);
+        if ($path === null) {
+            return null;
+        }
+
+        return $this->getJailedPath($path);
+    }
+
+    /**
+     * Move a file or folder in the cache
+     *
+     * Note that this should make sure the entries are removed from the source cache
+     *
+     * @param \OCP\Files\Cache\ICache $sourceCache
+     * @param string $sourcePath
+     * @param string $targetPath
+     */
+    public function moveFromCache(\OCP\Files\Cache\ICache $sourceCache, $sourcePath, $targetPath) {
+        if ($sourceCache === $this) {
+            return $this->move($sourcePath, $targetPath);
+        }
+        return $this->getCache()->moveFromCache($sourceCache, $sourcePath, $this->getSourcePath($targetPath));
+    }
+
+    public function getQueryFilterForStorage(): ISearchOperator {
+        return $this->addJailFilterQuery($this->getCache()->getQueryFilterForStorage());
+    }
+
+    protected function addJailFilterQuery(ISearchOperator $filter): ISearchOperator {
+        if ($this->getGetUnjailedRoot() !== '' && $this->getGetUnjailedRoot() !== '/') {
+            return new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_AND,
+                [
+                    $filter,
+                    new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_OR,
+                        [
+                            new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'path', $this->getGetUnjailedRoot()),
+                            new SearchComparison(ISearchComparison::COMPARE_LIKE_CASE_SENSITIVE, 'path', SearchComparison::escapeLikeParameter($this->getGetUnjailedRoot()) . '/%'),
+                        ],
+                    )
+                ]
+            );
+        } else {
+            return $filter;
+        }
+    }
+
+    public function getCacheEntryFromSearchResult(ICacheEntry $rawEntry): ?ICacheEntry {
+        if ($this->getGetUnjailedRoot() === '' || str_starts_with($rawEntry->getPath(), $this->getGetUnjailedRoot())) {
+            $rawEntry = $this->getCache()->getCacheEntryFromSearchResult($rawEntry);
+            if ($rawEntry) {
+                $jailedPath = $this->getJailedPath($rawEntry->getPath());
+                if ($jailedPath !== null) {
+                    return $this->formatCacheEntry(clone $rawEntry) ?: null;
+                }
+            }
+        }
+
+        return null;
+    }
 }