nextcloud / server

apps/theming/lib/ThemingDefaults.php

Spacing +28 added lines, -28 removed lines

@@ -121,13 +121,13 @@ 
 
 		if ($entity !== '') {
 			if ($baseUrl !== '') {
-				$footer = '<a href="' . $baseUrl . '" target="_blank"'
-					. ' rel="noreferrer noopener" class="entity-name">' . $entity . '</a>';
+				$footer = '<a href="'.$baseUrl.'" target="_blank"'
+					. ' rel="noreferrer noopener" class="entity-name">'.$entity.'</a>';
 			} else {
-				$footer = '<span class="entity-name">' . $entity . '</span>';
+				$footer = '<span class="entity-name">'.$entity.'</span>';
 			}
 		}
-		$footer .= ($slogan !== '' ? ' – ' . $slogan : '');
+		$footer .= ($slogan !== '' ? ' – '.$slogan : '');
 
 		$links = [
 			[
@@ -141,7 +141,7 @@ 
 		];
 
 		$navigation = $this->navigationManager->getAll(INavigationManager::TYPE_GUEST);
-		$guestNavigation = array_map(function ($nav) {
+		$guestNavigation = array_map(function($nav) {
 			return [
 				'text' => $nav['name'],
 				'url' => $nav['href']
@@ -155,13 +155,13 @@ 
 			if ($link['url'] !== ''
 				&& filter_var($link['url'], FILTER_VALIDATE_URL)
 			) {
-				$legalLinks .= $divider . '<a href="' . $link['url'] . '" class="legal" target="_blank"'
-					. ' rel="noreferrer noopener">' . $link['text'] . '</a>';
+				$legalLinks .= $divider.'<a href="'.$link['url'].'" class="legal" target="_blank"'
+					. ' rel="noreferrer noopener">'.$link['text'].'</a>';
 				$divider = ' · ';
 			}
 		}
 		if ($legalLinks !== '') {
-			$footer .= '<br/><span class="footer__legal-links">' . $legalLinks . '</span>';
+			$footer .= '<br/><span class="footer__legal-links">'.$legalLinks.'</span>';
 		}
 
 		return $footer;
@@ -270,17 +270,17 @@ 
 			}
 		}
 
-		$cacheBusterCounter = (string)$this->appConfig->getAppValueInt(ConfigLexicon::CACHE_BUSTER);
+		$cacheBusterCounter = (string) $this->appConfig->getAppValueInt(ConfigLexicon::CACHE_BUSTER);
 		if (!$logo || !$logoExists) {
 			if ($useSvg) {
 				$logo = $this->urlGenerator->imagePath('core', 'logo/logo.svg');
 			} else {
 				$logo = $this->urlGenerator->imagePath('core', 'logo/logo.png');
 			}
-			return $logo . '?v=' . $cacheBusterCounter;
+			return $logo.'?v='.$cacheBusterCounter;
 		}
 
-		return $this->urlGenerator->linkToRoute('theming.Theming.getImage', [ 'key' => 'logo', 'useSvg' => $useSvg, 'v' => $cacheBusterCounter ]);
+		return $this->urlGenerator->linkToRoute('theming.Theming.getImage', ['key' => 'logo', 'useSvg' => $useSvg, 'v' => $cacheBusterCounter]);
 	}
 
 	/**
@@ -290,7 +290,7 @@ 
 	 * @return string
 	 */
 	public function getBackground(bool $darkVariant = false): string {
-		return $this->imageManager->getImageUrl('background' . ($darkVariant ? 'Dark' : ''));
+		return $this->imageManager->getImageUrl('background'.($darkVariant ? 'Dark' : ''));
 	}
 
 	/**
@@ -327,23 +327,23 @@ 
 	 */
 	public function getScssVariables() {
 		$cacheBuster = $this->appConfig->getAppValueInt(ConfigLexicon::CACHE_BUSTER);
-		$cache = $this->cacheFactory->createDistributed('theming-' . (string)$cacheBuster . '-' . $this->urlGenerator->getBaseUrl());
+		$cache = $this->cacheFactory->createDistributed('theming-'.(string) $cacheBuster.'-'.$this->urlGenerator->getBaseUrl());
 		if ($value = $cache->get('getScssVariables')) {
 			return $value;
 		}
 
 		$variables = [
-			'theming-cachebuster' => "'" . $cacheBuster . "'",
-			'theming-logo-mime' => "'" . $this->appConfig->getAppValueString('logoMime') . "'",
-			'theming-background-mime' => "'" . $this->appConfig->getAppValueString('backgroundMime') . "'",
-			'theming-logoheader-mime' => "'" . $this->appConfig->getAppValueString('logoheaderMime') . "'",
-			'theming-favicon-mime' => "'" . $this->appConfig->getAppValueString('faviconMime') . "'"
+			'theming-cachebuster' => "'".$cacheBuster."'",
+			'theming-logo-mime' => "'".$this->appConfig->getAppValueString('logoMime')."'",
+			'theming-background-mime' => "'".$this->appConfig->getAppValueString('backgroundMime')."'",
+			'theming-logoheader-mime' => "'".$this->appConfig->getAppValueString('logoheaderMime')."'",
+			'theming-favicon-mime' => "'".$this->appConfig->getAppValueString('faviconMime')."'"
 		];
 
-		$variables['image-logo'] = "url('" . $this->imageManager->getImageUrl('logo') . "')";
-		$variables['image-logoheader'] = "url('" . $this->imageManager->getImageUrl('logoheader') . "')";
-		$variables['image-favicon'] = "url('" . $this->imageManager->getImageUrl('favicon') . "')";
-		$variables['image-login-background'] = "url('" . $this->imageManager->getImageUrl('background') . "')";
+		$variables['image-logo'] = "url('".$this->imageManager->getImageUrl('logo')."')";
+		$variables['image-logoheader'] = "url('".$this->imageManager->getImageUrl('logoheader')."')";
+		$variables['image-favicon'] = "url('".$this->imageManager->getImageUrl('favicon')."')";
+		$variables['image-login-background'] = "url('".$this->imageManager->getImageUrl('background')."')";
 		$variables['image-login-plain'] = 'false';
 
 		if ($this->appConfig->getAppValueString('primary_color', '') !== '') {
@@ -388,19 +388,19 @@ 
 		if ($image === 'manifest.json') {
 			try {
 				$appPath = $this->appManager->getAppPath($app);
-				if (file_exists($appPath . '/img/manifest.json')) {
+				if (file_exists($appPath.'/img/manifest.json')) {
 					return false;
 				}
 			} catch (AppPathNotFoundException $e) {
 			}
-			$route = $this->urlGenerator->linkToRoute('theming.Theming.getManifest', ['app' => $app ]);
+			$route = $this->urlGenerator->linkToRoute('theming.Theming.getManifest', ['app' => $app]);
 		}
-		if (str_starts_with($image, 'filetypes/') && file_exists(\OC::$SERVERROOT . '/core/img/' . $image)) {
+		if (str_starts_with($image, 'filetypes/') && file_exists(\OC::$SERVERROOT.'/core/img/'.$image)) {
 			$route = $this->urlGenerator->linkToRoute('theming.Icon.getThemedIcon', ['app' => $app, 'image' => $image]);
 		}
 
 		if ($route) {
-			return $route . '?v=' . $this->util->getCacheBuster();
+			return $route.'?v='.$this->util->getCacheBuster();
 		}
 
 		return false;
@@ -433,7 +433,7 @@ 
 	public function set($setting, $value): void {
 		switch ($setting) {
 			case ConfigLexicon::CACHE_BUSTER:
-				$this->appConfig->setAppValueInt(ConfigLexicon::CACHE_BUSTER, (int)$value);
+				$this->appConfig->setAppValueInt(ConfigLexicon::CACHE_BUSTER, (int) $value);
 				break;
 			case ConfigLexicon::USER_THEMING_DISABLED:
 				$value = in_array($value, ['1', 'true', 'yes', 'on']);
@@ -494,7 +494,7 @@ 
 			case 'background':
 			case 'favicon':
 				$this->imageManager->delete($setting);
-				$this->appConfig->deleteAppValue($setting . 'Mime');
+				$this->appConfig->deleteAppValue($setting.'Mime');
 				break;
 		}
 

apps/theming/tests/ThemingDefaultsTest.php

Spacing +5 added lines, -5 removed lines

@@ -339,8 +339,8 @@ 
 
 	public static function invalidLegalUrlProvider(): array {
 		return [
-			['example.com/legal'],  # missing scheme
-			['https:///legal'],     # missing host
+			['example.com/legal'], # missing scheme
+			['https:///legal'], # missing host
 		];
 	}
 
@@ -664,7 +664,7 @@ 
 			->method('linkToRoute')
 			->with('theming.Theming.getImage')
 			->willReturn('custom-logo?v=0');
-		$this->assertEquals('custom-logo' . '?v=0', $this->template->getLogo());
+		$this->assertEquals('custom-logo'.'?v=0', $this->template->getLogo());
 	}
 
 	public function testGetScssVariablesCached(): void {
@@ -804,7 +804,7 @@ 
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('dataReplaceImagePath')]
-	public function testReplaceImagePath(string $app, string $image, string|bool $result = 'themingRoute?v=1234abcd'): void {
+	public function testReplaceImagePath(string $app, string $image, string | bool $result = 'themingRoute?v=1234abcd'): void {
 		$this->cache->expects($this->any())
 			->method('get')
 			->with('shouldReplaceIcons')
@@ -838,7 +838,7 @@ 
 	#[\PHPUnit\Framework\Attributes\DataProvider('setTypesProvider')]
 	public function testSetTypes(string $setting, string $value, mixed $expected): void {
 		$setValue = null;
-		$cb = function ($setting, $value) use (&$setValue) {
+		$cb = function($setting, $value) use (&$setValue) {
 			if ($setting !== ConfigLexicon::CACHE_BUSTER) {
 				$setValue = $value;
 			}