Passed
Push — master ( 3c2dd0...7c6e77 )
by Robin
10:46 queued 14s
created
apps/dav/lib/Connector/Sabre/ChecksumList.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 	 */
65 65
 	public function xmlSerialize(Writer $writer) {
66 66
 		foreach ($this->checksums as $checksum) {
67
-			$writer->writeElement('{' . self::NS_OWNCLOUD . '}checksum', $checksum);
67
+			$writer->writeElement('{'.self::NS_OWNCLOUD.'}checksum', $checksum);
68 68
 		}
69 69
 	}
70 70
 }
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ShareTypeList.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -71,8 +71,8 @@  discard block
 block discarded – undo
71 71
 			return null;
72 72
 		}
73 73
 		foreach ($tree as $elem) {
74
-			if ($elem['name'] === '{' . self::NS_OWNCLOUD . '}share-type') {
75
-				$shareTypes[] = (int)$elem['value'];
74
+			if ($elem['name'] === '{'.self::NS_OWNCLOUD.'}share-type') {
75
+				$shareTypes[] = (int) $elem['value'];
76 76
 			}
77 77
 		}
78 78
 		return new self($shareTypes);
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 	 */
87 87
 	public function xmlSerialize(Writer $writer) {
88 88
 		foreach ($this->shareTypes as $shareType) {
89
-			$writer->writeElement('{' . self::NS_OWNCLOUD . '}share-type', $shareType);
89
+			$writer->writeElement('{'.self::NS_OWNCLOUD.'}share-type', $shareType);
90 90
 		}
91 91
 	}
92 92
 }
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Search/Xml/Filter/SearchTermFilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
 	public static function xmlDeserialize(Reader $reader) {
36 36
 		$value = $reader->parseInnerTree();
37 37
 		if (!is_string($value)) {
38
-			throw new BadRequest('The {' . SearchPlugin::NS_Nextcloud . '}search-term has illegal value');
38
+			throw new BadRequest('The {'.SearchPlugin::NS_Nextcloud.'}search-term has illegal value');
39 39
 		}
40 40
 
41 41
 		return $value;
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsObjectMappingCollection.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -94,15 +94,15 @@  discard block
 block discarded – undo
94 94
 			$tags = $this->tagManager->getTagsByIds([$tagId]);
95 95
 			$tag = current($tags);
96 96
 			if (!$this->tagManager->canUserSeeTag($tag, $this->user)) {
97
-				throw new PreconditionFailed('Tag with id ' . $tagId . ' does not exist, cannot assign');
97
+				throw new PreconditionFailed('Tag with id '.$tagId.' does not exist, cannot assign');
98 98
 			}
99 99
 			if (!$this->tagManager->canUserAssignTag($tag, $this->user)) {
100
-				throw new Forbidden('No permission to assign tag ' . $tagId);
100
+				throw new Forbidden('No permission to assign tag '.$tagId);
101 101
 			}
102 102
 
103 103
 			$this->tagMapper->assignTags($this->objectId, $this->objectType, $tagId);
104 104
 		} catch (TagNotFoundException $e) {
105
-			throw new PreconditionFailed('Tag with id ' . $tagId . ' does not exist, cannot assign');
105
+			throw new PreconditionFailed('Tag with id '.$tagId.' does not exist, cannot assign');
106 106
 		}
107 107
 	}
108 108
 
@@ -119,11 +119,11 @@  discard block
 block discarded – undo
119 119
 					return $this->makeNode($tag);
120 120
 				}
121 121
 			}
122
-			throw new NotFound('Tag with id ' . $tagId . ' not present for object ' . $this->objectId);
122
+			throw new NotFound('Tag with id '.$tagId.' not present for object '.$this->objectId);
123 123
 		} catch (\InvalidArgumentException $e) {
124 124
 			throw new BadRequest('Invalid tag id', 0, $e);
125 125
 		} catch (TagNotFoundException $e) {
126
-			throw new NotFound('Tag with id ' . $tagId . ' not found', 0, $e);
126
+			throw new NotFound('Tag with id '.$tagId.' not found', 0, $e);
127 127
 		}
128 128
 	}
129 129
 
@@ -135,11 +135,11 @@  discard block
 block discarded – undo
135 135
 		$tags = $this->tagManager->getTagsByIds($tagIds);
136 136
 
137 137
 		// filter out non-visible tags
138
-		$tags = array_filter($tags, function ($tag) {
138
+		$tags = array_filter($tags, function($tag) {
139 139
 			return $this->tagManager->canUserSeeTag($tag, $this->user);
140 140
 		});
141 141
 
142
-		return array_values(array_map(function ($tag) {
142
+		return array_values(array_map(function($tag) {
143 143
 			return $this->makeNode($tag);
144 144
 		}, $tags));
145 145
 	}
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsByIdCollection.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -104,13 +104,13 @@  discard block
 block discarded – undo
104 104
 			$tag = $this->tagManager->getTagsByIds([$name]);
105 105
 			$tag = current($tag);
106 106
 			if (!$this->tagManager->canUserSeeTag($tag, $this->userSession->getUser())) {
107
-				throw new NotFound('Tag with id ' . $name . ' not found');
107
+				throw new NotFound('Tag with id '.$name.' not found');
108 108
 			}
109 109
 			return $this->makeNode($tag);
110 110
 		} catch (\InvalidArgumentException $e) {
111 111
 			throw new BadRequest('Invalid tag id', 0, $e);
112 112
 		} catch (TagNotFoundException $e) {
113
-			throw new NotFound('Tag with id ' . $name . ' not found', 0, $e);
113
+			throw new NotFound('Tag with id '.$name.' not found', 0, $e);
114 114
 		}
115 115
 	}
116 116
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 		}
122 122
 
123 123
 		$tags = $this->tagManager->getAllTags($visibilityFilter);
124
-		return array_map(function ($tag) {
124
+		return array_map(function($tag) {
125 125
 			return $this->makeNode($tag);
126 126
 		}, $tags);
127 127
 	}
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagPlugin.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 			if ($node instanceof SystemTagsObjectMappingCollection) {
134 134
 				// also add to collection
135 135
 				$node->createFile($tag->getId());
136
-				$url = $request->getBaseUrl() . 'systemtags/';
136
+				$url = $request->getBaseUrl().'systemtags/';
137 137
 			} else {
138 138
 				$url = $request->getUrl();
139 139
 			}
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 				$url .= '/';
143 143
 			}
144 144
 
145
-			$response->setHeader('Content-Location', $url . $tag->getId());
145
+			$response->setHeader('Content-Location', $url.$tag->getId());
146 146
 
147 147
 			// created
148 148
 			$response->setStatus(201);
@@ -177,11 +177,11 @@  discard block
 block discarded – undo
177 177
 		$userAssignable = true;
178 178
 
179 179
 		if (isset($data['userVisible'])) {
180
-			$userVisible = (bool)$data['userVisible'];
180
+			$userVisible = (bool) $data['userVisible'];
181 181
 		}
182 182
 
183 183
 		if (isset($data['userAssignable'])) {
184
-			$userAssignable = (bool)$data['userAssignable'];
184
+			$userAssignable = (bool) $data['userAssignable'];
185 185
 		}
186 186
 
187 187
 		$groups = [];
@@ -224,29 +224,29 @@  discard block
 block discarded – undo
224 224
 			return;
225 225
 		}
226 226
 
227
-		$propFind->handle(self::ID_PROPERTYNAME, function () use ($node) {
227
+		$propFind->handle(self::ID_PROPERTYNAME, function() use ($node) {
228 228
 			return $node->getSystemTag()->getId();
229 229
 		});
230 230
 
231
-		$propFind->handle(self::DISPLAYNAME_PROPERTYNAME, function () use ($node) {
231
+		$propFind->handle(self::DISPLAYNAME_PROPERTYNAME, function() use ($node) {
232 232
 			return $node->getSystemTag()->getName();
233 233
 		});
234 234
 
235
-		$propFind->handle(self::USERVISIBLE_PROPERTYNAME, function () use ($node) {
235
+		$propFind->handle(self::USERVISIBLE_PROPERTYNAME, function() use ($node) {
236 236
 			return $node->getSystemTag()->isUserVisible() ? 'true' : 'false';
237 237
 		});
238 238
 
239
-		$propFind->handle(self::USERASSIGNABLE_PROPERTYNAME, function () use ($node) {
239
+		$propFind->handle(self::USERASSIGNABLE_PROPERTYNAME, function() use ($node) {
240 240
 			// this is the tag's inherent property "is user assignable"
241 241
 			return $node->getSystemTag()->isUserAssignable() ? 'true' : 'false';
242 242
 		});
243 243
 
244
-		$propFind->handle(self::CANASSIGN_PROPERTYNAME, function () use ($node) {
244
+		$propFind->handle(self::CANASSIGN_PROPERTYNAME, function() use ($node) {
245 245
 			// this is the effective permission for the current user
246 246
 			return $this->tagManager->canUserAssignTag($node->getSystemTag(), $this->userSession->getUser()) ? 'true' : 'false';
247 247
 		});
248 248
 
249
-		$propFind->handle(self::GROUPS_PROPERTYNAME, function () use ($node) {
249
+		$propFind->handle(self::GROUPS_PROPERTYNAME, function() use ($node) {
250 250
 			if (!$this->groupManager->isAdmin($this->userSession->getUser()->getUID())) {
251 251
 				// property only available for admins
252 252
 				throw new Forbidden();
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 			self::USERVISIBLE_PROPERTYNAME,
280 280
 			self::USERASSIGNABLE_PROPERTYNAME,
281 281
 			self::GROUPS_PROPERTYNAME,
282
-		], function ($props) use ($node) {
282
+		], function($props) use ($node) {
283 283
 			$tag = $node->getSystemTag();
284 284
 			$name = $tag->getName();
285 285
 			$userVisible = $tag->isUserVisible();
Please login to merge, or discard this patch.
apps/dav/lib/Upload/UploadFolder.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
 	}
40 40
 
41 41
 	public function createDirectory($name) {
42
-		throw new Forbidden('Permission denied to create file (filename ' . $name . ')');
42
+		throw new Forbidden('Permission denied to create file (filename '.$name.')');
43 43
 	}
44 44
 
45 45
 	public function getChild($name) {
Please login to merge, or discard this patch.
apps/dav/lib/Upload/FutureFile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
 	 */
85 85
 	public function getSize() {
86 86
 		$children = $this->root->getChildren();
87
-		$sizes = array_map(function ($node) {
87
+		$sizes = array_map(function($node) {
88 88
 			/** @var IFile $node */
89 89
 			return $node->getSize();
90 90
 		}, $children);
Please login to merge, or discard this patch.
apps/dav/appinfo/v1/webdav.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
 
63 63
 $requestUri = \OC::$server->getRequest()->getRequestUri();
64 64
 
65
-$server = $serverFactory->createServer($baseuri, $requestUri, $authPlugin, function () {
65
+$server = $serverFactory->createServer($baseuri, $requestUri, $authPlugin, function() {
66 66
 	// use the view for the logged in user
67 67
 	return \OC\Files\Filesystem::getView();
68 68
 });
Please login to merge, or discard this patch.