Passed
Push — master ( 130535...64f1ad )
by John
12:54 queued 12s
created
apps/settings/templates/settings/admin/overview.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -28,40 +28,40 @@
 block discarded – undo
28 28
 ?>
29 29
 
30 30
 <div id="security-warning" class="section">
31
-	<h2 class="inlineblock"><?php p($l->t('Security & setup warnings'));?></h2>
32
-	<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation'));?>" href="<?php p(link_to_docs('admin-warnings')); ?>"></a>
33
-	<p class="settings-hint"><?php p($l->t('It\'s important for the security and performance of your instance that everything is configured correctly. To help you with that we are doing some automatic checks. Please see the linked documentation for more information.'));?></p>
31
+	<h2 class="inlineblock"><?php p($l->t('Security & setup warnings')); ?></h2>
32
+	<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation')); ?>" href="<?php p(link_to_docs('admin-warnings')); ?>"></a>
33
+	<p class="settings-hint"><?php p($l->t('It\'s important for the security and performance of your instance that everything is configured correctly. To help you with that we are doing some automatic checks. Please see the linked documentation for more information.')); ?></p>
34 34
 
35 35
 	<div id="security-warning-state-ok" class="hidden">
36
-		<span class="icon icon-checkmark-white"></span><span class="message"><?php p($l->t('All checks passed.'));?></span>
36
+		<span class="icon icon-checkmark-white"></span><span class="message"><?php p($l->t('All checks passed.')); ?></span>
37 37
 	</div>
38 38
 	<div id="security-warning-state-failure" class="hidden">
39
-		<span class="icon icon-close-white"></span><span class="message"><?php p($l->t('There are some errors regarding your setup.'));?></span>
39
+		<span class="icon icon-close-white"></span><span class="message"><?php p($l->t('There are some errors regarding your setup.')); ?></span>
40 40
 	</div>
41 41
 	<div id="security-warning-state-warning" class="hidden">
42
-		<span class="icon icon-error-white"></span><span class="message"><?php p($l->t('There are some warnings regarding your setup.'));?></span>
42
+		<span class="icon icon-error-white"></span><span class="message"><?php p($l->t('There are some warnings regarding your setup.')); ?></span>
43 43
 	</div>
44 44
 	<div id="security-warning-state-loading">
45
-		<span class="icon loading"></span><span class="message"><?php p($l->t('Checking for system and security issues.'));?></span>
45
+		<span class="icon loading"></span><span class="message"><?php p($l->t('Checking for system and security issues.')); ?></span>
46 46
 	</div>
47 47
 
48
-	<div id="postsetupchecks" data-check-wellknown="<?php if($_['checkForWorkingWellKnownSetup']) { p('true'); } else { p('false'); } ?>">
48
+	<div id="postsetupchecks" data-check-wellknown="<?php if ($_['checkForWorkingWellKnownSetup']) { p('true'); } else { p('false'); } ?>">
49 49
 		<ul class="errors hidden"></ul>
50 50
 		<ul class="warnings hidden"></ul>
51 51
 		<ul class="info hidden"></ul>
52 52
 	</div>
53 53
 	<p id="postsetupchecks-hint" class="hidden">
54
-		<?php print_unescaped($l->t('Please double check the <a target="_blank" rel="noreferrer noopener" href="%1$s">installation guides ↗</a>, and check for any errors or warnings in the <a href="%2$s">log</a>.', [link_to_docs('admin-install'), \OC::$server->getURLGenerator()->linkToRoute('settings.AdminSettings.index', ['section' => 'logging'])] )); ?>
54
+		<?php print_unescaped($l->t('Please double check the <a target="_blank" rel="noreferrer noopener" href="%1$s">installation guides ↗</a>, and check for any errors or warnings in the <a href="%2$s">log</a>.', [link_to_docs('admin-install'), \OC::$server->getURLGenerator()->linkToRoute('settings.AdminSettings.index', ['section' => 'logging'])])); ?>
55 55
 	</p>
56 56
 
57 57
 	<p class="extra-top-margin">
58
-		<?php print_unescaped($l->t('Check the security of your Nextcloud over <a target="_blank" rel="noreferrer noopener" href="%s">our security scan ↗</a>.', ['https://scan.nextcloud.com']));?>
58
+		<?php print_unescaped($l->t('Check the security of your Nextcloud over <a target="_blank" rel="noreferrer noopener" href="%s">our security scan ↗</a>.', ['https://scan.nextcloud.com'])); ?>
59 59
 	</p>
60 60
 
61 61
 </div>
62 62
 
63 63
 <div id="version" class="section">
64 64
 	<!-- should be the last part, so Updater can follow if enabled (it has no heading therefore). -->
65
-	<h2><?php p($l->t('Version'));?></h2>
65
+	<h2><?php p($l->t('Version')); ?></h2>
66 66
 	<p><strong><a href="<?php print_unescaped($theme->getBaseUrl()); ?>" rel="noreferrer noopener" target="_blank"><?php p($theme->getTitle()); ?></a> <?php p(OC_Util::getHumanVersion()) ?></strong></p>
67 67
 </div>
Please login to merge, or discard this patch.
apps/settings/templates/settings/admin/security.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -29,15 +29,15 @@
 block discarded – undo
29 29
 ?>
30 30
 
31 31
 <div id="two-factor-auth" class="section">
32
-	<h2><?php p($l->t('Two-Factor Authentication'));?></h2>
33
-	<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation'));?>" href="<?php p(link_to_docs('admin-2fa')); ?>"></a>
32
+	<h2><?php p($l->t('Two-Factor Authentication')); ?></h2>
33
+	<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation')); ?>" href="<?php p(link_to_docs('admin-2fa')); ?>"></a>
34 34
 	<div id="two-factor-auth-settings"></div>
35 35
 </div>
36 36
 
37 37
 <div class="section" id='encryptionAPI'>
38 38
 	<h2><?php p($l->t('Server-side encryption')); ?></h2>
39 39
 	<a target="_blank" rel="noreferrer noopener" class="icon-info"
40
-	   title="<?php p($l->t('Open documentation'));?>"
40
+	   title="<?php p($l->t('Open documentation')); ?>"
41 41
 	   href="<?php p(link_to_docs('admin-encryption')); ?>"></a>
42 42
 	<p class="settings-hint"><?php p($l->t('Server-side encryption makes it possible to encrypt files which are uploaded to this server. This comes with limitations like a performance penalty, so enable this only if needed.')); ?></p>
43 43
 	<p id="enable">
Please login to merge, or discard this patch.
apps/theming/templates/settings-admin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 ?>
29 29
 <div id="theming" class="section">
30 30
 	<h2 class="inlineblock"><?php p($l->t('Theming')); ?></h2>
31
-	<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation'));?>" href="<?php p(link_to_docs('admin-theming')); ?>"></a>
31
+	<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation')); ?>" href="<?php p(link_to_docs('admin-theming')); ?>"></a>
32 32
         <p class="settings-hint"><?php p($l->t('Theming makes it possible to easily customize the look and feel of your instance and supported clients. This will be visible for all users.')); ?></p>
33 33
 		<div id="theming_settings_status">
34 34
 			<div id="theming_settings_loading" class="icon-loading-small" style="display: none;"></div>
Please login to merge, or discard this patch.
apps/files_external/templates/settings.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -96,9 +96,9 @@
 block discarded – undo
96 96
 	<h2><?php p($l->t('No external storage configured or you don\'t have the permission to configure them')); ?></h2>
97 97
 </div>
98 98
 
99
-<form data-can-create="<?php echo $canCreateMounts?'true':'false' ?>" id="files_external" class="section" data-encryption-enabled="<?php echo $_['encryptionEnabled']?'true': 'false'; ?>">
99
+<form data-can-create="<?php echo $canCreateMounts ? 'true' : 'false' ?>" id="files_external" class="section" data-encryption-enabled="<?php echo $_['encryptionEnabled'] ? 'true' : 'false'; ?>">
100 100
 	<h2 class="inlineblock" data-anchor-name="external-storage"><?php p($l->t('External storages')); ?></h2>
101
-	<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation'));?>" href="<?php p(link_to_docs('admin-external-storage')); ?>"></a>
101
+	<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation')); ?>" href="<?php p(link_to_docs('admin-external-storage')); ?>"></a>
102 102
 	<p class="settings-hint"><?php p($l->t('External storage enables you to mount external storage services and devices as secondary Nextcloud storage devices. You may also allow users to mount their own external storage services.')); ?></p>
103 103
 	<?php if (isset($_['dependencies']) and ($_['dependencies'] !== '') and $canCreateMounts) print_unescaped(''.$_['dependencies'].''); ?>
104 104
 	<table id="externalStorage" class="grid" data-admin='<?php print_unescaped(json_encode($_['visibilityType'] === BackendService::VISIBILITY_ADMIN)); ?>'>
Please login to merge, or discard this patch.
Braces   +24 added lines, -6 removed lines patch added patch discarded remove patch
@@ -100,7 +100,10 @@  discard block
 block discarded – undo
100 100
 	<h2 class="inlineblock" data-anchor-name="external-storage"><?php p($l->t('External storages')); ?></h2>
101 101
 	<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation'));?>" href="<?php p(link_to_docs('admin-external-storage')); ?>"></a>
102 102
 	<p class="settings-hint"><?php p($l->t('External storage enables you to mount external storage services and devices as secondary Nextcloud storage devices. You may also allow users to mount their own external storage services.')); ?></p>
103
-	<?php if (isset($_['dependencies']) and ($_['dependencies'] !== '') and $canCreateMounts) print_unescaped(''.$_['dependencies'].''); ?>
103
+	<?php if (isset($_['dependencies']) and ($_['dependencies'] !== '') and $canCreateMounts) {
104
+    print_unescaped(''.$_['dependencies'].'');
105
+}
106
+?>
104 107
 	<table id="externalStorage" class="grid" data-admin='<?php print_unescaped(json_encode($_['visibilityType'] === BackendService::VISIBILITY_ADMIN)); ?>'>
105 108
 		<thead>
106 109
 			<tr>
@@ -109,7 +112,10 @@  discard block
 block discarded – undo
109 112
 				<th><?php p($l->t('External storage')); ?></th>
110 113
 				<th><?php p($l->t('Authentication')); ?></th>
111 114
 				<th><?php p($l->t('Configuration')); ?></th>
112
-				<?php if ($_['visibilityType'] === BackendService::VISIBILITY_ADMIN) print_unescaped('<th>'.$l->t('Available for').'</th>'); ?>
115
+				<?php if ($_['visibilityType'] === BackendService::VISIBILITY_ADMIN) {
116
+    print_unescaped('<th>'.$l->t('Available for').'</th>');
117
+}
118
+?>
113 119
 				<th>&nbsp;</th>
114 120
 				<th>&nbsp;</th>
115 121
 				<th>&nbsp;</th>
@@ -142,7 +148,10 @@  discard block
 block discarded – undo
142 148
 							});
143 149
 						?>
144 150
 						<?php foreach ($sortedBackends as $backend): ?>
145
-							<?php if ($backend->getDeprecateTo()) continue; // ignore deprecated backends ?>
151
+							<?php if ($backend->getDeprecateTo()) {
152
+    continue;
153
+}
154
+// ignore deprecated backends ?>
146 155
 							<option value="<?php p($backend->getIdentifier()); ?>"><?php p($backend->getText()); ?></option>
147 156
 						<?php endforeach; ?>
148 157
 					</select>
@@ -167,7 +176,10 @@  discard block
 block discarded – undo
167 176
 
168 177
 	<?php if ($_['visibilityType'] === BackendService::VISIBILITY_ADMIN): ?>
169 178
 		<input type="checkbox" name="allowUserMounting" id="allowUserMounting" class="checkbox"
170
-			value="1" <?php if ($_['allowUserMounting']) print_unescaped(' checked="checked"'); ?> />
179
+			value="1" <?php if ($_['allowUserMounting']) {
180
+    print_unescaped(' checked="checked"');
181
+}
182
+?> />
171 183
 		<label for="allowUserMounting"><?php p($l->t('Allow users to mount external storage')); ?></label> <span id="userMountingMsg" class="msg"></span>
172 184
 
173 185
 		<p id="userMountingBackends"<?php if (!$_['allowUserMounting']): ?> class="hidden"<?php endif; ?>>
@@ -179,8 +191,14 @@  discard block
 block discarded – undo
179 191
 			<?php $i = 0; foreach ($userBackends as $backend): ?>
180 192
 				<?php if ($deprecateTo = $backend->getDeprecateTo()): ?>
181 193
 					<input type="hidden" id="allowUserMountingBackends<?php p($i); ?>" name="allowUserMountingBackends[]" value="<?php p($backend->getIdentifier()); ?>" data-deprecate-to="<?php p($deprecateTo->getIdentifier()); ?>" />
182
-				<?php else: ?>
183
-					<input type="checkbox" id="allowUserMountingBackends<?php p($i); ?>" class="checkbox" name="allowUserMountingBackends[]" value="<?php p($backend->getIdentifier()); ?>" <?php if ($backend->isVisibleFor(BackendService::VISIBILITY_PERSONAL)) print_unescaped(' checked="checked"'); ?> />
194
+				<?php else {
195
+    : ?>
196
+					<input type="checkbox" id="allowUserMountingBackends<?php p($i);
197
+}
198
+?>" class="checkbox" name="allowUserMountingBackends[]" value="<?php p($backend->getIdentifier()); ?>" <?php if ($backend->isVisibleFor(BackendService::VISIBILITY_PERSONAL)) {
199
+    print_unescaped(' checked="checked"');
200
+}
201
+?> />
184 202
 					<label for="allowUserMountingBackends<?php p($i); ?>"><?php p($backend->getText()); ?></label> <br />
185 203
 				<?php endif; ?>
186 204
 				<?php $i++; ?>
Please login to merge, or discard this patch.