Issues in SubscriptionMapperTest.php (master) - Issues in master - nextcloud/polls - Measure and Improve Code Quality continuously with Scrutinizer

Issues (27)

tests/Unit/Db/SubscriptionMapperTest.php (2 issues)

Labels

Severity

Minor 2

<?php declare(strict_types=1);
/**
 * @copyright Copyright (c) 2017 Kai Schröer <[email protected]>
 *
 * @author Kai Schröer <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU Affero General Public License as
 *  published by the Free Software Foundation, either version 3 of the
 *  License, or (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU Affero General Public License for more details.
 *
 *  You should have received a copy of the GNU Affero General Public License
 *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Polls\Tests\Unit\Db;

use League\FactoryMuffin\Faker\Facade as Faker;
use OCP\IDBConnection;
use OCA\Polls\Tests\Unit\UnitTestCase;

use OCA\Polls\Db\Poll;
use OCA\Polls\Db\PollMapper;
use OCA\Polls\Db\Subscription;
use OCA\Polls\Db\SubscriptionMapper;

class SubscriptionMapperTest extends UnitTestCase {

	/** @var IDBConnection */
	private $con;

	/** @var SubscriptionMapper */
	private $subscriptionMapper;

	/** @var PollMapper */
	private $pollMapper;

	/** @var array */
	private $polls = [];

	/** @var array */
	private $subscriptions = [];

	/** @var array */
	private $users = [];


	/**
	 * {@inheritDoc}
	 */
	protected function setUp(): void {
		parent::setUp();
		$this->con = \OC::$server->getDatabaseConnection();
		$this->subscriptionMapper = new SubscriptionMapper($this->con);
		$this->pollMapper = new PollMapper($this->con);

		$this->polls = [
			$this->fm->instance('OCA\Polls\Db\Poll')
		];

		foreach ($this->polls as &$poll) {
			$poll = $this->pollMapper->insert($poll);

			for ($count=0; $count < 2; $count++) {
				$subscription = $this->fm->instance('OCA\Polls\Db\Subscription');
				$subscription->setPollId($poll->getId());
				array_push($this->subscriptions, $this->subscriptionMapper->insert($subscription));
			}
			$this->users[$poll->getId()] = $subscription->getUserId();

		}
		unset($poll);
	}

	/**
	 * testFindAllByPoll
	 */
	public function testFindAllByPoll() {
		foreach ($this->polls as $poll) {
			$this->assertTrue(count($this->subscriptionMapper->findAllByPoll($poll->getId())) > 0);
		}
	}

	/**
	 * testfindByPollAndUser
	 */
	public function testfindByPollAndUser() {
		foreach ($this->polls as $poll) {
			$this->assertInstanceOf(Subscription::class, $this->subscriptionMapper->findByPollAndUser($poll->getId(), $this->users[$poll->getId()]));
		}
	}
	/**
	 * testUnsubscribe
	 */
	public function testUnsubscribe() {
		foreach ($this->polls as $poll) {
			$this->assertNull($this->subscriptionMapper->unsubscribe($poll->getId(), $this->users[$poll->getId()]));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
		}
	}

	/**
	 * tearDown
	 */
	public function tearDown(): void {
		parent::tearDown();
		foreach ($this->polls as $poll) {
			$this->pollMapper->delete($poll);
		}
	}

}


1			<?php declare(strict_types=1);
2			/**
3			* @copyright Copyright (c) 2017 Kai Schröer <[email protected]>
4			*
5			* @author Kai Schröer <[email protected]>
6			*
7			* @license GNU AGPL version 3 or any later version
8			*
9			* This program is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License as
11			* published by the Free Software Foundation, either version 3 of the
12			* License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU Affero General Public License for more details.
18			*
19			* You should have received a copy of the GNU Affero General Public License
20			* along with this program. If not, see <http://www.gnu.org/licenses/>.
21			*
22			*/
23
24			namespace OCA\Polls\Tests\Unit\Db;
25
26			use League\FactoryMuffin\Faker\Facade as Faker;
27			use OCP\IDBConnection;
28			use OCA\Polls\Tests\Unit\UnitTestCase;
29
30			use OCA\Polls\Db\Poll;
31			use OCA\Polls\Db\PollMapper;
32			use OCA\Polls\Db\Subscription;
33			use OCA\Polls\Db\SubscriptionMapper;
34
35			class SubscriptionMapperTest extends UnitTestCase {
36
37			/** @var IDBConnection */
38			private $con;
39
40			/** @var SubscriptionMapper */
41			private $subscriptionMapper;
42
43			/** @var PollMapper */
44			private $pollMapper;
45
46			/** @var array */
47			private $polls = [];
48
49			/** @var array */
50			private $subscriptions = [];
51
52			/** @var array */
53			private $users = [];
54
55
56			/**
57			* {@inheritDoc}
58			*/
59			protected function setUp(): void {
60			parent::setUp();
61			$this->con = \OC::$server->getDatabaseConnection();
62			$this->subscriptionMapper = new SubscriptionMapper($this->con);
63			$this->pollMapper = new PollMapper($this->con);
64
65			$this->polls = [
66			$this->fm->instance('OCA\Polls\Db\Poll')
67			];
68
69			foreach ($this->polls as &$poll) {
70			$poll = $this->pollMapper->insert($poll);
71
72			for ($count=0; $count < 2; $count++) {
73			$subscription = $this->fm->instance('OCA\Polls\Db\Subscription');
74			$subscription->setPollId($poll->getId());
75			array_push($this->subscriptions, $this->subscriptionMapper->insert($subscription));
76			}
77			$this->users[$poll->getId()] = $subscription->getUserId();
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-11-29 08:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$subscription` does not seem to be defined for all execution paths leading up to this point. Loading history...
78			}
79			unset($poll);
80			}
81
82			/**
83			* testFindAllByPoll
84			*/
85			public function testFindAllByPoll() {
86			foreach ($this->polls as $poll) {
87			$this->assertTrue(count($this->subscriptionMapper->findAllByPoll($poll->getId())) > 0);
88			}
89			}
90
91			/**
92			* testfindByPollAndUser
93			*/
94			public function testfindByPollAndUser() {
95			foreach ($this->polls as $poll) {
96			$this->assertInstanceOf(Subscription::class, $this->subscriptionMapper->findByPollAndUser($poll->getId(), $this->users[$poll->getId()]));
97			}
98			}
99			/**
100			* testUnsubscribe
101			*/
102			public function testUnsubscribe() {
103			foreach ($this->polls as $poll) {
104			$this->assertNull($this->subscriptionMapper->unsubscribe($poll->getId(), $this->users[$poll->getId()]));
			0 ignored issues – show Bug introduced 2020-12-05 18:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->subscriptionMappe...>users[$poll->getId()])` targeting `OCA\Polls\Db\SubscriptionMapper::unsubscribe()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
105			}
106			}
107
108			/**
109			* tearDown
110			*/
111			public function tearDown(): void {
112			parent::tearDown();
113			foreach ($this->polls as $poll) {
114			$this->pollMapper->delete($poll);
115			}
116			}
117
118			}
119

nextcloud / polls

Issues (27)

tests/Unit/Db/SubscriptionMapperTest.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like