Inspection of "Fixed typo" - nextcloud/polls - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#604)

by rakekniven

created 2019-06-22 15:02 UTC

Status

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -132,7 +132,7 @@  discard block
 block discarded – undo
 	 * @return Boolean
 	 */
 	private function checkUserAccess($accessList) {
-		foreach ($accessList as $accessItem ) {
+		foreach ($accessList as $accessItem) {
 			if ($accessItem['type'] === 'user' && $accessItem['id'] === \OC::$server->getUserSession()->getUser()->getUID()) {
 				return true;
 			}
@@ -146,8 +146,8 @@  discard block
 block discarded – undo
 	 * @return Boolean
 	 */
 	private function checkGroupAccess($accessList) {
-		foreach ($accessList as $accessItem ) {
-			if ($accessItem['type'] === 'group' && $this->groupManager->isInGroup(\OC::$server->getUserSession()->getUser()->getUID(),$accessItem['id'])) {
+		foreach ($accessList as $accessItem) {
+			if ($accessItem['type'] === 'group' && $this->groupManager->isInGroup(\OC::$server->getUserSession()->getUser()->getUID(), $accessItem['id'])) {
 				return true;
 			}
 		}

Please login to merge, or discard this patch.

templates/vote.tmpl.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -234,7 +234,7 @@
 block discarded – undo
 								// look what user voted for this dts
 								foreach ($others[$usr] as $vote) {
 									if ($optionElement->getPollOptionText() === $vote->getVoteOptionText()) {
-										$class = $vote->getVoteAnswer() . ' icon-'.$vote->getVoteAnswer();
+										$class = $vote->getVoteAnswer() . ' icon-' . $vote->getVoteAnswer();
 										break;
 									}
 									$class = 'no icon-no';

Please login to merge, or discard this patch.

lib/Controller/PageController.php 1 patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -131,27 +131,27 @@
 block discarded – undo
 	}
 
 	/**
-	* @NoAdminRequired
-	* @NoCSRFRequired
-	*/
+	 * @NoAdminRequired
+	 * @NoCSRFRequired
+	 */
 	public function index() {
 		return new TemplateResponse('polls', 'polls.tmpl',
 		['urlGenerator' => $this->urlGenerator]);
 	}
 
 	/**
-	* @NoAdminRequired
-	* @NoCSRFRequired
-	*/
+	 * @NoAdminRequired
+	 * @NoCSRFRequired
+	 */
 	public function createPoll() {
 		return new TemplateResponse('polls', 'polls.tmpl',
 		['urlGenerator' => $this->urlGenerator]);
 	}
 
 	/**
-	* @NoAdminRequired
-	* @NoCSRFRequired
-	*/
+	 * @NoAdminRequired
+	 * @NoCSRFRequired
+	 */
 	public function clonePoll() {
 		return new TemplateResponse('polls', 'polls.tmpl',
 		['urlGenerator' => $this->urlGenerator]);

Please login to merge, or discard this patch.

lib/Db/EventMapper.php 1 patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -47,13 +47,13 @@  discard block
 block discarded – undo
 	public function find($id) {
 		$qb = $this->db->getQueryBuilder();
 
-        $qb->select('*')
-           ->from($this->getTableName())
-           ->where(
-               $qb->expr()->eq('id', $qb->createNamedParameter($id, IQueryBuilder::PARAM_INT))
-           );
+		$qb->select('*')
+		   ->from($this->getTableName())
+		   ->where(
+			   $qb->expr()->eq('id', $qb->createNamedParameter($id, IQueryBuilder::PARAM_INT))
+		   );
 
-        return $this->findEntity($qb);
+		return $this->findEntity($qb);
 	}
 
 	/**
@@ -65,13 +65,13 @@  discard block
 block discarded – undo
 	public function findByHash($hash) {
 		$qb = $this->db->getQueryBuilder();
 
-        $qb->select('*')
-           ->from($this->getTableName())
-           ->where(
-               $qb->expr()->eq('hash', $qb->createNamedParameter($hash, IQueryBuilder::PARAM_STR))
-           );
+		$qb->select('*')
+		   ->from($this->getTableName())
+		   ->where(
+			   $qb->expr()->eq('hash', $qb->createNamedParameter($hash, IQueryBuilder::PARAM_STR))
+		   );
 
-        return $this->findEntity($qb);
+		return $this->findEntity($qb);
 	}
 
 	/**
@@ -81,10 +81,10 @@  discard block
 block discarded – undo
 	public function findAll() {
 		$qb = $this->db->getQueryBuilder();
 
-        $qb->select('*')
-           ->from($this->getTableName());
+		$qb->select('*')
+		   ->from($this->getTableName());
 
-        return $this->findEntities($qb);
+		return $this->findEntities($qb);
 	}
 
 }

Please login to merge, or discard this patch.

lib/Db/VoteMapper.php 1 patch

Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch

@@ -47,13 +47,13 @@  discard block
 block discarded – undo
 	public function findByPoll($pollId) {
 		$qb = $this->db->getQueryBuilder();
 
-        $qb->select('*')
-           ->from($this->getTableName())
-           ->where(
-               $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
-           );
+		$qb->select('*')
+		   ->from($this->getTableName())
+		   ->where(
+			   $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
+		   );
 
-        return $this->findEntities($qb);
+		return $this->findEntities($qb);
 	}
 	
 	/**
@@ -64,13 +64,13 @@  discard block
 block discarded – undo
 	public function findParticipantsByPoll($pollId, $limit = null, $offset = null) {
 		$qb = $this->db->getQueryBuilder();
 
-        $qb->select('user_id')
-           ->from($this->getTableName())
-           ->where(
-               $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
-           );
+		$qb->select('user_id')
+		   ->from($this->getTableName())
+		   ->where(
+			   $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
+		   );
 
-        return $this->findEntities($qb);
+		return $this->findEntities($qb);
 	}
 
 	/**
@@ -80,20 +80,20 @@  discard block
 block discarded – undo
 	 public function deleteByPollAndUser($pollId, $userId) {
 		$qb = $this->db->getQueryBuilder();
 
-        $qb->delete($this->getTableName())
-           ->where(
-               $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
-           )
-           ->andWhere(
-               $qb->expr()->eq('user_id', $qb->createNamedParameter($userId, IQueryBuilder::PARAM_STR))
-           );
+		$qb->delete($this->getTableName())
+		   ->where(
+			   $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
+		   )
+		   ->andWhere(
+			   $qb->expr()->eq('user_id', $qb->createNamedParameter($userId, IQueryBuilder::PARAM_STR))
+		   );
 
 	   $qb->execute();
 	}
 
 	/**
-	* @param int $pollId
-	*/
+	 * @param int $pollId
+	 */
 	public function deleteByPoll($pollId) {
 		$qb = $this->db->getQueryBuilder();
 

Please login to merge, or discard this patch.

lib/Db/NotificationMapper.php 1 patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -69,9 +69,9 @@
 block discarded – undo
 			->where(
 				$qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
 			)
-	        ->andWhere(
-	        	$qb->expr()->eq('user_id', $qb->createNamedParameter($userId, IQueryBuilder::PARAM_STR))
-	        );
+			->andWhere(
+				$qb->expr()->eq('user_id', $qb->createNamedParameter($userId, IQueryBuilder::PARAM_STR))
+			);
 
 		 return $this->findEntities($qb);
 	}

Please login to merge, or discard this patch.

lib/Db/OptionMapper.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -47,13 +47,13 @@  discard block
 block discarded – undo
 	public function findByPoll($pollId) {
 		$qb = $this->db->getQueryBuilder();
 
-        $qb->select('*')
-           ->from($this->getTableName())
-           ->where(
-               $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
-           );
+		$qb->select('*')
+		   ->from($this->getTableName())
+		   ->where(
+			   $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
+		   );
 
-        return $this->findEntities($qb);
+		return $this->findEntities($qb);
 	}
 
 	/**
@@ -62,10 +62,10 @@  discard block
 block discarded – undo
 	public function deleteByPoll($pollId) {
 		$qb = $this->db->getQueryBuilder();
 
-        $qb->delete($this->getTableName())
-           ->where(
-               $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
-           );
+		$qb->delete($this->getTableName())
+		   ->where(
+			   $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
+		   );
 
 	   $qb->execute();
 	}

Please login to merge, or discard this patch.

lib/Db/CommentMapper.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -47,13 +47,13 @@  discard block
 block discarded – undo
 	public function findByPoll($pollId) {
 		$qb = $this->db->getQueryBuilder();
 
-        $qb->select('*')
-           ->from($this->getTableName())
-           ->where(
-               $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
-           );
+		$qb->select('*')
+		   ->from($this->getTableName())
+		   ->where(
+			   $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
+		   );
 
-        return $this->findEntities($qb);
+		return $this->findEntities($qb);
 	}
 
 	/**
@@ -62,10 +62,10 @@  discard block
 block discarded – undo
 	public function deleteByPoll($pollId) {
 		$qb = $this->db->getQueryBuilder();
 
-        $qb->delete($this->getTableName())
-           ->where(
-               $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
-           );
+		$qb->delete($this->getTableName())
+		   ->where(
+			   $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
+		   );
 
 	   $qb->execute();
 	}

Please login to merge, or discard this patch.

		@@ -132,7 +132,7 @@ discard block
		block discarded – undo
132	132	* @return Boolean
133	133	*/
134	134	private function checkUserAccess($accessList) {
135		- foreach ($accessList as $accessItem ) {
	135	+ foreach ($accessList as $accessItem) {
136	136	if ($accessItem['type'] === 'user' && $accessItem['id'] === \OC::$server->getUserSession()->getUser()->getUID()) {
137	137	return true;
138	138	}
		@@ -146,8 +146,8 @@ discard block
		block discarded – undo
146	146	* @return Boolean
147	147	*/
148	148	private function checkGroupAccess($accessList) {
149		- foreach ($accessList as $accessItem ) {
150		- if ($accessItem['type'] === 'group' && $this->groupManager->isInGroup(\OC::$server->getUserSession()->getUser()->getUID(),$accessItem['id'])) {
	149	+ foreach ($accessList as $accessItem) {
	150	+ if ($accessItem['type'] === 'group' && $this->groupManager->isInGroup(\OC::$server->getUserSession()->getUser()->getUID(), $accessItem['id'])) {
151	151	return true;
152	152	}
153	153	}

		@@ -234,7 +234,7 @@
		block discarded – undo
234	234	// look what user voted for this dts
235	235	foreach ($others[$usr] as $vote) {
236	236	if ($optionElement->getPollOptionText() === $vote->getVoteOptionText()) {
237		- $class = $vote->getVoteAnswer() . ' icon-'.$vote->getVoteAnswer();
	237	+ $class = $vote->getVoteAnswer() . ' icon-' . $vote->getVoteAnswer();
238	238	break;
239	239	}
240	240	$class = 'no icon-no';

		@@ -131,27 +131,27 @@
		block discarded – undo
131	131	}
132	132
133	133	/**
134		- * @NoAdminRequired
135		- * @NoCSRFRequired
136		- */
	134	+ * @NoAdminRequired
	135	+ * @NoCSRFRequired
	136	+ */
137	137	public function index() {
138	138	return new TemplateResponse('polls', 'polls.tmpl',
139	139	['urlGenerator' => $this->urlGenerator]);
140	140	}
141	141
142	142	/**
143		- * @NoAdminRequired
144		- * @NoCSRFRequired
145		- */
	143	+ * @NoAdminRequired
	144	+ * @NoCSRFRequired
	145	+ */
146	146	public function createPoll() {
147	147	return new TemplateResponse('polls', 'polls.tmpl',
148	148	['urlGenerator' => $this->urlGenerator]);
149	149	}
150	150
151	151	/**
152		- * @NoAdminRequired
153		- * @NoCSRFRequired
154		- */
	152	+ * @NoAdminRequired
	153	+ * @NoCSRFRequired
	154	+ */
155	155	public function clonePoll() {
156	156	return new TemplateResponse('polls', 'polls.tmpl',
157	157	['urlGenerator' => $this->urlGenerator]);

		@@ -47,13 +47,13 @@ discard block
		block discarded – undo
47	47	public function find($id) {
48	48	$qb = $this->db->getQueryBuilder();
49	49
50		- $qb->select('*')
51		- ->from($this->getTableName())
52		- ->where(
53		- $qb->expr()->eq('id', $qb->createNamedParameter($id, IQueryBuilder::PARAM_INT))
54		- );
	50	+ $qb->select('*')
	51	+ ->from($this->getTableName())
	52	+ ->where(
	53	+ $qb->expr()->eq('id', $qb->createNamedParameter($id, IQueryBuilder::PARAM_INT))
	54	+ );
55	55
56		- return $this->findEntity($qb);
	56	+ return $this->findEntity($qb);
57	57	}
58	58
59	59	/**
		@@ -65,13 +65,13 @@ discard block
		block discarded – undo
65	65	public function findByHash($hash) {
66	66	$qb = $this->db->getQueryBuilder();
67	67
68		- $qb->select('*')
69		- ->from($this->getTableName())
70		- ->where(
71		- $qb->expr()->eq('hash', $qb->createNamedParameter($hash, IQueryBuilder::PARAM_STR))
72		- );
	68	+ $qb->select('*')
	69	+ ->from($this->getTableName())
	70	+ ->where(
	71	+ $qb->expr()->eq('hash', $qb->createNamedParameter($hash, IQueryBuilder::PARAM_STR))
	72	+ );
73	73
74		- return $this->findEntity($qb);
	74	+ return $this->findEntity($qb);
75	75	}
76	76
77	77	/**
		@@ -81,10 +81,10 @@ discard block
		block discarded – undo
81	81	public function findAll() {
82	82	$qb = $this->db->getQueryBuilder();
83	83
84		- $qb->select('*')
85		- ->from($this->getTableName());
	84	+ $qb->select('*')
	85	+ ->from($this->getTableName());
86	86
87		- return $this->findEntities($qb);
	87	+ return $this->findEntities($qb);
88	88	}
89	89
90	90	}

		@@ -47,13 +47,13 @@ discard block
		block discarded – undo
47	47	public function findByPoll($pollId) {
48	48	$qb = $this->db->getQueryBuilder();
49	49
50		- $qb->select('*')
51		- ->from($this->getTableName())
52		- ->where(
53		- $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
54		- );
	50	+ $qb->select('*')
	51	+ ->from($this->getTableName())
	52	+ ->where(
	53	+ $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
	54	+ );
55	55
56		- return $this->findEntities($qb);
	56	+ return $this->findEntities($qb);
57	57	}
58	58
59	59	/**
		@@ -64,13 +64,13 @@ discard block
		block discarded – undo
64	64	public function findParticipantsByPoll($pollId, $limit = null, $offset = null) {
65	65	$qb = $this->db->getQueryBuilder();
66	66
67		- $qb->select('user_id')
68		- ->from($this->getTableName())
69		- ->where(
70		- $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
71		- );
	67	+ $qb->select('user_id')
	68	+ ->from($this->getTableName())
	69	+ ->where(
	70	+ $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
	71	+ );
72	72
73		- return $this->findEntities($qb);
	73	+ return $this->findEntities($qb);
74	74	}
75	75
76	76	/**
		@@ -80,20 +80,20 @@ discard block
		block discarded – undo
80	80	public function deleteByPollAndUser($pollId, $userId) {
81	81	$qb = $this->db->getQueryBuilder();
82	82
83		- $qb->delete($this->getTableName())
84		- ->where(
85		- $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
86		- )
87		- ->andWhere(
88		- $qb->expr()->eq('user_id', $qb->createNamedParameter($userId, IQueryBuilder::PARAM_STR))
89		- );
	83	+ $qb->delete($this->getTableName())
	84	+ ->where(
	85	+ $qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
	86	+ )
	87	+ ->andWhere(
	88	+ $qb->expr()->eq('user_id', $qb->createNamedParameter($userId, IQueryBuilder::PARAM_STR))
	89	+ );
90	90
91	91	$qb->execute();
92	92	}
93	93
94	94	/**
95		- * @param int $pollId
96		- */
	95	+ * @param int $pollId
	96	+ */
97	97	public function deleteByPoll($pollId) {
98	98	$qb = $this->db->getQueryBuilder();
99	99

		@@ -69,9 +69,9 @@
		block discarded – undo
69	69	->where(
70	70	$qb->expr()->eq('poll_id', $qb->createNamedParameter($pollId, IQueryBuilder::PARAM_INT))
71	71	)
72		- ->andWhere(
73		- $qb->expr()->eq('user_id', $qb->createNamedParameter($userId, IQueryBuilder::PARAM_STR))
74		- );
	72	+ ->andWhere(
	73	+ $qb->expr()->eq('user_id', $qb->createNamedParameter($userId, IQueryBuilder::PARAM_STR))
	74	+ );
75	75
76	76	return $this->findEntities($qb);
77	77	}

nextcloud / polls

Pull Request — master (#604)

Status

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch