nextcloud /
passman
| Conditions | 1 |
| Paths | 2 |
| Total Lines | 57 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | /** |
||
| 27 | (function (window, $, PassmanImporter) { |
||
| 28 | 'use strict'; |
||
| 29 | |||
| 30 | // Define the importer |
||
| 31 | PassmanImporter.zohoCsv = { |
||
| 32 | info: { |
||
| 33 | name: 'ZOHO csv', |
||
| 34 | id: 'zohoCsv', |
||
| 35 | description: 'Create an csv export. Go to Tools -> Export secrets -> Select "General CSV" and click "Export Secrets"' |
||
| 36 | } |
||
| 37 | }; |
||
| 38 | |||
| 39 | PassmanImporter.zohoCsv.readFile = function (file_data) { |
||
| 40 | /** global: C_Promise */ |
||
| 41 | return new C_Promise(function () { |
||
| 42 | var parsed_csv = PassmanImporter.readCsv(file_data); |
||
| 43 | |||
| 44 | var credential_list = []; |
||
| 45 | for (var i = 0; i < parsed_csv.length; i++) { |
||
| 46 | var row = parsed_csv[i]; |
||
| 47 | var _credential = PassmanImporter.newCredential(); |
||
| 48 | _credential.label = row.secret_name; |
||
| 49 | _credential.url = row.secret_url; |
||
| 50 | _credential.description = row.notes; |
||
| 51 | if (row.hasOwnProperty('secretdata')) { |
||
| 52 | var rows = row.secretdata.split("\n"); |
||
| 53 | for (var r = 0; r < rows.length; r++) { |
||
| 54 | var cells = rows[r].split(':'); |
||
| 55 | var key = cells[0]; |
||
| 56 | var value = cells.slice(1).join(':'); |
||
| 57 | if (key && value) { |
||
| 58 | _credential.custom_fields.push( |
||
| 59 | { |
||
| 60 | 'label': key, |
||
| 61 | 'value': value, |
||
| 62 | 'secret': false |
||
| 63 | } |
||
| 64 | ); |
||
| 65 | } |
||
| 66 | } |
||
| 67 | } |
||
| 68 | if (_credential.label !== "") { |
||
| 69 | credential_list.push(_credential); |
||
| 70 | } |
||
| 71 | |||
| 72 | var progress = { |
||
| 73 | percent: i / parsed_csv.length * 100, |
||
| 74 | loaded: i, |
||
| 75 | total: parsed_csv.length |
||
| 76 | }; |
||
| 77 | |||
| 78 | this.call_progress(progress); |
||
| 79 | } |
||
| 80 | this.call_then(credential_list); |
||
| 81 | }); |
||
| 82 | }; |
||
| 83 | })(window, $, PassmanImporter); |
||
| 84 |
Loading history...