Inspection of "add the collaborator search plugin" - nextcloud/circles - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#126)

by Blizzz

created 2017-09-06 21:06 UTC

Status

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -45,7 +45,7 @@  discard block
 block discarded – undo
 	 *
 	 * @throws FakeException
 	 */
-	public function parseSubjectMemberJoin(IEvent &$event, Circle $circle, Member $member) {
+	public function parseSubjectMemberJoin(IEvent & $event, Circle $circle, Member $member) {
 		if ($event->getSubject() !== 'member_request_invitation') {
 			return;
 		}
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
 	 *
 	 * @throws FakeException
 	 */
-	private function parseSubjectMemberJoinClosedCircle(IEvent &$event, Circle $circle, Member $member) {
+	private function parseSubjectMemberJoinClosedCircle(IEvent & $event, Circle $circle, Member $member) {
 		if ($circle->getType() !== Circle::CIRCLES_CLOSED) {
 			return;
 		}
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
 	 *
 	 * @throws FakeException
 	 */
-	public function parseSubjectMemberAdd(IEvent &$event, Circle $circle, Member $member) {
+	public function parseSubjectMemberAdd(IEvent & $event, Circle $circle, Member $member) {
 		if ($event->getSubject() !== 'member_add') {
 			return;
 		}
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 	 *
 	 * @throws FakeException
 	 */
-	private function parseSubjectMemberAddNotLocalMember(IEvent &$event, Circle $circle, Member $member
+	private function parseSubjectMemberAddNotLocalMember(IEvent & $event, Circle $circle, Member $member
 	) {
 		if ($member->getType() === Member::TYPE_USER) {
 			return;
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
 	 *
 	 * @throws FakeException
 	 */
-	private function parseSubjectMemberAddClosedCircle(IEvent &$event, Circle $circle, Member $member) {
+	private function parseSubjectMemberAddClosedCircle(IEvent & $event, Circle $circle, Member $member) {
 		if ($circle->getType() !== Circle::CIRCLES_CLOSED) {
 			return;
 		}
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
 	 *
 	 * @throws FakeException
 	 */
-	public function parseSubjectMemberLeft(IEvent &$event, Circle $circle, Member $member) {
+	public function parseSubjectMemberLeft(IEvent & $event, Circle $circle, Member $member) {
 
 		if ($event->getSubject() !== 'member_left') {
 			return;
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
 	 *
 	 * @throws FakeException
 	 */
-	private function parseSubjectNonMemberLeftClosedCircle(IEvent &$event, Circle $circle, Member $member
+	private function parseSubjectNonMemberLeftClosedCircle(IEvent & $event, Circle $circle, Member $member
 	) {
 		if ($circle->getType() !== Circle::CIRCLES_CLOSED
 			|| $member->getLevel() !== Member::LEVEL_NONE) {
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
 	 *
 	 * @throws FakeException
 	 */
-	public function parseSubjectMemberRemove(IEvent &$event, Circle $circle, Member $member) {
+	public function parseSubjectMemberRemove(IEvent & $event, Circle $circle, Member $member) {
 
 		if ($event->getSubject() !== 'member_remove') {
 			return;
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
 	 * @throws FakeException
 	 */
 	private function parseSubjectMemberRemoveNotLocalMember(
-		IEvent &$event, Circle $circle, Member $member
+		IEvent & $event, Circle $circle, Member $member
 	) {
 		if ($member->getType() === Member::TYPE_USER) {
 			return;
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
 	 * @throws FakeException
 	 */
 	private function parseSubjectMemberRemoveNotYetMember(
-		IEvent &$event, Circle $circle, Member $member
+		IEvent & $event, Circle $circle, Member $member
 	) {
 		if ($circle->getType() !== Circle::CIRCLES_CLOSED
 			|| $member->getLevel() !== Member::LEVEL_NONE) {
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
 
 
 	private function parseSubjectMemberRemoveNotYetMemberRequesting(
-		IEvent &$event, Circle $circle, Member $member
+		IEvent & $event, Circle $circle, Member $member
 	) {
 		if ($member->getStatus() !== Member::STATUS_REQUEST) {
 			return;
@@ -330,7 +330,7 @@  discard block
 block discarded – undo
 	 *
 	 * @throws FakeException
 	 */
-	public function parseMemberInvited(IEvent &$event, Circle $circle, Member $member) {
+	public function parseMemberInvited(IEvent & $event, Circle $circle, Member $member) {
 		if ($event->getSubject() !== 'member_invited') {
 			return;
 		}
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
 	 *
 	 * @throws FakeException
 	 */
-	public function parseMemberLevel(IEvent &$event, Circle $circle, Member $member) {
+	public function parseMemberLevel(IEvent & $event, Circle $circle, Member $member) {
 		if ($event->getSubject() !== 'member_level') {
 			return;
 		}
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
 	 *
 	 * @throws FakeException
 	 */
-	public function parseMemberRequestInvitation(IEvent &$event, Circle $circle, Member $member) {
+	public function parseMemberRequestInvitation(IEvent & $event, Circle $circle, Member $member) {
 		if ($event->getSubject() !== 'member_request_invitation') {
 			return;
 		}
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
 	 *
 	 * @throws FakeException
 	 */
-	public function parseMemberOwner(IEvent &$event, Circle $circle, Member $member) {
+	public function parseMemberOwner(IEvent & $event, Circle $circle, Member $member) {
 		if ($event->getSubject() !== 'member_owner') {
 			return;
 		}

Please login to merge, or discard this patch.

lib/Collaboration/CollaboratorSearchPlugin.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@
 block discarded – undo
 	public function search($search, $limit, $offset, ISearchResult $searchResult) {
 		$result = ['wide' => [], 'exact' => []];
 
-		if(\OC_App::isEnabled('circles')) {
+		if (\OC_App::isEnabled('circles')) {
 			$circles = Sharees::search($search);
 			if (array_key_exists('circles', $circles['exact'])) {
 				$result['exact'] = $circles['exact']['circles'];

Please login to merge, or discard this patch.

		@@ -45,7 +45,7 @@ discard block
		block discarded – undo
45	45	*
46	46	* @throws FakeException
47	47	*/
48		- public function parseSubjectMemberJoin(IEvent &$event, Circle $circle, Member $member) {
	48	+ public function parseSubjectMemberJoin(IEvent & $event, Circle $circle, Member $member) {
49	49	if ($event->getSubject() !== 'member_request_invitation') {
50	50	return;
51	51	}
		@@ -67,7 +67,7 @@ discard block
		block discarded – undo
67	67	*
68	68	* @throws FakeException
69	69	*/
70		- private function parseSubjectMemberJoinClosedCircle(IEvent &$event, Circle $circle, Member $member) {
	70	+ private function parseSubjectMemberJoinClosedCircle(IEvent & $event, Circle $circle, Member $member) {
71	71	if ($circle->getType() !== Circle::CIRCLES_CLOSED) {
72	72	return;
73	73	}
		@@ -92,7 +92,7 @@ discard block
		block discarded – undo
92	92	*
93	93	* @throws FakeException
94	94	*/
95		- public function parseSubjectMemberAdd(IEvent &$event, Circle $circle, Member $member) {
	95	+ public function parseSubjectMemberAdd(IEvent & $event, Circle $circle, Member $member) {
96	96	if ($event->getSubject() !== 'member_add') {
97	97	return;
98	98	}
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117	*
118	118	* @throws FakeException
119	119	*/
120		- private function parseSubjectMemberAddNotLocalMember(IEvent &$event, Circle $circle, Member $member
	120	+ private function parseSubjectMemberAddNotLocalMember(IEvent & $event, Circle $circle, Member $member
121	121	) {
122	122	if ($member->getType() === Member::TYPE_USER) {
123	123	return;
		@@ -140,7 +140,7 @@ discard block
		block discarded – undo
140	140	*
141	141	* @throws FakeException
142	142	*/
143		- private function parseSubjectMemberAddClosedCircle(IEvent &$event, Circle $circle, Member $member) {
	143	+ private function parseSubjectMemberAddClosedCircle(IEvent & $event, Circle $circle, Member $member) {
144	144	if ($circle->getType() !== Circle::CIRCLES_CLOSED) {
145	145	return;
146	146	}
		@@ -167,7 +167,7 @@ discard block
		block discarded – undo
167	167	*
168	168	* @throws FakeException
169	169	*/
170		- public function parseSubjectMemberLeft(IEvent &$event, Circle $circle, Member $member) {
	170	+ public function parseSubjectMemberLeft(IEvent & $event, Circle $circle, Member $member) {
171	171
172	172	if ($event->getSubject() !== 'member_left') {
173	173	return;
		@@ -195,7 +195,7 @@ discard block
		block discarded – undo
195	195	*
196	196	* @throws FakeException
197	197	*/
198		- private function parseSubjectNonMemberLeftClosedCircle(IEvent &$event, Circle $circle, Member $member
	198	+ private function parseSubjectNonMemberLeftClosedCircle(IEvent & $event, Circle $circle, Member $member
199	199	) {
200	200	if ($circle->getType() !== Circle::CIRCLES_CLOSED
201	201	\|\| $member->getLevel() !== Member::LEVEL_NONE) {
		@@ -231,7 +231,7 @@ discard block
		block discarded – undo
231	231	*
232	232	* @throws FakeException
233	233	*/
234		- public function parseSubjectMemberRemove(IEvent &$event, Circle $circle, Member $member) {
	234	+ public function parseSubjectMemberRemove(IEvent & $event, Circle $circle, Member $member) {
235	235
236	236	if ($event->getSubject() !== 'member_remove') {
237	237	return;
		@@ -258,7 +258,7 @@ discard block
		block discarded – undo
258	258	* @throws FakeException
259	259	*/
260	260	private function parseSubjectMemberRemoveNotLocalMember(
261		- IEvent &$event, Circle $circle, Member $member
	261	+ IEvent & $event, Circle $circle, Member $member
262	262	) {
263	263	if ($member->getType() === Member::TYPE_USER) {
264	264	return;
		@@ -286,7 +286,7 @@ discard block
		block discarded – undo
286	286	* @throws FakeException
287	287	*/
288	288	private function parseSubjectMemberRemoveNotYetMember(
289		- IEvent &$event, Circle $circle, Member $member
	289	+ IEvent & $event, Circle $circle, Member $member
290	290	) {
291	291	if ($circle->getType() !== Circle::CIRCLES_CLOSED
292	292	\|\| $member->getLevel() !== Member::LEVEL_NONE) {
		@@ -306,7 +306,7 @@ discard block
		block discarded – undo
306	306
307	307
308	308	private function parseSubjectMemberRemoveNotYetMemberRequesting(
309		- IEvent &$event, Circle $circle, Member $member
	309	+ IEvent & $event, Circle $circle, Member $member
310	310	) {
311	311	if ($member->getStatus() !== Member::STATUS_REQUEST) {
312	312	return;
		@@ -330,7 +330,7 @@ discard block
		block discarded – undo
330	330	*
331	331	* @throws FakeException
332	332	*/
333		- public function parseMemberInvited(IEvent &$event, Circle $circle, Member $member) {
	333	+ public function parseMemberInvited(IEvent & $event, Circle $circle, Member $member) {
334	334	if ($event->getSubject() !== 'member_invited') {
335	335	return;
336	336	}
		@@ -353,7 +353,7 @@ discard block
		block discarded – undo
353	353	*
354	354	* @throws FakeException
355	355	*/
356		- public function parseMemberLevel(IEvent &$event, Circle $circle, Member $member) {
	356	+ public function parseMemberLevel(IEvent & $event, Circle $circle, Member $member) {
357	357	if ($event->getSubject() !== 'member_level') {
358	358	return;
359	359	}
		@@ -377,7 +377,7 @@ discard block
		block discarded – undo
377	377	*
378	378	* @throws FakeException
379	379	*/
380		- public function parseMemberRequestInvitation(IEvent &$event, Circle $circle, Member $member) {
	380	+ public function parseMemberRequestInvitation(IEvent & $event, Circle $circle, Member $member) {
381	381	if ($event->getSubject() !== 'member_request_invitation') {
382	382	return;
383	383	}
		@@ -399,7 +399,7 @@ discard block
		block discarded – undo
399	399	*
400	400	* @throws FakeException
401	401	*/
402		- public function parseMemberOwner(IEvent &$event, Circle $circle, Member $member) {
	402	+ public function parseMemberOwner(IEvent & $event, Circle $circle, Member $member) {
403	403	if ($event->getSubject() !== 'member_owner') {
404	404	return;
405	405	}

		@@ -33,7 +33,7 @@
		block discarded – undo
33	33	public function search($search, $limit, $offset, ISearchResult $searchResult) {
34	34	$result = ['wide' => [], 'exact' => []];
35	35
36		- if(\OC_App::isEnabled('circles')) {
	36	+ if (\OC_App::isEnabled('circles')) {
37	37	$circles = Sharees::search($search);
38	38	if (array_key_exists('circles', $circles['exact'])) {
39	39	$result['exact'] = $circles['exact']['circles'];

nextcloud / circles

Pull Request — master (#126)

Status

Category

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch