Completed
Push — some-scrutinizing ( d3de44...c6cac2 )
by Maxence
02:32
created
lib/Db/CircleProviderRequestBuilder.php 2 patches
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 * Limit the request to a Circle.
67 67
 	 *
68 68
 	 * @param $qb
69
-	 * @param $circleId
69
+	 * @param integer $circleId
70 70
 	 */
71 71
 	protected function limitToCircle(& $qb, $circleId) {
72 72
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 	 * limit the request to a userId
174 174
 	 *
175 175
 	 * @param $qb
176
-	 * @param $userId
176
+	 * @param string $userId
177 177
 	 * @param bool $reShares
178 178
 	 */
179 179
 	protected function limitToOwner(& $qb, $userId, $reShares = false) {
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
 	 * @deprecated
201 201
 	 *
202 202
 	 * @param $qb
203
-	 * @param $shareId
203
+	 * @param integer $shareId
204 204
 	 */
205 205
 	protected function linkCircleField(& $qb, $shareId) {
206 206
 		$expr = $qb->expr();
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
 	 * Link to members (userId) of circle
221 221
 	 *
222 222
 	 * @param $qb
223
-	 * @param $userId
223
+	 * @param string $userId
224 224
 	 */
225 225
 	protected function linkToMember(& $qb, $userId) {
226 226
 		$expr = $qb->expr();
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
 	 * Link to storage/filecache
237 237
 	 *
238 238
 	 * @param $qb
239
-	 * @param $userId
239
+	 * @param string $userId
240 240
 	 */
241 241
 	protected function linkToFileCache(& $qb, $userId) {
242 242
 		$expr = $qb->expr();
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
 		$qb->andWhere(
75 75
 			$qb->expr()
76
-			   ->eq($pf . 'share_with', $qb->createNamedParameter($circleId))
76
+			   ->eq($pf.'share_with', $qb->createNamedParameter($circleId))
77 77
 		);
78 78
 	}
79 79
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
90 90
 
91 91
 		$qb->andWhere(
92
-			$expr->eq($pf . 'id', $qb->createNamedParameter($shareId))
92
+			$expr->eq($pf.'id', $qb->createNamedParameter($shareId))
93 93
 		);
94 94
 	}
95 95
 
@@ -138,8 +138,8 @@  discard block
 block discarded – undo
138 138
 
139 139
 		$qb->andWhere(
140 140
 			$expr->orX(
141
-				$expr->eq($pf . 'parent', $qb->createNamedParameter($circleId)),
142
-				$expr->eq($pf . 'id', $qb->createNamedParameter($circleId))
141
+				$expr->eq($pf.'parent', $qb->createNamedParameter($circleId)),
142
+				$expr->eq($pf.'id', $qb->createNamedParameter($circleId))
143 143
 			)
144 144
 		);
145 145
 	}
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 
157 157
 		$qb->andWhere(
158 158
 			$qb->expr()
159
-			   ->eq($pf . 'file_source', $qb->createNamedParameter($fileId))
159
+			   ->eq($pf.'file_source', $qb->createNamedParameter($fileId))
160 160
 		);
161 161
 	}
162 162
 
@@ -181,12 +181,12 @@  discard block
 block discarded – undo
181 181
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
182 182
 
183 183
 		if ($reShares === false) {
184
-			$qb->andWhere($expr->eq($pf . 'uid_initiator', $qb->createNamedParameter($userId)));
184
+			$qb->andWhere($expr->eq($pf.'uid_initiator', $qb->createNamedParameter($userId)));
185 185
 		} else {
186 186
 			$qb->andWhere(
187 187
 				$expr->orX(
188
-					$expr->eq($pf . 'uid_owner', $qb->createNamedParameter($userId)),
189
-					$expr->eq($pf . 'uid_initiator', $qb->createNamedParameter($userId))
188
+					$expr->eq($pf.'uid_owner', $qb->createNamedParameter($userId)),
189
+					$expr->eq($pf.'uid_initiator', $qb->createNamedParameter($userId))
190 190
 				)
191 191
 			);
192 192
 		}
Please login to merge, or discard this patch.
lib/ShareByCircleProvider.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -221,7 +221,7 @@
 block discarded – undo
221 221
 	 * return the child ID of a share
222 222
 	 *
223 223
 	 * @param IShare $share
224
-	 * @param $userId
224
+	 * @param string $userId
225 225
 	 *
226 226
 	 * @return bool
227 227
 	 */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -410,7 +410,7 @@
 block discarded – undo
410 410
 	 * @return IShare[]
411 411
 	 */
412 412
 	public function getSharedWith($userId, $shareType, $node, $limit, $offset) {
413
-		$this->misc->log("CircleProvider: getSharedWith " . $userId . '   ' . $shareType);
413
+		$this->misc->log("CircleProvider: getSharedWith ".$userId.'   '.$shareType);
414 414
 
415 415
 		$qb = $this->getCompleteSelectSql();
416 416
 		$this->linkToMember($qb, $userId);
Please login to merge, or discard this patch.