Completed
Push — experimental/sf ( bba429...028691 )
by Kentaro
45:42
created
src/Eccube/Service/Composer/ComposerProcessService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -242,7 +242,7 @@
 block discarded – undo
242 242
     /**
243 243
      * Get mode
244 244
      *
245
-     * @return mixed|string
245
+     * @return string
246 246
      */
247 247
     public function getMode()
248 248
     {
Please login to merge, or discard this patch.
src/Eccube/Service/PluginService.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use Eccube\Entity\Plugin;
34 34
 use Eccube\Entity\PluginEventHandler;
35 35
 use Eccube\Exception\PluginException;
36
-use Eccube\Plugin\ConfigManager;
37 36
 use Eccube\Plugin\ConfigManager as PluginConfigManager;
38 37
 use Eccube\Repository\PluginEventHandlerRepository;
39 38
 use Eccube\Repository\PluginRepository;
Please login to merge, or discard this patch.
Doc Comments   +13 added lines, -7 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
      * @param string $path   path to tar.gz/zip plugin file
148 148
      * @param int    $source
149 149
      *
150
-     * @return mixed
150
+     * @return boolean
151 151
      *
152 152
      * @throws PluginException
153 153
      * @throws \Exception
@@ -274,8 +274,8 @@  discard block
 block discarded – undo
274 274
     }
275 275
 
276 276
     /**
277
-     * @param $archive
278
-     * @param $dir
277
+     * @param string $archive
278
+     * @param string $dir
279 279
      *
280 280
      * @throws PluginException
281 281
      */
@@ -344,6 +344,9 @@  discard block
 block discarded – undo
344 344
         }
345 345
     }
346 346
 
347
+    /**
348
+     * @param string $yml
349
+     */
347 350
     public function readYml($yml)
348 351
     {
349 352
         if (file_exists($yml)) {
@@ -361,6 +364,9 @@  discard block
 block discarded – undo
361 364
         // ディレクトリ名などに使われれるので厳しめ
362 365
     }
363 366
 
367
+    /**
368
+     * @param string $path
369
+     */
364 370
     public function deleteFile($path)
365 371
     {
366 372
         $f = new Filesystem();
@@ -381,7 +387,7 @@  discard block
 block discarded – undo
381 387
     }
382 388
 
383 389
     /**
384
-     * @param $d
390
+     * @param string $d
385 391
      *
386 392
      * @throws PluginException
387 393
      */
@@ -456,7 +462,7 @@  discard block
 block discarded – undo
456 462
 
457 463
     /**
458 464
      * @param $meta
459
-     * @param $method
465
+     * @param string $method
460 466
      */
461 467
     public function callPluginManagerMethod($meta, $method)
462 468
     {
@@ -997,7 +1003,7 @@  discard block
 block discarded – undo
997 1003
      * [プラグインコード]/Resource/assets
998 1004
      * 配下に置かれているファイルが所定の位置へコピーされる
999 1005
      *
1000
-     * @param $pluginBaseDir
1006
+     * @param string $pluginBaseDir
1001 1007
      * @param $pluginCode
1002 1008
      */
1003 1009
     public function copyAssets($pluginBaseDir, $pluginCode)
@@ -1033,7 +1039,7 @@  discard block
 block discarded – undo
1033 1039
      * @param string $pluginVersion
1034 1040
      * @param string $remoteVersion
1035 1041
      *
1036
-     * @return mixed
1042
+     * @return boolean
1037 1043
      */
1038 1044
     public function isUpdate($pluginVersion, $remoteVersion)
1039 1045
     {
Please login to merge, or discard this patch.
codeception/acceptance/ZZ99PluginUninstallerCest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,5 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-use Codeception\Util\Fixtures;
4 3
 use Page\Admin\OwnersPluginPage;
5 4
 
6 5
 /**
Please login to merge, or discard this patch.
src/Eccube/Form/Type/ShippingMultipleItemType.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
     /**
65 65
      * ShippingMultipleItemType constructor.
66 66
      *
67
-     * @param array $eccubeConfig
67
+     * @param EccubeConfig $eccubeConfig
68 68
      * @param Session $session
69 69
      * @param AuthorizationCheckerInterface $authorizationChecker
70 70
      * @param TokenStorageInterface $tokenStorage
Please login to merge, or discard this patch.
src/Eccube/Service/CartService.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -438,6 +438,9 @@
 block discarded – undo
438 438
         return $user;
439 439
     }
440 440
 
441
+    /**
442
+     * @param string $allocatedId
443
+     */
441 444
     protected function createCartKey($allocatedId, Customer $Customer = null)
442 445
     {
443 446
         if ($Customer instanceof Customer) {
Please login to merge, or discard this patch.
src/Eccube/Service/MailService.php 1 patch
Doc Comments   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
      * Send customer confirm mail.
99 99
      *
100 100
      * @param $Customer 会員情報
101
-     * @param $activateUrl アクティベート用url
101
+     * @param string $activateUrl アクティベート用url
102 102
      */
103 103
     public function sendCustomerConfirmMail(\Eccube\Entity\Customer $Customer, $activateUrl)
104 104
     {
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
      *
296 296
      * @param \Eccube\Entity\Order $Order 受注情報
297 297
      *
298
-     * @return string
298
+     * @return \Swift_Message
299 299
      */
300 300
     public function sendOrderMail(\Eccube\Entity\Order $Order)
301 301
     {
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
      * Send admin customer confirm mail.
341 341
      *
342 342
      * @param $Customer 会員情報
343
-     * @param $activateUrl アクティベート用url
343
+     * @param string $activateUrl アクティベート用url
344 344
      */
345 345
     public function sendAdminCustomerConfirmMail(\Eccube\Entity\Customer $Customer, $activateUrl)
346 346
     {
@@ -391,7 +391,7 @@  discard block
 block discarded – undo
391 391
      * @param $formData 入力内容
392 392
      * @param string $twig テンプレートファイル名
393 393
      *
394
-     * @return $this
394
+     * @return \Swift_Message
395 395
      *
396 396
      * @throws \Twig_Error_Loader
397 397
      * @throws \Twig_Error_Runtime
@@ -438,6 +438,7 @@  discard block
 block discarded – undo
438 438
      * Send password reset notification mail.
439 439
      *
440 440
      * @param $Customer 会員情報
441
+     * @param string $reset_url
441 442
      */
442 443
     public function sendPasswordResetNotificationMail(\Eccube\Entity\Customer $Customer, $reset_url)
443 444
     {
@@ -484,6 +485,7 @@  discard block
 block discarded – undo
484 485
      * Send password reset notification mail.
485 486
      *
486 487
      * @param $Customer 会員情報
488
+     * @param string $password
487 489
      */
488 490
     public function sendPasswordResetCompleteMail(\Eccube\Entity\Customer $Customer, $password)
489 491
     {
Please login to merge, or discard this patch.
codeception/_support/Page/Admin/ShippingCsvUploadPage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -33,6 +33,9 @@
 block discarded – undo
33 33
         parent::__construct($I);
34 34
     }
35 35
 
36
+    /**
37
+     * @param \AcceptanceTester $I
38
+     */
36 39
     public static function go($I)
37 40
     {
38 41
         $page = new ProductCsvUploadPage($I);
Please login to merge, or discard this patch.
codeception/_support/Page/Admin/ShippingEditPage.php 1 patch
Doc Comments   +45 added lines patch added patch discarded remove patch
@@ -19,6 +19,9 @@  discard block
 block discarded – undo
19 19
         parent::__construct($I);
20 20
     }
21 21
 
22
+    /**
23
+     * @param \AcceptanceTester $I
24
+     */
22 25
     public static function go($I)
23 26
     {
24 27
         $page = new self($I);
@@ -26,6 +29,9 @@  discard block
 block discarded – undo
26 29
         return $page;
27 30
     }
28 31
 
32
+    /**
33
+     * @param \AcceptanceTester $I
34
+     */
29 35
     public static function at($I)
30 36
     {
31 37
         $page = new self($I);
@@ -33,6 +39,9 @@  discard block
 block discarded – undo
33 39
         return $page;
34 40
     }
35 41
 
42
+    /**
43
+     * @param string $value
44
+     */
36 45
     public function 入力_出荷日($value)
37 46
     {
38 47
         $this->tester->executeJS("document.getElementById('shipping_shipping_date').value = '{$value}'");
@@ -46,30 +55,45 @@  discard block
 block discarded – undo
46 55
         return $this;
47 56
     }
48 57
 
58
+    /**
59
+     * @param string $value
60
+     */
49 61
     public function 入力_姓($value)
50 62
     {
51 63
         $this->tester->fillField(['id' => 'shipping_name_name01'], $value);
52 64
         return $this;
53 65
     }
54 66
 
67
+    /**
68
+     * @param string $value
69
+     */
55 70
     public function 入力_名($value)
56 71
     {
57 72
         $this->tester->fillField(['id' => 'shipping_name_name02'], $value);
58 73
         return $this;
59 74
     }
60 75
 
76
+    /**
77
+     * @param string $value
78
+     */
61 79
     public function 入力_セイ($value)
62 80
     {
63 81
         $this->tester->fillField(['id' => 'shipping_kana_kana01'], $value);
64 82
         return $this;
65 83
     }
66 84
 
85
+    /**
86
+     * @param string $value
87
+     */
67 88
     public function 入力_メイ($value)
68 89
     {
69 90
         $this->tester->fillField(['id' => 'shipping_kana_kana02'], $value);
70 91
         return $this;
71 92
     }
72 93
 
94
+    /**
95
+     * @param string $value
96
+     */
73 97
     public function 入力_郵便番号($value)
74 98
     {
75 99
         $this->tester->fillField(['id' => 'shipping_postal_code'], $value);
@@ -83,18 +107,27 @@  discard block
 block discarded – undo
83 107
         return $this;
84 108
     }
85 109
 
110
+    /**
111
+     * @param string $value
112
+     */
86 113
     public function 入力_市区町村名($value)
87 114
     {
88 115
         $this->tester->fillField(['id' => 'shipping_address_addr01'], $value);
89 116
         return $this;
90 117
     }
91 118
 
119
+    /**
120
+     * @param string $value
121
+     */
92 122
     public function 入力_番地_ビル名($value)
93 123
     {
94 124
         $this->tester->fillField(['id' => 'shipping_address_addr02'], $value);
95 125
         return $this;
96 126
     }
97 127
 
128
+    /**
129
+     * @param string $value
130
+     */
98 131
     public function 入力_電話番号($value)
99 132
     {
100 133
         $this->tester->fillField(['id' => 'shipping_phone_number'], $value);
@@ -102,18 +135,27 @@  discard block
 block discarded – undo
102 135
         return $this;
103 136
     }
104 137
 
138
+    /**
139
+     * @param string $value
140
+     */
105 141
     public function 入力_出荷伝票番号($value)
106 142
     {
107 143
         $this->tester->fillField(['id' => 'shipping_tracking_number'], $value);
108 144
         return $this;
109 145
     }
110 146
 
147
+    /**
148
+     * @param string[] $value
149
+     */
111 150
     public function 入力_配送業者($value)
112 151
     {
113 152
         $this->tester->selectOption(['id' => 'shipping_Delivery'], $value);
114 153
         return $this;
115 154
     }
116 155
 
156
+    /**
157
+     * @param string $value
158
+     */
117 159
     public function 入力_配達用メモ($value)
118 160
     {
119 161
         $this->tester->fillField(['id' => 'shipping_note'], $value);
@@ -128,6 +170,9 @@  discard block
 block discarded – undo
128 170
         return $this;
129 171
     }
130 172
 
173
+    /**
174
+     * @param integer $rowNum
175
+     */
131 176
     public function 商品検索結果_選択($rowNum)
132 177
     {
133 178
         $this->tester->click(['xpath' => "//*[@id='searchItemsResult']/table/tbody/tr[${rowNum}]/td[5]/i"]);
Please login to merge, or discard this patch.
codeception/_support/Page/Admin/ShippingManagePage.php 1 patch
Doc Comments   +18 added lines patch added patch discarded remove patch
@@ -44,12 +44,18 @@  discard block
 block discarded – undo
44 44
         return $this;
45 45
     }
46 46
 
47
+    /**
48
+     * @param string $value
49
+     */
47 50
     public function 入力_ご注文者お名前($value)
48 51
     {
49 52
         $this->tester->fillField(['id' => 'admin_search_shipping_order_name'], $value);
50 53
         return $this;
51 54
     }
52 55
 
56
+    /**
57
+     * @param string $value
58
+     */
53 59
     public function 入力_ご注文者お名前フリガナ($value)
54 60
     {
55 61
         $this->tester->fillField(['id' => 'admin_search_shipping_order_kana'], $value);
@@ -77,6 +83,9 @@  discard block
 block discarded – undo
77 83
         return $this;
78 84
     }
79 85
 
86
+    /**
87
+     * @param integer $rowNum
88
+     */
80 89
     public function 一覧_編集($rowNum)
81 90
     {
82 91
         $this->tester->click(['xpath' => "//*[@id='form_bulk']/div[2]/div/table/tbody/tr[${rowNum}]/td[2]/a"]);
@@ -136,16 +145,25 @@  discard block
 block discarded – undo
136 145
         $this->tester->click('#form_bulk #btn_bulk_mail');
137 146
     }
138 147
 
148
+    /**
149
+     * @param integer $rowNum
150
+     */
139 151
     public function 一覧_チェックボックス($rowNum)
140 152
     {
141 153
         $this->tester->click(['xpath' => "//*[@id='form_bulk']/div[2]/div/table/tbody/tr[${rowNum}]/td[1]/input"]);
142 154
     }
143 155
 
156
+    /**
157
+     * @param integer $rowNum
158
+     */
144 159
     public function 取得_出荷伝票番号($rowNum)
145 160
     {
146 161
         return $this->tester->grabTextFrom("#form_bulk table > tbody > tr:nth-child(${rowNum}) > td:nth-child(3)");
147 162
     }
148 163
 
164
+    /**
165
+     * @param integer $rowNum
166
+     */
149 167
     public function 取得_出荷日($rowNum)
150 168
     {
151 169
         return $this->tester->grabTextFrom("#form_bulk table > tbody > tr:nth-child(${rowNum}) > td:nth-child(7)");
Please login to merge, or discard this patch.