Config::with() - Code Metrics - Inspection of "Merge pull request #99 from devosc/master" - mvc5/mvc5 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a1f230...f04eab )

by devosc

created 2017-03-19 23:26 UTC

Config::with() A

↳ Parent: Config

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	2

<?php
/**
 *
 */

namespace Mvc5\Http\Headers;

use Mvc5\Config as _Config;
use Mvc5\Http\Headers;

class Config
    extends _Config
    implements Headers
{
    /**
     * @param array $config
     */
    function __construct(array $config = [])

    {
        parent::__construct(array_change_key_case($config, CASE_LOWER));
    }

    /**
     * @param string $name
     * @return mixed
     */
    function get($name)

    {
        return parent::get(strtolower($name));
    }

    /**
     * @param string $name
     * @return bool
     */
    function has($name)

    {
        return parent::has(strtolower($name));
    }

    /**
     * @param string $name
     * @return void
     */
    function remove($name)

    {
        parent::remove(strtolower($name));
    }

    /**
     * @param string $name
     * @param mixed $value
     * @return mixed
     */
    function set($name, $value)

    {
        return parent::set(strtolower($name), $value);
    }

    /**
     * @param string $name
     * @param mixed $value
     * @return self|mixed
     */
    function with($name, $value)

    {
        return parent::with(strtolower($name), $value);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @param string $name
     * @return self|mixed
     */
    function without($name)

    {
        return parent::without(strtolower($name));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2			/**
3			*
4			*/
5
6			namespace Mvc5\Http\Headers;
7
8			use Mvc5\Config as _Config;
9			use Mvc5\Http\Headers;
10
11			class Config
12			extends _Config
13			implements Headers
14			{
15			/**
16			* @param array $config
17			*/
18			function __construct(array $config = [])
			0 ignored issues – show Best Practice introduced 2017-03-19 23:28 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
19			{
20			parent::__construct(array_change_key_case($config, CASE_LOWER));
21			}
22
23			/**
24			* @param string $name
25			* @return mixed
26			*/
27			function get($name)
			0 ignored issues – show Best Practice introduced 2017-03-19 23:28 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
28			{
29			return parent::get(strtolower($name));
30			}
31
32			/**
33			* @param string $name
34			* @return bool
35			*/
36			function has($name)
			0 ignored issues – show Best Practice introduced 2017-03-19 23:28 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
37			{
38			return parent::has(strtolower($name));
39			}
40
41			/**
42			* @param string $name
43			* @return void
44			*/
45			function remove($name)
			0 ignored issues – show Best Practice introduced 2017-03-19 23:28 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
46			{
47			parent::remove(strtolower($name));
48			}
49
50			/**
51			* @param string $name
52			* @param mixed $value
53			* @return mixed
54			*/
55			function set($name, $value)
			0 ignored issues – show Best Practice introduced 2017-03-19 23:28 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
56			{
57			return parent::set(strtolower($name), $value);
58			}
59
60			/**
61			* @param string $name
62			* @param mixed $value
63			* @return self\|mixed
64			*/
65			function with($name, $value)
			0 ignored issues – show Best Practice introduced 2017-03-19 23:28 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
66			{
67			return parent::with(strtolower($name), $value);
			0 ignored issues – show Bug Best Practice introduced 2017-03-19 23:28 UTC by Report Bug Copy Issue Report The return type of `return parent::with(strtolower($name), $value);` (`Mvc5\Http\Headers\Config`) is incompatible with the return type of the parent method `Mvc5\Config::with` of type `Mvc5\Config\Config`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
68			}
69
70			/**
71			* @param string $name
72			* @return self\|mixed
73			*/
74			function without($name)
			0 ignored issues – show Best Practice introduced 2017-03-19 23:28 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
75			{
76			return parent::without(strtolower($name));
			0 ignored issues – show Bug Best Practice introduced 2017-03-19 23:28 UTC by Report Bug Copy Issue Report The return type of `return parent::without(strtolower($name));` (`Mvc5\Http\Headers\Config`) is incompatible with the return type of the parent method `Mvc5\Config::without` of type `Mvc5\Config\Config`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
77			}
78			}
79

mvc5 / mvc5

Push — master ( a1f230...f04eab )

Config::with() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like