Completed
Push — master ( 928644...38310f )
by Matthew
17:30
created

DtcQueueListener::prePersist()   A

Complexity

Conditions 3
Paths 3

Size

Total Lines 12
Code Lines 7

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 7
CRAP Score 3.0175

Importance

Changes 1
Bugs 1 Features 0
Metric Value
dl 0
loc 12
ccs 7
cts 8
cp 0.875
rs 9.4285
c 1
b 1
f 0
cc 3
eloc 7
nc 3
nop 1
crap 3.0175
1
<?php
2
3
namespace Dtc\QueueBundle\Doctrine;
4
5
use Doctrine\Common\Persistence\Event\LifecycleEventArgs;
6
use Doctrine\ODM\MongoDB\DocumentManager;
7
use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
8
use Doctrine\ORM\EntityManager;
9
use Doctrine\ORM\Id\AssignedGenerator;
10
use Dtc\QueueBundle\Model\StallableJob;
11
use Dtc\QueueBundle\Model\Run;
12
use Dtc\QueueBundle\ODM\JobManager;
13
use Dtc\QueueBundle\Util\Util;
14
15
class DtcQueueListener
16
{
17
    private $jobArchiveClass;
18
    private $runArchiveClass;
19
    private $objectManager;
20
21 19
    public function __construct($jobArchiveClass, $runArchiveClass)
22
    {
23 19
        $this->jobArchiveClass = $jobArchiveClass;
24 19
        $this->runArchiveClass = $runArchiveClass;
25 19
    }
26
27 36
    public function preRemove(LifecycleEventArgs $eventArgs)
28
    {
29 36
        $this->objectManager = $eventArgs->getObjectManager();
30 36
        $object = $eventArgs->getObject();
31
32 36
        if ($object instanceof \Dtc\QueueBundle\Model\Job) {
33 33
            $this->processJob($object);
34 9
        } elseif ($object instanceof Run) {
35 9
            $this->processRun($object);
36
        }
37 36
    }
38
39 9
    public function processRun(Run $object)
40
    {
41 9
        $runArchiveClass = $this->runArchiveClass;
42 9
        if ($object instanceof $runArchiveClass) {
43
            return;
44
        }
45
46 9
        $objectManager = $this->objectManager;
47 9
        $repository = $objectManager->getRepository($runArchiveClass);
48 9
        if (!$runArchive = $repository->find($object->getId())) {
49 9
            $runArchive = new $runArchiveClass();
50 9
            $newArchive = true;
51
        }
52
53 9
        Util::copy($object, $runArchive);
54 9
        if ($newArchive) {
0 ignored issues
show
Bug introduced by
The variable $newArchive does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
55 9
            $metadata = $objectManager->getClassMetadata($runArchiveClass);
56 9
            $this->adjustIdGenerator($metadata);
57
        }
58
59 9
        $objectManager->persist($runArchive);
60 9
    }
61
62
    /**
63
     * @param $metadata
64
     */
65 36
    protected function adjustIdGenerator(\Doctrine\Common\Persistence\Mapping\ClassMetadata $metadata)
66
    {
67 36
        $objectManager = $this->objectManager;
68 36
        if ($objectManager instanceof EntityManager && $metadata instanceof \Doctrine\ORM\Mapping\ClassMetadata) {
69 17
            $metadata->setIdGeneratorType(\Doctrine\ORM\Mapping\ClassMetadata::GENERATOR_TYPE_NONE);
70 17
            $metadata->setIdGenerator(new AssignedGenerator());
71 19
        } elseif ($objectManager instanceof DocumentManager && $metadata instanceof ClassMetadata) {
72 19
            $metadata->setIdGeneratorType(ClassMetadata::GENERATOR_TYPE_NONE);
73
        }
74 36
    }
75
76 33
    public function processJob(\Dtc\QueueBundle\Model\Job $object)
77
    {
78 33
        if ($object instanceof \Dtc\QueueBundle\Document\Job ||
79 33
            $object instanceof \Dtc\QueueBundle\Entity\Job) {
80
            /** @var JobManager $jobManager */
81 33
            $archiveObjectName = $this->jobArchiveClass;
82 33
            $objectManager = $this->objectManager;
83 33
            $repository = $objectManager->getRepository($archiveObjectName);
84 33
            $className = $repository->getClassName();
85
86
            /** @var StallableJob $jobArchive */
87 33
            $newArchive = false;
88 33
            if (!$jobArchive = $repository->find($object->getId())) {
89 33
                $jobArchive = new $className();
90 33
                $newArchive = true;
91
            }
92
93 33
            if ($newArchive) {
94 33
                $metadata = $objectManager->getClassMetadata($className);
95 33
                $this->adjustIdGenerator($metadata);
96
            }
97
98 33
            Util::copy($object, $jobArchive);
99 33
            $jobArchive->setUpdatedAt(new \DateTime());
100 33
            $objectManager->persist($jobArchive);
101
        }
102 33
    }
103
104 20
    public function preUpdate(LifecycleEventArgs $eventArgs)
105
    {
106 20
        $object = $eventArgs->getObject();
107 20
        if ($object instanceof \Dtc\QueueBundle\Model\StallableJob) {
108 20
            $dateTime = \Dtc\QueueBundle\Util\Util::getMicrotimeDateTime();
109 20
            $object->setUpdatedAt($dateTime);
110
        }
111 20
    }
112
113 47
    public function prePersist(LifecycleEventArgs $eventArgs)
114
    {
115 47
        $object = $eventArgs->getObject();
116
117 47
        if ($object instanceof \Dtc\QueueBundle\Model\StallableJob) {
118 43
            $dateTime = \Dtc\QueueBundle\Util\Util::getMicrotimeDateTime();
119 43
            if (!$object->getCreatedAt()) {
120
                $object->setCreatedAt($dateTime);
121
            }
122 43
            $object->setUpdatedAt($dateTime);
123
        }
124 47
    }
125
}
126