Rebuild::__construct() - Code Metrics - Inspection of "Changing the actions to take an array parameter in..." - mfrost503/Billow - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7c71a4...34aff4 )

by Matt

created 2016-01-28 16:38 UTC

Rebuild::__construct() A

↳ Parent: Rebuild

Complexity

Conditions	4
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	11
Ratio	100 %

Code Coverage

Tests	6
CRAP Score	4.0466

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	11
loc	11
ccs	6
cts	7
cp	0.8571
rs	9.2
cc	4
eloc	6
nc	3
nop	1
crap	4.0466

<?php
namespace Billow\Actions;
use InvalidArgumentException;

/**
 * @author Matt Frost<[email protected]>
 * @package Billow
 * @subpackage Actions
 * @license http://opensource.org/licenses/MIT MIT
 */
class Rebuild extends Action

{
    /**
     * Action parameter
     *
     * @const ACTION
     */
    const ACTION = 'rebuild';

    /**
     * Action HTTP Method
     *
     * @const method
     */
    const METHOD = 'POST';

    /**
     * Image slug or ID
     *
     * @var mixed image
     */
    protected $image;

    /**
     * Constructor for rebuild action
     *
     * @param Array values
     * @throws \InvalidArgumentException
     */
    public function __construct(Array $values)
    {
        if (!isset($values['image'])) {
            throw new InvalidArgumentException('Required value "image" is not present');
        }

        if (!is_numeric($values['image']) && !is_string($values['image'])) {
            throw new InvalidArgumentException("Image argument must be a slug or ID");
        }
        $this->image = $values['image'];
    }

    /**
     * Return the body of the request
     *
     * @return string json representation of the body
     */
    public function getBody()
    {
        return json_encode([
            'type' => self::ACTION,
            'image' => $this->image
        ]);
    }
}



1			<?php
2			namespace Billow\Actions;
3			use InvalidArgumentException;
4
5			/**
6			* @author Matt Frost<[email protected]>
7			* @package Billow
8			* @subpackage Actions
9			* @license http://opensource.org/licenses/MIT MIT
10			*/
11		View Code Duplication	class Rebuild extends Action
			0 ignored issues – show Duplication introduced 2015-12-01 18:39 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12			{
13			/**
14			* Action parameter
15			*
16			* @const ACTION
17			*/
18			const ACTION = 'rebuild';
19
20			/**
21			* Action HTTP Method
22			*
23			* @const method
24			*/
25			const METHOD = 'POST';
26
27			/**
28			* Image slug or ID
29			*
30			* @var mixed image
31			*/
32			protected $image;
33
34			/**
35			* Constructor for rebuild action
36			*
37			* @param Array values
38			* @throws \InvalidArgumentException
39			*/
40	7		public function __construct(Array $values)
41			{
42	7		if (!isset($values['image'])) {
43	4		throw new InvalidArgumentException('Required value "image" is not present');
44			}
45
46	3		if (!is_numeric($values['image']) && !is_string($values['image'])) {
47			throw new InvalidArgumentException("Image argument must be a slug or ID");
48			}
49	3		$this->image = $values['image'];
50	3		}
51
52			/**
53			* Return the body of the request
54			*
55			* @return string json representation of the body
56			*/
57	2		public function getBody()
58			{
59	2		return json_encode([
60	2		'type' => self::ACTION,
61	2		'image' => $this->image
62	2		]);
63			}
64			}
65
66

mfrost503 / Billow

Push — master ( 7c71a4...34aff4 )

Rebuild::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like