SpecialDiceFactory::normaliseType() - Code Metrics - Inspection of "split out dice building logic" - meadsteve/DiceApi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 79c16c...fd607f )

by Steve

created 2016-12-18 18:31 UTC

SpecialDiceFactory::normaliseType() A

↳ Parent: SpecialDiceFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace MeadSteve\DiceApi\Dice\Factories;

use MeadSteve\DiceApi\BasicDice;
use MeadSteve\DiceApi\Dice;
use MeadSteve\DiceApi\Dice\SteveDice;
use MeadSteve\DiceApi\Dice\UncreatableDiceException;
use MeadSteve\DiceApi\Dice\ZeropointDice;

class SpecialDiceFactory implements DiceFactory
{
    /**
     * @var callable[]
     */
    private $diceTypeCallbacks;

    public function __construct()
    {
        $this->diceTypeCallbacks = [

            'steve' => [$this, 'buildSteveDice']
        ];
    }


    public function handlesType(string $type) : bool
    {
        return array_key_exists(
            $this->normaliseType($type),
            $this->diceTypeCallbacks
        );
    }

    /**
     * @param string $type
     * @param int $number
     * @return Dice[]
     */
    public function buildDice(string $type, int $number) : array
    {
        $function = $this->diceTypeCallbacks[$this->normaliseType($type)];
        return $function($type, $number);
    }

    private function buildSteveDice($_type, $diceCount)
    {
        $newDice = [];
        for ($i = 0; $i < $diceCount; $i++) {
            $newDice[] = new SteveDice();
        }
        return $newDice;
    }

    private function normaliseType(string $type): string
    {
        return strtolower($type);
    }
}


1			<?php
2
3			namespace MeadSteve\DiceApi\Dice\Factories;
4
5			use MeadSteve\DiceApi\BasicDice;
6			use MeadSteve\DiceApi\Dice;
7			use MeadSteve\DiceApi\Dice\SteveDice;
8			use MeadSteve\DiceApi\Dice\UncreatableDiceException;
9			use MeadSteve\DiceApi\Dice\ZeropointDice;
10
11			class SpecialDiceFactory implements DiceFactory
12			{
13			/**
14			* @var callable[]
15			*/
16			private $diceTypeCallbacks;
17
18			public function __construct()
19			{
20			$this->diceTypeCallbacks = [
			0 ignored issues – show Documentation Bug introduced 2016-12-18 18:33 UTC by Report Bug Copy Issue Report It seems like `array('steve' => array($this, 'buildSteveDice'))` of type `array<string,array<integ...",\"1\":\"string\"}>"}>` is incompatible with the declared type `array<integer,callable>` of property `$diceTypeCallbacks`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
21			'steve' => [$this, 'buildSteveDice']
22			];
23			}
24
25
26			public function handlesType(string $type) : bool
27			{
28			return array_key_exists(
29			$this->normaliseType($type),
30			$this->diceTypeCallbacks
31			);
32			}
33
34			/**
35			* @param string $type
36			* @param int $number
37			* @return Dice[]
38			*/
39			public function buildDice(string $type, int $number) : array
40			{
41			$function = $this->diceTypeCallbacks[$this->normaliseType($type)];
42			return $function($type, $number);
43			}
44
45			private function buildSteveDice($_type, $diceCount)
46			{
47			$newDice = [];
48			for ($i = 0; $i < $diceCount; $i++) {
49			$newDice[] = new SteveDice();
50			}
51			return $newDice;
52			}
53
54			private function normaliseType(string $type): string
55			{
56			return strtolower($type);
57			}
58			}
59

meadsteve / DiceApi

Push — master ( 79c16c...fd607f )

SpecialDiceFactory::normaliseType() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like