mdaniels5757 / waca

includes/Background/BackgroundTaskBase.php

Braces +1 added lines, -1 removed lines

@@ -177,7 +177,7 @@
             throw new ApplicationLogicException('Cannot locate request');
         }
 
-        if($this->job->getEmailTemplate() !== null){
+        if($this->job->getEmailTemplate() !== null) {
             $this->emailTemplate = EmailTemplate::getById($this->job->getEmailTemplate(), $this->getDatabase());
 
             if ($this->emailTemplate === false) {

includes/Pages/PageEmailManagement.php

Braces +2 added lines, -4 removed lines

@@ -115,8 +115,7 @@ 
             SessionAlert::success("Email template has been saved successfully.");
 
             $this->redirect('emailManagement');
-        }
-        else {
+        } else {
             $this->assignCSRFToken();
             $this->assign('id', $template->getId());
             $this->assign('emailTemplate', $template);
@@ -183,8 +182,7 @@ 
             SessionAlert::success("Email template has been saved successfully.");
 
             $this->redirect('emailManagement');
-        }
-        else {
+        } else {
             $this->assignCSRFToken();
             $this->assign('id', -1);
             $this->assign('emailTemplate', new EmailTemplate());

includes/Pages/PageExpandedRequestList.php

Braces +1 added lines, -2 removed lines

@@ -42,8 +42,7 @@
             if ($config->getEmailConfirmationEnabled()) {
                 $query = "SELECT * FROM request WHERE status = :type AND emailconfirm = 'Confirmed';";
                 $totalQuery = "SELECT COUNT(id) FROM request WHERE status = :type AND emailconfirm = 'Confirmed';";
-            }
-            else {
+            } else {
                 $query = "SELECT * FROM request WHERE status = :type;";
                 $totalQuery = "SELECT COUNT(id) FROM request WHERE status = :type;";
             }

includes/Pages/RequestAction/PageBreakReservation.php

Braces +3 added lines, -6 removed lines

@@ -33,13 +33,11 @@ 
 
         if ($currentUser->getId() === $request->getReserved()) {
             $this->doUnreserve($request, $database);
-        }
-        else {
+        } else {
             // not the same user!
             if ($this->barrierTest('force', $currentUser)) {
                 $this->doBreakReserve($request, $database);
-            }
-            else {
+            } else {
                 throw new AccessDeniedException($this->getSecurityManager());
             }
         }
@@ -83,8 +81,7 @@ 
             $this->skipAlerts();
 
             $this->setTemplate("confirmations/breakreserve.tpl");
-        }
-        else {
+        } else {
             $request->setReserved(null);
             $request->setUpdateVersion(WebRequest::postInt('updateversion'));
             $request->save();

includes/Pages/RequestAction/PageCreateRequest.php

Braces +1 added lines, -2 removed lines

@@ -55,8 +55,7 @@
             && $creationMode === 'bot'
         ) {
             throw new AccessDeniedException($secMgr);
-        }
-        elseif ($secMgr->allows('RequestCreation', User::CREATION_OAUTH, $user) !== SecurityManager::ALLOWED
+        } elseif ($secMgr->allows('RequestCreation', User::CREATION_OAUTH, $user) !== SecurityManager::ALLOWED
             && $creationMode === 'oauth'
         ) {
             throw new AccessDeniedException($secMgr);

includes/Pages/PageUserManagement.php

Braces +7 added lines, -14 removed lines

@@ -60,8 +60,7 @@ 
             $this->assign("declinedUsers", $declinedUsers);
 
             UserSearchHelper::get($database)->getRoleMap($roleMap);
-        }
-        else {
+        } else {
             $this->assign("showAll", false);
             $this->assign("suspendedUsers", array());
             $this->assign("declinedUsers", array());
@@ -182,8 +181,7 @@ 
             $this->redirect('statistics/users', 'detail', array('user' => $user->getId()));
 
             return;
-        }
-        else {
+        } else {
             $this->assignCSRFToken();
             $this->setTemplate('usermanagement/roleedit.tpl');
             $this->assign('user', $user);
@@ -244,8 +242,7 @@ 
             $this->redirect('userManagement');
 
             return;
-        }
-        else {
+        } else {
             $this->assignCSRFToken();
             $this->setTemplate('usermanagement/changelevel-reason.tpl');
             $this->assign('user', $user);
@@ -309,8 +306,7 @@ 
             $this->redirect('userManagement');
 
             return;
-        }
-        else {
+        } else {
             $this->assignCSRFToken();
             $this->setTemplate('usermanagement/changelevel-reason.tpl');
             $this->assign('user', $user);
@@ -364,8 +360,7 @@ 
             $this->redirect("userManagement");
 
             return;
-        }
-        else {
+        } else {
             $this->assignCSRFToken();
             $this->setTemplate("usermanagement/changelevel-reason.tpl");
             $this->assign("user", $user);
@@ -445,8 +440,7 @@ 
             $this->redirect("userManagement");
 
             return;
-        }
-        else {
+        } else {
             $this->assignCSRFToken();
             $this->setTemplate('usermanagement/renameuser.tpl');
             $this->assign('user', $user);
@@ -505,8 +499,7 @@ 
             $this->redirect("userManagement");
 
             return;
-        }
-        else {
+        } else {
             $this->assignCSRFToken();
             $oauth = new OAuthUserHelper($user, $database, $this->getOAuthProtocolHelper(),
                 $this->getSiteConfiguration());

includes/Pages/PageBan.php

Braces +7 added lines, -11 removed lines

@@ -33,7 +33,8 @@ 
         $bans = Ban::getActiveBans(null, $this->getDatabase());
 
         $userIds = array_map(
-            function(Ban $entry) {
+            function(Ban $entry)
+            {
                 return $entry->getUser();
             },
             $bans);
@@ -64,8 +65,7 @@ 
                 SessionAlert::error($ex->getMessage());
                 $this->redirect("bans", "set");
             }
-        }
-        else {
+        } else {
             $this->handleGetMethodForSetBan();
         }
     }
@@ -103,8 +103,7 @@ 
             $this->getNotificationHelper()->unbanned($ban, $unbanReason);
 
             $this->redirect('bans');
-        }
-        else {
+        } else {
             $this->assignCSRFToken();
             $this->assign('ban', $ban);
             $this->setTemplate('bans/unban.tpl');
@@ -122,17 +121,14 @@ 
 
             if (!$duration) {
                 throw new ApplicationLogicException('Invalid ban time');
-            }
-            elseif (time() > $duration) {
+            } elseif (time() > $duration) {
                 throw new ApplicationLogicException('Ban time has already expired!');
             }
 
             return $duration;
-        }
-        elseif ($duration === "-1") {
+        } elseif ($duration === "-1") {
             return null;
-        }
-        else {
+        } else {
             $duration = WebRequest::postInt('duration') + time();
 
             return $duration;

includes/Pages/PageSearch.php

Braces +1 added lines, -2 removed lines

@@ -62,8 +62,7 @@
 
             $this->assignCSRFToken();
             $this->setTemplate('search/searchResult.tpl');
-        }
-        else {
+        } else {
             $this->assignCSRFToken();
             $this->setTemplate('search/searchForm.tpl');
         }

includes/Pages/UserAuth/Login/LoginCredentialPageBase.php

Braces +8 added lines, -13 removed lines

@@ -65,8 +65,7 @@ 
                     }
 
                     $user = User::getByUsername($username, $database);
-                }
-                else {
+                } else {
                     $user = User::getById($partialId, $database);
                 }
 
@@ -105,8 +104,7 @@ 
 
                 return;
             }
-        }
-        else {
+        } else {
             $this->assign('showSignIn', true);
 
             $this->setupPartial();
@@ -131,8 +129,7 @@ 
             if (WebRequest::isHttps()) {
                 // Client can clearly use HTTPS, so let's enforce it for all connections.
                 $this->headerQueue[] = "Strict-Transport-Security: max-age=15768000";
-            }
-            else {
+            } else {
                 // This is the login form, not the request form. We need protection here.
                 $this->redirectUrl('https://' . WebRequest::serverName() . WebRequest::requestUri());
 
@@ -166,8 +163,7 @@ 
             $username = $this->partialUser->getUsername();
 
             $this->setupAlternates($this->partialUser, $partialStage, $database);
-        }
-        else {
+        } else {
             // No, see if we've preloaded a username
             $preloadUsername = WebRequest::getString('tplUsername');
             if ($preloadUsername !== null) {
@@ -194,13 +190,11 @@ 
         $redirectDestination = WebRequest::clearPostLoginRedirect();
         if ($redirectDestination !== null) {
             $this->redirectUrl($redirectDestination);
-        }
-        else {
+        } else {
             if ($user->isNewUser()) {
                 // home page isn't allowed, go to preferences instead
                 $this->redirect('preferences');
-            }
-            else {
+            } else {
                 // go to the home page
                 $this->redirect('');
             }
@@ -323,7 +317,8 @@ 
         if (isset($types[$type])) {
             $options = $types[$type];
 
-            array_walk($options, function(&$val) {
+            array_walk($options, function(&$val)
+            {
                 $val = $this->names[$val];
             });