mdaniels5757 / waca

includes/Pages/UserAuth/PageForgotPassword.php

Braces +2 added lines, -4 removed lines

@@ -46,8 +46,7 @@ 
             SessionAlert::success('<strong>Your password reset request has been completed.</strong> If the details you have provided match our records, you should receive an email shortly.');
 
             $this->redirect('login');
-        }
-        else {
+        } else {
             $this->assignCSRFToken();
             $this->setTemplate('forgot-password/forgotpw.tpl');
         }
@@ -130,8 +129,7 @@ 
 
                 return;
             }
-        }
-        else {
+        } else {
             $this->assignCSRFToken();
             $this->assign('user', $user);
             $this->setTemplate('forgot-password/forgotpwreset.tpl');

Indentation +209 added lines, -209 removed lines

@@ -23,213 +23,213 @@
 
 class PageForgotPassword extends InternalPageBase
 {
-    /**
-     * Main function for this page, when no specific actions are called.
-     *
-     * This is the forgotten password reset form
-     * @category Security-Critical
-     */
-    protected function main()
-    {
-        if (WebRequest::wasPosted()) {
-            $this->validateCSRFToken();
-            $username = WebRequest::postString('username');
-            $email = WebRequest::postEmail('email');
-            $database = $this->getDatabase();
-
-            if ($username === null || trim($username) === "" || $email === null || trim($email) === "") {
-                throw new ApplicationLogicException("Both username and email address must be specified!");
-            }
-
-            $user = User::getByUsername($username, $database);
-            $this->sendResetMail($user, $email);
-
-            SessionAlert::success('<strong>Your password reset request has been completed.</strong> If the details you have provided match our records, you should receive an email shortly.');
-
-            $this->redirect('login');
-        }
-        else {
-            $this->assignCSRFToken();
-            $this->setTemplate('forgot-password/forgotpw.tpl');
-        }
-    }
-
-    /**
-     * Sends a reset email if the user is authenticated
-     *
-     * @param User|boolean $user  The user located from the database, or false. Doesn't really matter, since we do the
-     *                            check anyway within this method and silently skip if we don't have a user.
-     * @param string       $email The provided email address
-     */
-    private function sendResetMail($user, $email)
-    {
-        // If the user isn't found, or the email address is wrong, skip sending the details silently.
-        if (!$user instanceof User) {
-            return;
-        }
-
-        if (strtolower($user->getEmail()) === strtolower($email)) {
-            $clientIp = $this->getXffTrustProvider()
-                ->getTrustedClientIp(WebRequest::remoteAddress(), WebRequest::forwardedAddress());
-
-            $this->cleanExistingTokens($user);
-
-            $hash = Base32::encodeUpper(openssl_random_pseudo_bytes(30));
-
-            $encryptionHelper = new EncryptionHelper($this->getSiteConfiguration());
-
-            $cred = new Credential();
-            $cred->setDatabase($this->getDatabase());
-            $cred->setFactor(-1);
-            $cred->setUserId($user->getId());
-            $cred->setType('reset');
-            $cred->setData($encryptionHelper->encryptData($hash));
-            $cred->setVersion(0);
-            $cred->setDisabled(0);
-            $cred->setTimeout(new DateTimeImmutable('+ 1 hour'));
-            $cred->setPriority(9);
-            $cred->save();
-
-            $this->assign("user", $user);
-            $this->assign("hash", $hash);
-            $this->assign("remoteAddress", $clientIp);
-
-            $emailContent = $this->fetchTemplate('forgot-password/reset-mail.tpl');
-
-            // FIXME: domains!
-            /** @var Domain $domain */
-            $domain = Domain::getById(1, $this->getDatabase());
-            $this->getEmailHelper()->sendMail(
-                null, $user->getEmail(), "WP:ACC password reset", $emailContent);
-        }
-    }
-
-    /**
-     * Entry point for the reset action
-     *
-     * This is the reset password part of the form.
-     * @category Security-Critical
-     */
-    protected function reset()
-    {
-        $si = WebRequest::getString('si');
-        $id = WebRequest::getString('id');
-
-        if ($si === null || trim($si) === "" || $id === null || trim($id) === "") {
-            throw new ApplicationLogicException("Link not valid, please ensure it has copied correctly");
-        }
-
-        $database = $this->getDatabase();
-        $user = $this->getResettingUser($id, $database, $si);
-
-        // Dual mode
-        if (WebRequest::wasPosted()) {
-            $this->validateCSRFToken();
-            try {
-                $this->doReset($user);
-                $this->cleanExistingTokens($user);
-            }
-            catch (ApplicationLogicException $ex) {
-                SessionAlert::error($ex->getMessage());
-                $this->redirect('forgotPassword', 'reset', array('si' => $si, 'id' => $id));
-
-                return;
-            }
-        }
-        else {
-            $this->assignCSRFToken();
-            $this->assign('user', $user);
-            $this->setTemplate('forgot-password/forgotpwreset.tpl');
-            $this->addJs("/vendor/dropbox/zxcvbn/dist/zxcvbn.js");
-        }
-    }
-
-    /**
-     * Gets the user resetting their password from the database, or throwing an exception if that is not possible.
-     *
-     * @param integer     $id       The ID of the user to retrieve
-     * @param PdoDatabase $database The database object to use
-     * @param string      $si       The reset hash provided
-     *
-     * @return User
-     * @throws ApplicationLogicException
-     */
-    private function getResettingUser($id, $database, $si)
-    {
-        $user = User::getById($id, $database);
-
-        if ($user === false || $user->isCommunityUser()) {
-            throw new ApplicationLogicException("Password reset failed. Please try again.");
-        }
-
-        $statement = $database->prepare("SELECT * FROM credential WHERE type = 'reset' AND user = :user;");
-        $statement->execute([':user' => $user->getId()]);
-
-        /** @var Credential $credential */
-        $credential = $statement->fetchObject(Credential::class);
-
-        $statement->closeCursor();
-
-        if ($credential === false) {
-            throw new ApplicationLogicException("Password reset failed. Please try again.");
-        }
-
-        $credential->setDatabase($database);
-
-        $encryptionHelper = new EncryptionHelper($this->getSiteConfiguration());
-        if ($encryptionHelper->decryptData($credential->getData()) != $si) {
-            throw new ApplicationLogicException("Password reset failed. Please try again.");
-        }
-
-        if ($credential->getTimeout() < new DateTimeImmutable()) {
-            $credential->delete();
-            throw new ApplicationLogicException("Password reset token expired. Please try again.");
-        }
-
-        return $user;
-    }
-
-    /**
-     * Performs the setting of the new password
-     *
-     * @param User $user The user to set the password for
-     *
-     * @throws ApplicationLogicException
-     */
-    private function doReset(User $user)
-    {
-        $pw = WebRequest::postString('newpassword');
-        $pw2 = WebRequest::postString('newpasswordconfirm');
-
-        if ($pw !== $pw2) {
-            throw new ApplicationLogicException('Passwords do not match!');
-        }
-
-        $passwordCredentialProvider = new PasswordCredentialProvider($user->getDatabase(), $this->getSiteConfiguration());
-        $passwordCredentialProvider->setCredential($user, 1, $pw);
-
-        SessionAlert::success('You may now log in!');
-        $this->redirect('login');
-    }
-
-    protected function isProtectedPage()
-    {
-        return false;
-    }
-
-    /**
-     * @param $user
-     */
-    private function cleanExistingTokens($user): void
-    {
-        // clean out existing reset tokens
-        $statement = $this->getDatabase()->prepare("SELECT * FROM credential WHERE type = 'reset' AND user = :user;");
-        $statement->execute([':user' => $user->getId()]);
-        $existing = $statement->fetchAll(PdoDatabase::FETCH_CLASS, Credential::class);
-
-        foreach ($existing as $c) {
-            $c->setDatabase($this->getDatabase());
-            $c->delete();
-        }
-    }
+	/**
+	 * Main function for this page, when no specific actions are called.
+	 *
+	 * This is the forgotten password reset form
+	 * @category Security-Critical
+	 */
+	protected function main()
+	{
+		if (WebRequest::wasPosted()) {
+			$this->validateCSRFToken();
+			$username = WebRequest::postString('username');
+			$email = WebRequest::postEmail('email');
+			$database = $this->getDatabase();
+
+			if ($username === null || trim($username) === "" || $email === null || trim($email) === "") {
+				throw new ApplicationLogicException("Both username and email address must be specified!");
+			}
+
+			$user = User::getByUsername($username, $database);
+			$this->sendResetMail($user, $email);
+
+			SessionAlert::success('<strong>Your password reset request has been completed.</strong> If the details you have provided match our records, you should receive an email shortly.');
+
+			$this->redirect('login');
+		}
+		else {
+			$this->assignCSRFToken();
+			$this->setTemplate('forgot-password/forgotpw.tpl');
+		}
+	}
+
+	/**
+	 * Sends a reset email if the user is authenticated
+	 *
+	 * @param User|boolean $user  The user located from the database, or false. Doesn't really matter, since we do the
+	 *                            check anyway within this method and silently skip if we don't have a user.
+	 * @param string       $email The provided email address
+	 */
+	private function sendResetMail($user, $email)
+	{
+		// If the user isn't found, or the email address is wrong, skip sending the details silently.
+		if (!$user instanceof User) {
+			return;
+		}
+
+		if (strtolower($user->getEmail()) === strtolower($email)) {
+			$clientIp = $this->getXffTrustProvider()
+				->getTrustedClientIp(WebRequest::remoteAddress(), WebRequest::forwardedAddress());
+
+			$this->cleanExistingTokens($user);
+
+			$hash = Base32::encodeUpper(openssl_random_pseudo_bytes(30));
+
+			$encryptionHelper = new EncryptionHelper($this->getSiteConfiguration());
+
+			$cred = new Credential();
+			$cred->setDatabase($this->getDatabase());
+			$cred->setFactor(-1);
+			$cred->setUserId($user->getId());
+			$cred->setType('reset');
+			$cred->setData($encryptionHelper->encryptData($hash));
+			$cred->setVersion(0);
+			$cred->setDisabled(0);
+			$cred->setTimeout(new DateTimeImmutable('+ 1 hour'));
+			$cred->setPriority(9);
+			$cred->save();
+
+			$this->assign("user", $user);
+			$this->assign("hash", $hash);
+			$this->assign("remoteAddress", $clientIp);
+
+			$emailContent = $this->fetchTemplate('forgot-password/reset-mail.tpl');
+
+			// FIXME: domains!
+			/** @var Domain $domain */
+			$domain = Domain::getById(1, $this->getDatabase());
+			$this->getEmailHelper()->sendMail(
+				null, $user->getEmail(), "WP:ACC password reset", $emailContent);
+		}
+	}
+
+	/**
+	 * Entry point for the reset action
+	 *
+	 * This is the reset password part of the form.
+	 * @category Security-Critical
+	 */
+	protected function reset()
+	{
+		$si = WebRequest::getString('si');
+		$id = WebRequest::getString('id');
+
+		if ($si === null || trim($si) === "" || $id === null || trim($id) === "") {
+			throw new ApplicationLogicException("Link not valid, please ensure it has copied correctly");
+		}
+
+		$database = $this->getDatabase();
+		$user = $this->getResettingUser($id, $database, $si);
+
+		// Dual mode
+		if (WebRequest::wasPosted()) {
+			$this->validateCSRFToken();
+			try {
+				$this->doReset($user);
+				$this->cleanExistingTokens($user);
+			}
+			catch (ApplicationLogicException $ex) {
+				SessionAlert::error($ex->getMessage());
+				$this->redirect('forgotPassword', 'reset', array('si' => $si, 'id' => $id));
+
+				return;
+			}
+		}
+		else {
+			$this->assignCSRFToken();
+			$this->assign('user', $user);
+			$this->setTemplate('forgot-password/forgotpwreset.tpl');
+			$this->addJs("/vendor/dropbox/zxcvbn/dist/zxcvbn.js");
+		}
+	}
+
+	/**
+	 * Gets the user resetting their password from the database, or throwing an exception if that is not possible.
+	 *
+	 * @param integer     $id       The ID of the user to retrieve
+	 * @param PdoDatabase $database The database object to use
+	 * @param string      $si       The reset hash provided
+	 *
+	 * @return User
+	 * @throws ApplicationLogicException
+	 */
+	private function getResettingUser($id, $database, $si)
+	{
+		$user = User::getById($id, $database);
+
+		if ($user === false || $user->isCommunityUser()) {
+			throw new ApplicationLogicException("Password reset failed. Please try again.");
+		}
+
+		$statement = $database->prepare("SELECT * FROM credential WHERE type = 'reset' AND user = :user;");
+		$statement->execute([':user' => $user->getId()]);
+
+		/** @var Credential $credential */
+		$credential = $statement->fetchObject(Credential::class);
+
+		$statement->closeCursor();
+
+		if ($credential === false) {
+			throw new ApplicationLogicException("Password reset failed. Please try again.");
+		}
+
+		$credential->setDatabase($database);
+
+		$encryptionHelper = new EncryptionHelper($this->getSiteConfiguration());
+		if ($encryptionHelper->decryptData($credential->getData()) != $si) {
+			throw new ApplicationLogicException("Password reset failed. Please try again.");
+		}
+
+		if ($credential->getTimeout() < new DateTimeImmutable()) {
+			$credential->delete();
+			throw new ApplicationLogicException("Password reset token expired. Please try again.");
+		}
+
+		return $user;
+	}
+
+	/**
+	 * Performs the setting of the new password
+	 *
+	 * @param User $user The user to set the password for
+	 *
+	 * @throws ApplicationLogicException
+	 */
+	private function doReset(User $user)
+	{
+		$pw = WebRequest::postString('newpassword');
+		$pw2 = WebRequest::postString('newpasswordconfirm');
+
+		if ($pw !== $pw2) {
+			throw new ApplicationLogicException('Passwords do not match!');
+		}
+
+		$passwordCredentialProvider = new PasswordCredentialProvider($user->getDatabase(), $this->getSiteConfiguration());
+		$passwordCredentialProvider->setCredential($user, 1, $pw);
+
+		SessionAlert::success('You may now log in!');
+		$this->redirect('login');
+	}
+
+	protected function isProtectedPage()
+	{
+		return false;
+	}
+
+	/**
+	 * @param $user
+	 */
+	private function cleanExistingTokens($user): void
+	{
+		// clean out existing reset tokens
+		$statement = $this->getDatabase()->prepare("SELECT * FROM credential WHERE type = 'reset' AND user = :user;");
+		$statement->execute([':user' => $user->getId()]);
+		$existing = $statement->fetchAll(PdoDatabase::FETCH_CLASS, Credential::class);
+
+		foreach ($existing as $c) {
+			$c->setDatabase($this->getDatabase());
+			$c->delete();
+		}
+	}
 }

includes/API/IXmlApiAction.php

Indentation +8 added lines, -8 removed lines

@@ -16,12 +16,12 @@
  */
 interface IXmlApiAction extends IRoutedTask, IApiAction
 {
-    /**
-     * Method that runs API action
-     *
-     * @param DOMElement $apiDocument
-     *
-     * @return DOMElement The modified API document
-     */
-    public function executeApiAction(DOMElement $apiDocument);
+	/**
+	 * Method that runs API action
+	 *
+	 * @param DOMElement $apiDocument
+	 *
+	 * @return DOMElement The modified API document
+	 */
+	public function executeApiAction(DOMElement $apiDocument);
 }

includes/API/IJsonApiAction.php

Indentation +6 added lines, -6 removed lines

@@ -15,10 +15,10 @@
  */
 interface IJsonApiAction extends IRoutedTask, IApiAction
 {
-    /**
-     * Method that runs API action
-     *
-     * @return object|array The modified API document
-     */
-    public function executeApiAction();
+	/**
+	 * Method that runs API action
+	 *
+	 * @return object|array The modified API document
+	 */
+	public function executeApiAction();
 }

includes/API/Actions/UnknownAction.php

Indentation +9 added lines, -9 removed lines

@@ -16,15 +16,15 @@
  */
 class UnknownAction extends HelpAction implements IXmlApiAction
 {
-    public function executeApiAction(DOMElement $apiDocument)
-    {
-        $errorText = "Unknown API action specified.";
-        $errorNode = $this->document->createElement("error", $errorText);
-        $apiDocument->appendChild($errorNode);
+	public function executeApiAction(DOMElement $apiDocument)
+	{
+		$errorText = "Unknown API action specified.";
+		$errorNode = $this->document->createElement("error", $errorText);
+		$apiDocument->appendChild($errorNode);
 
-        $helpElement = $this->getHelpElement();
-        $apiDocument->appendChild($helpElement);
+		$helpElement = $this->getHelpElement();
+		$apiDocument->appendChild($helpElement);
 
-        return $apiDocument;
-    }
+		return $apiDocument;
+	}
 }

includes/API/Actions/HelpAction.php

Indentation +30 added lines, -30 removed lines

@@ -18,34 +18,34 @@
  */
 class HelpAction extends XmlApiPageBase implements IXmlApiAction
 {
-    public function executeApiAction(DOMElement $apiDocument)
-    {
-        $helpElement = $this->getHelpElement();
-        $apiDocument->appendChild($helpElement);
-
-        return $apiDocument;
-    }
-
-    /**
-     * Gets the help information
-     * @return DOMElement
-     */
-    protected function getHelpElement()
-    {
-        $helpInfo = "API help can be found at https://github.com/enwikipedia-acc/waca/wiki/API";
-
-        $help = $this->document->createElement("help");
-        $helptext = $this->document->createElement("info", $helpInfo);
-        $helpactions = $this->document->createElement("actions");
-
-        foreach (ApiRequestRouter::getActionList() as $action) {
-            $actionElement = $this->document->createElement("action", $action);
-            $helpactions->appendChild($actionElement);
-        }
-
-        $help->appendChild($helptext);
-        $help->appendChild($helpactions);
-
-        return $help;
-    }
+	public function executeApiAction(DOMElement $apiDocument)
+	{
+		$helpElement = $this->getHelpElement();
+		$apiDocument->appendChild($helpElement);
+
+		return $apiDocument;
+	}
+
+	/**
+	 * Gets the help information
+	 * @return DOMElement
+	 */
+	protected function getHelpElement()
+	{
+		$helpInfo = "API help can be found at https://github.com/enwikipedia-acc/waca/wiki/API";
+
+		$help = $this->document->createElement("help");
+		$helptext = $this->document->createElement("info", $helpInfo);
+		$helpactions = $this->document->createElement("actions");
+
+		foreach (ApiRequestRouter::getActionList() as $action) {
+			$actionElement = $this->document->createElement("action", $action);
+			$helpactions->appendChild($actionElement);
+		}
+
+		$help->appendChild($helptext);
+		$help->appendChild($helpactions);
+
+		return $help;
+	}
 }

includes/API/Actions/MonitorAction.php

Indentation +50 added lines, -50 removed lines

@@ -23,65 +23,65 @@
  */
 class MonitorAction extends XmlApiPageBase implements IXmlApiAction
 {
-    /**
-     * @param DOMElement $apiDocument
-     *
-     * @return DOMElement
-     */
-    public function executeApiAction(DOMElement $apiDocument)
-    {
-        $now = new DateTime();
+	/**
+	 * @param DOMElement $apiDocument
+	 *
+	 * @return DOMElement
+	 */
+	public function executeApiAction(DOMElement $apiDocument)
+	{
+		$now = new DateTime();
 
-        $old = $this->getOldest();
-        $oldest = new DateTime($old);
+		$old = $this->getOldest();
+		$oldest = new DateTime($old);
 
-        $new = $this->getNewest();
-        $newest = new DateTime($new);
+		$new = $this->getNewest();
+		$newest = new DateTime($new);
 
-        $monitoringElement = $this->document->createElement("data");
-        $monitoringElement->setAttribute("date", $now->format('c'));
-        $monitoringElement->setAttribute("oldest", $old === null ? null : $oldest->format('c'));
-        $monitoringElement->setAttribute("newest", $new === null ? null : $newest->format('c'));
-        $apiDocument->appendChild($monitoringElement);
+		$monitoringElement = $this->document->createElement("data");
+		$monitoringElement->setAttribute("date", $now->format('c'));
+		$monitoringElement->setAttribute("oldest", $old === null ? null : $oldest->format('c'));
+		$monitoringElement->setAttribute("newest", $new === null ? null : $newest->format('c'));
+		$apiDocument->appendChild($monitoringElement);
 
-        return $apiDocument;
-    }
+		return $apiDocument;
+	}
 
-    /**
-     * @return string|null
-     */
-    private function getOldest()
-    {
-        $statement = $this->getDatabase()
-            ->prepare("SELECT min(date) FROM request WHERE email != :email AND ip != :ip;");
-        $successful = $statement->execute(array(
-            ':email' => $this->getSiteConfiguration()->getDataClearEmail(),
-            ':ip'    => $this->getSiteConfiguration()->getDataClearIp(),
-        ));
+	/**
+	 * @return string|null
+	 */
+	private function getOldest()
+	{
+		$statement = $this->getDatabase()
+			->prepare("SELECT min(date) FROM request WHERE email != :email AND ip != :ip;");
+		$successful = $statement->execute(array(
+			':email' => $this->getSiteConfiguration()->getDataClearEmail(),
+			':ip'    => $this->getSiteConfiguration()->getDataClearIp(),
+		));
 
-        if (!$successful) {
-            return null;
-        }
+		if (!$successful) {
+			return null;
+		}
 
-        $result = $statement->fetchColumn();
+		$result = $statement->fetchColumn();
 
-        return $result;
-    }
+		return $result;
+	}
 
-    /**
-     * @return string
-     */
-    private function getNewest()
-    {
-        $statement = $this->getDatabase()
-            ->prepare("SELECT max(date) FROM request WHERE email != :email AND ip != :ip;");
-        $statement->execute(array(
-            ':email' => $this->getSiteConfiguration()->getDataClearEmail(),
-            ':ip'    => $this->getSiteConfiguration()->getDataClearIp(),
-        ));
+	/**
+	 * @return string
+	 */
+	private function getNewest()
+	{
+		$statement = $this->getDatabase()
+			->prepare("SELECT max(date) FROM request WHERE email != :email AND ip != :ip;");
+		$statement->execute(array(
+			':email' => $this->getSiteConfiguration()->getDataClearEmail(),
+			':ip'    => $this->getSiteConfiguration()->getDataClearIp(),
+		));
 
-        $result = $statement->fetchColumn(0);
+		$result = $statement->fetchColumn(0);
 
-        return $result;
-    }
+		return $result;
+	}
 }

includes/API/IApiAction.php

Indentation +4 added lines, -4 removed lines

@@ -15,8 +15,8 @@
  */
 interface IApiAction extends IRoutedTask
 {
-    /**
-     * @return string the XML, or false if an error occurred.
-     */
-    public function runApiPage();
+	/**
+	 * @return string the XML, or false if an error occurred.
+	 */
+	public function runApiPage();
 }

includes/AutoLoader.php

Indentation +29 added lines, -29 removed lines

@@ -13,37 +13,37 @@
  */
 class AutoLoader
 {
-    public static function load($class)
-    {
-        // handle namespaces sensibly
-        if (strpos($class, "Waca") !== false) {
-            // strip off the initial namespace
-            $class = str_replace("Waca\\", "", $class);
+	public static function load($class)
+	{
+		// handle namespaces sensibly
+		if (strpos($class, "Waca") !== false) {
+			// strip off the initial namespace
+			$class = str_replace("Waca\\", "", $class);
 
-            // swap backslashes for forward slashes to map to directory names
-            $class = str_replace("\\", "/", $class);
-        }
+			// swap backslashes for forward slashes to map to directory names
+			$class = str_replace("\\", "/", $class);
+		}
 
-        $paths = array(
-            __DIR__ . '/' . $class . ".php",
-            __DIR__ . '/DataObjects/' . $class . ".php",
-            __DIR__ . '/Providers/' . $class . ".php",
-            __DIR__ . '/Providers/Interfaces/' . $class . ".php",
-            __DIR__ . '/Validation/' . $class . ".php",
-            __DIR__ . '/Helpers/' . $class . ".php",
-            __DIR__ . '/Helpers/Interfaces/' . $class . ".php",
-            __DIR__ . '/' . $class . ".php",
-        );
+		$paths = array(
+			__DIR__ . '/' . $class . ".php",
+			__DIR__ . '/DataObjects/' . $class . ".php",
+			__DIR__ . '/Providers/' . $class . ".php",
+			__DIR__ . '/Providers/Interfaces/' . $class . ".php",
+			__DIR__ . '/Validation/' . $class . ".php",
+			__DIR__ . '/Helpers/' . $class . ".php",
+			__DIR__ . '/Helpers/Interfaces/' . $class . ".php",
+			__DIR__ . '/' . $class . ".php",
+		);
 
-        foreach ($paths as $file) {
-            if (file_exists($file)) {
-                /** @noinspection PhpIncludeInspection */
-                require_once($file);
-            }
+		foreach ($paths as $file) {
+			if (file_exists($file)) {
+				/** @noinspection PhpIncludeInspection */
+				require_once($file);
+			}
 
-            if (class_exists($class)) {
-                return;
-            }
-        }
-    }
+			if (class_exists($class)) {
+				return;
+			}
+		}
+	}
 }

includes/Fragments/RequestListData.php

Braces +2 added lines, -1 removed lines

@@ -38,7 +38,8 @@
         $requestList->requests = $requests;
 
         $userIds = array_map(
-            function(Request $entry) {
+            function(Request $entry)
+            {
                 return $entry->getReserved();
             },
             $requests

Indentation +73 added lines, -73 removed lines

@@ -19,77 +19,77 @@
 
 trait RequestListData
 {
-    // function imports from InternalPageBase etc.
-    protected abstract function getDatabase();
-
-    protected abstract function getXffTrustProvider();
-
-    /** @return SiteConfiguration */
-    protected abstract function getSiteConfiguration();
-
-    protected abstract function barrierTest($action, User $user, $pageName = null);
-
-    /**
-     * @param Request[] $requests
-     *
-     * @return RequestList
-     */
-    protected function prepareRequestData(array $requests) : RequestList
-    {
-        $requestList = new RequestList();
-        $requestList->requests = $requests;
-
-        $userIds = array_map(
-            function(Request $entry) {
-                return $entry->getReserved();
-            },
-            $requests
-        );
-
-        $requestList->userList = UserSearchHelper::get($this->getDatabase())->inIds($userIds)->fetchMap('username');
-
-        $requestList->requestTrustedIp = [];
-        $requestList->relatedIpRequests = [];
-        $requestList->relatedEmailRequests = [];
-
-        foreach ($requests as $request) {
-            $trustedIp = $this->getXffTrustProvider()->getTrustedClientIp(
-                $request->getIp(),
-                $request->getForwardedIp()
-            );
-
-            // TODO: Do we really want to return results from other domains?
-            RequestSearchHelper::get($this->getDatabase(), null)
-                ->byIp($trustedIp)
-                ->withConfirmedEmail()
-                ->excludingPurgedData($this->getSiteConfiguration())
-                ->excludingRequest($request->getId())
-                ->getRecordCount($ipCount);
-
-            RequestSearchHelper::get($this->getDatabase(), null)
-                ->byEmailAddress($request->getEmail())
-                ->withConfirmedEmail()
-                ->excludingPurgedData($this->getSiteConfiguration())
-                ->excludingRequest($request->getId())
-                ->getRecordCount($emailCount);
-
-            $requestList->requestTrustedIp[$request->getId()] = $trustedIp;
-            $requestList->relatedEmailRequests[$request->getId()] = $emailCount;
-            $requestList->relatedIpRequests[$request->getId()] = $ipCount;
-
-            $emailDomain = explode("@", $request->getEmail())[1];
-            $requestList->commonEmail[$request->getId()] = in_array(strtolower($emailDomain), $this->getSiteConfiguration()->getCommonEmailDomains())
-               || $request->getEmail() === $this->getSiteConfiguration()->getDataClearEmail();
-        }
-
-        $currentUser = User::getCurrent($this->getDatabase());
-
-        $requestList->canBan = $this->barrierTest('set', $currentUser, PageBan::class);
-        $requestList->canBreakReservation = $this->barrierTest('force', $currentUser, PageBreakReservation::class);
-        $requestList->showPrivateData = $this->barrierTest('alwaysSeePrivateData', $currentUser, 'RequestData');
-        $requestList->dataClearEmail = $this->getSiteConfiguration()->getDataClearEmail();
-        $requestList->dataClearIp = $this->getSiteConfiguration()->getDataClearIp();
-
-        return $requestList;
-    }
+	// function imports from InternalPageBase etc.
+	protected abstract function getDatabase();
+
+	protected abstract function getXffTrustProvider();
+
+	/** @return SiteConfiguration */
+	protected abstract function getSiteConfiguration();
+
+	protected abstract function barrierTest($action, User $user, $pageName = null);
+
+	/**
+	 * @param Request[] $requests
+	 *
+	 * @return RequestList
+	 */
+	protected function prepareRequestData(array $requests) : RequestList
+	{
+		$requestList = new RequestList();
+		$requestList->requests = $requests;
+
+		$userIds = array_map(
+			function(Request $entry) {
+				return $entry->getReserved();
+			},
+			$requests
+		);
+
+		$requestList->userList = UserSearchHelper::get($this->getDatabase())->inIds($userIds)->fetchMap('username');
+
+		$requestList->requestTrustedIp = [];
+		$requestList->relatedIpRequests = [];
+		$requestList->relatedEmailRequests = [];
+
+		foreach ($requests as $request) {
+			$trustedIp = $this->getXffTrustProvider()->getTrustedClientIp(
+				$request->getIp(),
+				$request->getForwardedIp()
+			);
+
+			// TODO: Do we really want to return results from other domains?
+			RequestSearchHelper::get($this->getDatabase(), null)
+				->byIp($trustedIp)
+				->withConfirmedEmail()
+				->excludingPurgedData($this->getSiteConfiguration())
+				->excludingRequest($request->getId())
+				->getRecordCount($ipCount);
+
+			RequestSearchHelper::get($this->getDatabase(), null)
+				->byEmailAddress($request->getEmail())
+				->withConfirmedEmail()
+				->excludingPurgedData($this->getSiteConfiguration())
+				->excludingRequest($request->getId())
+				->getRecordCount($emailCount);
+
+			$requestList->requestTrustedIp[$request->getId()] = $trustedIp;
+			$requestList->relatedEmailRequests[$request->getId()] = $emailCount;
+			$requestList->relatedIpRequests[$request->getId()] = $ipCount;
+
+			$emailDomain = explode("@", $request->getEmail())[1];
+			$requestList->commonEmail[$request->getId()] = in_array(strtolower($emailDomain), $this->getSiteConfiguration()->getCommonEmailDomains())
+			   || $request->getEmail() === $this->getSiteConfiguration()->getDataClearEmail();
+		}
+
+		$currentUser = User::getCurrent($this->getDatabase());
+
+		$requestList->canBan = $this->barrierTest('set', $currentUser, PageBan::class);
+		$requestList->canBreakReservation = $this->barrierTest('force', $currentUser, PageBreakReservation::class);
+		$requestList->showPrivateData = $this->barrierTest('alwaysSeePrivateData', $currentUser, 'RequestData');
+		$requestList->dataClearEmail = $this->getSiteConfiguration()->getDataClearEmail();
+		$requestList->dataClearIp = $this->getSiteConfiguration()->getDataClearIp();
+
+		return $requestList;
+	}
 }