mbirth / cops

rating.php

<?php
/**
 * COPS (Calibre OPDS PHP Server) class file
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 * @author     Michael Pfitzner
 */

class Rating extends Base {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    const ALL_RATING_ID = "cops:rating";

The string literal cops:rating does not require double quotes, as per coding-style, please use single quotes.

    const RATING_COLUMNS = "ratings.id as id, ratings.rating as rating, count(*) as count";

The string literal ratings.id as id, ratings.rating as rating, count(*) as count does not require double quotes, as per coding-style, please use single quotes.

    const SQL_ALL_RATINGS ="select {0} from ratings, books_ratings_link where books_ratings_link.rating = ratings.id group by ratings.id order by ratings.rating";

The string literal select {0} from ratings, books_ratings_link where books_ratings_link.rating = ratings.id group by ratings.id order by ratings.rating does not require double quotes, as per coding-style, please use single quotes.

    public $id;
    public $name;

    public function __construct($pid, $pname) {
        $this->id = $pid;
        $this->name = $pname;
    }

    public function getUri () {
        return "?page=".parent::PAGE_RATING_DETAIL."&id=$this->id";

The string literal ?page= does not require double quotes, as per coding-style, please use single quotes.

As per coding-style, please use concatenation or sprintf for the variable $this instead of interpolation.

    }

    public function getEntryId () {
        return self::ALL_RATING_ID.":".$this->id;

The string literal : does not require double quotes, as per coding-style, please use single quotes.

    }

    public static function getCount() {
        // str_format (localize("ratings", count(array))

50% of this comment could be valid code. Did you maybe forget this after debugging?

        return parent::getCountGeneric ("ratings", self::ALL_RATING_ID, parent::PAGE_ALL_RATINGS, "ratings");

It seems like you call parent on a different method (getCountGeneric() instead of getCount()). Are you sure this is correct? If so, you might want to change this to $this->getCountGeneric().

The string literal ratings does not require double quotes, as per coding-style, please use single quotes.

    }

    public static function getAllRatings() {
        return self::getEntryArray (self::SQL_ALL_RATINGS, array ());
    }

    public static function getEntryArray ($query, $params) {
        list (, $result) = parent::executeQuery ($query, self::RATING_COLUMNS, "", $params, -1);

It seems like you call parent on a different method (executeQuery() instead of getEntryArray()). Are you sure this is correct? If so, you might want to change this to $this->executeQuery().

The string literal does not require double quotes, as per coding-style, please use single quotes.

        $entryArray = array();
        while ($post = $result->fetchObject ())
        {
            $ratingObj = new Rating ($post->id, $post->rating);
            $rating=$post->rating/2;
            $rating = str_format (localize("ratingword", $rating), $rating);

The string literal ratingword does not require double quotes, as per coding-style, please use single quotes.

            array_push ($entryArray, new Entry ($rating, $ratingObj->getEntryId (),
                str_format (localize("bookword", $post->count), $post->count), "text",

The string literal bookword does not require double quotes, as per coding-style, please use single quotes.

The string literal text does not require double quotes, as per coding-style, please use single quotes.

                array ( new LinkNavigation ($ratingObj->getUri ())), "", $post->count));

The string literal does not require double quotes, as per coding-style, please use single quotes.

        }
        return $entryArray;
    }

    public static function getRatingById ($ratingId) {
        $result = parent::getDb ()->prepare('select rating from ratings where id = ?');

It seems like you call parent on a different method (getDb() instead of getRatingById()). Are you sure this is correct? If so, you might want to change this to $this->getDb().

        $result->execute (array ($ratingId));
        return new Rating ($ratingId, $result->fetchColumn ());
    }
}