Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 10 | class TaskRepository extends BaseRepository |
||
| 11 | { |
||
| 12 | /** |
||
| 13 | * @param object $database |
||
| 14 | */ |
||
| 15 | public function __construct(\PDO $database = null) |
||
| 19 | |||
| 20 | /** |
||
| 21 | * Check if the task exists. |
||
| 22 | * |
||
| 23 | * @param int $taskId |
||
| 24 | * @return array $task |
||
| 25 | * @throws \Exception |
||
| 26 | */ |
||
| 27 | public function checkTask($taskId) |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Get all tasks. |
||
| 43 | * |
||
| 44 | * @return array |
||
| 45 | */ |
||
| 46 | public function getTasks() |
||
| 54 | |||
| 55 | /** |
||
| 56 | * Search tasks by name. |
||
| 57 | * |
||
| 58 | * @param string $tasksName |
||
| 59 | * @return array |
||
| 60 | * @throws \Exception |
||
| 61 | */ |
||
| 62 | View Code Duplication | public function searchTasks($tasksName) |
|
| 76 | |||
| 77 | /** |
||
| 78 | * Create a task. |
||
| 79 | * |
||
| 80 | * @param array $data |
||
| 81 | * @return array |
||
| 82 | * @throws \Exception |
||
| 83 | */ |
||
| 84 | public function createTask($data) |
||
| 95 | |||
| 96 | /** |
||
| 97 | * Update a task. |
||
| 98 | * |
||
| 99 | * @param array $data |
||
| 100 | * @param int $taskId |
||
| 101 | * @return array |
||
| 102 | */ |
||
| 103 | public function updateTask($data, $taskId) |
||
| 115 | |||
| 116 | /** |
||
| 117 | * Delete a task. |
||
| 118 | * |
||
| 119 | * @param int $taskId |
||
| 120 | * @return void |
||
| 121 | */ |
||
| 122 | public function deleteTask($taskId) |
||
| 129 | |||
| 130 | /** |
||
| 131 | * Get Task Sql Query. |
||
| 132 | * |
||
| 133 | * @return string |
||
| 134 | */ |
||
| 135 | public function getTaskQuery() |
||
| 139 | |||
| 140 | public function getTasksQuery() |
||
| 144 | |||
| 145 | public function searchTasksQuery() |
||
| 149 | |||
| 150 | public function createTaskQuery() |
||
| 154 | |||
| 155 | public function updateTaskQuery() |
||
| 159 | |||
| 160 | public function deleteTaskQuery() |
||
| 164 | } |
||
| 165 |