XmlReader::__construct() - Code Metrics - mathielen/import-engine - Measure and Improve Code Quality continuously with Scrutinizer

XmlReader::__construct() A
last analyzed 2021-02-08 13:43 UTC

↳ Parent: XmlReader

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3.0416

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	5
cts	6
cp	0.8333
rs	9.9332
c	0
b	0
f	0
cc	3
nc	2
nop	2
crap	3.0416

<?php

namespace Mathielen\DataImport\Reader;

use Ddeboer\DataImport\Reader\CountableReaderInterface;

/**
 * Reads data from a xml file.
 */
class XmlReader implements CountableReaderInterface
{
    /**
     * @var \Iterator
     */
    protected $iterableResult;

    private $filename;
    private $xpath;

    public function __construct(\SplFileObject $file, $xpath = null)
    {
        $this->filename = $file->getPathname();

        if (!is_null($xpath) && !is_string($xpath)) {
            throw new \InvalidArgumentException('xpath must be null or a string');
        }

        $this->xpath = $xpath;
    }

    /**
     * {@inheritdoc}
     */
    public function getFields()
    {
        return array_keys($this->current()['@attributes']); //TODO
    }

    /**
     * {@inheritdoc}
     */
    public function current()
    {
        if (!$this->iterableResult) {
            $this->rewind();
        }

        return (array) $this->iterableResult->current();
    }

    /**
     * {@inheritdoc}
     */
    public function next()
    {
        $this->iterableResult->next();
    }

    /**
     * {@inheritdoc}
     */
    public function key()
    {
        return $this->iterableResult->key();
    }

    /**
     * {@inheritdoc}
     */
    public function valid()
    {
        return $this->iterableResult->valid();
    }

    /**
     * {@inheritdoc}
     */
    public function rewind()
    {
        if (!$this->iterableResult) {
            $this->iterableResult = new \SimpleXMLIterator(file_get_contents($this->filename));

            if ($this->xpath) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $this->iterableResult = new \ArrayIterator($this->iterableResult->xpath($this->xpath));
            }
        }

        $this->iterableResult->rewind();
    }

    /**
     * {@inheritdoc}
     */
    public function count()
    {
        if (!$this->iterableResult) {
            $this->rewind();
        }

        return count($this->iterableResult);
    }
}


1		<?php
2
3		namespace Mathielen\DataImport\Reader;
4
5		use Ddeboer\DataImport\Reader\CountableReaderInterface;
6
7		/**
8		* Reads data from a xml file.
9		*/
10		class XmlReader implements CountableReaderInterface
11		{
12		/**
13		* @var \Iterator
14		*/
15		protected $iterableResult;
16
17		private $filename;
18		private $xpath;
19
20	3	public function __construct(\SplFileObject $file, $xpath = null)
21		{
22	3	$this->filename = $file->getPathname();
23
24	3	if (!is_null($xpath) && !is_string($xpath)) {
25		throw new \InvalidArgumentException('xpath must be null or a string');
26		}
27
28	3	$this->xpath = $xpath;
29	3	}
30
31		/**
32		* {@inheritdoc}
33		*/
34	2	public function getFields()
35		{
36	2	return array_keys($this->current()['@attributes']); //TODO
37		}
38
39		/**
40		* {@inheritdoc}
41		*/
42	3	public function current()
43		{
44	3	if (!$this->iterableResult) {
45		$this->rewind();
46		}
47
48	3	return (array) $this->iterableResult->current();
49		}
50
51		/**
52		* {@inheritdoc}
53		*/
54	3	public function next()
55		{
56	3	$this->iterableResult->next();
57	3	}
58
59		/**
60		* {@inheritdoc}
61		*/
62	2	public function key()
63		{
64	2	return $this->iterableResult->key();
65		}
66
67		/**
68		* {@inheritdoc}
69		*/
70	3	public function valid()
71		{
72	3	return $this->iterableResult->valid();
73		}
74
75		/**
76		* {@inheritdoc}
77		*/
78	3	public function rewind()
79		{
80	3	if (!$this->iterableResult) {
81	3	$this->iterableResult = new \SimpleXMLIterator(file_get_contents($this->filename));
82
83	3	if ($this->xpath) {
		0 ignored issues – show Bug Best Practice introduced 2015-12-08 09:18 UTC by Report Bug Copy Issue Report The expression `$this->xpath` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
84	1	$this->iterableResult = new \ArrayIterator($this->iterableResult->xpath($this->xpath));
85		}
86		}
87
88	3	$this->iterableResult->rewind();
89	3	}
90
91		/**
92		* {@inheritdoc}
93		*/
94	2	public function count()
95		{
96	2	if (!$this->iterableResult) {
97	2	$this->rewind();
98		}
99
100	2	return count($this->iterableResult);
101		}
102		}
103

mathielen / import-engine

XmlReader::__construct() A last analyzed 2021-02-08 13:43 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

XmlReader::__construct() A
last analyzed 2021-02-08 13:43 UTC