mambax7 / smartfaq

smartfaq/answer.php

Indentation +1 added lines, -1 removed lines

@@ -184,7 +184,7 @@
     }
 
     //redirect_header("javascript:history.go(-1)", 3, $redirect_msg);
-     redirect_header("index.php", 3, $redirect_msg);
+        redirect_header("index.php", 3, $redirect_msg);
     exit;
 
     break;

Braces +6 added lines, -2 removed lines

@@ -20,8 +20,12 @@
 $op = 'form';
 
 // Getting the operation we are doing
-if (isset($_GET['op'])) $op = $_GET['op'];
-if (isset($_POST['op'])) $op = $_POST['op'];
+if (isset($_GET['op'])) {
+    $op = $_GET['op'];
+}
+if (isset($_POST['op'])) {
+    $op = $_POST['op'];
+}
 
 // Getting the faqid
 $faqid = isset($_GET['faqid'])? intval($_GET['faqid']) : 0;

smartfaq/include/functions.php

Indentation +2 added lines, -3 removed lines

@@ -287,8 +287,7 @@ 
 * @param array $groups : group with granted permission
 * @param integer $itemID : faqid on which we are setting permissions
 * @return boolean : TRUE if the no errors occured
-
-*/
+ */
 function sf_saveItemPermissions($groups, $itemID)
 {
     $result = true;
@@ -536,7 +535,7 @@ 
 function sf_collapsableBar($tablename = '', $iconname = '')
 {
 
-   ?>
+    ?>
     <script type="text/javascript"><!--
     function goto_URL(object)
     {

smartfaq/include/answer.inc.php

Indentation +13 added lines, -13 removed lines

@@ -24,19 +24,19 @@
 //$form->addElement(new XoopsFormDhtmlTextArea(_MD_SF_ANSWER_FAQ, 'answer', '', 15, 60), true);
 
 $editorTray = new XoopsFormElementTray(_MD_SF_ANSWER_FAQ, '<br />');
-   if (class_exists('XoopsFormEditor')) {
-           $options['name'] = 'answer';
-           $options['value'] = '';
-           $options['rows'] = 5;
-           $options['cols'] = '100%';
-           $options['width'] = '100%';
-           $options['height'] = '200px';
-       $answerEditor  = new XoopsFormEditor('', $xoopsModuleConfig['form_editorOptionsUser'], $options, $nohtml = false, $onfailure = 'textarea');
-           $editorTray->addElement($answerEditor,true );
-       } else {
-       $answerEditor  = new XoopsFormDhtmlTextArea(_MD_SF_ANSWER_FAQ, 'answer', '', '100%', '100%');
-       $editorTray->addElement($answerEditor, true );
-   }
+    if (class_exists('XoopsFormEditor')) {
+            $options['name'] = 'answer';
+            $options['value'] = '';
+            $options['rows'] = 5;
+            $options['cols'] = '100%';
+            $options['width'] = '100%';
+            $options['height'] = '200px';
+        $answerEditor  = new XoopsFormEditor('', $xoopsModuleConfig['form_editorOptionsUser'], $options, $nohtml = false, $onfailure = 'textarea');
+            $editorTray->addElement($answerEditor,true );
+        } else {
+        $answerEditor  = new XoopsFormDhtmlTextArea(_MD_SF_ANSWER_FAQ, 'answer', '', '100%', '100%');
+        $editorTray->addElement($answerEditor, true );
+    }
 $form->addElement($editorTray);
 
 // NOTIFY ON PUBLISH

smartfaq/include/functions.render.php

Braces +3 added lines, -1 removed lines

@@ -123,7 +123,9 @@
     global $xoTheme, $xoopsConfig;
     static $icon_handler;
 
-    if (isset($icon_handler)) return $icon_handler;
+    if (isset($icon_handler)) {
+        return $icon_handler;
+    }
 
     if (!class_exists("NewbbIconHandler")) {
         require_once dirname(__DIR__)."/class/icon.php";

smartfaq/include/onupdate.inc.php

Indentation +5 added lines, -5 removed lines

@@ -24,7 +24,7 @@ 
     }
 
     // Changing categoryid type to int(11)
-       $table->addAlteredField('categoryid', "int(11) NOT NULL default '0'", false);
+        $table->addAlteredField('categoryid', "int(11) NOT NULL default '0'", false);
 
     if (!$dbupdater->updateTable($table)) {
         /**
@@ -36,10 +36,10 @@ 
     // Editing smartfaq_categories table
     $table = new SmartDbTable('smartfaq_categories');
     // Changing categoryid type to int(11)
-       $table->addAlteredField('categoryid', "int(11) NOT NULL default '0'", false);
+        $table->addAlteredField('categoryid', "int(11) NOT NULL default '0'", false);
 
     // Changing parentid type to int(11)
-       $table->addAlteredField('parentid', "int(11) NOT NULL default '0'", false);
+        $table->addAlteredField('parentid', "int(11) NOT NULL default '0'", false);
 
     if (!$dbupdater->updateTable($table)) {
         /**
@@ -51,10 +51,10 @@ 
     // Editing smartfaq_answers table
     $table = new SmartDbTable('smartfaq_answers');
     // Changing categoryid type to int(11)
-       $table->addAlteredField('answerid', "int(11) NOT NULL default '0'", false);
+        $table->addAlteredField('answerid', "int(11) NOT NULL default '0'", false);
 
     // Changing parentid type to int(11)
-       $table->addAlteredField('faqid', "int(11) NOT NULL default '0'", false);
+        $table->addAlteredField('faqid', "int(11) NOT NULL default '0'", false);
 
     if (!$dbupdater->updateTable($table)) {
         /**

smartfaq/include/blocksadmin.inc.php

Indentation +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
 if ( isset($HTTP_POST_VARS) ) {
     foreach ($HTTP_POST_VARS as $k => $v) {
         $$k = $v;
-      }
+        }
 }
 
 if ( isset($HTTP_GET_VARS['op']) ) {

Braces +4 added lines, -1 removed lines

@@ -191,7 +191,10 @@
         }
         $myblock = new XoopsBlock($bid);
         // $myblock->setVar('side', $bside); GIJ -
-        if ( $bside >= 0 ) $myblock->setVar('side', $bside); // GIJ +
+        if ( $bside >= 0 ) {
+            $myblock->setVar('side', $bside);
+        }
+        // GIJ +
         $myblock->setVar('weight', $bweight);
         $myblock->setVar('visible', $bvisible);
         $myblock->setVar('title', $btitle);

smartfaq/include/submit.inc.php

Indentation +14 added lines, -14 removed lines

@@ -37,20 +37,20 @@
 //$form->addElement($answer_text, true);
 
 $editorTray = new XoopsFormElementTray(_MD_SF_ANSWER_FAQ, '<br />');
-   if (class_exists('XoopsFormEditor')) {
-           $options['name'] = 'answer';
-           $options['value'] = $answerObj->answer();
-           $options['rows'] = 5;
-           $options['cols'] = '100%';
-           $options['width'] = '100%';
-           $options['height'] = '200px';
-       $answerEditor  = new XoopsFormEditor('', $xoopsModuleConfig['form_editorOptionsUser'], $options, $nohtml = false, $onfailure = 'textarea');
-           $editorTray->addElement($answerEditor);
-       } else {
-       $answerEditor  = new XoopsFormDhtmlTextArea('', 'answer', $faqObj->question(), '100%', '100%');
-       $answerEditor->setDescription(_MD_SF_ANSWER_FAQ_DSC);
-       $editorTray->addElement($answerEditor);
-   }
+    if (class_exists('XoopsFormEditor')) {
+            $options['name'] = 'answer';
+            $options['value'] = $answerObj->answer();
+            $options['rows'] = 5;
+            $options['cols'] = '100%';
+            $options['width'] = '100%';
+            $options['height'] = '200px';
+        $answerEditor  = new XoopsFormEditor('', $xoopsModuleConfig['form_editorOptionsUser'], $options, $nohtml = false, $onfailure = 'textarea');
+            $editorTray->addElement($answerEditor);
+        } else {
+        $answerEditor  = new XoopsFormDhtmlTextArea('', 'answer', $faqObj->question(), '100%', '100%');
+        $answerEditor->setDescription(_MD_SF_ANSWER_FAQ_DSC);
+        $editorTray->addElement($answerEditor);
+    }
 
 $form->addElement($editorTray);
 

smartfaq/include/functions.image.php

Braces +24 added lines, -9 removed lines

@@ -80,7 +80,9 @@ 
         $attachmentImage .= '</a>';
     } elseif (file_exists($image)) {
         $attachmentImage = '<img src="'.$image_url.'" alt="'.$source.' '.$img_info.'" />';
-    } else $attachmentImage = '';
+    } else {
+        $attachmentImage = '';
+    }
 
     return $attachmentImage;
 }
@@ -152,17 +154,27 @@ 
     $type = $imginfo[2];
     $supported_types = array();
 
-    if (!extension_loaded('gd')) return false;
-    if (function_exists('imagegif')) $supported_types[] = 1;
-    if (function_exists('imagejpeg'))$supported_types[] = 2;
-    if (function_exists('imagepng')) $supported_types[] = 3;
+    if (!extension_loaded('gd')) {
+        return false;
+    }
+    if (function_exists('imagegif')) {
+        $supported_types[] = 1;
+    }
+    if (function_exists('imagejpeg')) {
+        $supported_types[] = 2;
+    }
+    if (function_exists('imagepng')) {
+        $supported_types[] = 3;
+    }
 
     $imageCreateFunction = (function_exists('imagecreatetruecolor'))? "imagecreatetruecolor" : "imagecreate";
 
     if (in_array($type, $supported_types) ) {
         switch ($type) {
             case 1 :
-                if (!function_exists('imagecreatefromgif')) return false;
+                if (!function_exists('imagecreatefromgif')) {
+                    return false;
+                }
                 $im = imagecreatefromgif ($src_file);
                 $new_im = imagecreate($newWidth, $newHeight);
                 imagecopyresized($new_im, $im, 0, 0, 0, 0, $newWidth, $newHeight, $imginfo[0], $imginfo[1]);
@@ -189,8 +201,11 @@ 
         }
     }
 
-    if (file_exists($new_file))    return true;
-    else return false;
-}
+    if (file_exists($new_file)) {
+        return true;
+    } else {
+        return false;
+    }
+    }
 
 endif;

smartfaq/class/answer.php

Indentation +73 added lines, -73 removed lines

@@ -23,8 +23,8 @@ 
 {
     var $attachment_array = array();
     /**
-    * constructor
-    */
+     * constructor
+     */
     function __construct ($id = null)
     {
         $this->db =& XoopsDatabaseFactory::getDatabaseConnection();
@@ -184,7 +184,7 @@ 
                 }
                 $post_attachment .= '<br />';
             }
-       }
+        }
 
         return $post_attachment;
     }
@@ -240,7 +240,7 @@ 
 
     function notLoaded()
     {
-       return ($this->getVar('answerid')== -1);
+        return ($this->getVar('answerid')== -1);
     }
 
     function sendNotifications($notifications=array())
@@ -294,11 +294,11 @@ 
 {
 
     /**
-    * create a new answer
-    *
-    * @param bool $isNew flag the new objects as "new"?
-    * @return object sfAnswer
-    */
+     * create a new answer
+     *
+     * @param bool $isNew flag the new objects as "new"?
+     * @return object sfAnswer
+     */
     function &create($isNew = true)
     {
         $answer = new sfAnswer();
@@ -310,11 +310,11 @@ 
     }
 
     /**
-    * retrieve an answer
-    *
-    * @param int $id answerid of the answer
-    * @return mixed reference to the {@link sfAnswer} object, FALSE if failed
-    */
+     * retrieve an answer
+     *
+     * @param int $id answerid of the answer
+     * @return mixed reference to the {@link sfAnswer} object, FALSE if failed
+     */
     function &get($id)
     {
         if (intval($id) > 0) {
@@ -336,12 +336,12 @@ 
     }
 
     /**
-    * insert a new answer in the database
-    *
-    * @param object $answer reference to the {@link sfAnswer} object
-    * @param bool $force
-    * @return bool FALSE if failed, TRUE if already present and unchanged or successful
-    */
+     * insert a new answer in the database
+     *
+     * @param object $answer reference to the {@link sfAnswer} object
+     * @param bool $force
+     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
+     */
     function insert(&$answerObj, $force = false)
     {
         if (strtolower(get_class($answerObj)) != 'sfanswer') {
@@ -384,12 +384,12 @@ 
     }
 
     /**
-    * delete an answer from the database
-    *
-    * @param object $answer reference to the answer to delete
-    * @param bool $force
-    * @return bool FALSE if failed.
-    */
+     * delete an answer from the database
+     *
+     * @param object $answer reference to the answer to delete
+     * @param bool $force
+     * @return bool FALSE if failed.
+     */
     function delete(&$answer, $force = false)
     {
         if (strtolower(get_class($answer)) != 'sfanswer') {
@@ -412,12 +412,12 @@ 
     }
 
     /**
-    * delete an answer from the database
-    *
-    * @param object $answer reference to the answer to delete
-    * @param bool $force
-    * @return bool FALSE if failed.
-    */
+     * delete an answer from the database
+     *
+     * @param object $answer reference to the answer to delete
+     * @param bool $force
+     * @return bool FALSE if failed.
+     */
     function deleteFaqAnswers(&$faqObj)
     {
         if (strtolower(get_class($faqObj)) != 'sffaq') {
@@ -435,12 +435,12 @@ 
     }
 
     /**
-    * retrieve answers from the database
-    *
-    * @param object $criteria {@link CriteriaElement} conditions to be met
-    * @param bool $id_as_key use the answerid as key for the array?
-    * @return array array of {@link sfAnswer} objects
-    */
+     * retrieve answers from the database
+     *
+     * @param object $criteria {@link CriteriaElement} conditions to be met
+     * @param bool $id_as_key use the answerid as key for the array?
+     * @return array array of {@link sfAnswer} objects
+     */
     function &getObjects($criteria = null, $id_as_key = false)
     {
         $ret = array();
@@ -474,12 +474,12 @@ 
     }
 
     /**
-    * retrieve 1 official answer (for now SmartFAQ only allow 1 official answer...)
-    *
-    * @param object $criteria {@link CriteriaElement} conditions to be met
-    * @param int $faqid
-    * @return mixed reference to the {@link sfAnswer} object, FALSE if failed
-    */
+     * retrieve 1 official answer (for now SmartFAQ only allow 1 official answer...)
+     *
+     * @param object $criteria {@link CriteriaElement} conditions to be met
+     * @param int $faqid
+     * @return mixed reference to the {@link sfAnswer} object, FALSE if failed
+     */
     function &getOfficialAnswer($faqid=0)
     {
         $theaAnswers =& $this->getAllAnswers($faqid, _SF_AN_STATUS_APPROVED, 1, 0);
@@ -493,12 +493,12 @@ 
     }
 
     /**
-    * retrieve all answers
-    *
-    * @param object $criteria {@link CriteriaElement} conditions to be met
-    * @param int $faqid
-    * @return array array of {@link sfAnswer} objects
-    */
+     * retrieve all answers
+     *
+     * @param object $criteria {@link CriteriaElement} conditions to be met
+     * @param int $faqid
+     * @return array array of {@link sfAnswer} objects
+     */
     function &getAllAnswers($faqid=0, $status = -1, $limit = 0, $start = 0, $sort = 'datesub', $order = 'DESC')
     {
         $hasStatusCriteria = false;
@@ -531,11 +531,11 @@ 
     }
 
     /**
-    * count answers matching a condition
-    *
-    * @param object $criteria {@link CriteriaElement} to match
-    * @return int count of answers
-    */
+     * count answers matching a condition
+     *
+     * @param object $criteria {@link CriteriaElement} to match
+     * @return int count of answers
+     */
     function getCount($criteria = null)
     {
         $sql = 'SELECT COUNT(*) FROM '.$this->db->prefix('smartfaq_answers');
@@ -552,11 +552,11 @@ 
     }
 
     /**
-    * count answers matching a condition and group by faq ID
-    *
-    * @param object $criteria {@link CriteriaElement} to match
-    * @return array
-    */
+     * count answers matching a condition and group by faq ID
+     *
+     * @param object $criteria {@link CriteriaElement} to match
+     * @return array
+     */
     function getCountByFAQ($criteria = null)
     {
         $sql = 'SELECT faqid, COUNT(*) FROM '.$this->db->prefix('smartfaq_answers');
@@ -580,11 +580,11 @@ 
     }
 
     /**
-    * delete answers matching a set of conditions
-    *
-    * @param object $criteria {@link CriteriaElement}
-    * @return bool FALSE if deletion failed
-    */
+     * delete answers matching a set of conditions
+     *
+     * @param object $criteria {@link CriteriaElement}
+     * @return bool FALSE if deletion failed
+     */
     function deleteAll($criteria = null)
     {
         $sql = 'DELETE FROM '.$this->db->prefix('smartfaq_answers');
@@ -599,14 +599,14 @@ 
     }
 
     /**
-    * Change a value for answers with a certain criteria
-    *
-    * @param   string  $fieldname  Name of the field
-    * @param   string  $fieldvalue Value to write
-    * @param   object  $criteria   {@link CriteriaElement}
-    *
-    * @return  bool
-    **/
+     * Change a value for answers with a certain criteria
+     *
+     * @param   string  $fieldname  Name of the field
+     * @param   string  $fieldvalue Value to write
+     * @param   object  $criteria   {@link CriteriaElement}
+     *
+     * @return  bool
+     **/
     function updateAll($fieldname, $fieldvalue, $criteria = null)
     {
         $set_clause = is_numeric($fieldvalue)? $fieldname.' = '.$fieldvalue : $fieldname.' = '.$this->db->quoteString($fieldvalue);

Braces +31 added lines, -13 removed lines

@@ -62,17 +62,24 @@ 
     // attachment functions    TODO: there should be a file/attachment management class
     function getAttachment()
     {
-        if (count($this->attachment_array)) return $this->attachment_array;
+        if (count($this->attachment_array)) {
+            return $this->attachment_array;
+        }
         $attachment = $this->getVar('attachment');
-        if (empty($attachment)) $this->attachment_array = null;
-        else $this->attachment_array = @unserialize(base64_decode($attachment));
+        if (empty($attachment)) {
+            $this->attachment_array = null;
+        } else {
+            $this->attachment_array = @unserialize(base64_decode($attachment));
+        }
 
         return $this->attachment_array;
     }
 
     function incrementDownload($attach_key)
     {
-        if (!$attach_key) return false;
+        if (!$attach_key) {
+            return false;
+        }
         $this->attachment_array[strval($attach_key)]['num_download'] ++;
 
         return $this->attachment_array[strval($attach_key)]['num_download'];
@@ -80,9 +87,11 @@ 
 
     function saveAttachment()
     {
-        if (is_array($this->attachment_array) && count($this->attachment_array) > 0)
-            $attachment_save = base64_encode(serialize($this->attachment_array));
-        else $attachment_save = '';
+        if (is_array($this->attachment_array) && count($this->attachment_array) > 0) {
+                    $attachment_save = base64_encode(serialize($this->attachment_array));
+        } else {
+            $attachment_save = '';
+        }
         $this->setVar('attachment', $attachment_save);
         $sql = "UPDATE " . $GLOBALS["xoopsDB"]->prefix("smartfaq_answers") . " SET attachment=" . $GLOBALS["xoopsDB"]->quoteString($attachment_save) . " WHERE post_id = " . $this->getVar('answerid');
         if (!$result = $GLOBALS["xoopsDB"]->queryF($sql)) {
@@ -98,11 +107,18 @@ 
         global $xoopsModuleConfig;
 
         $attach_old = $this->getAttachment();
-        if (!is_array($attach_old) || count($attach_old) < 1) return true;
+        if (!is_array($attach_old) || count($attach_old) < 1) {
+            return true;
+        }
         $this->attachment_array = array();
 
-        if ($attach_array === null) $attach_array = array_keys($attach_old); // to delete all!
-        if (!is_array($attach_array)) $attach_array = array($attach_array);
+        if ($attach_array === null) {
+            $attach_array = array_keys($attach_old);
+        }
+        // to delete all!
+        if (!is_array($attach_array)) {
+            $attach_array = array($attach_array);
+        }
 
         foreach ($attach_old as $key => $attach) {
             if (in_array($key, $attach_array)) {
@@ -112,9 +128,11 @@ 
             }
             $this->attachment_array[$key] = $attach;
         }
-        if (is_array($this->attachment_array) && count($this->attachment_array) > 0)
-            $attachment_save = base64_encode(serialize($this->attachment_array));
-        else $attachment_save = '';
+        if (is_array($this->attachment_array) && count($this->attachment_array) > 0) {
+                    $attachment_save = base64_encode(serialize($this->attachment_array));
+        } else {
+            $attachment_save = '';
+        }
         $this->setVar('attachment', $attachment_save);
 
         return true;