locomotivemtl / charcoal-attachment

src/Charcoal/Admin/Widget/AttachmentWidget.php

Doc Comments +1 added lines, -1 removed lines

@@ -215,7 +215,7 @@
     /**
      * Determine the number of attachments.
      *
-     * @return boolean
+     * @return integer
      */
     public function hasAttachments()
     {

Spacing +3 added lines, -3 removed lines

@@ -210,7 +210,7 @@ 
         ]);
 
         foreach ($attachments as $attachment) {
-            $this->setDynamicTemplate('widget_template', (string)$attachment->rawPreview());
+            $this->setDynamicTemplate('widget_template', (string) $attachment->rawPreview());
 
             if (isset($attachableObjects[$attachment->objType()])) {
                 $attachment->attachmentType = $attachableObjects[$attachment->objType()];
@@ -474,7 +474,7 @@ 
             );
         }
 
-        $num = (int)$num;
+        $num = (int) $num;
 
         if ($num < 0) {
             throw new InvalidArgumentException(
@@ -502,7 +502,7 @@ 
             );
         }
 
-        $page = (int)$page;
+        $page = (int) $page;
 
         if ($page < 0) {
             throw new InvalidArgumentException(

src/Charcoal/Attachment/Object/File.php

Doc Comments +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
     /**
      * Alias of {@see Attachment::file()}.
      *
-     * @return string|null
+     * @return \Psr\Http\Message\UriInterface|null
      */
     public function src()
     {

src/Charcoal/Attachment/Object/Image.php

Doc Comments +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
     /**
      * Alias of {@see Attachment::thumbnail()} and {@see Attachment::file()}.
      *
-     * @return string|null
+     * @return \Psr\Http\Message\UriInterface|null
      */
     public function src()
     {

src/Charcoal/Attachment/Object/Join.php

Doc Comments +1 added lines, -1 removed lines

@@ -471,7 +471,7 @@
     /**
      * Retrieve the relationship's group ID.
      *
-     * @return mixed
+     * @return string
      */
     public function group()
     {

Spacing +1 added lines, -1 removed lines

@@ -402,7 +402,7 @@
             );
         }
 
-        $this->position = (int)$position;
+        $this->position = (int) $position;
 
         return $this;
     }

src/Charcoal/Attachment/Traits/AttachmentRelationTrait.php

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
         $pivot = $this->modelFactory()->create(Join::class);
 
         if (is_string($data) && strpos($data, '_') > 1) {
-            $data = array_combine([ 'obj_type', 'obj_id' ], explode('_', $data, 1));
+            $data = array_combine(['obj_type', 'obj_id'], explode('_', $data, 1));
         }
 
         if (is_scalar($data)) {

src/Charcoal/Attachment/Script/CleanupScript.php

Spacing +6 added lines, -6 removed lines

@@ -256,7 +256,7 @@ 
                     ]);
                     $rows = $source->dbQuery(
                         strtr($sql, $binds),
-                        [ 'objType' => $row['object_type'] ]
+                        ['objType' => $row['object_type']]
                     );
 
                     /** @todo Show found rows, confirm deletion of dead relationships */
@@ -276,7 +276,7 @@ 
                     $sql  = 'SELECT p.* FROM `%pivotTable` AS p WHERE p.`%sourceType` = :objType;';
                     $rows = $source->dbQuery(
                         strtr($sql, $defaultBinds),
-                        [ 'objType' => $model ]
+                        ['objType' => $model]
                     );
 
                     /** @todo Explain missing model, confirm deletion of dead relationships */
@@ -394,7 +394,7 @@ 
                 ];
 
                 if ($ask && $verb) {
-                    $dead = array_merge([ 'Deleted' => null, 'Failed' => null ], $dead);
+                    $dead = array_merge(['Deleted' => null, 'Failed' => null], $dead);
                 }
             }
 
@@ -617,7 +617,7 @@ 
         $cli = $this->climate();
 
         if (is_string($this->action)) {
-            $opts = [ 'y', 'n', 'r', 'q', '?' ];
+            $opts = ['y', 'n', 'r', 'q', '?'];
             $help = [
                 '[y]es    — delete the attachment',
                 '[n]o     — don’t delete the attachment',
@@ -625,7 +625,7 @@ 
                 '[q]uit   — exit immediately (does not undo previous actions)',
             ];
         } else {
-            $opts = [ 'y', 'a', 'n', 's', 'q', '?' ];
+            $opts = ['y', 'a', 'n', 's', 'q', '?'];
             $help = [
                 '[y]es  — delete this attachment',
                 '[a]ll  — delete all attachments',
@@ -686,7 +686,7 @@ 
     {
         $cli = $this->climate();
 
-        $opts = [ 'y', 'n', 'v', '?' ];
+        $opts = ['y', 'n', 'v', '?'];
         $help = [
             '[y]es  — continue to deletion phase',
             '[n]o   — cancel deletion phase',

src/Charcoal/Admin/Action/JoinAction.php

Spacing +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
 
         $count = count($attachments);
         $i = 0;
-        for (; $i<$count; $i++) {
+        for (; $i < $count; $i++) {
             $attachmentId = $attachments[$i]['attachment_id'];
             $position = $attachments[$i]['position'];
 

src/Charcoal/Attachment/Object/Container.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
     public function attachments(...$args)
     {
         $attachables = $this->attachableObjects();
-        $attachments = call_user_func_array([ $this, 'getAttachments' ], $args);
+        $attachments = call_user_func_array([$this, 'getAttachments'], $args);
 
         foreach ($attachments as $attachment) {
             if (isset($attachables[$attachment->objType()])) {

src/Charcoal/Attachment/Object/Attachment.php

Doc Comments +8 added lines, -8 removed lines

@@ -324,7 +324,7 @@ 
      *
      * @param  string $type The attachment type.
      * @throws InvalidArgumentException If provided argument is not of type 'string'.
-     * @return string
+     * @return Attachment
      */
     public function setType($type)
     {
@@ -765,7 +765,7 @@ 
     /**
      * Retrieve the attachment's sub-title.
      *
-     * @return Translation|string|null
+     * @return null|Translation
      */
     public function subtitle()
     {
@@ -775,7 +775,7 @@ 
     /**
      * Retrieve attachment's description.
      *
-     * @return Translation|string|null
+     * @return null|Translation
      */
     public function description()
     {
@@ -795,7 +795,7 @@ 
     /**
      * Retrieve the path to the thumbnail associated with the object.
      *
-     * @return string|null
+     * @return string
      */
     public function thumbnail()
     {
@@ -838,7 +838,7 @@ 
     /**
      * Retrieve the file label.
      *
-     * @return string|null
+     * @return null|Translation
      */
     public function fileLabel()
     {
@@ -848,7 +848,7 @@ 
     /**
      * Retrieve the link label.
      *
-     * @return string|null
+     * @return null|Translation
      */
     public function linkLabel()
     {
@@ -893,7 +893,7 @@ 
     }
 
     /**
-     * @return ModelInterface|mixed
+     * @return ModelInterface
      */
     public function presenter()
     {
@@ -1001,7 +1001,7 @@ 
      * Prepend the base URI to the given path.
      *
      * @param  string $text A string to parse relative URIs.
-     * @return UriInterface|null
+     * @return string
      */
     protected function resolveUrls($text)
     {

Spacing +9 added lines, -9 removed lines

@@ -196,7 +196,7 @@ 
     {
         parent::__construct($data);
 
-        if (is_callable([ $this, 'defaultData' ])) {
+        if (is_callable([$this, 'defaultData'])) {
             $defaultData = $this->metadata()->defaultData();
             if ($defaultData) {
                 $this->setData($defaultData);
@@ -372,7 +372,7 @@ 
      */
     public function heading()
     {
-        $heading = $this->render((string)$this->heading);
+        $heading = $this->render((string) $this->heading);
 
         if (!$heading) {
             $heading = $this->translator()->translation('{{ objType }} #{{ id }}', [
@@ -415,7 +415,7 @@ 
     public function preview()
     {
         if ($this->preview) {
-            return $this->render((string)$this->preview);
+            return $this->render((string) $this->preview);
         }
 
         return '';
@@ -1008,19 +1008,19 @@ 
         static $search;
 
         if ($search === null) {
-            $attr   = [ 'href', 'link', 'url', 'src' ];
-            $scheme = [ '../', './', '/', 'data', 'mailto', 'http' ];
+            $attr   = ['href', 'link', 'url', 'src'];
+            $scheme = ['../', './', '/', 'data', 'mailto', 'http'];
 
             $search = sprintf(
                 '(?<=%1$s=")(?!%2$s)(\S+)(?=")',
-                implode('="|', array_map('preg_quote', $attr, [ '~' ])),
-                implode('|', array_map('preg_quote', $scheme, [ '~' ]))
+                implode('="|', array_map('preg_quote', $attr, ['~'])),
+                implode('|', array_map('preg_quote', $scheme, ['~']))
             );
         }
 
         $text = preg_replace_callback(
             '~'.$search.'~i',
-            function ($matches) {
+            function($matches) {
                 return $this->createAbsoluteUrl($matches[1]);
             },
             $text
@@ -1039,7 +1039,7 @@ 
     protected function isRelativeUri($uri)
     {
         if ($uri && !parse_url($uri, PHP_URL_SCHEME)) {
-            if (!in_array($uri[0], [ '/', '#', '?' ])) {
+            if (!in_array($uri[0], ['/', '#', '?'])) {
                 return true;
             }
         }