librenms / librenmsv2

app/Http/Controllers/General/SearchController.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -25,10 +25,10 @@
 
 namespace App\Http\Controllers\General;
 
+use App\DataTables\General\ArpDataTable;
 use App\DataTables\General\IPv4DataTable;
 use App\DataTables\General\IPv6DataTable;
 use App\DataTables\General\MacDataTable;
-use App\DataTables\General\ArpDataTable;
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
 

app/Http/Controllers/UserController.php

Doc Comments +2 added lines, -2 removed lines

@@ -44,7 +44,7 @@ 
     /**
      * Update a notifications status.
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function update($id, $action)
     {
@@ -55,7 +55,7 @@ 
     /**
      * Create a new notification
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function create(Request $request)
     {

app/DataTables/DeviceDataTable.php

Unused Use Statements -1 removed lines

@@ -25,7 +25,6 @@
 
 namespace App\DataTables;
 
-use App\Models\DeviceGroup;
 use App\Models\Device;
 
 class DeviceDataTable extends BaseDataTable

app/Http/Controllers/DeviceGroupController.php

Doc Comments +4 added lines, -4 removed lines

@@ -58,7 +58,7 @@ 
      * Store a newly created resource in storage.
      *
      * @param  \Illuminate\Http\Request $request
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function store(DeviceGroupRequest $request)
     {
@@ -71,7 +71,7 @@ 
      * Display the specified resource.
      *
      * @param  int $id
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function show($id)
     {
@@ -95,7 +95,7 @@ 
      *
      * @param  \Illuminate\Http\Request $request
      * @param  int $id
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function update(DeviceGroupRequest $request, $id)
     {
@@ -110,7 +110,7 @@ 
      *
      * @param \Illuminate\Http\Request $request
      * @param  int $id
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      * @throws \Exception
      */
     public function destroy(AdminOnlyRequest $request, $id)

app/Models/DeviceGroup.php

Doc Comments +1 added lines, -1 removed lines

@@ -203,7 +203,7 @@
      * Convert a v1 device group pattern to v2 style
      *
      * @param $pattern
-     * @return array
+     * @return string
      */
     private function convertV1Pattern($pattern)
     {

app/QueryBuilderFilter.php

Doc Comments +3 added lines

@@ -38,6 +38,9 @@
         return json_encode(self::generateMacroFilter('alert.macros.rule', self::generateTableFilter()));
     }
 
+    /**
+     * @param string $setting
+     */
     private static function generateMacroFilter($setting, $filter = [])
     {
         foreach (Settings::get($setting, []) as $key => $value) {

app/Graphs/BaseGraph.php

Doc Comments +8 added lines, -5 removed lines

@@ -80,7 +80,7 @@ 
     /**
      * Get json output.
      *
-     * @return array
+     * @return string
      */
     public function json(Request $request)
     {
@@ -96,7 +96,7 @@ 
     /**
      * Get csv output.
      *
-     * @return array
+     * @return string|null
      */
     public function csv(Request $request)
     {
@@ -111,7 +111,7 @@ 
     /**
      * Get png output.
      *
-     * @return array
+     * @return string|null
      */
     public function png(Request $request)
     {
@@ -159,8 +159,8 @@ 
     }
 
     /**
-     * @param $cmd
-     * @return mixed|string
+     * @param string $cmd
+     * @return string
      */
     public function runRRDGraph($cmd)
     {
@@ -176,6 +176,7 @@ 
     /**
      * Run the RRD Xport query
      *
+     * @param string $query
      * @return string
      */
     public function runRRDXport($query)
@@ -196,6 +197,7 @@ 
     /**
      * Run the RRD Xport query
      *
+     * @param string $response
      * @return string
      */
     public function parseRRDJson($response)
@@ -224,6 +226,7 @@ 
     /**
      * Parse RRD output to csv
      *
+     * @param string $response
      * @return string
      */
     public function parseRRDCsv($response, $headers)

Unused Use Statements +2 added lines, -4 removed lines

@@ -23,13 +23,11 @@
 
 namespace App\Graphs;
 
+use App\Models\Device;
 use Carbon\Carbon;
 use Illuminate\Http\Request;
-use Symfony\Component\Process\Process;
-use Symfony\Component\Process\ProcessBuilder;
 use Symfony\Component\Process\Exception\ProcessFailedException;
-use App\Models\Device;
-use Settings;
+use Symfony\Component\Process\Process;
 
 class BaseGraph
 {

app/Graphs/Device_bits.php

Unused Use Statements -5 removed lines

@@ -23,11 +23,6 @@
 
 namespace App\Graphs;
 
-use Illuminate\Http\Request;
-use App\Models\Device;
-use Settings;
-use App\Models\Port;
-
 class Device_bits extends BaseGraph
 {
 

app/Graphs/Device_processor.php

Unused Use Statements -2 removed lines

@@ -23,9 +23,7 @@
 
 namespace App\Graphs;
 
-use Illuminate\Http\Request;
 use App\Models\Device;
-use App\Models\Processor;
 use Settings;
 
 class Device_processor extends BaseGraph