TwitterStatusUpdate::getApiEndpoint() - Code Metrics - Inspection of "Merge pull request #15 from laravel-notification-c..." - laravel-notification-channels/twitter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0fa15b...4b090c )

unknown

created 2016-09-17 14:23 UTC

TwitterStatusUpdate::getApiEndpoint() A

↳ Parent: TwitterStatusUpdate

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace NotificationChannels\Twitter;

class TwitterStatusUpdate
{
    /** @var string */
    protected $content;

    /**
     * @var  array
     */
    private $imagePaths;

    /**
     * @var  array
     */
    public $imageIds;

    /**
     * @var  string
     */
    private $apiEndpoint = 'statuses/update';

    /*
     * @param  string $content
     */
    public function __construct(string $content, array $imagePaths = null)
    {
        $this->content = $content;
        $this->imagePaths = $imagePaths ? collect($imagePaths) : null;

    }

    /**
     * Get Twitter status update content.
     *
     * @return  string
     */
    public function getContent()
    {
        return $this->content;
    }

    /**
     * Get Twitter status update image paths.
     *
     * @return  string
     */
    public function getImagePaths()
    {
        return $this->imagePaths;
    }

    /**
     * Return Twitter status update api endpoint.
     * @return  string
     */
    public function getApiEndpoint()
    {
        return $this->apiEndpoint;
    }

    /**
     * Build Twitter request body.
     * @return  array
     */
    public function getRequestBody()
    {
        $body = [
            'status' => $this->getContent(),
        ];

        if ($this->imageIds) {

            $body['media_ids'] = $this->imageIds->implode(',');

        }

        return $body;
    }
}


1			<?php
2
3			namespace NotificationChannels\Twitter;
4
5			class TwitterStatusUpdate
6			{
7			/** @var string */
8			protected $content;
9
10			/**
11			* @var array
12			*/
13			private $imagePaths;
14
15			/**
16			* @var array
17			*/
18			public $imageIds;
19
20			/**
21			* @var string
22			*/
23			private $apiEndpoint = 'statuses/update';
24
25			/*
26			* @param string $content
27			*/
28			public function __construct(string $content, array $imagePaths = null)
29			{
30			$this->content = $content;
31			$this->imagePaths = $imagePaths ? collect($imagePaths) : null;
			0 ignored issues – show Documentation Bug introduced 2016-09-17 14:19 UTC by Report Bug Copy Issue Report It seems like `$imagePaths ? collect($imagePaths) : null` of type `object<Illuminate\Support\Collection>` or `null` is incompatible with the declared type `array` of property `$imagePaths`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
32			}
33
34			/**
35			* Get Twitter status update content.
36			*
37			* @return string
38			*/
39			public function getContent()
40			{
41			return $this->content;
42			}
43
44			/**
45			* Get Twitter status update image paths.
46			*
47			* @return string
48			*/
49			public function getImagePaths()
50			{
51			return $this->imagePaths;
52			}
53
54			/**
55			* Return Twitter status update api endpoint.
56			* @return string
57			*/
58			public function getApiEndpoint()
59			{
60			return $this->apiEndpoint;
61			}
62
63			/**
64			* Build Twitter request body.
65			* @return array
66			*/
67			public function getRequestBody()
68			{
69			$body = [
70			'status' => $this->getContent(),
71			];
72
73			if ($this->imageIds) {
			0 ignored issues – show Bug Best Practice introduced 2016-09-17 14:19 UTC by Report Bug Copy Issue Report The expression `$this->imageIds` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
74			$body['media_ids'] = $this->imageIds->implode(',');
			0 ignored issues – show Bug introduced 2016-09-17 14:19 UTC by Report Bug Copy Issue Report The method `implode` cannot be called on `$this->imageIds` (of type `array`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
75			}
76
77			return $body;
78			}
79			}
80

laravel-notification-channels / twitter

GitHub Access Token became invalid

Push — master ( 0fa15b...4b090c )

TwitterStatusUpdate::getApiEndpoint() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like