App\Traits\TenantConnectionResolver::getConnectionName()

Complexity

Conditions	5
Paths	4

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	8
Bugs	4	Features	0

<?php
    public function getConnectionName()
    {
        if (! App::runningUnitTests() && Auth::check()) {
            $user = \Auth::user();
            $role_id = $user->role_id;

The assignment to $role_id is dead and can be removed.

Accessing role_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            if ($user->isAdmin()) {

The method isAdmin() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

                return env('DB_DATABASE', 'genealogy'); //'enso');
            }
            if (session()->get('db')) {
                return 'tenantdb';
            }
        }

        return $this->connection;
    }