Inspection of "Improve search date handling" - kitodo/kitodo-publication - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#64)

unknown

created 2018-01-12 12:44 UTC

Status

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -69,14 +69,14 @@
 block discarded – undo
         $body = array('field' => 'value');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'PUT',
-                                 '/_template/testName',
-                                 array(),
-                                 $body
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'PUT',
+                                    '/_template/testName',
+                                    array(),
+                                    $body
+                                )
+                            ->getMock();
 
         $action = new Put($mockTransport);
         $action->setIndex('testIndex')->setName('testName')->setBody($body)

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -60,20 +60,20 @@
 block discarded – undo
         $mockTransport = m::mock('\Elasticsearch\Transport');
 
         $index = new Put($mockTransport);
-        $index->setBody(array())->performRequest();
+        $index->setBody(array ())->performRequest();
 
     }
 
     public function testValidPut()
     {
-        $body = array('field' => 'value');
+        $body = array ('field' => 'value');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()
                          ->with(
                                  'PUT',
                                  '/_template/testName',
-                                 array(),
+                                 array (),
                                  $body
                              )
                          ->getMock();

Please login to merge, or discard this patch.

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

@@ -19,8 +19,7 @@  discard block
 block discarded – undo
  * @license http://www.apache.org/licenses/LICENSE-2.0 Apache2
  * @link    http://elasticsearch.org
  */
-class PutTest extends \PHPUnit_Framework_TestCase
-{
+class PutTest extends \PHPUnit_Framework_TestCase {
     public function tearDown() {
         m::close();
     }
@@ -28,8 +27,7 @@  discard block
 block discarded – undo
     /**
      * @expectedException RuntimeException
      */
-    public function testNoNameNoBody()
-    {
+    public function testNoNameNoBody() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport');
 
@@ -41,8 +39,7 @@  discard block
 block discarded – undo
     /**
      * @expectedException RuntimeException
      */
-    public function testNoBody()
-    {
+    public function testNoBody() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport');
 
@@ -54,8 +51,7 @@  discard block
 block discarded – undo
     /**
      * @expectedException RuntimeException
      */
-    public function testNoName()
-    {
+    public function testNoName() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport');
 
@@ -64,8 +60,7 @@  discard block
 block discarded – undo
 
     }
 
-    public function testValidPut()
-    {
+    public function testValidPut() {
         $body = array('field' => 'value');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')

Please login to merge, or discard this patch.

tests/Elasticsearch/Tests/Endpoints/Indices/Gateway/SnapshotTest.php 4 patches

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -27,14 +27,14 @@  discard block
 block discarded – undo
     public function testValidSnapshotWithNoIndex()
     {
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'POST',
-                                 '/_gateway/snapshot',
-                                 array(),
-                                 null
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'POST',
+                                    '/_gateway/snapshot',
+                                    array(),
+                                    null
+                                )
+                            ->getMock();
 
         $action = new Snapshot($mockTransport);
         $action->performRequest();
@@ -45,14 +45,14 @@  discard block
 block discarded – undo
     {
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'POST',
-                                 '/testIndex/_gateway/snapshot',
-                                 array(),
-                                 null
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'POST',
+                                    '/testIndex/_gateway/snapshot',
+                                    array(),
+                                    null
+                                )
+                            ->getMock();
 
         $action = new Snapshot($mockTransport);
         $action->setIndex('testIndex')

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
                          ->with(
                                  'POST',
                                  '/_gateway/snapshot',
-                                 array(),
+                                 array (),
                                  null
                              )
                          ->getMock();
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
                          ->with(
                                  'POST',
                                  '/testIndex/_gateway/snapshot',
-                                 array(),
+                                 array (),
                                  null
                              )
                          ->getMock();

Please login to merge, or discard this patch.

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -18,14 +18,12 @@  discard block
 block discarded – undo
  * @link    http://elasticsearch.org
  */
 
-class SnapshotTest extends \PHPUnit_Framework_TestCase
-{
+class SnapshotTest extends \PHPUnit_Framework_TestCase {
     public function tearDown() {
         m::close();
     }
 
-    public function testValidSnapshotWithNoIndex()
-    {
+    public function testValidSnapshotWithNoIndex() {
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()
                          ->with(
@@ -41,8 +39,7 @@  discard block
 block discarded – undo
 
     }
 
-    public function testValidSnapshotWithIndex()
-    {
+    public function testValidSnapshotWithIndex() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()

Please login to merge, or discard this patch.

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -32,7 +32,7 @@  discard block
 block discarded – undo
                                  'POST',
                                  '/_gateway/snapshot',
                                  array(),
-                                 null
+                                 NULL
                              )
                          ->getMock();
 
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
                                  'POST',
                                  '/testIndex/_gateway/snapshot',
                                  array(),
-                                 null
+                                 NULL
                              )
                          ->getMock();
 

Please login to merge, or discard this patch.

tests/Elasticsearch/Tests/Endpoints/Indices/RefreshTest.php 4 patches

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -26,14 +26,14 @@  discard block
 block discarded – undo
     public function testValidRefreshWithNoIndex()
     {
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'GET',
-                                 '/_refresh',
-                                 array(),
-                                 null
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'GET',
+                                    '/_refresh',
+                                    array(),
+                                    null
+                                )
+                            ->getMock();
 
         $action = new Refresh($mockTransport);
         $action->performRequest();
@@ -44,14 +44,14 @@  discard block
 block discarded – undo
     {
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'GET',
-                                 '/testIndex/_refresh',
-                                 array(),
-                                 null
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'GET',
+                                    '/testIndex/_refresh',
+                                    array(),
+                                    null
+                                )
+                            ->getMock();
 
         $action = new Refresh($mockTransport);
         $action->setIndex('testIndex')

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
                          ->with(
                                  'GET',
                                  '/_refresh',
-                                 array(),
+                                 array (),
                                  null
                              )
                          ->getMock();
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
                          ->with(
                                  'GET',
                                  '/testIndex/_refresh',
-                                 array(),
+                                 array (),
                                  null
                              )
                          ->getMock();

Please login to merge, or discard this patch.

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -17,14 +17,12 @@  discard block
 block discarded – undo
  * @license http://www.apache.org/licenses/LICENSE-2.0 Apache2
  * @link    http://elasticsearch.org
  */
-class RefreshTest extends \PHPUnit_Framework_TestCase
-{
+class RefreshTest extends \PHPUnit_Framework_TestCase {
     public function tearDown() {
         m::close();
     }
 
-    public function testValidRefreshWithNoIndex()
-    {
+    public function testValidRefreshWithNoIndex() {
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()
                          ->with(
@@ -40,8 +38,7 @@  discard block
 block discarded – undo
 
     }
 
-    public function testValidRefreshWithIndex()
-    {
+    public function testValidRefreshWithIndex() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()

Please login to merge, or discard this patch.

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
                                  'GET',
                                  '/_refresh',
                                  array(),
-                                 null
+                                 NULL
                              )
                          ->getMock();
 
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
                                  'GET',
                                  '/testIndex/_refresh',
                                  array(),
-                                 null
+                                 NULL
                              )
                          ->getMock();
 

Please login to merge, or discard this patch.

tests/Elasticsearch/Tests/Endpoints/Indices/OptimizeTest.php 4 patches

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -26,14 +26,14 @@  discard block
 block discarded – undo
     public function testValidOptimizeWithNoIndex()
     {
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'POST',
-                                 '/_optimize',
-                                 array(),
-                                 null
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'POST',
+                                    '/_optimize',
+                                    array(),
+                                    null
+                                )
+                            ->getMock();
 
         $action = new Optimize($mockTransport);
         $action->performRequest();
@@ -44,14 +44,14 @@  discard block
 block discarded – undo
     {
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'POST',
-                                 '/testIndex/_optimize',
-                                 array(),
-                                 null
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'POST',
+                                    '/testIndex/_optimize',
+                                    array(),
+                                    null
+                                )
+                            ->getMock();
 
         $action = new Optimize($mockTransport);
         $action->setIndex('testIndex')

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
                          ->with(
                                  'POST',
                                  '/_optimize',
-                                 array(),
+                                 array (),
                                  null
                              )
                          ->getMock();
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
                          ->with(
                                  'POST',
                                  '/testIndex/_optimize',
-                                 array(),
+                                 array (),
                                  null
                              )
                          ->getMock();

Please login to merge, or discard this patch.

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -17,14 +17,12 @@  discard block
 block discarded – undo
  * @license http://www.apache.org/licenses/LICENSE-2.0 Apache2
  * @link    http://elasticsearch.org
  */
-class OptimizeTest extends \PHPUnit_Framework_TestCase
-{
+class OptimizeTest extends \PHPUnit_Framework_TestCase {
     public function tearDown() {
         m::close();
     }
 
-    public function testValidOptimizeWithNoIndex()
-    {
+    public function testValidOptimizeWithNoIndex() {
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()
                          ->with(
@@ -40,8 +38,7 @@  discard block
 block discarded – undo
 
     }
 
-    public function testValidOptimizeWithIndex()
-    {
+    public function testValidOptimizeWithIndex() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()

Please login to merge, or discard this patch.

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
                                  'POST',
                                  '/_optimize',
                                  array(),
-                                 null
+                                 NULL
                              )
                          ->getMock();
 
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
                                  'POST',
                                  '/testIndex/_optimize',
                                  array(),
-                                 null
+                                 NULL
                              )
                          ->getMock();
 

Please login to merge, or discard this patch.

tests/Elasticsearch/Tests/Endpoints/Indices/Exists/TypesTest.php 4 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -68,14 +68,14 @@
 block discarded – undo
     public function testValidTypesExists()
     {
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'HEAD',
-                                 '/testIndex/testType',
-                                 array(),
-                                 null
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'HEAD',
+                                    '/testIndex/testType',
+                                    array(),
+                                    null
+                                )
+                            ->getMock();
 
         $action = new Types($mockTransport);
         $action->setIndex('testIndex')->setType('testType')->performRequest();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@
 block discarded – undo
                          ->with(
                                  'HEAD',
                                  '/testIndex/testType',
-                                 array(),
+                                 array (),
                                  null
                              )
                          ->getMock();

Please login to merge, or discard this patch.

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

@@ -19,8 +19,7 @@  discard block
 block discarded – undo
  * @license http://www.apache.org/licenses/LICENSE-2.0 Apache2
  * @link    http://elasticsearch.org
  */
-class TypesTest extends \PHPUnit_Framework_TestCase
-{
+class TypesTest extends \PHPUnit_Framework_TestCase {
     public function tearDown() {
         m::close();
     }
@@ -28,8 +27,7 @@  discard block
 block discarded – undo
     /**
      * @expectedException RuntimeException
      */
-    public function testNoIndexNoType()
-    {
+    public function testNoIndexNoType() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport');
 
@@ -41,8 +39,7 @@  discard block
 block discarded – undo
     /**
      * @expectedException RuntimeException
      */
-    public function testNoIndex()
-    {
+    public function testNoIndex() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport');
 
@@ -54,8 +51,7 @@  discard block
 block discarded – undo
     /**
      * @expectedException RuntimeException
      */
-    public function testNoType()
-    {
+    public function testNoType() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport');
 
@@ -65,8 +61,7 @@  discard block
 block discarded – undo
     }
 
 
-    public function testValidTypesExists()
-    {
+    public function testValidTypesExists() {
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()
                          ->with(

Please login to merge, or discard this patch.

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -73,7 +73,7 @@
 block discarded – undo
                                  'HEAD',
                                  '/testIndex/testType',
                                  array(),
-                                 null
+                                 NULL
                              )
                          ->getMock();
 

Please login to merge, or discard this patch.

tests/Elasticsearch/Tests/Endpoints/Indices/Exists/IndicesTest.php 4 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -40,14 +40,14 @@
 block discarded – undo
     public function testValidIndicesExists()
     {
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'HEAD',
-                                 '/testIndex',
-                                 array(),
-                                 null
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'HEAD',
+                                    '/testIndex',
+                                    array(),
+                                    null
+                                )
+                            ->getMock();
 
         $action = new Exists($mockTransport);
         $action->setIndex('testIndex')->performRequest();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -44,7 +44,7 @@
 block discarded – undo
                          ->with(
                                  'HEAD',
                                  '/testIndex',
-                                 array(),
+                                 array (),
                                  null
                              )
                          ->getMock();

Please login to merge, or discard this patch.

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -19,8 +19,7 @@  discard block
 block discarded – undo
  * @license http://www.apache.org/licenses/LICENSE-2.0 Apache2
  * @link    http://elasticsearch.org
  */
-class IndicesTest extends \PHPUnit_Framework_TestCase
-{
+class IndicesTest extends \PHPUnit_Framework_TestCase {
     public function tearDown() {
         m::close();
     }
@@ -28,8 +27,7 @@  discard block
 block discarded – undo
     /**
      * @expectedException RuntimeException
      */
-    public function testNoIndex()
-    {
+    public function testNoIndex() {
         $mockTransport = m::mock('\Elasticsearch\Transport');
 
         $index = new Exists($mockTransport);
@@ -37,8 +35,7 @@  discard block
 block discarded – undo
 
     }
 
-    public function testValidIndicesExists()
-    {
+    public function testValidIndicesExists() {
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()
                          ->with(

Please login to merge, or discard this patch.

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -45,7 +45,7 @@
 block discarded – undo
                                  'HEAD',
                                  '/testIndex',
                                  array(),
-                                 null
+                                 NULL
                              )
                          ->getMock();
 

Please login to merge, or discard this patch.

tests/Elasticsearch/Tests/Endpoints/Indices/CloseTest.php 4 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -41,14 +41,14 @@
 block discarded – undo
     {
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'POST',
-                                 '/testIndex/_close',
-                                 array(),
-                                 null
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'POST',
+                                    '/testIndex/_close',
+                                    array(),
+                                    null
+                                )
+                            ->getMock();
 
 
 

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -45,7 +45,7 @@
 block discarded – undo
                          ->with(
                                  'POST',
                                  '/testIndex/_close',
-                                 array(),
+                                 array (),
                                  null
                              )
                          ->getMock();

Please login to merge, or discard this patch.

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -18,8 +18,7 @@  discard block
 block discarded – undo
  * @license http://www.apache.org/licenses/LICENSE-2.0 Apache2
  * @link    http://elasticsearch.org
  */
-class CloseTest extends \PHPUnit_Framework_TestCase
-{
+class CloseTest extends \PHPUnit_Framework_TestCase {
     public function tearDown() {
         m::close();
     }
@@ -27,8 +26,7 @@  discard block
 block discarded – undo
     /**
      * @expectedException RuntimeException
      */
-    public function testNoIndex()
-    {
+    public function testNoIndex() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport');
 
@@ -37,8 +35,7 @@  discard block
 block discarded – undo
 
     }
 
-    public function testValidClose()
-    {
+    public function testValidClose() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()

Please login to merge, or discard this patch.

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@
 block discarded – undo
                                  'POST',
                                  '/testIndex/_close',
                                  array(),
-                                 null
+                                 NULL
                              )
                          ->getMock();
 

Please login to merge, or discard this patch.

tests/Elasticsearch/Tests/Endpoints/Indices/Cache/ClearTest.php 4 patches

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -28,14 +28,14 @@  discard block
 block discarded – undo
     public function testValidSegmentsWithNoIndex()
     {
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'POST',
-                                 '/_cache/clear',
-                                 array(),
-                                 null
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'POST',
+                                    '/_cache/clear',
+                                    array(),
+                                    null
+                                )
+                            ->getMock();
 
         $action = new Clear($mockTransport);
         $action->performRequest();
@@ -46,14 +46,14 @@  discard block
 block discarded – undo
     {
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'POST',
-                                 '/testIndex/_cache/clear',
-                                 array(),
-                                 null
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'POST',
+                                    '/testIndex/_cache/clear',
+                                    array(),
+                                    null
+                                )
+                            ->getMock();
 
         $action = new Clear($mockTransport);
         $action->setIndex('testIndex')

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -32,7 +32,7 @@  discard block
 block discarded – undo
                          ->with(
                                  'POST',
                                  '/_cache/clear',
-                                 array(),
+                                 array (),
                                  null
                              )
                          ->getMock();
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
                          ->with(
                                  'POST',
                                  '/testIndex/_cache/clear',
-                                 array(),
+                                 array (),
                                  null
                              )
                          ->getMock();

Please login to merge, or discard this patch.

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -19,14 +19,12 @@  discard block
 block discarded – undo
  * @link    http://elasticsearch.org
  */
 
-class ClearTest extends \PHPUnit_Framework_TestCase
-{
+class ClearTest extends \PHPUnit_Framework_TestCase {
     public function tearDown() {
         m::close();
     }
 
-    public function testValidSegmentsWithNoIndex()
-    {
+    public function testValidSegmentsWithNoIndex() {
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()
                          ->with(
@@ -42,8 +40,7 @@  discard block
 block discarded – undo
 
     }
 
-    public function testValidSegmentsWithIndex()
-    {
+    public function testValidSegmentsWithIndex() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()

Please login to merge, or discard this patch.

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
                                  'POST',
                                  '/_cache/clear',
                                  array(),
-                                 null
+                                 NULL
                              )
                          ->getMock();
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
                                  'POST',
                                  '/testIndex/_cache/clear',
                                  array(),
-                                 null
+                                 NULL
                              )
                          ->getMock();
 

Please login to merge, or discard this patch.

ElasticSearchPhpClient/tests/Elasticsearch/Tests/Endpoints/IndexTest.php 3 patches

Indentation +32 added lines, -32 removed lines patch added patch discarded remove patch

@@ -82,14 +82,14 @@  discard block
 block discarded – undo
         $doc = array('field' => 'value');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'POST',
-                                 '/testIndex/testType',
-                                 array(),
-                                 $doc
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'POST',
+                                    '/testIndex/testType',
+                                    array(),
+                                    $doc
+                                )
+                            ->getMock();
 
 
 
@@ -106,14 +106,14 @@  discard block
 block discarded – undo
         $doc = array('field' => 'value');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'PUT',
-                                 '/testIndex/testType/abc',
-                                 array(),
-                                 $doc
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'PUT',
+                                    '/testIndex/testType/abc',
+                                    array(),
+                                    $doc
+                                )
+                            ->getMock();
 
 
 
@@ -132,14 +132,14 @@  discard block
 block discarded – undo
         $params = array('op_type' => 'create');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'POST',
-                                 '/testIndex/testType',
-                                 $params,
-                                 $doc
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'POST',
+                                    '/testIndex/testType',
+                                    $params,
+                                    $doc
+                                )
+                            ->getMock();
 
 
 
@@ -157,14 +157,14 @@  discard block
 block discarded – undo
         $doc = array('field' => 'value');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
-                         ->shouldReceive('performRequest')->once()
-                         ->with(
-                                 'PUT',
-                                 '/testIndex/testType/abc/_create',
-                                 array(),
-                                 $doc
-                             )
-                         ->getMock();
+                            ->shouldReceive('performRequest')->once()
+                            ->with(
+                                    'PUT',
+                                    '/testIndex/testType/abc/_create',
+                                    array(),
+                                    $doc
+                                )
+                            ->getMock();
 
 
 

Please login to merge, or discard this patch.

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -79,14 +79,14 @@  discard block
 block discarded – undo
 
     public function testValidIndexNoID()
     {
-        $doc = array('field' => 'value');
+        $doc = array ('field' => 'value');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()
                          ->with(
                                  'POST',
                                  '/testIndex/testType',
-                                 array(),
+                                 array (),
                                  $doc
                              )
                          ->getMock();
@@ -103,14 +103,14 @@  discard block
 block discarded – undo
 
     public function testValidIndexWithID()
     {
-        $doc = array('field' => 'value');
+        $doc = array ('field' => 'value');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()
                          ->with(
                                  'PUT',
                                  '/testIndex/testType/abc',
-                                 array(),
+                                 array (),
                                  $doc
                              )
                          ->getMock();
@@ -128,8 +128,8 @@  discard block
 block discarded – undo
 
     public function testValidIndexNoIDWithCreateIfAbsent()
     {
-        $doc    = array('field' => 'value');
-        $params = array('op_type' => 'create');
+        $doc    = array ('field' => 'value');
+        $params = array ('op_type' => 'create');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()
@@ -154,14 +154,14 @@  discard block
 block discarded – undo
 
     public function testValidIndexWithIDWithCreateIfAbsent()
     {
-        $doc = array('field' => 'value');
+        $doc = array ('field' => 'value');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
                          ->shouldReceive('performRequest')->once()
                          ->with(
                                  'PUT',
                                  '/testIndex/testType/abc/_create',
-                                 array(),
+                                 array (),
                                  $doc
                              )
                          ->getMock();

Please login to merge, or discard this patch.

Braces +9 added lines, -18 removed lines patch added patch discarded remove patch

@@ -18,8 +18,7 @@  discard block
 block discarded – undo
  * @license http://www.apache.org/licenses/LICENSE-2.0 Apache2
  * @link    http://elasticsearch.org
  */
-class IndexTest extends \PHPUnit_Framework_TestCase
-{
+class IndexTest extends \PHPUnit_Framework_TestCase {
     public function tearDown() {
         m::close();
     }
@@ -28,8 +27,7 @@  discard block
 block discarded – undo
     /**
      * @expectedException RuntimeException
      */
-    public function testNoIndexTypeOrID()
-    {
+    public function testNoIndexTypeOrID() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport');
 
@@ -41,8 +39,7 @@  discard block
 block discarded – undo
     /**
      * @expectedException RuntimeException
      */
-    public function testNoIndex()
-    {
+    public function testNoIndex() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport');
 
@@ -54,8 +51,7 @@  discard block
 block discarded – undo
     /**
      * @expectedException RuntimeException
      */
-    public function testNoType()
-    {
+    public function testNoType() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport');
 
@@ -67,8 +63,7 @@  discard block
 block discarded – undo
     /**
      * @expectedException RuntimeException
      */
-    public function testNoDocumentBody()
-    {
+    public function testNoDocumentBody() {
 
         $mockTransport = m::mock('\Elasticsearch\Transport');
 
@@ -77,8 +72,7 @@  discard block
 block discarded – undo
 
     }
 
-    public function testValidIndexNoID()
-    {
+    public function testValidIndexNoID() {
         $doc = array('field' => 'value');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
@@ -101,8 +95,7 @@  discard block
 block discarded – undo
 
     }
 
-    public function testValidIndexWithID()
-    {
+    public function testValidIndexWithID() {
         $doc = array('field' => 'value');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')
@@ -126,8 +119,7 @@  discard block
 block discarded – undo
 
     }
 
-    public function testValidIndexNoIDWithCreateIfAbsent()
-    {
+    public function testValidIndexNoIDWithCreateIfAbsent() {
         $doc    = array('field' => 'value');
         $params = array('op_type' => 'create');
 
@@ -152,8 +144,7 @@  discard block
 block discarded – undo
 
     }
 
-    public function testValidIndexWithIDWithCreateIfAbsent()
-    {
+    public function testValidIndexWithIDWithCreateIfAbsent() {
         $doc = array('field' => 'value');
 
         $mockTransport = m::mock('\Elasticsearch\Transport')

Please login to merge, or discard this patch.

		@@ -82,14 +82,14 @@ discard block
		block discarded – undo
82	82	$doc = array('field' => 'value');
83	83
84	84	$mockTransport = m::mock('\Elasticsearch\Transport')
85		- ->shouldReceive('performRequest')->once()
86		- ->with(
87		- 'POST',
88		- '/testIndex/testType',
89		- array(),
90		- $doc
91		- )
92		- ->getMock();
	85	+ ->shouldReceive('performRequest')->once()
	86	+ ->with(
	87	+ 'POST',
	88	+ '/testIndex/testType',
	89	+ array(),
	90	+ $doc
	91	+ )
	92	+ ->getMock();
93	93
94	94
95	95
		@@ -106,14 +106,14 @@ discard block
		block discarded – undo
106	106	$doc = array('field' => 'value');
107	107
108	108	$mockTransport = m::mock('\Elasticsearch\Transport')
109		- ->shouldReceive('performRequest')->once()
110		- ->with(
111		- 'PUT',
112		- '/testIndex/testType/abc',
113		- array(),
114		- $doc
115		- )
116		- ->getMock();
	109	+ ->shouldReceive('performRequest')->once()
	110	+ ->with(
	111	+ 'PUT',
	112	+ '/testIndex/testType/abc',
	113	+ array(),
	114	+ $doc
	115	+ )
	116	+ ->getMock();
117	117
118	118
119	119
		@@ -132,14 +132,14 @@ discard block
		block discarded – undo
132	132	$params = array('op_type' => 'create');
133	133
134	134	$mockTransport = m::mock('\Elasticsearch\Transport')
135		- ->shouldReceive('performRequest')->once()
136		- ->with(
137		- 'POST',
138		- '/testIndex/testType',
139		- $params,
140		- $doc
141		- )
142		- ->getMock();
	135	+ ->shouldReceive('performRequest')->once()
	136	+ ->with(
	137	+ 'POST',
	138	+ '/testIndex/testType',
	139	+ $params,
	140	+ $doc
	141	+ )
	142	+ ->getMock();
143	143
144	144
145	145
		@@ -157,14 +157,14 @@ discard block
		block discarded – undo
157	157	$doc = array('field' => 'value');
158	158
159	159	$mockTransport = m::mock('\Elasticsearch\Transport')
160		- ->shouldReceive('performRequest')->once()
161		- ->with(
162		- 'PUT',
163		- '/testIndex/testType/abc/_create',
164		- array(),
165		- $doc
166		- )
167		- ->getMock();
	160	+ ->shouldReceive('performRequest')->once()
	161	+ ->with(
	162	+ 'PUT',
	163	+ '/testIndex/testType/abc/_create',
	164	+ array(),
	165	+ $doc
	166	+ )
	167	+ ->getMock();
168	168
169	169
170	170

		@@ -79,14 +79,14 @@ discard block
		block discarded – undo
79	79
80	80	public function testValidIndexNoID()
81	81	{
82		- $doc = array('field' => 'value');
	82	+ $doc = array ('field' => 'value');
83	83
84	84	$mockTransport = m::mock('\Elasticsearch\Transport')
85	85	->shouldReceive('performRequest')->once()
86	86	->with(
87	87	'POST',
88	88	'/testIndex/testType',
89		- array(),
	89	+ array (),
90	90	$doc
91	91	)
92	92	->getMock();
		@@ -103,14 +103,14 @@ discard block
		block discarded – undo
103	103
104	104	public function testValidIndexWithID()
105	105	{
106		- $doc = array('field' => 'value');
	106	+ $doc = array ('field' => 'value');
107	107
108	108	$mockTransport = m::mock('\Elasticsearch\Transport')
109	109	->shouldReceive('performRequest')->once()
110	110	->with(
111	111	'PUT',
112	112	'/testIndex/testType/abc',
113		- array(),
	113	+ array (),
114	114	$doc
115	115	)
116	116	->getMock();
		@@ -128,8 +128,8 @@ discard block
		block discarded – undo
128	128
129	129	public function testValidIndexNoIDWithCreateIfAbsent()
130	130	{
131		- $doc = array('field' => 'value');
132		- $params = array('op_type' => 'create');
	131	+ $doc = array ('field' => 'value');
	132	+ $params = array ('op_type' => 'create');
133	133
134	134	$mockTransport = m::mock('\Elasticsearch\Transport')
135	135	->shouldReceive('performRequest')->once()
		@@ -154,14 +154,14 @@ discard block
		block discarded – undo
154	154
155	155	public function testValidIndexWithIDWithCreateIfAbsent()
156	156	{
157		- $doc = array('field' => 'value');
	157	+ $doc = array ('field' => 'value');
158	158
159	159	$mockTransport = m::mock('\Elasticsearch\Transport')
160	160	->shouldReceive('performRequest')->once()
161	161	->with(
162	162	'PUT',
163	163	'/testIndex/testType/abc/_create',
164		- array(),
	164	+ array (),
165	165	$doc
166	166	)
167	167	->getMock();

		@@ -69,14 +69,14 @@
		block discarded – undo
69	69	$body = array('field' => 'value');
70	70
71	71	$mockTransport = m::mock('\Elasticsearch\Transport')
72		- ->shouldReceive('performRequest')->once()
73		- ->with(
74		- 'PUT',
75		- '/_template/testName',
76		- array(),
77		- $body
78		- )
79		- ->getMock();
	72	+ ->shouldReceive('performRequest')->once()
	73	+ ->with(
	74	+ 'PUT',
	75	+ '/_template/testName',
	76	+ array(),
	77	+ $body
	78	+ )
	79	+ ->getMock();
80	80
81	81	$action = new Put($mockTransport);
82	82	$action->setIndex('testIndex')->setName('testName')->setBody($body)

		@@ -60,20 +60,20 @@
		block discarded – undo
60	60	$mockTransport = m::mock('\Elasticsearch\Transport');
61	61
62	62	$index = new Put($mockTransport);
63		- $index->setBody(array())->performRequest();
	63	+ $index->setBody(array ())->performRequest();
64	64
65	65	}
66	66
67	67	public function testValidPut()
68	68	{
69		- $body = array('field' => 'value');
	69	+ $body = array ('field' => 'value');
70	70
71	71	$mockTransport = m::mock('\Elasticsearch\Transport')
72	72	->shouldReceive('performRequest')->once()
73	73	->with(
74	74	'PUT',
75	75	'/_template/testName',
76		- array(),
	76	+ array (),
77	77	$body
78	78	)
79	79	->getMock();

		@@ -19,8 +19,7 @@ discard block
		block discarded – undo
19	19	* @license http://www.apache.org/licenses/LICENSE-2.0 Apache2
20	20	* @link http://elasticsearch.org
21	21	*/
22		-class PutTest extends \PHPUnit_Framework_TestCase
23		-{
	22	+class PutTest extends \PHPUnit_Framework_TestCase {
24	23	public function tearDown() {
25	24	m::close();
26	25	}
		@@ -28,8 +27,7 @@ discard block
		block discarded – undo
28	27	/**
29	28	* @expectedException RuntimeException
30	29	*/
31		- public function testNoNameNoBody()
32		- {
	30	+ public function testNoNameNoBody() {
33	31
34	32	$mockTransport = m::mock('\Elasticsearch\Transport');
35	33
		@@ -41,8 +39,7 @@ discard block
		block discarded – undo
41	39	/**
42	40	* @expectedException RuntimeException
43	41	*/
44		- public function testNoBody()
45		- {
	42	+ public function testNoBody() {
46	43
47	44	$mockTransport = m::mock('\Elasticsearch\Transport');
48	45
		@@ -54,8 +51,7 @@ discard block
		block discarded – undo
54	51	/**
55	52	* @expectedException RuntimeException
56	53	*/
57		- public function testNoName()
58		- {
	54	+ public function testNoName() {
59	55
60	56	$mockTransport = m::mock('\Elasticsearch\Transport');
61	57
		@@ -64,8 +60,7 @@ discard block
		block discarded – undo
64	60
65	61	}
66	62
67		- public function testValidPut()
68		- {
	63	+ public function testValidPut() {
69	64	$body = array('field' => 'value');
70	65
71	66	$mockTransport = m::mock('\Elasticsearch\Transport')

		@@ -27,14 +27,14 @@ discard block
		block discarded – undo
27	27	public function testValidSnapshotWithNoIndex()
28	28	{
29	29	$mockTransport = m::mock('\Elasticsearch\Transport')
30		- ->shouldReceive('performRequest')->once()
31		- ->with(
32		- 'POST',
33		- '/_gateway/snapshot',
34		- array(),
35		- null
36		- )
37		- ->getMock();
	30	+ ->shouldReceive('performRequest')->once()
	31	+ ->with(
	32	+ 'POST',
	33	+ '/_gateway/snapshot',
	34	+ array(),
	35	+ null
	36	+ )
	37	+ ->getMock();
38	38
39	39	$action = new Snapshot($mockTransport);
40	40	$action->performRequest();
		@@ -45,14 +45,14 @@ discard block
		block discarded – undo
45	45	{
46	46
47	47	$mockTransport = m::mock('\Elasticsearch\Transport')
48		- ->shouldReceive('performRequest')->once()
49		- ->with(
50		- 'POST',
51		- '/testIndex/_gateway/snapshot',
52		- array(),
53		- null
54		- )
55		- ->getMock();
	48	+ ->shouldReceive('performRequest')->once()
	49	+ ->with(
	50	+ 'POST',
	51	+ '/testIndex/_gateway/snapshot',
	52	+ array(),
	53	+ null
	54	+ )
	55	+ ->getMock();
56	56
57	57	$action = new Snapshot($mockTransport);
58	58	$action->setIndex('testIndex')

		@@ -31,7 +31,7 @@ discard block
		block discarded – undo
31	31	->with(
32	32	'POST',
33	33	'/_gateway/snapshot',
34		- array(),
	34	+ array (),
35	35	null
36	36	)
37	37	->getMock();
		@@ -49,7 +49,7 @@ discard block
		block discarded – undo
49	49	->with(
50	50	'POST',
51	51	'/testIndex/_gateway/snapshot',
52		- array(),
	52	+ array (),
53	53	null
54	54	)
55	55	->getMock();

		@@ -18,14 +18,12 @@ discard block
		block discarded – undo
18	18	* @link http://elasticsearch.org
19	19	*/
20	20
21		-class SnapshotTest extends \PHPUnit_Framework_TestCase
22		-{
	21	+class SnapshotTest extends \PHPUnit_Framework_TestCase {
23	22	public function tearDown() {
24	23	m::close();
25	24	}
26	25
27		- public function testValidSnapshotWithNoIndex()
28		- {
	26	+ public function testValidSnapshotWithNoIndex() {
29	27	$mockTransport = m::mock('\Elasticsearch\Transport')
30	28	->shouldReceive('performRequest')->once()
31	29	->with(
		@@ -41,8 +39,7 @@ discard block
		block discarded – undo
41	39
42	40	}
43	41
44		- public function testValidSnapshotWithIndex()
45		- {
	42	+ public function testValidSnapshotWithIndex() {
46	43
47	44	$mockTransport = m::mock('\Elasticsearch\Transport')
48	45	->shouldReceive('performRequest')->once()

		@@ -32,7 +32,7 @@ discard block
		block discarded – undo
32	32	'POST',
33	33	'/_gateway/snapshot',
34	34	array(),
35		- null
	35	+ NULL
36	36	)
37	37	->getMock();
38	38
		@@ -50,7 +50,7 @@ discard block
		block discarded – undo
50	50	'POST',
51	51	'/testIndex/_gateway/snapshot',
52	52	array(),
53		- null
	53	+ NULL
54	54	)
55	55	->getMock();
56	56

		@@ -26,14 +26,14 @@ discard block
		block discarded – undo
26	26	public function testValidRefreshWithNoIndex()
27	27	{
28	28	$mockTransport = m::mock('\Elasticsearch\Transport')
29		- ->shouldReceive('performRequest')->once()
30		- ->with(
31		- 'GET',
32		- '/_refresh',
33		- array(),
34		- null
35		- )
36		- ->getMock();
	29	+ ->shouldReceive('performRequest')->once()
	30	+ ->with(
	31	+ 'GET',
	32	+ '/_refresh',
	33	+ array(),
	34	+ null
	35	+ )
	36	+ ->getMock();
37	37
38	38	$action = new Refresh($mockTransport);
39	39	$action->performRequest();
		@@ -44,14 +44,14 @@ discard block
		block discarded – undo
44	44	{
45	45
46	46	$mockTransport = m::mock('\Elasticsearch\Transport')
47		- ->shouldReceive('performRequest')->once()
48		- ->with(
49		- 'GET',
50		- '/testIndex/_refresh',
51		- array(),
52		- null
53		- )
54		- ->getMock();
	47	+ ->shouldReceive('performRequest')->once()
	48	+ ->with(
	49	+ 'GET',
	50	+ '/testIndex/_refresh',
	51	+ array(),
	52	+ null
	53	+ )
	54	+ ->getMock();
55	55
56	56	$action = new Refresh($mockTransport);
57	57	$action->setIndex('testIndex')

		@@ -30,7 +30,7 @@ discard block
		block discarded – undo
30	30	->with(
31	31	'GET',
32	32	'/_refresh',
33		- array(),
	33	+ array (),
34	34	null
35	35	)
36	36	->getMock();
		@@ -48,7 +48,7 @@ discard block
		block discarded – undo
48	48	->with(
49	49	'GET',
50	50	'/testIndex/_refresh',
51		- array(),
	51	+ array (),
52	52	null
53	53	)
54	54	->getMock();

		@@ -17,14 +17,12 @@ discard block
		block discarded – undo
17	17	* @license http://www.apache.org/licenses/LICENSE-2.0 Apache2
18	18	* @link http://elasticsearch.org
19	19	*/
20		-class RefreshTest extends \PHPUnit_Framework_TestCase
21		-{
	20	+class RefreshTest extends \PHPUnit_Framework_TestCase {
22	21	public function tearDown() {
23	22	m::close();
24	23	}
25	24
26		- public function testValidRefreshWithNoIndex()
27		- {
	25	+ public function testValidRefreshWithNoIndex() {
28	26	$mockTransport = m::mock('\Elasticsearch\Transport')
29	27	->shouldReceive('performRequest')->once()
30	28	->with(
		@@ -40,8 +38,7 @@ discard block
		block discarded – undo
40	38
41	39	}
42	40
43		- public function testValidRefreshWithIndex()
44		- {
	41	+ public function testValidRefreshWithIndex() {
45	42
46	43	$mockTransport = m::mock('\Elasticsearch\Transport')
47	44	->shouldReceive('performRequest')->once()

		@@ -26,14 +26,14 @@ discard block
		block discarded – undo
26	26	public function testValidOptimizeWithNoIndex()
27	27	{
28	28	$mockTransport = m::mock('\Elasticsearch\Transport')
29		- ->shouldReceive('performRequest')->once()
30		- ->with(
31		- 'POST',
32		- '/_optimize',
33		- array(),
34		- null
35		- )
36		- ->getMock();
	29	+ ->shouldReceive('performRequest')->once()
	30	+ ->with(
	31	+ 'POST',
	32	+ '/_optimize',
	33	+ array(),
	34	+ null
	35	+ )
	36	+ ->getMock();
37	37
38	38	$action = new Optimize($mockTransport);
39	39	$action->performRequest();
		@@ -44,14 +44,14 @@ discard block
		block discarded – undo
44	44	{
45	45
46	46	$mockTransport = m::mock('\Elasticsearch\Transport')
47		- ->shouldReceive('performRequest')->once()
48		- ->with(
49		- 'POST',
50		- '/testIndex/_optimize',
51		- array(),
52		- null
53		- )
54		- ->getMock();
	47	+ ->shouldReceive('performRequest')->once()
	48	+ ->with(
	49	+ 'POST',
	50	+ '/testIndex/_optimize',
	51	+ array(),
	52	+ null
	53	+ )
	54	+ ->getMock();
55	55
56	56	$action = new Optimize($mockTransport);
57	57	$action->setIndex('testIndex')

		@@ -68,14 +68,14 @@
		block discarded – undo
68	68	public function testValidTypesExists()
69	69	{
70	70	$mockTransport = m::mock('\Elasticsearch\Transport')
71		- ->shouldReceive('performRequest')->once()
72		- ->with(
73		- 'HEAD',
74		- '/testIndex/testType',
75		- array(),
76		- null
77		- )
78		- ->getMock();
	71	+ ->shouldReceive('performRequest')->once()
	72	+ ->with(
	73	+ 'HEAD',
	74	+ '/testIndex/testType',
	75	+ array(),
	76	+ null
	77	+ )
	78	+ ->getMock();
79	79
80	80	$action = new Types($mockTransport);
81	81	$action->setIndex('testIndex')->setType('testType')->performRequest();

		@@ -72,7 +72,7 @@
		block discarded – undo
72	72	->with(
73	73	'HEAD',
74	74	'/testIndex/testType',
75		- array(),
	75	+ array (),
76	76	null
77	77	)
78	78	->getMock();

		@@ -73,7 +73,7 @@
		block discarded – undo
73	73	'HEAD',
74	74	'/testIndex/testType',
75	75	array(),
76		- null
	76	+ NULL
77	77	)
78	78	->getMock();
79	79

		@@ -40,14 +40,14 @@
		block discarded – undo
40	40	public function testValidIndicesExists()
41	41	{
42	42	$mockTransport = m::mock('\Elasticsearch\Transport')
43		- ->shouldReceive('performRequest')->once()
44		- ->with(
45		- 'HEAD',
46		- '/testIndex',
47		- array(),
48		- null
49		- )
50		- ->getMock();
	43	+ ->shouldReceive('performRequest')->once()
	44	+ ->with(
	45	+ 'HEAD',
	46	+ '/testIndex',
	47	+ array(),
	48	+ null
	49	+ )
	50	+ ->getMock();
51	51
52	52	$action = new Exists($mockTransport);
53	53	$action->setIndex('testIndex')->performRequest();

		@@ -44,7 +44,7 @@
		block discarded – undo
44	44	->with(
45	45	'HEAD',
46	46	'/testIndex',
47		- array(),
	47	+ array (),
48	48	null
49	49	)
50	50	->getMock();

		@@ -45,7 +45,7 @@
		block discarded – undo
45	45	'HEAD',
46	46	'/testIndex',
47	47	array(),
48		- null
	48	+ NULL
49	49	)
50	50	->getMock();
51	51

		@@ -41,14 +41,14 @@
		block discarded – undo
41	41	{
42	42
43	43	$mockTransport = m::mock('\Elasticsearch\Transport')
44		- ->shouldReceive('performRequest')->once()
45		- ->with(
46		- 'POST',
47		- '/testIndex/_close',
48		- array(),
49		- null
50		- )
51		- ->getMock();
	44	+ ->shouldReceive('performRequest')->once()
	45	+ ->with(
	46	+ 'POST',
	47	+ '/testIndex/_close',
	48	+ array(),
	49	+ null
	50	+ )
	51	+ ->getMock();
52	52
53	53
54	54

		@@ -18,8 +18,7 @@ discard block
		block discarded – undo
18	18	* @license http://www.apache.org/licenses/LICENSE-2.0 Apache2
19	19	* @link http://elasticsearch.org
20	20	*/
21		-class CloseTest extends \PHPUnit_Framework_TestCase
22		-{
	21	+class CloseTest extends \PHPUnit_Framework_TestCase {
23	22	public function tearDown() {
24	23	m::close();
25	24	}
		@@ -27,8 +26,7 @@ discard block
		block discarded – undo
27	26	/**
28	27	* @expectedException RuntimeException
29	28	*/
30		- public function testNoIndex()
31		- {
	29	+ public function testNoIndex() {
32	30
33	31	$mockTransport = m::mock('\Elasticsearch\Transport');
34	32
		@@ -37,8 +35,7 @@ discard block
		block discarded – undo
37	35
38	36	}
39	37
40		- public function testValidClose()
41		- {
	38	+ public function testValidClose() {
42	39
43	40	$mockTransport = m::mock('\Elasticsearch\Transport')
44	41	->shouldReceive('performRequest')->once()

		@@ -46,7 +46,7 @@
		block discarded – undo
46	46	'POST',
47	47	'/testIndex/_close',
48	48	array(),
49		- null
	49	+ NULL
50	50	)
51	51	->getMock();
52	52

kitodo / kitodo-publication

Pull Request — master (#64)

Status

Category

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +32 added lines, -32 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Braces +9 added lines, -18 removed lines patch added patch discarded remove patch

		@@ -28,14 +28,14 @@ discard block
		block discarded – undo
28	28	public function testValidSegmentsWithNoIndex()
29	29	{
30	30	$mockTransport = m::mock('\Elasticsearch\Transport')
31		- ->shouldReceive('performRequest')->once()
32		- ->with(
33		- 'POST',
34		- '/_cache/clear',
35		- array(),
36		- null
37		- )
38		- ->getMock();
	31	+ ->shouldReceive('performRequest')->once()
	32	+ ->with(
	33	+ 'POST',
	34	+ '/_cache/clear',
	35	+ array(),
	36	+ null
	37	+ )
	38	+ ->getMock();
39	39
40	40	$action = new Clear($mockTransport);
41	41	$action->performRequest();
		@@ -46,14 +46,14 @@ discard block
		block discarded – undo
46	46	{
47	47
48	48	$mockTransport = m::mock('\Elasticsearch\Transport')
49		- ->shouldReceive('performRequest')->once()
50		- ->with(
51		- 'POST',
52		- '/testIndex/_cache/clear',
53		- array(),
54		- null
55		- )
56		- ->getMock();
	49	+ ->shouldReceive('performRequest')->once()
	50	+ ->with(
	51	+ 'POST',
	52	+ '/testIndex/_cache/clear',
	53	+ array(),
	54	+ null
	55	+ )
	56	+ ->getMock();
57	57
58	58	$action = new Clear($mockTransport);
59	59	$action->setIndex('testIndex')

		@@ -19,14 +19,12 @@ discard block
		block discarded – undo
19	19	* @link http://elasticsearch.org
20	20	*/
21	21
22		-class ClearTest extends \PHPUnit_Framework_TestCase
23		-{
	22	+class ClearTest extends \PHPUnit_Framework_TestCase {
24	23	public function tearDown() {
25	24	m::close();
26	25	}
27	26
28		- public function testValidSegmentsWithNoIndex()
29		- {
	27	+ public function testValidSegmentsWithNoIndex() {
30	28	$mockTransport = m::mock('\Elasticsearch\Transport')
31	29	->shouldReceive('performRequest')->once()
32	30	->with(
		@@ -42,8 +40,7 @@ discard block
		block discarded – undo
42	40
43	41	}
44	42
45		- public function testValidSegmentsWithIndex()
46		- {
	43	+ public function testValidSegmentsWithIndex() {
47	44
48	45	$mockTransport = m::mock('\Elasticsearch\Transport')
49	46	->shouldReceive('performRequest')->once()

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33	'POST',
34	34	'/_cache/clear',
35	35	array(),
36		- null
	36	+ NULL
37	37	)
38	38	->getMock();
39	39
		@@ -51,7 +51,7 @@ discard block
		block discarded – undo
51	51	'POST',
52	52	'/testIndex/_cache/clear',
53	53	array(),
54		- null
	54	+ NULL
55	55	)
56	56	->getMock();
57	57