kitodo / kitodo-publication

Classes/Domain/Repository/FrontendUserRepository.php

Braces +2 added lines, -4 removed lines

@@ -4,15 +4,13 @@
 use EWW\Dpf\Domain\Model\Document;
 use TYPO3\CMS\Extbase\Persistence\QueryResultInterface;
 
-class FrontendUserRepository extends \TYPO3\CMS\Extbase\Domain\Repository\FrontendUserRepository
-{
+class FrontendUserRepository extends \TYPO3\CMS\Extbase\Domain\Repository\FrontendUserRepository {
     /**
      * @param $feUserUid
      * @param $clientPid
      * @return bool
      */
-    public function isUserInClient($feUserUid, $clientPid)
-    {
+    public function isUserInClient($feUserUid, $clientPid) {
         /** @var $querySettings \TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings */
         $querySettings = $this->objectManager->get('TYPO3\\CMS\\Extbase\\Persistence\\Generic\\Typo3QuerySettings');
         $querySettings->setRespectStoragePage(false);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
     {
         /** @var $querySettings \TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings */
         $querySettings = $this->objectManager->get('TYPO3\\CMS\\Extbase\\Persistence\\Generic\\Typo3QuerySettings');
-        $querySettings->setRespectStoragePage(false);
+        $querySettings->setRespectStoragePage(FALSE);
         $this->setDefaultQuerySettings($querySettings);
         $query = $this->createQuery();
 

Classes/Domain/Model/Document.php

Spacing +10 added lines, -10 removed lines

@@ -359,7 +359,7 @@ 
     public function setObjectIdentifier($objectIdentifier)
     {
         // Due to uniqe key uc_object_identifier, which should ignore empty object identifiers.
-        $this->objectIdentifier = empty($objectIdentifier)? null : $objectIdentifier;
+        $this->objectIdentifier = empty($objectIdentifier) ? null : $objectIdentifier;
     }
 
     /**
@@ -541,14 +541,14 @@ 
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
-        $files = array();
+        $files = array ();
 
         if (is_a($this->getFile(), '\TYPO3\CMS\Extbase\Persistence\ObjectStorage')) {
             foreach ($this->getFile() as $file) {
 
                 if (!$file->isFileGroupDeleted()) {
 
-                    $tmpFile = array(
+                    $tmpFile = array (
                         'path' => $file->getUrl(),
                         'type' => $file->getContentType(),
                         'title' => (($file->getLabel()) ? $file->getLabel() : $file->getTitle()),
@@ -592,12 +592,12 @@ 
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
-        $files = array();
+        $files = array ();
 
         if (is_a($this->getFile(), '\TYPO3\CMS\Extbase\Persistence\ObjectStorage')) {
             foreach ($this->getFile() as $file) {
 
-                $tmpFile = array(
+                $tmpFile = array (
                     'path' => $file->getUrl(),
                     'type' => $file->getContentType(),
                     'title' => (($file->getLabel()) ? $file->getLabel() : $file->getTitle()),
@@ -749,7 +749,7 @@ 
      */
     public function getCreator()
     {
-        return $this->creator? $this->creator : 0;
+        return $this->creator ? $this->creator : 0;
     }
 
     /**
@@ -904,7 +904,7 @@ 
 
         foreach ($availableProperties as $propertyName) {
             if (\TYPO3\CMS\Extbase\Reflection\ObjectAccess::isPropertySettable($newDocument, $propertyName)
-                && !in_array($propertyName, array('uid','pid', 'file', 'comment', 'linkedUid', 'suggestion', 'creator'))) {
+                && !in_array($propertyName, array ('uid', 'pid', 'file', 'comment', 'linkedUid', 'suggestion', 'creator'))) {
 
                 $propertyValue = \TYPO3\CMS\Extbase\Reflection\ObjectAccess::getProperty($documentToCopy, $propertyName);
                 \TYPO3\CMS\Extbase\Reflection\ObjectAccess::setProperty($newDocument, $propertyName, $propertyValue);
@@ -926,7 +926,7 @@ 
      */
     public function getDocumentIdentifier()
     {
-        return $this->getObjectIdentifier()? $this->getObjectIdentifier() : $this->getUid();
+        return $this->getObjectIdentifier() ? $this->getObjectIdentifier() : $this->getUid();
     }
 
     /**
@@ -959,8 +959,8 @@ 
     public function getPublicationYear()
     {
         $internalFormat = new InternalFormat($this->getXmlData(), $this->getPid());
-        $year =  $internalFormat->getPublishingYear();
-        return $year? $year : "";
+        $year = $internalFormat->getPublishingYear();
+        return $year ? $year : "";
     }
 
     /**

Braces +64 added lines, -128 removed lines

@@ -21,8 +21,7 @@ 
 /**
  * Document
  */
-class Document extends AbstractEntity
-{
+class Document extends AbstractEntity {
     // xml data size ist limited to 64 KB
     const XML_DATA_SIZE_LIMIT = 64 * 1024;
 
@@ -213,8 +212,7 @@ 
     /**
      * __construct
      */
-    public function __construct()
-    {
+    public function __construct() {
         //Do not remove the next line: It would break the functionality
         $this->initStorageObjects();
     }
@@ -224,8 +222,7 @@ 
      *
      * @return void
      */
-    protected function initStorageObjects()
-    {
+    protected function initStorageObjects() {
         $this->file = new \TYPO3\CMS\Extbase\Persistence\ObjectStorage();
         $this->initCreationDate();
     }
@@ -235,8 +232,7 @@ 
      *
      * @return string $title
      */
-    public function getTitle()
-    {
+    public function getTitle() {
         return $this->title;
     }
 
@@ -246,8 +242,7 @@ 
      * @param string $title
      * @return void
      */
-    public function setTitle($title)
-    {
+    public function setTitle($title) {
         $this->title = $title ?? '';
         //htmlspecialchars_decode($title,ENT_QUOTES);
     }
@@ -257,8 +252,7 @@ 
      *
      * @return array $authors
      */
-    public function getAuthors()
-    {
+    public function getAuthors() {
         $authors = @unserialize($this->authors);
         if (is_array($authors)) {
             return $authors;
@@ -273,8 +267,7 @@ 
      * @param array $authors
      * @return void
      */
-    public function setAuthors($authors)
-    {
+    public function setAuthors($authors) {
         $this->authors = serialize($authors);
     }
 
@@ -283,8 +276,7 @@ 
      *
      * @return string $xmlData
      */
-    public function getXmlData()
-    {
+    public function getXmlData() {
         return $this->xmlData;
     }
 
@@ -294,8 +286,7 @@ 
      * @param string $xmlData
      * @return void
      */
-    public function setXmlData($xmlData)
-    {
+    public function setXmlData($xmlData) {
         $this->xmlData = $xmlData;
     }
 
@@ -304,8 +295,7 @@ 
      *
      * @return string $slubInfoData
      */
-    public function getSlubInfoData()
-    {
+    public function getSlubInfoData() {
         return $this->slubInfoData;
     }
 
@@ -314,8 +304,7 @@ 
      *
      * @return string $slubInfoData
      */
-    public function setSlubInfoData($slubInfoData)
-    {
+    public function setSlubInfoData($slubInfoData) {
         $this->slubInfoData = $slubInfoData;
     }
 
@@ -324,8 +313,7 @@ 
      *
      * @return \EWW\Dpf\Domain\Model\DocumentType $documentType
      */
-    public function getDocumentType()
-    {
+    public function getDocumentType() {
         return $this->documentType;
     }
 
@@ -335,8 +323,7 @@ 
      * @param \EWW\Dpf\Domain\Model\DocumentType $documentType
      * @return void
      */
-    public function setDocumentType(\EWW\Dpf\Domain\Model\DocumentType $documentType)
-    {
+    public function setDocumentType(\EWW\Dpf\Domain\Model\DocumentType $documentType) {
         $this->documentType = $documentType;
     }
 
@@ -345,8 +332,7 @@ 
      *
      * @return string
      */
-    public function getObjectIdentifier()
-    {
+    public function getObjectIdentifier() {
         return $this->objectIdentifier;
     }
 
@@ -356,8 +342,7 @@ 
      * @param string $objectIdentifier
      * @return void
      */
-    public function setObjectIdentifier($objectIdentifier)
-    {
+    public function setObjectIdentifier($objectIdentifier) {
         // Due to uniqe key uc_object_identifier, which should ignore empty object identifiers.
         $this->objectIdentifier = empty($objectIdentifier)? null : $objectIdentifier;
     }
@@ -367,8 +352,7 @@ 
      *
      * @return string
      */
-    public function getReservedObjectIdentifier()
-    {
+    public function getReservedObjectIdentifier() {
         return $this->reservedObjectIdentifier;
     }
 
@@ -378,8 +362,7 @@ 
      * @param string $reservedObjectIdentifier
      * @return void
      */
-    public function setReservedObjectIdentifier($reservedObjectIdentifier)
-    {
+    public function setReservedObjectIdentifier($reservedObjectIdentifier) {
         $this->reservedObjectIdentifier = $reservedObjectIdentifier;
     }
 
@@ -388,8 +371,7 @@ 
      *
      * @return string
      */
-    public function getTransferStatus()
-    {
+    public function getTransferStatus() {
         return $this->transferStatus;
     }
 
@@ -399,8 +381,7 @@ 
      * @param string
      * @return void
      */
-    public function setTransferStatus($transferStatus)
-    {
+    public function setTransferStatus($transferStatus) {
         $this->transferStatus = $transferStatus;
     }
 
@@ -409,8 +390,7 @@ 
      *
      * @return integer
      */
-    public function getTransferDate()
-    {
+    public function getTransferDate() {
         return $this->transferDate;
     }
 
@@ -420,8 +400,7 @@ 
      * @param integer $transferDate
      * @return void
      */
-    public function setTransferDate($transferDate)
-    {
+    public function setTransferDate($transferDate) {
         $this->transferDate = $transferDate;
     }
 
@@ -430,8 +409,7 @@ 
      *
      * @var integer
      */
-    public function getTransferErrorCode()
-    {
+    public function getTransferErrorCode() {
         return $this->transferErrorCode;
     }
 
@@ -441,8 +419,7 @@ 
      * @param integer $transferErrorCode
      * @return void
      */
-    public function setTransferErrorCode($transferErrorCode)
-    {
+    public function setTransferErrorCode($transferErrorCode) {
         $this->transferErrorCode = $transferErrorCode;
     }
 
@@ -451,8 +428,7 @@ 
      *
      * @var string
      */
-    public function getTransferResponse()
-    {
+    public function getTransferResponse() {
         return $this->transferResponse;
     }
 
@@ -462,8 +438,7 @@ 
      * @param string $transferResponse
      * @return void
      */
-    public function setTransferResponse($transferResponse)
-    {
+    public function setTransferResponse($transferResponse) {
         $this->transferResponse = $transferResponse;
     }
 
@@ -472,8 +447,7 @@ 
      *
      * @var integer
      */
-    public function getTransferHttpStatus()
-    {
+    public function getTransferHttpStatus() {
         return $this->transferHttpStatus;
     }
 
@@ -483,8 +457,7 @@ 
      * @param integer $transferHttpStatus
      * @return void
      */
-    public function setTransferHttpStatus($transferHttpStatus)
-    {
+    public function setTransferHttpStatus($transferHttpStatus) {
         $this->transferHttpStatus = $transferHttpStatus;
     }
 
@@ -494,8 +467,7 @@ 
      * @param \EWW\Dpf\Domain\Model\File $file
      * @return void
      */
-    public function addFile(\EWW\Dpf\Domain\Model\File $file)
-    {
+    public function addFile(\EWW\Dpf\Domain\Model\File $file) {
         $this->file->attach($file);
     }
 
@@ -505,8 +477,7 @@ 
      * @param \EWW\Dpf\Domain\Model\File $fileToRemove The File to be removed
      * @return void
      */
-    public function removeFile(\EWW\Dpf\Domain\Model\File $fileToRemove)
-    {
+    public function removeFile(\EWW\Dpf\Domain\Model\File $fileToRemove) {
         $this->file->detach($fileToRemove);
     }
 
@@ -515,8 +486,7 @@ 
      *
      * @return \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\File> $file
      */
-    public function getFile()
-    {
+    public function getFile() {
         return $this->file;
     }
 
@@ -526,8 +496,7 @@ 
      * @param \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\File> $file
      * @return void
      */
-    public function setFile(\TYPO3\CMS\Extbase\Persistence\ObjectStorage $file)
-    {
+    public function setFile(\TYPO3\CMS\Extbase\Persistence\ObjectStorage $file) {
         $this->file = $file;
     }
 
@@ -536,8 +505,7 @@ 
      *
      * @return array
      */
-    public function getFileData()
-    {
+    public function getFileData() {
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
@@ -587,8 +555,7 @@ 
      *
      * @return array
      */
-    public function getCurrentFileData()
-    {
+    public function getCurrentFileData() {
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
@@ -636,8 +603,7 @@ 
      *
      * @return boolean $changed
      */
-    public function getChanged()
-    {
+    public function getChanged() {
         return $this->changed;
     }
 
@@ -647,8 +613,7 @@ 
      * @param boolean $changed
      * @return void
      */
-    public function setChanged($changed)
-    {
+    public function setChanged($changed) {
         $this->changed = boolval($changed);
     }
 
@@ -657,8 +622,7 @@ 
      *
      * @return boolean $valid
      */
-    public function getValid()
-    {
+    public function getValid() {
         return $this->valid;
     }
 
@@ -668,8 +632,7 @@ 
      * @param boolean $valid
      * @return void
      */
-    public function setValid($valid)
-    {
+    public function setValid($valid) {
         $this->valid = boolval($valid);
     }
 
@@ -678,8 +641,7 @@ 
      *
      * @return string
      */
-    public function getDateIssued()
-    {
+    public function getDateIssued() {
         return empty($this->dateIssued) ? '' : $this->dateIssued;
     }
 
@@ -689,8 +651,7 @@ 
      * @param string $dateIssued
      * @return void
      */
-    public function setDateIssued($dateIssued)
-    {
+    public function setDateIssued($dateIssued) {
         $this->dateIssued = empty($dateIssued) ? '' : $dateIssued;
     }
 
@@ -700,8 +661,7 @@ 
      *
      * @return string
      */
-    public function getProcessNumber()
-    {
+    public function getProcessNumber() {
         return $this->processNumber;
     }
 
@@ -711,8 +671,7 @@ 
      * @param string $processNumber
      * @return void
      */
-    public function setProcessNumber($processNumber)
-    {
+    public function setProcessNumber($processNumber) {
         $this->processNumber = trim($processNumber);
     }
 
@@ -721,8 +680,7 @@ 
      *
      * @return string
      */
-    public function getSubmitterName()
-    {
+    public function getSubmitterName() {
         try {
             $internalFormat = new InternalFormat($this->getXmlData(), $this->getPid());
             return $internalFormat->getSubmitterName();
@@ -736,8 +694,7 @@ 
      *
      * @return string
      */
-    public function getPrimaryUrn()
-    {
+    public function getPrimaryUrn() {
         $internalFormat = new InternalFormat($this->getXmlData(), $this->getPid());
         return $internalFormat->getPrimaryUrn();
     }
@@ -747,8 +704,7 @@ 
      *
      * @return int
      */
-    public function getCreator()
-    {
+    public function getCreator() {
         return $this->creator? $this->creator : 0;
     }
 
@@ -758,24 +714,20 @@ 
      * @param int $creator
      * @return void
      */
-    public function setCreator($creator)
-    {
+    public function setCreator($creator) {
         $this->creator = $creator;
     }
 
-    public function getState()
-    {
+    public function getState() {
         return $this->state;
     }
 
-    public function setState($state)
-    {
+    public function setState($state) {
         $this->stateChange = $this->state != $state;
         $this->state = $state;
     }
 
-    public function getRemoteState()
-    {
+    public function getRemoteState() {
         $state = explode(':', $this->state);
         if (is_array($state) && array_key_exists(1, $state)) {
             return $state[1];
@@ -813,8 +765,7 @@ 
     /**
      * @return string
      */
-    public function getRemoteLastModDate()
-    {
+    public function getRemoteLastModDate() {
         return $this->remoteLastModDate;
     }
 
@@ -822,24 +773,21 @@ 
      * @param string $remoteLastModDate
      * @return void
      */
-    public function setRemoteLastModDate($remoteLastModDate)
-    {
+    public function setRemoteLastModDate($remoteLastModDate) {
         $this->remoteLastModDate = $remoteLastModDate;
     }
 
     /**
      * @return integer
      */
-    public function getTstamp()
-    {
+    public function getTstamp() {
         return $this->tstamp;
     }
 
     /**
      * @return integer
      */
-    public function getPid()
-    {
+    public function getPid() {
         return $this->pid;
     }
 
@@ -854,8 +802,7 @@ 
     /**
      * @param bool $suggestion
      */
-    public function setSuggestion(bool $suggestion)
-    {
+    public function setSuggestion(bool $suggestion) {
         $this->suggestion = boolval($suggestion);
     }
 
@@ -870,8 +817,7 @@ 
     /**
      * @param string $linkedUid
      */
-    public function setLinkedUid(string $linkedUid)
-    {
+    public function setLinkedUid(string $linkedUid) {
         $this->linkedUid = $linkedUid;
     }
 
@@ -886,8 +832,7 @@ 
     /**
      * @param string $comment
      */
-    public function setComment(string $comment)
-    {
+    public function setComment(string $comment) {
         $this->comment = $comment;
     }
 
@@ -924,8 +869,7 @@ 
      *
      * @return string|int
      */
-    public function getDocumentIdentifier()
-    {
+    public function getDocumentIdentifier() {
         return $this->getObjectIdentifier()? $this->getObjectIdentifier() : $this->getUid();
     }
 
@@ -934,8 +878,7 @@ 
      *
      * @return bool
      */
-    public function isWorkingCopy()
-    {
+    public function isWorkingCopy() {
         return $this->getObjectIdentifier() && !$this->isTemporary() && !$this->isSuggestion();
     }
 
@@ -945,8 +888,7 @@ 
      *
      * @return bool
      */
-    public function isTemporaryCopy()
-    {
+    public function isTemporaryCopy() {
         return $this->getObjectIdentifier() && $this->isTemporary() && !$this->isSuggestion();
     }
 
@@ -956,8 +898,7 @@ 
      *
      * @return string|null
      */
-    public function getPublicationYear()
-    {
+    public function getPublicationYear() {
         $internalFormat = new InternalFormat($this->getXmlData(), $this->getPid());
         $year =  $internalFormat->getPublishingYear();
         return $year? $year : "";
@@ -968,8 +909,7 @@ 
      *
      * @return string|null
      */
-    public function getSourceDetails()
-    {
+    public function getSourceDetails() {
         $internalFormat = new InternalFormat($this->getXmlData(), $this->getPid());
         $data = $internalFormat->getSourceDetails();
         return $data;
@@ -986,8 +926,7 @@ 
     /**
      * @param \DateTime|null $embargoDate
      */
-    public function setEmbargoDate(?\DateTime $embargoDate)
-    {
+    public function setEmbargoDate(?\DateTime $embargoDate) {
         $this->embargoDate = $embargoDate;
     }
 
@@ -1010,8 +949,7 @@ 
     /**
      * @return array
      */
-    public function getPreviouslyAssignedFobIdentifiers()
-    {
+    public function getPreviouslyAssignedFobIdentifiers() {
         return array_diff(
             $this->getAssignedFobIdentifiers(), $this->getNewlyAssignedFobIdentifiers()
         );
@@ -1037,8 +975,7 @@ 
     /**
      * @return mixed
      */
-    public function getDepositLicense()
-    {
+    public function getDepositLicense() {
         $internalFormat = new InternalFormat($this->getXmlData(), $this->getPid());
         $data = $internalFormat->getDepositLicense();
         return $data;
@@ -1081,8 +1018,7 @@ 
     /**
      * @return bool
      */
-    public function isClientChangeable()
-    {
+    public function isClientChangeable() {
         return (
             in_array(
                 $this->getState(),

Classes/Controller/BackendAdminController.php

Spacing +2 added lines, -2 removed lines

@@ -338,13 +338,13 @@
     )
     {
         $messageHeader = LocalizationUtility::translate(
-            'LLL:EXT:dpf/Resources/Private/Language/locallang_mod.xlf:admin_module.'.$headerKey,
+            'LLL:EXT:dpf/Resources/Private/Language/locallang_mod.xlf:admin_module.' . $headerKey,
             'dpf',
             $headerArguments
         );
 
         $messageBody = LocalizationUtility::translate(
-            'LLL:EXT:dpf/Resources/Private/Language/locallang_mod.xlf:admin_module.'.$bodyKey,
+            'LLL:EXT:dpf/Resources/Private/Language/locallang_mod.xlf:admin_module.' . $bodyKey,
             'dpf',
             $bodyArguments
         );

Indentation +30 added lines, -30 removed lines

@@ -83,10 +83,10 @@ 
     protected $clientRepository = null;
 
     /**
-    * Backend Template Container
-    *
-    * @var string
-    */
+     * Backend Template Container
+     *
+     * @var string
+     */
     protected $defaultViewObjectName = BackendTemplateView::class;
 
     /**
@@ -267,25 +267,25 @@ 
                 $targetElasticSearch->index($document);
 
                 $this->flashMessage(
-                   'client_changed',
-                   'client_changed_message',
-                   AbstractMessage::OK,
-                   [],
-                   [$identifier]
+                    'client_changed',
+                    'client_changed_message',
+                    AbstractMessage::OK,
+                    [],
+                    [$identifier]
                 );
-           } else {
-               $this->flashMessage(
-                   'change_client_forbidden',
-                   'change_client_forbidden_message',
-                   AbstractMessage::ERROR,
-                   [],
-                   [$identifier]
-               );
-           }
-
-           $this->view->assign('currentClient', $client);
-           $this->view->assign('document', $document);
-       } else {
+            } else {
+                $this->flashMessage(
+                    'change_client_forbidden',
+                    'change_client_forbidden_message',
+                    AbstractMessage::ERROR,
+                    [],
+                    [$identifier]
+                );
+            }
+
+            $this->view->assign('currentClient', $client);
+            $this->view->assign('document', $document);
+        } else {
             $this->flashMessage(
                 'missing_document_type',
                 'missing_document_type_message',
@@ -295,15 +295,15 @@ 
             );
 
             $this->forward(
-              'chooseNewClient',
-              null,
-              null,
-              [
-                  'document' => $document,
-                  'identifier' => $identifier
-              ]
+                'chooseNewClient',
+                null,
+                null,
+                [
+                    'document' => $document,
+                    'identifier' => $identifier
+                ]
             );
-       }
+        }
     }
 
     /**

Braces +6 added lines, -12 removed lines

@@ -32,8 +32,7 @@ 
 /**
 * Backend module user/group action controller
 */
-class BackendAdminController extends ActionController
-{
+class BackendAdminController extends ActionController {
     /**
      * documentRepository
      *
@@ -95,8 +94,7 @@ 
      * @param ViewInterface $view
      * @return void
      */
-    protected function initializeView(ViewInterface $view)
-    {
+    protected function initializeView(ViewInterface $view) {
         /** @var BackendTemplateView $view */
         parent::initializeView($view);
         if ($this->actionMethodName == 'indexAction'
@@ -114,8 +112,7 @@ 
     /**
      * @param string $identifier
      */
-    public function searchDocumentAction(string $identifier = '')
-    {
+    public function searchDocumentAction(string $identifier = '') {
         $identifier = trim($identifier);
         $this->view->assign('identifier', $identifier);
 
@@ -153,8 +150,7 @@ 
      * @param Document $document
      * @param string $identifier
      */
-    public function chooseNewClientAction(Document $document, string $identifier)
-    {
+    public function chooseNewClientAction(Document $document, string $identifier) {
         if ($document) {
             if ($document->isClientChangeable()) {
                 /** @var Client $currentClient */
@@ -207,8 +203,7 @@ 
      * @param string $identifier
      * @param DocumentType $documentType
      */
-    public function changeClientAction(Document $document, Client $client, string $identifier, DocumentType $documentType = null)
-    {
+    public function changeClientAction(Document $document, Client $client, string $identifier, DocumentType $documentType = null) {
         if ($documentType instanceof DocumentType) {
             if ($document->isClientChangeable()) {
 
@@ -323,8 +318,7 @@ 
         array $headerArguments,
         array $bodyArguments,
         bool $storeInSession = false
-    )
-    {
+    ) {
         $messageHeader = LocalizationUtility::translate(
             'LLL:EXT:dpf/Resources/Private/Language/locallang_mod.xlf:admin_module.'.$headerKey,
             'dpf',

Upper-Lower-Casing +16 added lines, -16 removed lines

@@ -40,7 +40,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentRepository = null;
+    protected $documentRepository = NULL;
 
     /**
      * fileRepository
@@ -48,7 +48,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\FileRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $fileRepository = null;
+    protected $fileRepository = NULL;
 
     /**
      * documentTypeRepository
@@ -56,7 +56,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentTypeRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentTypeRepository = null;
+    protected $documentTypeRepository = NULL;
 
     /**
      * bookmarkRepository
@@ -64,7 +64,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\BookmarkRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $bookmarkRepository = null;
+    protected $bookmarkRepository = NULL;
 
     /**
      * frontendUserRepository
@@ -72,7 +72,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\FrontendUserRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $frontendUserRepository = null;
+    protected $frontendUserRepository = NULL;
 
     /**
      * clientRepository
@@ -80,7 +80,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\ClientRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $clientRepository = null;
+    protected $clientRepository = NULL;
 
     /**
     * Backend Template Container
@@ -121,7 +121,7 @@ 
 
         if ($identifier) {
 
-            $this->documentRepository->crossClient(true);
+            $this->documentRepository->crossClient(TRUE);
 
             $documents = $this->documentRepository->searchForIdentifier($identifier);
 
@@ -160,7 +160,7 @@ 
                 /** @var Client $currentClient */
                 $currentClient = $this->clientRepository->findAllByPid($document->getPid())->current();
 
-                $allClients = $this->clientRepository->crossClientFindAll(false);
+                $allClients = $this->clientRepository->crossClientFindAll(FALSE);
 
                 $documentTypes = [];
                 $clients = [];
@@ -169,7 +169,7 @@ 
                 foreach ($allClients as $client) {
                     if ($client->getUid() != $currentClient->getUid()) {
                         $clients[] = $client;
-                        $this->documentTypeRepository->crossClient(true);
+                        $this->documentTypeRepository->crossClient(TRUE);
                         $documentTypes[$client->getPid()] = $this->documentTypeRepository->findByPid($client->getPid());
                     }
                 }
@@ -191,8 +191,8 @@ 
 
                 $this->forward(
                     'searchDocument',
-                    null,
-                    null,
+                    NULL,
+                    NULL,
                     [
                         'identifier' => $identifier
                     ]
@@ -207,7 +207,7 @@ 
      * @param string $identifier
      * @param DocumentType $documentType
      */
-    public function changeClientAction(Document $document, Client $client, string $identifier, DocumentType $documentType = null)
+    public function changeClientAction(Document $document, Client $client, string $identifier, DocumentType $documentType = NULL)
     {
         if ($documentType instanceof DocumentType) {
             if ($document->isClientChangeable()) {
@@ -248,7 +248,7 @@ 
 
                 // If there are bookmarks, they have to be adjusted, depending on the existence of the related user
                 // inside the target client, and either deleted or moved to the target client.
-                $this->bookmarkRepository->crossClient(true);
+                $this->bookmarkRepository->crossClient(TRUE);
                 $bookmarks = $this->bookmarkRepository->findDocumentBookmarks($document);
                 /** @var Bookmark $bookmark */
                 foreach ($bookmarks as $bookmark) {
@@ -296,8 +296,8 @@ 
 
             $this->forward(
               'chooseNewClient',
-              null,
-              null,
+              NULL,
+              NULL,
               [
                   'document' => $document,
                   'identifier' => $identifier
@@ -322,7 +322,7 @@ 
         int $severity = AbstractMessage::INFO,
         array $headerArguments,
         array $bodyArguments,
-        bool $storeInSession = false
+        bool $storeInSession = FALSE
     )
     {
         $messageHeader = LocalizationUtility::translate(

Classes/Exceptions/ElasticSearchMissingIndexNameException.php

Braces +2 added lines, -4 removed lines

@@ -14,10 +14,8 @@
  * The TYPO3 project - inspiring people to share!
  */
 
-class ElasticSearchMissingIndexNameException extends \Exception implements DPFExceptionInterface
-{
-    public function messageLanguageKey()
-    {
+class ElasticSearchMissingIndexNameException extends \Exception implements DPFExceptionInterface {
+    public function messageLanguageKey() {
         return 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:document_transfer.elasticsearch_indexname_error';
     }
 }

Classes/Services/ElasticSearch/ElasticSearch.php

Spacing +2 added lines, -2 removed lines

@@ -82,7 +82,7 @@ 
             throw new ElasticSearchMissingIndexNameException('Missing search index name.');
         }
 
-        $hosts = array(
+        $hosts = array (
             $this->server . ':' . $this->port,
         );
 
@@ -310,7 +310,7 @@ 
             if ($notes && is_array($notes)) {
                 $data->notes = $notes;
             } else {
-                $data->notes = array();
+                $data->notes = array ();
             }
 
             $files = $document->getFile();

Braces +9 added lines, -18 removed lines

@@ -28,8 +28,7 @@ 
 use TYPO3\CMS\Core\Log\LogManager;
 use TYPO3\CMS\Extbase\Utility\LocalizationUtility;
 
-class ElasticSearch
-{
+class ElasticSearch {
     /**
      * @var \EWW\Dpf\Configuration\ClientConfigurationManager
      */
@@ -61,8 +60,7 @@ 
      * @param int|null $clientPid
      * @throws ElasticSearchMissingIndexNameException
      */
-    public function __construct($clientPid = null)
-    {
+    public function __construct($clientPid = null) {
         $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
 
         $this->elasticsearchMapper = $objectManager->get(ElasticsearchMapper::class);
@@ -103,8 +101,7 @@ 
     /**
      * @return string|null
      */
-    protected function getIndexName()
-    {
+    protected function getIndexName() {
         return $this->indexName;
     }
 
@@ -113,8 +110,7 @@ 
      *
      * @param $indexName
      */
-    protected function initializeIndex($indexName)
-    {
+    protected function initializeIndex($indexName) {
         $paramsIndex = [
             'index' => $indexName,
             'body' => [
@@ -252,8 +248,7 @@ 
      *
      * @param Document $document
      */
-    public function index($document)
-    {
+    public function index($document) {
         try {
             $data = json_decode($this->elasticsearchMapper->getElasticsearchJson($document));
         } catch (\Throwable $throwable) {
@@ -391,8 +386,7 @@ 
      *
      * @param string $identifier
      */
-    public function delete($identifier)
-    {
+    public function delete($identifier) {
         try {
 
             $params = [
@@ -418,8 +412,7 @@ 
     /**
      * @param $identifier
      */
-    public function getDocument($identifier)
-    {
+    public function getDocument($identifier) {
         $params = [
             'index' => $this->getIndexName(),
             'id'    => $identifier
@@ -434,8 +427,7 @@ 
      * @param  array $query search query
      * @return array        result list
      */
-    public function search($query, $type = null)
-    {
+    public function search($query, $type = null) {
         try {
             // define type and index
             if (empty($query['index'])) {
@@ -467,8 +459,7 @@ 
      * Get the results
      * @return mixed
      */
-    public function getResults()
-    {
+    public function getResults() {
         // return results from the last search request
         return $this->results;
     }

Upper-Lower-Casing +11 added lines, -11 removed lines

@@ -61,7 +61,7 @@ 
      * @param int|null $clientPid
      * @throws ElasticSearchMissingIndexNameException
      */
-    public function __construct($clientPid = null)
+    public function __construct($clientPid = NULL)
     {
         $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
 
@@ -152,7 +152,7 @@ 
                 ],
                 'mappings' => [
                     '_source' => [
-                        'enabled' => true
+                        'enabled' => TRUE
                     ],
                     //'dynamic' => 'strict',
                     'properties' => [
@@ -215,11 +215,11 @@ 
                                 ],
                                 'fobId' => [
                                     //'type' => 'keyword'
-                                    'enabled' => false
+                                    'enabled' => FALSE
                                 ],
                                 'index' => [
                                     //'type' => 'integer'
-                                    'enabled' => false
+                                    'enabled' => FALSE
                                 ]
                             ]
                         ],
@@ -281,7 +281,7 @@ 
             if ($document->getCreator()) {
                 $data->creator = $document->getCreator();
             } else {
-                $data->creator = null;
+                $data->creator = NULL;
             }
 
             if ($document->getCreator()) {
@@ -315,9 +315,9 @@ 
 
             $files = $document->getFile();
             if ($files->count() > 0) {
-                $data->hasFiles = true;
+                $data->hasFiles = TRUE;
             } else {
-                $data->hasFiles = false;
+                $data->hasFiles = FALSE;
             }
 
             $internalFormat = new \EWW\Dpf\Helper\InternalFormat($document->getXmlData(), $this->clientPid);
@@ -353,11 +353,11 @@ 
 
             $data->source = $document->getSourceDetails();
 
-            $data->universityCollection = false;
+            $data->universityCollection = FALSE;
             if ($data->collections && is_array($data->collections)) {
                 foreach ($data->collections as $collection) {
                     if ($collection == $this->clientConfigurationManager->getUniversityCollection()) {
-                        $data->universityCollection = true;
+                        $data->universityCollection = TRUE;
                         break;
                     }
                 }
@@ -367,7 +367,7 @@ 
             if ($embargoDate instanceof \DateTime) {
                 $data->embargoDate = $embargoDate->format("Y-m-d");
             } else {
-                $data->embargoDate = null;
+                $data->embargoDate = NULL;
             }
 
             $data->originalSourceTitle = $internalFormat->getOriginalSourceTitle();
@@ -434,7 +434,7 @@ 
      * @param  array $query search query
      * @return array        result list
      */
-    public function search($query, $type = null)
+    public function search($query, $type = NULL)
     {
         try {
             // define type and index

Classes/Services/ElasticSearch/QueryBuilder.php

Spacing +38 added lines, -38 removed lines

@@ -122,7 +122,7 @@ 
             $query = [
                 'bool' => [
                     'must' => [
-                        'match_all' => (object)[]
+                        'match_all' => (object) []
                     ],
                     'filter' => $queryFilter
                 ]
@@ -164,12 +164,12 @@ 
                             'script' => [
                                 'lang' => 'painless',
                                 'source' =>
-                                    "for (int i = 0; i < doc['collections'].length; ++i) {".
-                                    "    if(doc['collections'][i] =='".
-                                    $this->clientConfigurationManager->getUniversityCollection() ."') {".
-                                    "        return 'true';".
-                                    "    }".
-                                    "}".
+                                    "for (int i = 0; i < doc['collections'].length; ++i) {" .
+                                    "    if(doc['collections'][i] =='" .
+                                    $this->clientConfigurationManager->getUniversityCollection() . "') {" .
+                                    "        return 'true';" .
+                                    "    }" .
+                                    "}" .
                                     "return 'false';"
                             ]
                         ]
@@ -185,23 +185,23 @@ 
                             'script' => [
                                 'lang' => 'painless',
                                 'source' =>
-                                    "if (".
-                                    "    doc['creator'].size() > 0 &&".
-                                    "    doc['creator'].value == '".$this->security->getUser()->getUid()."') {".
-                                    "    return 'self';".
-                                    "}".
-                                    "if (".
-                                    "    doc['creatorRole'].size() > 0 &&".
-                                    "    doc['creatorRole'].value == '".Security::ROLE_LIBRARIAN."'".
-                                    ") {".
-                                    "    return 'librarian';".
-                                    "}".
-                                    "if (".
-                                    "    doc['creatorRole'].size() > 0 &&".
-                                    "    doc['creatorRole'].value == '".Security::ROLE_RESEARCHER."'".
-                                    ") {".
-                                    "    return 'user';".
-                                    "}".
+                                    "if (" .
+                                    "    doc['creator'].size() > 0 &&" .
+                                    "    doc['creator'].value == '" . $this->security->getUser()->getUid() . "') {" .
+                                    "    return 'self';" .
+                                    "}" .
+                                    "if (" .
+                                    "    doc['creatorRole'].size() > 0 &&" .
+                                    "    doc['creatorRole'].value == '" . Security::ROLE_LIBRARIAN . "'" .
+                                    ") {" .
+                                    "    return 'librarian';" .
+                                    "}" .
+                                    "if (" .
+                                    "    doc['creatorRole'].size() > 0 &&" .
+                                    "    doc['creatorRole'].value == '" . Security::ROLE_RESEARCHER . "'" .
+                                    ") {" .
+                                    "    return 'user';" .
+                                    "}" .
                                     "return 'unknown';"
                             ]
                         ]
@@ -414,8 +414,8 @@ 
      */
     protected function buildSortQueryPart($sortField, $sortOrder) {
 
-        $sortField = ($sortField)? $sortField : 'title';
-        $sortOrder = ($sortOrder)? $sortOrder : 'asc';
+        $sortField = ($sortField) ? $sortField : 'title';
+        $sortOrder = ($sortOrder) ? $sortOrder : 'asc';
 
         // Build the sorting part.
         $script = "";
@@ -446,11 +446,11 @@ 
             ];
         } else {
             if ($sortField == 'title') {
-                $sortField.= ".keyword";
+                $sortField .= ".keyword";
             }
 
             if ($sortField == 'personsSort') {
-                $sortField.= ".keyword";
+                $sortField .= ".keyword";
             }
 
             $sort = [
@@ -467,7 +467,7 @@ 
     protected function getSortScriptUniversityCollection($collection)
     {
         $script  = "for (int i = 0; i < doc['collections'].length; ++i) {";
-        $script .= "    if (doc['collections'][i] == '".$collection."') {";
+        $script .= "    if (doc['collections'][i] == '" . $collection . "') {";
         $script .= "        return '1';";
         $script .= "    }";
         $script .= "}";
@@ -488,13 +488,13 @@ 
 
     protected function getSortScriptCreatorRole($feUserUid)
     {
-        $script = "if (doc['creator'].value == '".$feUserUid."') {";
+        $script = "if (doc['creator'].value == '" . $feUserUid . "') {";
         $script .= "    return '1';";
         $script .= "}";
-        $script .= "if (doc['creatorRole'].value == '".Security::ROLE_LIBRARIAN."') {";
+        $script .= "if (doc['creatorRole'].value == '" . Security::ROLE_LIBRARIAN . "') {";
         $script .= "return '2';";
         $script .= "}";
-        $script .= "if (doc['creatorRole'].value == '".Security::ROLE_RESEARCHER."') {";
+        $script .= "if (doc['creatorRole'].value == '" . Security::ROLE_RESEARCHER . "') {";
         $script .= "    return '3';";
         $script .= "}";
         $script .= "return '4';";
@@ -509,15 +509,15 @@ 
         foreach (DocumentWorkflow::PLACES as $state) {
             if (array_key_exists($state, DocumentWorkflow::STATE_TO_ALIASSTATE_MAPPING)) {
                 $aliasState = DocumentWorkflow::STATE_TO_ALIASSTATE_MAPPING[$state];
-                $key = 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:manager.documentList.state.'.$aliasState;
+                $key = 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:manager.documentList.state.' . $aliasState;
                 $stateName = LocalizationUtility::translate($key, 'dpf');
-                $sortStates[] = "if (doc['state'].value == '".$state."') return '".$stateName."';";
+                $sortStates[] = "if (doc['state'].value == '" . $state . "') return '" . $stateName . "';";
             }
         }
 
         $sortStates = implode(" ", $sortStates);
 
-        return $sortStates." return '';";
+        return $sortStates . " return '';";
     }
 
 
@@ -526,14 +526,14 @@ 
         $sortDoctypes = [];
         foreach ($this->documentTypeRepository->findAll() as $documentType) {
             if ($documentType->getName() && $documentType->getDisplayname()) {
-                $sortDoctypes[] = "if (doc['doctype'].value == '".$documentType->getName()."')"
-                    ." return '".$documentType->getDisplayname()."';";
+                $sortDoctypes[] = "if (doc['doctype'].value == '" . $documentType->getName() . "')"
+                    ." return '" . $documentType->getDisplayname() . "';";
             }
         }
 
         $sortDoctypes = implode(" ", $sortDoctypes);
 
-        return $sortDoctypes." return '';";
+        return $sortDoctypes . " return '';";
     }
 
 }

Braces +7 added lines, -14 removed lines

@@ -19,8 +19,7 @@ 
 use EWW\Dpf\Security\Security;
 use TYPO3\CMS\Extbase\Utility\LocalizationUtility;
 
-class QueryBuilder
-{
+class QueryBuilder {
     /**
      *
      * @var \EWW\Dpf\Configuration\ClientConfigurationManager
@@ -62,8 +61,7 @@ 
     public function buildQuery(
         $itemsPerPage, $workspaceFilter, $from = 0, $bookmarkIdentifiers = [], $filters = [],
         $excludeFilters = [], $sortField = null, $sortOrder = null, $queryString = null
-    )
-    {
+    ) {
 
         if ($workspaceFilter) {
             $workspaceFilter = [0 => $workspaceFilter];
@@ -464,8 +462,7 @@ 
     }
 
 
-    protected function getSortScriptUniversityCollection($collection)
-    {
+    protected function getSortScriptUniversityCollection($collection) {
         $script  = "for (int i = 0; i < doc['collections'].length; ++i) {";
         $script .= "    if (doc['collections'][i] == '".$collection."') {";
         $script .= "        return '1';";
@@ -476,8 +473,7 @@ 
         return $script;
     }
 
-    protected function getSortScriptHasFiles()
-    {
+    protected function getSortScriptHasFiles() {
         $script = "if (doc['hasFiles'].value == 'true') {";
         $script .= "    return '1';";
         $script .= "}";
@@ -486,8 +482,7 @@ 
         return $script;
     }
 
-    protected function getSortScriptCreatorRole($feUserUid)
-    {
+    protected function getSortScriptCreatorRole($feUserUid) {
         $script = "if (doc['creator'].value == '".$feUserUid."') {";
         $script .= "    return '1';";
         $script .= "}";
@@ -503,8 +498,7 @@ 
     }
 
 
-    protected function getSortScriptState()
-    {
+    protected function getSortScriptState() {
         $sortStates = [];
         foreach (DocumentWorkflow::PLACES as $state) {
             if (array_key_exists($state, DocumentWorkflow::STATE_TO_ALIASSTATE_MAPPING)) {
@@ -521,8 +515,7 @@ 
     }
 
 
-    protected function getSortScriptDoctype()
-    {
+    protected function getSortScriptDoctype() {
         $sortDoctypes = [];
         foreach ($this->documentTypeRepository->findAll() as $documentType) {
             if ($documentType->getName() && $documentType->getDisplayname()) {

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -34,7 +34,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentTypeRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentTypeRepository = null;
+    protected $documentTypeRepository = NULL;
 
     /**
      * security
@@ -42,7 +42,7 @@ 
      * @var \EWW\Dpf\Security\Security
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $security = null;
+    protected $security = NULL;
 
     /**
      * Builds the document list query.
@@ -61,7 +61,7 @@ 
      */
     public function buildQuery(
         $itemsPerPage, $workspaceFilter, $from = 0, $bookmarkIdentifiers = [], $filters = [],
-        $excludeFilters = [], $sortField = null, $sortOrder = null, $queryString = null
+        $excludeFilters = [], $sortField = NULL, $sortOrder = NULL, $queryString = NULL
     )
     {
 
@@ -238,7 +238,7 @@ 
 
             foreach ($filters as $key => $filterValues) {
                 $queryFilterPart = [];
-                if (in_array($key, $validKeys, true)) {
+                if (in_array($key, $validKeys, TRUE)) {
                     if ($key == 'universityCollection') {
                         if ($filterValues && is_array($filterValues)) {
                             if (in_array("true", $filterValues)) {

Classes/Services/ParserGenerator.php

Braces +10 added lines, -20 removed lines

@@ -23,8 +23,7 @@ 
 /**
  * ParserGenerator
  */
-class ParserGenerator
-{
+class ParserGenerator {
     /**
      * clientConfigurationManager
      *
@@ -93,8 +92,7 @@ 
      * ParserGenerator constructor.
      * @param int $clientPid
      */
-    public function __construct($clientPid = 0)
-    {
+    public function __construct($clientPid = 0) {
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $this->clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);
 
@@ -128,16 +126,14 @@ 
      * returns the mods xml string
      * @return string mods xml
      */
-    public function getXMLData()
-    {
+    public function getXMLData() {
         $xml = $this->xmlData->saveXML();
         $xml = preg_replace("/eww=\"\d-\d-\d\"/", '${1}${2}${3}', $xml);
 
         return $xml;
     }
 
-    public function transformInputXML($xml)
-    {
+    public function transformInputXML($xml) {
         $XSLTransformator = new XSLTransformator();
         return $XSLTransformator->transformInputXML($xml);
     }
@@ -146,8 +142,7 @@ 
      * @param $document
      * @return string The transformed xml
      */
-    public function getTransformedOutputXML($document)
-    {
+    public function getTransformedOutputXML($document) {
         $XSLTransformator = new XSLTransformator();
         return $XSLTransformator->getTransformedOutputXML($document);
     }
@@ -157,8 +152,7 @@ 
      * build mods from form array
      * @param array $array structured form data array
      */
-    public function buildXmlFromForm($array)
-    {
+    public function buildXmlFromForm($array) {
         $fedoraNamespace = $this->clientConfigurationManager->getFedoraNamespace();
 
         $this->xmlData = $this->xmlData;
@@ -241,8 +235,7 @@ 
      * @param  xpath $xPath xPath expression
      * @return xml
      */
-    public function parseXPath($xPath)
-    {
+    public function parseXPath($xPath) {
 
         $this->parser->generateXmlFromXPath($xPath);
         $xml = $this->parser->getXML();
@@ -250,8 +243,7 @@ 
         return $xml;
     }
 
-    public function parseXPathWrapped($xPath)
-    {
+    public function parseXPathWrapped($xPath) {
         $this->parser->generateXmlFromXPath($xPath);
         $xml = $this->parser->getXML();
 
@@ -266,8 +258,7 @@ 
      * @param  string $value form value
      * @return xml    created xml
      */
-    public function customXPath($xPath, $newGroupFlag = false, $value = '', $attributeOnly = false)
-    {
+    public function customXPath($xPath, $newGroupFlag = false, $value = '', $attributeOnly = false) {
         if (!$attributeOnly) {
             // Explode xPath
             $newPath = explode('%', $xPath);
@@ -466,8 +457,7 @@ 
      * sets the file data and generates file xml
      * @param string $value
      */
-    public function setFileData($value = '')
-    {
+    public function setFileData($value = '') {
         $this->files = $value;
         $this->generateFileXML();
     }

Classes/Domain/Repository/DocumentRepository.php

Spacing +10 added lines, -10 removed lines

@@ -46,7 +46,7 @@ 
             case Security::ROLE_RESEARCHER:
                 $query->matching(
                     $query->logicalAnd(
-                        array(
+                        array (
                             $query->equals('suggestion', true),
                             $query->equals('creator', $creatorUid)
                         )
@@ -65,7 +65,7 @@ 
     {
         $query = $this->createQuery();
 
-        $constraints = array(
+        $constraints = array (
             $query->logicalNot($query->equals('object_identifier', '')),
             $query->logicalNot($query->equals('object_identifier', null))
         );
@@ -84,7 +84,7 @@ 
 
         $result = $query->execute();
 
-        $objectIdentifiers = array();
+        $objectIdentifiers = array ();
 
         foreach ($result as $document) {
             $objectIdentifiers[$document->getObjectIdentifier()] = $document->getObjectIdentifier();
@@ -104,7 +104,7 @@ 
         $query = $this->createQuery();
         $query->getQuerySettings()->setRespectStoragePage(false);
 
-        $constraints = array();
+        $constraints = array ();
         $constraints[] = $query->equals('process_number', '');
         $constraints[] = $query->equals('process_number', null);
 
@@ -133,7 +133,7 @@ 
         $dateTimeObj = new \DateTime();
         $dateTimeObj->sub(new \DateInterval("PT" . $timeout . "S"));
 
-        $constraints = array();
+        $constraints = array ();
         $constraints[] = $query->lessThan('tstamp', $dateTimeObj->getTimestamp());
 
         $query->matching(
@@ -159,7 +159,7 @@ 
         $dateTimeObj = new \DateTime();
         $dateTimeObj->sub(new \DateInterval("PT" . $timeout . "S"));
 
-        $constraints = array();
+        $constraints = array ();
         $constraints[] = $query->lessThan('tstamp', $dateTimeObj->getTimestamp());
 
         $query->matching(
@@ -181,7 +181,7 @@ 
     {
         $query = $this->createQuery();
 
-        $constraints = array(
+        $constraints = array (
             $query->equals('object_identifier', $objectIdentifier),
             $query->logicalNot($query->equals('temporary', true)),
             $query->logicalNot($query->equals('suggestion', true))
@@ -222,7 +222,7 @@ 
             return null;
         }
 
-        $query->setOrderings(array("tstamp" => \TYPO3\CMS\Extbase\Persistence\QueryInterface::ORDER_DESCENDING));
+        $query->setOrderings(array ("tstamp" => \TYPO3\CMS\Extbase\Persistence\QueryInterface::ORDER_DESCENDING));
         $query->matching($query->logicalAnd($constraints));
 
         return $query->execute()->getFirst();
@@ -309,7 +309,7 @@ 
         $query = $this->createQuery();
         $query->matching(
             $query->logicalAnd(
-                array(
+                array (
                     $query->logicalNot(
                         $query->equals('embargo_date', 0)
                     )
@@ -347,7 +347,7 @@ 
                     $query->equals('suggestion', false)
                 );
 
-        $query->setOrderings(array("tstamp" => \TYPO3\CMS\Extbase\Persistence\QueryInterface::ORDER_DESCENDING));
+        $query->setOrderings(array ("tstamp" => \TYPO3\CMS\Extbase\Persistence\QueryInterface::ORDER_DESCENDING));
         $query->matching($query->logicalOr($constraints));
 
         return $query->execute();

Braces +13 added lines, -26 removed lines

@@ -22,8 +22,7 @@ 
 /**
  * The repository for Documents
  */
-class DocumentRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository
-{
+class DocumentRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository {
     /**
      * Finds all suggestion documents of the given user role filtered by creator feuser uid
      *
@@ -31,8 +30,7 @@ 
      * @param int $creatorUid
      * @return array|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
      */
-    public function findAllDocumentSuggestions($role, $creatorUid)
-    {
+    public function findAllDocumentSuggestions($role, $creatorUid) {
         $query = $this->createQuery();
 
         switch ($role) {
@@ -61,8 +59,7 @@ 
      * @param boolean $temporary
      * @return array
      */
-    public function getObjectIdentifiers($temporary = false)
-    {
+    public function getObjectIdentifiers($temporary = false) {
         $query = $this->createQuery();
 
         $constraints = array(
@@ -99,8 +96,7 @@ 
      *
      * @return array The found Document Objects
      */
-    public function findDocumentsWithoutProcessNumber()
-    {
+    public function findDocumentsWithoutProcessNumber() {
         $query = $this->createQuery();
         $query->getQuerySettings()->setRespectStoragePage(false);
 
@@ -126,8 +122,7 @@ 
      * @param integer $timeout : Time interval (in seconds) in which documents are not outdated.
      * @return array The found Document Objects
      */
-    public function findOutdatedTemporaryDocuments($timeout = 3600)
-    {
+    public function findOutdatedTemporaryDocuments($timeout = 3600) {
         $query = $this->createQuery();
 
         $dateTimeObj = new \DateTime();
@@ -152,8 +147,7 @@ 
      * @param integer $timeout : Time interval (in seconds) in which documents are not outdated.
      * @return array The found Document Objects
      */
-    public function findOutdatedLockedDocuments($timeout = 3600)
-    {
+    public function findOutdatedLockedDocuments($timeout = 3600) {
         $query = $this->createQuery();
 
         $dateTimeObj = new \DateTime();
@@ -177,8 +171,7 @@ 
      * @param string $objectIdentifier
      * @return array
      */
-    public function findWorkingCopyByObjectIdentifier($objectIdentifier)
-    {
+    public function findWorkingCopyByObjectIdentifier($objectIdentifier) {
         $query = $this->createQuery();
 
         $constraints = array(
@@ -196,8 +189,7 @@ 
      * @param string $identifier
      * @return Document
      */
-    public function findByIdentifier($identifier)
-    {
+    public function findByIdentifier($identifier) {
         $query = $this->createQuery();
 
         if (Identifier::isUid($identifier)) {
@@ -234,8 +226,7 @@ 
      * @param bool $includeSuggestion
      * @return Document
      */
-    public function findWorkingCopy($identifier, $includeTemporary = false, $includeSuggestion = false)
-    {
+    public function findWorkingCopy($identifier, $includeTemporary = false, $includeSuggestion = false) {
         $query = $this->createQuery();
 
         if (is_numeric($identifier)) {
@@ -261,8 +252,7 @@ 
      * @param object $modifiedObject The modified object
      * @throws \Exception
      */
-    public function update($modifiedObject)
-    {
+    public function update($modifiedObject) {
         /** @var Document $document */
         $document = $modifiedObject;
 
@@ -287,8 +277,7 @@ 
     }
 
 
-    public function updateCreator()
-    {
+    public function updateCreator() {
 
         $query = $this->createQuery();
         $query->statement("update tx_dpf_domain_model_document set creator = owner");
@@ -300,8 +289,7 @@ 
      * Finds all records with embargo date
      * @return mixed
      */
-    public function crossClientEmbargoFindAll()
-    {
+    public function crossClientEmbargoFindAll() {
         /** @var $querySettings \TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings */
         $querySettings = $this->objectManager->get('TYPO3\\CMS\\Extbase\\Persistence\\Generic\\Typo3QuerySettings');
         $querySettings->setRespectStoragePage(false);
@@ -323,8 +311,7 @@ 
      * @param string $identifier
      * @return array|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
      */
-    public function searchForIdentifier(string $identifier)
-    {
+    public function searchForIdentifier(string $identifier) {
         $identifier = str_replace("*", "%", $identifier);
 
         $query = $this->createQuery();

Upper-Lower-Casing +22 added lines, -22 removed lines

@@ -39,7 +39,7 @@ 
 
             case Security::ROLE_LIBRARIAN:
                 $query->matching(
-                    $query->equals('suggestion', true)
+                    $query->equals('suggestion', TRUE)
                 );
                 break;
 
@@ -47,7 +47,7 @@ 
                 $query->matching(
                     $query->logicalAnd(
                         array(
-                            $query->equals('suggestion', true),
+                            $query->equals('suggestion', TRUE),
                             $query->equals('creator', $creatorUid)
                         )
                     )
@@ -61,21 +61,21 @@ 
      * @param boolean $temporary
      * @return array
      */
-    public function getObjectIdentifiers($temporary = false)
+    public function getObjectIdentifiers($temporary = FALSE)
     {
         $query = $this->createQuery();
 
         $constraints = array(
             $query->logicalNot($query->equals('object_identifier', '')),
-            $query->logicalNot($query->equals('object_identifier', null))
+            $query->logicalNot($query->equals('object_identifier', NULL))
         );
 
         if (count($constraints)) {
             $constraints[] = $query->logicalAnd(
                 $query->logicalNot(
                     $query->logicalOr(
-                        $query->equals('temporary', true),
-                        $query->equals('suggestion', true)
+                        $query->equals('temporary', TRUE),
+                        $query->equals('suggestion', TRUE)
                     )
                 )
             );
@@ -102,16 +102,16 @@ 
     public function findDocumentsWithoutProcessNumber()
     {
         $query = $this->createQuery();
-        $query->getQuerySettings()->setRespectStoragePage(false);
+        $query->getQuerySettings()->setRespectStoragePage(FALSE);
 
         $constraints = array();
         $constraints[] = $query->equals('process_number', '');
-        $constraints[] = $query->equals('process_number', null);
+        $constraints[] = $query->equals('process_number', NULL);
 
         if (count($constraints)) {
             $query->matching(
                 $query->logicalAnd(
-                    $query->equals('temporary', false),
+                    $query->equals('temporary', FALSE),
                     $query->logicalOr($constraints)
                 )
             );
@@ -138,7 +138,7 @@ 
 
         $query->matching(
             $query->logicalAnd(
-                $query->equals('temporary', true),
+                $query->equals('temporary', TRUE),
                 $query->logicalOr($constraints)
             )
         );
@@ -183,8 +183,8 @@ 
 
         $constraints = array(
             $query->equals('object_identifier', $objectIdentifier),
-            $query->logicalNot($query->equals('temporary', true)),
-            $query->logicalNot($query->equals('suggestion', true))
+            $query->logicalNot($query->equals('temporary', TRUE)),
+            $query->logicalNot($query->equals('suggestion', TRUE))
         );
 
         $query->matching($query->logicalAnd($constraints));
@@ -208,18 +208,18 @@ 
             $constraints = [
                 $query->logicalAnd(
                     $query->equals('object_identifier', $identifier),
-                    $query->equals('suggestion', false)
+                    $query->equals('suggestion', FALSE)
                 )
             ];
         } elseif (Identifier::isProcessNumber($identifier)) {
             $constraints = [
                 $query->logicalAnd(
                     $query->equals('process_number', $identifier),
-                    $query->equals('suggestion', false)
+                    $query->equals('suggestion', FALSE)
                 )
             ];
         } else {
-            return null;
+            return NULL;
         }
 
         $query->setOrderings(array("tstamp" => \TYPO3\CMS\Extbase\Persistence\QueryInterface::ORDER_DESCENDING));
@@ -234,7 +234,7 @@ 
      * @param bool $includeSuggestion
      * @return Document
      */
-    public function findWorkingCopy($identifier, $includeTemporary = false, $includeSuggestion = false)
+    public function findWorkingCopy($identifier, $includeTemporary = FALSE, $includeSuggestion = FALSE)
     {
         $query = $this->createQuery();
 
@@ -269,8 +269,8 @@ 
         if (trim($document->getObjectIdentifier()) && !$document->isTemporary() && !$document->isSuggestion()) {
             $query = $this->createQuery();
             $constraints[] = $query->equals('object_identifier', trim($document->getObjectIdentifier()));
-            $constraints[] = $query->equals('temporary', false);
-            $constraints[] = $query->equals('suggestion', false);
+            $constraints[] = $query->equals('temporary', FALSE);
+            $constraints[] = $query->equals('suggestion', FALSE);
             $query->matching($query->logicalAnd($constraints));
 
             /** @var Document $workingCopy */
@@ -304,7 +304,7 @@ 
     {
         /** @var $querySettings \TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings */
         $querySettings = $this->objectManager->get('TYPO3\\CMS\\Extbase\\Persistence\\Generic\\Typo3QuerySettings');
-        $querySettings->setRespectStoragePage(false);
+        $querySettings->setRespectStoragePage(FALSE);
         $this->setDefaultQuerySettings($querySettings);
         $query = $this->createQuery();
         $query->matching(
@@ -332,19 +332,19 @@ 
             $constraints[] =
                 $query->logicalAnd(
                     $query->like('uid', $identifier),
-                    $query->equals('suggestion', false)
+                    $query->equals('suggestion', FALSE)
                 );
 
             $constraints[] =
                 $query->logicalAnd(
                     $query->like('object_identifier', $identifier),
-                    $query->equals('suggestion', false)
+                    $query->equals('suggestion', FALSE)
                 );
 
             $constraints[] =
                 $query->logicalAnd(
                     $query->like('process_number', $identifier),
-                    $query->equals('suggestion', false)
+                    $query->equals('suggestion', FALSE)
                 );
 
         $query->setOrderings(array("tstamp" => \TYPO3\CMS\Extbase\Persistence\QueryInterface::ORDER_DESCENDING));