kitodo / kitodo-publication

Classes/Configuration/ClientConfigurationManager.php

Braces +58 added lines, -116 removed lines

@@ -22,8 +22,7 @@ 
 use EWW\Dpf\Domain\Repository\ClientRepository;
 use TYPO3\CMS\Core\Configuration\ExtensionConfiguration;
 
-class ClientConfigurationManager
-{
+class ClientConfigurationManager {
     /**
      * settings
      *
@@ -46,8 +45,7 @@ 
      */
     protected $extensionConfiguration = array();
 
-    public function __construct()
-    {
+    public function __construct() {
         $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
         $clientRepository = $objectManager->get(ClientRepository::class);
 
@@ -77,8 +75,7 @@ 
 
     }
 
-    public function setConfigurationPid($pid)
-    {
+    public function setConfigurationPid($pid) {
         $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
         $clientRepository = $objectManager->get(ClientRepository::class);
 
@@ -88,8 +85,7 @@ 
     /**
      * @return int|null
      */
-    public function getClientPid()
-    {
+    public function getClientPid() {
         return $this->client->getPid();
     }
 
@@ -98,8 +94,7 @@ 
      *
      * @var array
      */
-    public function getSetting($settingName, $extConfig = null)
-    {
+    public function getSetting($settingName, $extConfig = null) {
         $setting = null;
         if ($this->client) {
             $setting = trim($this->client->{"get" . ucfirst($settingName)}());
@@ -114,270 +109,217 @@ 
     }
 
 
-    public function getOwnerId()
-    {
+    public function getOwnerId() {
         return $this->getSetting("ownerId");
     }
 
-    public function getSwordHost()
-    {
+    public function getSwordHost() {
         return $this->getSetting("swordHost", "swordHost");
     }
 
-    public function getSwordUser()
-    {
+    public function getSwordUser() {
         return $this->getSetting("swordUser", "swordUser");
     }
 
-    public function getSwordPassword()
-    {
+    public function getSwordPassword() {
         return $this->getSetting("swordPassword", "swordPassword");
     }
 
-    public function getSwordCollectionNamespace()
-    {
+    public function getSwordCollectionNamespace() {
         return $this->getSetting("swordCollectionNamespace", "swordCollectionNamespace");
     }
 
-    public function getFedoraHost()
-    {
+    public function getFedoraHost() {
         return $this->getSetting("fedoraHost", "fedoraHost");
     }
 
-    public function getFedoraUser()
-    {
+    public function getFedoraUser() {
         return $this->getSetting("fedoraUser", "fedoraUser");
     }
 
-    public function getFedoraPassword()
-    {
+    public function getFedoraPassword() {
         return $this->getSetting("fedoraPassword", "fedoraPassword");
     }
 
-    public function getElasticSearchHost()
-    {
+    public function getElasticSearchHost() {
         return $this->getSetting("elasticSearchHost", "elasticSearchHost");
     }
 
-    public function getElasticSearchPort()
-    {
+    public function getElasticSearchPort() {
         return $this->getSetting("elasticSearchPort", "elasticSearchPort");
     }
 
-    public function getElasticSearchIndexName()
-    {
+    public function getElasticSearchIndexName() {
         return $this->getSetting("elasticSearchIndexName", "elasticSearchIndexName");
     }
 
-    public function getUploadDirectory()
-    {
+    public function getUploadDirectory() {
         return $this->getSetting("uploadDirectory", "uploadDirectory");
     }
 
-    public function getUploadDomain()
-    {
+    public function getUploadDomain() {
         return $this->getSetting("uploadDomain", "uploadDomain");
     }
 
-    public function getSuggestionFlashMessage()
-    {
+    public function getSuggestionFlashMessage() {
         return $this->getSetting("suggestionFlashmessage", "suggestionFlashmessage");
     }
 
-    public function getFileXpath()
-    {
+    public function getFileXpath() {
         return $this->getSetting("fileXpath", "fileXpath");
     }
 
-    public function getStateXpath()
-    {
+    public function getStateXpath() {
         return $this->getSetting("stateXpath", "stateXpath");
     }
 
-    public function getTypeXpath()
-    {
+    public function getTypeXpath() {
         return $this->getSetting("typeXpath", "typeXpath");
     }
 
-    public function getTypeXpathInput()
-    {
+    public function getTypeXpathInput() {
         return $this->getSetting("typeXpathInput", "typeXpathInput");
     }
 
-    public function getUrnXpath()
-    {
+    public function getUrnXpath() {
         return $this->getSetting("urnXpath", "urnXpath");
     }
 
-    public function getPrimaryUrnXpath()
-    {
+    public function getPrimaryUrnXpath() {
         return $this->getSetting("primaryUrnXpath", "primaryUrnXpath");
     }
 
-    public function getDateXpath()
-    {
+    public function getDateXpath() {
         return $this->getSetting("dateXpath", "dateXpath");
     }
 
-    public function getPublishingYearXpath()
-    {
+    public function getPublishingYearXpath() {
         return $this->getSetting("publishingYearXpath", "publishingYearXpath");
     }
 
-    public function getNamespaces()
-    {
+    public function getNamespaces() {
         return $this->getSetting("namespaces", "namespaces");
     }
 
-    public function getTitleXpath()
-    {
+    public function getTitleXpath() {
         return $this->getSetting("titleXpath", "titleXpath");
     }
 
-    public function getOriginalSourceTitleXpath()
-    {
+    public function getOriginalSourceTitleXpath() {
         return $this->getSetting("originalSourceTitleXpath", "originalSourceTitleXpath");
     }
 
-    public function getProcessNumberXpath()
-    {
+    public function getProcessNumberXpath() {
         return $this->getSetting("processnumberXpath", "processnumberXpath");
     }
 
-    public function getSubmitterNameXpath()
-    {
+    public function getSubmitterNameXpath() {
         return $this->getSetting("submitterNameXpath", "submitterNameXpath");
     }
 
-    public function getSubmitterEmailXpath()
-    {
+    public function getSubmitterEmailXpath() {
         return $this->getSetting("submitterEmailXpath", "submitterEmailXpath");
     }
 
-    public function getSubmitterNoticeXpath()
-    {
+    public function getSubmitterNoticeXpath() {
         return $this->getSetting("submitterNoticeXpath", "submitterNoticeXpath");
     }
 
-    public function getCreatorXpath()
-    {
+    public function getCreatorXpath() {
         return $this->getSetting("creatorXpath", "creatorXpath");
     }
 
-    public function getCreationDateXpath()
-    {
+    public function getCreationDateXpath() {
         return $this->getSetting("creationDateXpath", "creationDateXpath");
     }
 
-    public function getRepositoryCreationDateXpath()
-    {
+    public function getRepositoryCreationDateXpath() {
         return $this->getSetting("repositoryCreationDateXpath", "repositoryCreationDateXpath");
     }
 
-    public function getRepositoryLastModDateXpath()
-    {
+    public function getRepositoryLastModDateXpath() {
         return $this->getSetting("repositoryLastModDateXpath", "repositoryLastModDateXpath");
     }
 
-    public function getDepositLicenseXpath()
-    {
+    public function getDepositLicenseXpath() {
         return $this->getSetting("depositLicenseXpath", "depositLicenseXpath");
     }
 
-    public function getAllNotesXpath()
-    {
+    public function getAllNotesXpath() {
         return $this->getSetting("allNotesXpath", "allNotesXpath");
     }
 
-    public function getPrivateNotesXpath()
-    {
+    public function getPrivateNotesXpath() {
         return $this->getSetting("privateNotesXpath", "privateNotesXpath");
     }
 
-    public function getInputTransformation()
-    {
+    public function getInputTransformation() {
         return $this->client->getInputTransformation()->current();
     }
 
-    public function getOutputTransformation()
-    {
+    public function getOutputTransformation() {
         return $this->client->getOutputTransformation()->current();
     }
 
-    public function getPersonXpath()
-    {
+    public function getPersonXpath() {
         return $this->getSetting("personXpath", "personXpath");
     }
 
-    public function getPersonFamilyXpath()
-    {
+    public function getPersonFamilyXpath() {
         return $this->getSetting("personFamilyXpath", "personFamilyXpath");
     }
 
-    public function getPersonGivenXpath()
-    {
+    public function getPersonGivenXpath() {
         return $this->getSetting("personGivenXpath", "personGivenXpath");
     }
 
-    public function getPersonRoleXpath()
-    {
+    public function getPersonRoleXpath() {
         return $this->getSetting("personRoleXpath", "personRoleXpath");
     }
 
-    public function getPersonFisIdentifierXpath()
-    {
+    public function getPersonFisIdentifierXpath() {
         return $this->getSetting("personFisIdentifierXpath", "personFisIdentifierXpath");
     }
 
-    public function getPersonAffiliationXpath()
-    {
+    public function getPersonAffiliationXpath() {
         return $this->getSetting("personAffiliationXpath", "personAffiliationXpath");
     }
 
-    public function getPersonAffiliationIdentifierXpath()
-    {
+    public function getPersonAffiliationIdentifierXpath() {
         return $this->getSetting("personAffiliationIdentifierXpath", "personAffiliationIdentifierXpath");
     }
 
-    public function getPersonAuthorRole()
-    {
+    public function getPersonAuthorRole() {
         return $this->getSetting("personAuthorRole", "personAuthorRole");
     }
 
-    public function getPersonPublisherRole()
-    {
+    public function getPersonPublisherRole() {
         return $this->getSetting("personPublisherRole", "personPublisherRole");
     }
 
-    public function getValidationXpath()
-    {
+    public function getValidationXpath() {
         return $this->getSetting("validationXpath", "validationXpath");
     }
 
-    public function fisIdXpath()
-    {
+    public function fisIdXpath() {
         return $this->getSetting("fisIdXpath", "fisIdXpath");
     }
 
-    public function getSourceDetailsXpaths()
-    {
+    public function getSourceDetailsXpaths() {
         return $this->getSetting("sourceDetailsXpaths", "sourceDetailsXpaths");
     }
 
-    public function getFedoraNamespace()
-    {
+    public function getFedoraNamespace() {
         $settings = $this->getTypoScriptSettings();
         return $settings['fedoraNamespace'];
     }
 
-    public function getUniversityCollection()
-    {
+    public function getUniversityCollection() {
         $settings = $this->getTypoScriptSettings();
         return $settings['universityCollection'];
     }
 
-    public function getTypoScriptSettings()
-    {
+    public function getTypoScriptSettings() {
         $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
         $configurationManager = $objectManager->get(ConfigurationManager::class);
         $settings = $configurationManager->getConfiguration(

Classes/Helper/InternalFormat.php

Braces +43 added lines, -82 removed lines

@@ -18,8 +18,7 @@ 
 use EWW\Dpf\Services\ParserGenerator;
 use TYPO3\CMS\Extbase\Object\ObjectManager;
 
-class InternalFormat
-{
+class InternalFormat {
     const rootNode = '//data/';
 
     /**
@@ -46,8 +45,7 @@ 
      * @param string $xml
      * @param int $clientPid
      */
-    public function __construct(string $xml, int $clientPid = 0)
-    {
+    public function __construct(string $xml, int $clientPid = 0) {
         $this->clientPid = $clientPid;
 
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
@@ -60,8 +58,7 @@ 
         $this->setXml($xml);
     }
 
-    public function setXml($xml)
-    {
+    public function setXml($xml) {
         if (empty($xml)) {
             $xml = "<data></data>";
         }
@@ -71,8 +68,7 @@ 
         $this->xml = $dom;
     }
 
-    public function getXml()
-    {
+    public function getXml() {
         return $this->xml->saveXML();
     }
 
@@ -80,37 +76,31 @@ 
         return $this->xml;
     }
 
-    public function getXpath()
-    {
+    public function getXpath() {
         return $domXPath = \EWW\Dpf\Helper\XPath::create($this->xml);
     }
 
-    public function getDocumentType()
-    {
+    public function getDocumentType() {
         $typeXpath = $this->clientConfigurationManager->getTypeXpath();
         return $this->getValue($typeXpath);
     }
 
-    public function setDocumentType($type)
-    {
+    public function setDocumentType($type) {
         $typeXpath = $this->clientConfigurationManager->getTypeXpath();
         $this->setValue($typeXpath, $type);
     }
 
-    public function getRepositoryState()
-    {
+    public function getRepositoryState() {
         $stateXpath = $this->clientConfigurationManager->getStateXpath();
         return $this->getValue($stateXpath);
     }
 
-    public function setRepositoryState($state)
-    {
+    public function setRepositoryState($state) {
         $stateXpath = $this->clientConfigurationManager->getStateXpath();
         $this->setValue($stateXpath,$state);
     }
 
-    public function getProcessNumber()
-    {
+    public function getProcessNumber() {
         $processNumberXpath = $this->clientConfigurationManager->getProcessNumberXpath();
         if ($processNumberXpath) {
             return $this->getValue($processNumberXpath);
@@ -119,14 +109,12 @@ 
         }
     }
 
-    public function setProcessNumber($processNumber)
-    {
+    public function setProcessNumber($processNumber) {
         $processNumberXpath = $this->clientConfigurationManager->getProcessNumberXpath();
         $this->setValue($processNumberXpath, $processNumber);
     }
 
-    public function getTitle()
-    {
+    public function getTitle() {
         $titleXpath = $this->clientConfigurationManager->getTitleXpath();
         $xpath = $this->getXpath();
 
@@ -141,14 +129,12 @@ 
     /**
      * @param string $title
      */
-    public function setTitle($title)
-    {
+    public function setTitle($title) {
         $titleXpath = $this->clientConfigurationManager->getTitleXpath();
         $this->setValue($titleXpath, $title);
     }
 
-    public function getFiles()
-    {
+    public function getFiles() {
         $xpath = $this->getXpath();
 
         $fileXpath = $this->clientConfigurationManager->getFileXpath();
@@ -178,8 +164,7 @@ 
         return $this->getValue($dateXpath);
     }
 
-    public function removeDateIssued()
-    {
+    public function removeDateIssued() {
         $xpath = $this->getXpath();
         $dateXpath = $this->clientConfigurationManager->getDateXpath();
 
@@ -190,8 +175,7 @@ 
 
     }
 
-    public function hasPrimaryUrn()
-    {
+    public function hasPrimaryUrn() {
         $xpath = $this->getXpath();
         $primaryUrnXpath = $this->clientConfigurationManager->getPrimaryUrnXpath();
 
@@ -203,8 +187,7 @@ 
         }
     }
 
-    public function getPrimaryUrn()
-    {
+    public function getPrimaryUrn() {
         $xpath = $this->getXpath();
         $primaryUrnXpath = $this->clientConfigurationManager->getPrimaryUrnXpath();
 
@@ -216,14 +199,12 @@ 
         }
     }
 
-    public function setPrimaryUrn($urn)
-    {
+    public function setPrimaryUrn($urn) {
         $primaryUrnXpath = $this->clientConfigurationManager->getPrimaryUrnXpath();
         $this->setValue($primaryUrnXpath, $urn);
     }
 
-    public function clearAllUrn()
-    {
+    public function clearAllUrn() {
         $xpath = $this->getXpath();
         $urnXpath = $this->clientConfigurationManager->getUrnXpath();
         $primaryUrnXpath = $this->clientConfigurationManager->getPrimaryUrnXpath();
@@ -278,50 +259,42 @@ 
         }
     }
 
-    public function getCreator()
-    {
+    public function getCreator() {
         $creatorXpath = $this->clientConfigurationManager->getCreatorXpath();
         return $this->getValue($creatorXpath);
     }
 
-    public function setCreator($creator)
-    {
+    public function setCreator($creator) {
         $creatorXpath = $this->clientConfigurationManager->getCreatorXpath();
         $this->setValue($creatorXpath, $creator);
     }
 
-    public function getCreationDate()
-    {
+    public function getCreationDate() {
         $xpath = $this->clientConfigurationManager->getCreationDateXpath();
         return $this->getValue($xpath);
     }
 
-    public function setCreationDate($creationDate)
-    {
+    public function setCreationDate($creationDate) {
         $xpath = $this->clientConfigurationManager->getCreationDateXpath();
         $this->setValue($xpath, $creationDate);
     }
 
-    public function getRepositoryCreationDate()
-    {
+    public function getRepositoryCreationDate() {
         $xpath = $this->clientConfigurationManager->getRepositoryCreationDateXpath();
         return $this->getValue($xpath);
     }
 
-    public function getRepositoryLastModDate()
-    {
+    public function getRepositoryLastModDate() {
         $xpath = $this->clientConfigurationManager->getRepositoryLastModDateXpath();
         return $this->getValue($xpath);
     }
 
-    public function getPublishingYear()
-    {
+    public function getPublishingYear() {
         $publishingYearXpath = $this->clientConfigurationManager->getPublishingYearXpath();
         return $this->getValue($publishingYearXpath);
     }
 
-    public function getOriginalSourceTitle()
-    {
+    public function getOriginalSourceTitle() {
         $originalSourceTitleXpath = $this->clientConfigurationManager->getOriginalSourceTitleXpath();
         return $this->getValue($originalSourceTitleXpath);
     }
@@ -329,8 +302,7 @@ 
     /**
      * @return string
      */
-    public function getSourceDetails()
-    {
+    public function getSourceDetails() {
         if (empty($sourceDetailsXpaths)) {
             return '';
         }
@@ -389,8 +361,7 @@ 
     /**
      * @return string
      */
-    public function getDepositLicense()
-    {
+    public function getDepositLicense() {
         $depositLicenseXpath = $this->clientConfigurationManager->getDepositLicenseXpath();
         return $this->getValue($depositLicenseXpath);
     }
@@ -398,8 +369,7 @@ 
     /**
      * @return array
      */
-    public function getNotes()
-    {
+    public function getNotes() {
         $notesXpath = $this->clientConfigurationManager->getAllNotesXpath();
 
         $xpath = $this->getXpath();
@@ -407,16 +377,14 @@ 
 
         $notes = array();
 
-        for ($i=0; $i < $notesNodes->length; $i++)
-        {
+        for ($i=0; $i < $notesNodes->length; $i++) {
             $notes[] = $notesNodes->item($i)->nodeValue;
         }
 
         return $notes;
     }
 
-    public function addNote($noteContent)
-    {
+    public function addNote($noteContent) {
         $notesXpath = $this->clientConfigurationManager->getPrivateNotesXpath();
 
         $parserGenerator = new ParserGenerator($this->clientPid);
@@ -426,13 +394,11 @@ 
         $this->xml->loadXML($parserGenerator->getXMLData());
     }
 
-    public function getAuthors()
-    {
+    public function getAuthors() {
         return $this->getPersons($this->clientConfigurationManager->getPersonAuthorRole());
     }
 
-    public function getPublishers()
-    {
+    public function getPublishers() {
         return $this->getPersons($this->clientConfigurationManager->getPersonPublisherRole());
     }
 
@@ -442,8 +408,7 @@ 
      * @param string $role
      * @return array
      */
-    public function getPersons($role = '')
-    {
+    public function getPersons($role = '') {
         $personXpath = $this->clientConfigurationManager->getPersonXpath();
         $familyXpath = $this->clientConfigurationManager->getPersonFamilyXpath();
         $givenXpath = $this->clientConfigurationManager->getPersonGivenXpath();
@@ -516,8 +481,9 @@ 
         if ($role) {
             $result = [];
             foreach ($persons as $person) {
-                if ($person['role'] == $role)
-                    $result[] = $person;
+                if ($person['role'] == $role) {
+                                    $result[] = $person;
+                }
             }
             return $result;
         } else {
@@ -528,8 +494,7 @@ 
     /**
      * @return bool
      */
-    public function getValidation()
-    {
+    public function getValidation() {
         $validationXpath =  $this->clientConfigurationManager->getValidationXpath();
         $validation = $this->getValue($validationXpath);
         return (strtolower($validation) === 'true')? true : false;
@@ -538,8 +503,7 @@ 
     /**
      * @param bool $validated
      */
-    public function setValidation($validated)
-    {
+    public function setValidation($validated) {
         $validationXpath =  $this->clientConfigurationManager->getValidationXpath();
         $this->setValue($validationXpath, ($validated? 'true' : 'false'));
     }
@@ -547,8 +511,7 @@ 
     /**
      * @param string $fisId
      */
-    public function setFisId($fisId)
-    {
+    public function setFisId($fisId) {
         $fisIdXpath =  $this->clientConfigurationManager->getFisIdXpath();
         $this->setValue($fisIdXpath, $fisId);
     }
@@ -557,8 +520,7 @@ 
      * @param string $xpathString
      * @return string
      */
-    protected function getValue($xpathString)
-    {
+    protected function getValue($xpathString) {
         $xpath = $this->getXpath();
         $nodeList = $xpath->query(self::rootNode . $xpathString);
         if ($nodeList->length > 0) {
@@ -571,8 +533,7 @@ 
      * @param string $xpathString
      * @param string $value
      */
-    protected function setValue($xpathString, $value)
-    {
+    protected function setValue($xpathString, $value) {
         $xpath = $this->getXpath();
         $nodes = $xpath->query(self::rootNode . $xpathString);
         if ($nodes->length > 0) {

Classes/Domain/Repository/DocumentRepository.php

Braces +12 added lines, -24 removed lines

@@ -22,8 +22,7 @@ 
 /**
  * The repository for Documents
  */
-class DocumentRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository
-{
+class DocumentRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository {
     /**
      * Finds all suggestion documents of the given user role filtered by creator feuser uid
      *
@@ -31,8 +30,7 @@ 
      * @param int $creatorUid
      * @return array|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
      */
-    public function findAllDocumentSuggestions($role, $creatorUid)
-    {
+    public function findAllDocumentSuggestions($role, $creatorUid) {
         $query = $this->createQuery();
 
         switch ($role) {
@@ -61,8 +59,7 @@ 
      * @param boolean $temporary
      * @return array
      */
-    public function getObjectIdentifiers($temporary = false)
-    {
+    public function getObjectIdentifiers($temporary = false) {
         $query = $this->createQuery();
 
         $constraints = array(
@@ -99,8 +96,7 @@ 
      *
      * @return array The found Document Objects
      */
-    public function findDocumentsWithoutProcessNumber()
-    {
+    public function findDocumentsWithoutProcessNumber() {
         $query = $this->createQuery();
         $query->getQuerySettings()->setRespectStoragePage(false);
 
@@ -126,8 +122,7 @@ 
      * @param integer $timeout : Time interval (in seconds) in which documents are not outdated.
      * @return array The found Document Objects
      */
-    public function findOutdatedTemporaryDocuments($timeout = 3600)
-    {
+    public function findOutdatedTemporaryDocuments($timeout = 3600) {
         $query = $this->createQuery();
 
         $dateTimeObj = new \DateTime();
@@ -152,8 +147,7 @@ 
      * @param integer $timeout : Time interval (in seconds) in which documents are not outdated.
      * @return array The found Document Objects
      */
-    public function findOutdatedLockedDocuments($timeout = 3600)
-    {
+    public function findOutdatedLockedDocuments($timeout = 3600) {
         $query = $this->createQuery();
 
         $dateTimeObj = new \DateTime();
@@ -177,8 +171,7 @@ 
      * @param string $objectIdentifier
      * @return array
      */
-    public function findWorkingCopyByObjectIdentifier($objectIdentifier)
-    {
+    public function findWorkingCopyByObjectIdentifier($objectIdentifier) {
         $query = $this->createQuery();
 
         $constraints = array(
@@ -196,8 +189,7 @@ 
      * @param string $identifier
      * @return Document
      */
-    public function findByIdentifier($identifier)
-    {
+    public function findByIdentifier($identifier) {
         $query = $this->createQuery();
 
         if (Identifier::isUid($identifier)) {
@@ -234,8 +226,7 @@ 
      * @param bool $includeSuggestion
      * @return Document
      */
-    public function findWorkingCopy($identifier, $includeTemporary = false, $includeSuggestion = false)
-    {
+    public function findWorkingCopy($identifier, $includeTemporary = false, $includeSuggestion = false) {
         $query = $this->createQuery();
 
         if (is_numeric($identifier)) {
@@ -261,8 +252,7 @@ 
      * @param object $modifiedObject The modified object
      * @throws \Exception
      */
-    public function update($modifiedObject)
-    {
+    public function update($modifiedObject) {
         /** @var Document $document */
         $document = $modifiedObject;
 
@@ -287,8 +277,7 @@ 
     }
 
 
-    public function updateCreator()
-    {
+    public function updateCreator() {
 
         $query = $this->createQuery();
         $query->statement("update tx_dpf_domain_model_document set creator = owner");
@@ -300,8 +289,7 @@ 
      * Finds all records with embargo date
      * @return mixed
      */
-    public function crossClientEmbargoFindAll()
-    {
+    public function crossClientEmbargoFindAll() {
         /** @var $querySettings \TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings */
         $querySettings = $this->objectManager->get('TYPO3\\CMS\\Extbase\\Persistence\\Generic\\Typo3QuerySettings');
         $querySettings->setRespectStoragePage(false);

Classes/Domain/Repository/BookmarkRepository.php

Braces +5 added lines, -10 removed lines

@@ -22,15 +22,13 @@ 
 /**
  * The repository for Bookmarks
  */
-class BookmarkRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository
-{
+class BookmarkRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository {
     /**
      * @param int $feUserUid
      * @param string $identifier
      * @return object
      */
-    public function findBookmark($feUserUid, $identifier)
-    {
+    public function findBookmark($feUserUid, $identifier) {
         $query = $this->createQuery();
 
         $query->matching(
@@ -49,8 +47,7 @@ 
      * @return bool
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException
      */
-    public function removeBookmark($document, $feUserUid)
-    {
+    public function removeBookmark($document, $feUserUid) {
         $query = $this->createQuery();
 
         if ($document instanceof Document) {
@@ -88,8 +85,7 @@ 
      * @return bool
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException
      */
-    public function addBookmark($document, $feUserUid)
-    {
+    public function addBookmark($document, $feUserUid) {
         if ($document instanceof Document) {
             // The returned documentIdentifier is either a PID or the document UID (TYPO3 db), see also
             // the above method removeBookmark().
@@ -115,8 +111,7 @@ 
      * @param Document $document
      * @return array|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
      */
-    public function findDocumentBookmarks(Document $document)
-    {
+    public function findDocumentBookmarks(Document $document) {
         $query = $this->createQuery();
 
         $constraintsAnd[] = $query->logicalOr(

Classes/Domain/Repository/AbstractRepository.php

Braces +2 added lines, -4 removed lines

@@ -17,8 +17,7 @@ 
 /**
  * The abstract repository
  */
-class AbstractRepository extends \TYPO3\CMS\Extbase\Persistence\Repository
-{
+class AbstractRepository extends \TYPO3\CMS\Extbase\Persistence\Repository {
     /**
      * Finds all records of all clients.
      *
@@ -34,8 +33,7 @@ 
         return $query->execute($returnRawQueryResult);
     }
 
-    public function crossClient($active = false)
-    {
+    public function crossClient($active = false) {
         /** @var $querySettings \TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings */
         $querySettings = $this->objectManager->get('TYPO3\\CMS\\Extbase\\Persistence\\Generic\\Typo3QuerySettings');
         $querySettings->setRespectStoragePage(!$active);

Classes/Domain/Repository/ClientRepository.php

Braces +2 added lines, -4 removed lines

@@ -17,16 +17,14 @@
 /**
  * The repository for Clients
  */
-class ClientRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository
-{
+class ClientRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository {
 
     /**
      * findAllByPid
      *
      * @return
      */
-    public function findAllByPid($pid)
-    {
+    public function findAllByPid($pid) {
         $query = $this->createQuery();
         $query->getQuerySettings()->setRespectStoragePage(false);
         $query->matching($query->equals('pid', $pid));

Classes/Domain/Repository/FrontendUserRepository.php

Braces +2 added lines, -4 removed lines

@@ -4,15 +4,13 @@
 use EWW\Dpf\Domain\Model\Document;
 use TYPO3\CMS\Extbase\Persistence\QueryResultInterface;
 
-class FrontendUserRepository extends \TYPO3\CMS\Extbase\Domain\Repository\FrontendUserRepository
-{
+class FrontendUserRepository extends \TYPO3\CMS\Extbase\Domain\Repository\FrontendUserRepository {
     /**
      * @param $feUserUid
      * @param $clientPid
      * @return bool
      */
-    public function isUserInClient($feUserUid, $clientPid)
-    {
+    public function isUserInClient($feUserUid, $clientPid) {
         /** @var $querySettings \TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings */
         $querySettings = $this->objectManager->get('TYPO3\\CMS\\Extbase\\Persistence\\Generic\\Typo3QuerySettings');
         $querySettings->setRespectStoragePage(false);

Classes/Domain/Model/Document.php

Braces +63 added lines, -126 removed lines

@@ -21,8 +21,7 @@ 
 /**
  * Document
  */
-class Document extends AbstractEntity
-{
+class Document extends AbstractEntity {
     // xml data size ist limited to 64 KB
     const XML_DATA_SIZE_LIMIT = 64 * 1024;
 
@@ -213,8 +212,7 @@ 
     /**
      * __construct
      */
-    public function __construct()
-    {
+    public function __construct() {
         //Do not remove the next line: It would break the functionality
         $this->initStorageObjects();
     }
@@ -224,8 +222,7 @@ 
      *
      * @return void
      */
-    protected function initStorageObjects()
-    {
+    protected function initStorageObjects() {
         $this->file = new \TYPO3\CMS\Extbase\Persistence\ObjectStorage();
         $this->initCreationDate();
     }
@@ -235,8 +232,7 @@ 
      *
      * @return string $title
      */
-    public function getTitle()
-    {
+    public function getTitle() {
         return $this->title;
     }
 
@@ -246,8 +242,7 @@ 
      * @param string $title
      * @return void
      */
-    public function setTitle($title)
-    {
+    public function setTitle($title) {
         $this->title = $title ?? '';
         //htmlspecialchars_decode($title,ENT_QUOTES);
     }
@@ -257,8 +252,7 @@ 
      *
      * @return array $authors
      */
-    public function getAuthors()
-    {
+    public function getAuthors() {
         $authors = @unserialize($this->authors);
         if (is_array($authors)) {
             return $authors;
@@ -273,8 +267,7 @@ 
      * @param array $authors
      * @return void
      */
-    public function setAuthors($authors)
-    {
+    public function setAuthors($authors) {
         $this->authors = serialize($authors);
     }
 
@@ -283,8 +276,7 @@ 
      *
      * @return string $xmlData
      */
-    public function getXmlData()
-    {
+    public function getXmlData() {
         return $this->xmlData;
     }
 
@@ -294,8 +286,7 @@ 
      * @param string $xmlData
      * @return void
      */
-    public function setXmlData($xmlData)
-    {
+    public function setXmlData($xmlData) {
         $this->xmlData = $xmlData;
     }
 
@@ -304,8 +295,7 @@ 
      *
      * @return string $slubInfoData
      */
-    public function getSlubInfoData()
-    {
+    public function getSlubInfoData() {
         return $this->slubInfoData;
     }
 
@@ -314,8 +304,7 @@ 
      *
      * @return string $slubInfoData
      */
-    public function setSlubInfoData($slubInfoData)
-    {
+    public function setSlubInfoData($slubInfoData) {
         $this->slubInfoData = $slubInfoData;
     }
 
@@ -324,8 +313,7 @@ 
      *
      * @return \EWW\Dpf\Domain\Model\DocumentType $documentType
      */
-    public function getDocumentType()
-    {
+    public function getDocumentType() {
         return $this->documentType;
     }
 
@@ -335,8 +323,7 @@ 
      * @param \EWW\Dpf\Domain\Model\DocumentType $documentType
      * @return void
      */
-    public function setDocumentType(\EWW\Dpf\Domain\Model\DocumentType $documentType)
-    {
+    public function setDocumentType(\EWW\Dpf\Domain\Model\DocumentType $documentType) {
         $this->documentType = $documentType;
     }
 
@@ -345,8 +332,7 @@ 
      *
      * @return string
      */
-    public function getObjectIdentifier()
-    {
+    public function getObjectIdentifier() {
         return $this->objectIdentifier;
     }
 
@@ -356,8 +342,7 @@ 
      * @param string $objectIdentifier
      * @return void
      */
-    public function setObjectIdentifier($objectIdentifier)
-    {
+    public function setObjectIdentifier($objectIdentifier) {
         // Due to uniqe key uc_object_identifier, which should ignore empty object identifiers.
         $this->objectIdentifier = empty($objectIdentifier)? null : $objectIdentifier;
     }
@@ -367,8 +352,7 @@ 
      *
      * @return string
      */
-    public function getReservedObjectIdentifier()
-    {
+    public function getReservedObjectIdentifier() {
         return $this->reservedObjectIdentifier;
     }
 
@@ -378,8 +362,7 @@ 
      * @param string $reservedObjectIdentifier
      * @return void
      */
-    public function setReservedObjectIdentifier($reservedObjectIdentifier)
-    {
+    public function setReservedObjectIdentifier($reservedObjectIdentifier) {
         $this->reservedObjectIdentifier = $reservedObjectIdentifier;
     }
 
@@ -388,8 +371,7 @@ 
      *
      * @return string
      */
-    public function getTransferStatus()
-    {
+    public function getTransferStatus() {
         return $this->transferStatus;
     }
 
@@ -399,8 +381,7 @@ 
      * @param string
      * @return void
      */
-    public function setTransferStatus($transferStatus)
-    {
+    public function setTransferStatus($transferStatus) {
         $this->transferStatus = $transferStatus;
     }
 
@@ -409,8 +390,7 @@ 
      *
      * @return integer
      */
-    public function getTransferDate()
-    {
+    public function getTransferDate() {
         return $this->transferDate;
     }
 
@@ -420,8 +400,7 @@ 
      * @param integer $transferDate
      * @return void
      */
-    public function setTransferDate($transferDate)
-    {
+    public function setTransferDate($transferDate) {
         $this->transferDate = $transferDate;
     }
 
@@ -430,8 +409,7 @@ 
      *
      * @var integer
      */
-    public function getTransferErrorCode()
-    {
+    public function getTransferErrorCode() {
         return $this->transferErrorCode;
     }
 
@@ -441,8 +419,7 @@ 
      * @param integer $transferErrorCode
      * @return void
      */
-    public function setTransferErrorCode($transferErrorCode)
-    {
+    public function setTransferErrorCode($transferErrorCode) {
         $this->transferErrorCode = $transferErrorCode;
     }
 
@@ -451,8 +428,7 @@ 
      *
      * @var string
      */
-    public function getTransferResponse()
-    {
+    public function getTransferResponse() {
         return $this->transferResponse;
     }
 
@@ -462,8 +438,7 @@ 
      * @param string $transferResponse
      * @return void
      */
-    public function setTransferResponse($transferResponse)
-    {
+    public function setTransferResponse($transferResponse) {
         $this->transferResponse = $transferResponse;
     }
 
@@ -472,8 +447,7 @@ 
      *
      * @var integer
      */
-    public function getTransferHttpStatus()
-    {
+    public function getTransferHttpStatus() {
         return $this->transferHttpStatus;
     }
 
@@ -483,8 +457,7 @@ 
      * @param integer $transferHttpStatus
      * @return void
      */
-    public function setTransferHttpStatus($transferHttpStatus)
-    {
+    public function setTransferHttpStatus($transferHttpStatus) {
         $this->transferHttpStatus = $transferHttpStatus;
     }
 
@@ -494,8 +467,7 @@ 
      * @param \EWW\Dpf\Domain\Model\File $file
      * @return void
      */
-    public function addFile(\EWW\Dpf\Domain\Model\File $file)
-    {
+    public function addFile(\EWW\Dpf\Domain\Model\File $file) {
         $this->file->attach($file);
     }
 
@@ -505,8 +477,7 @@ 
      * @param \EWW\Dpf\Domain\Model\File $fileToRemove The File to be removed
      * @return void
      */
-    public function removeFile(\EWW\Dpf\Domain\Model\File $fileToRemove)
-    {
+    public function removeFile(\EWW\Dpf\Domain\Model\File $fileToRemove) {
         $this->file->detach($fileToRemove);
     }
 
@@ -515,8 +486,7 @@ 
      *
      * @return \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\File> $file
      */
-    public function getFile()
-    {
+    public function getFile() {
         return $this->file;
     }
 
@@ -526,8 +496,7 @@ 
      * @param \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\File> $file
      * @return void
      */
-    public function setFile(\TYPO3\CMS\Extbase\Persistence\ObjectStorage $file)
-    {
+    public function setFile(\TYPO3\CMS\Extbase\Persistence\ObjectStorage $file) {
         $this->file = $file;
     }
 
@@ -536,8 +505,7 @@ 
      *
      * @return array
      */
-    public function getFileData()
-    {
+    public function getFileData() {
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
@@ -587,8 +555,7 @@ 
      *
      * @return array
      */
-    public function getCurrentFileData()
-    {
+    public function getCurrentFileData() {
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
@@ -636,8 +603,7 @@ 
      *
      * @return boolean $changed
      */
-    public function getChanged()
-    {
+    public function getChanged() {
         return $this->changed;
     }
 
@@ -647,8 +613,7 @@ 
      * @param boolean $changed
      * @return void
      */
-    public function setChanged($changed)
-    {
+    public function setChanged($changed) {
         $this->changed = boolval($changed);
     }
 
@@ -657,8 +622,7 @@ 
      *
      * @return boolean $valid
      */
-    public function getValid()
-    {
+    public function getValid() {
         return $this->valid;
     }
 
@@ -668,8 +632,7 @@ 
      * @param boolean $valid
      * @return void
      */
-    public function setValid($valid)
-    {
+    public function setValid($valid) {
         $this->valid = boolval($valid);
     }
 
@@ -678,8 +641,7 @@ 
      *
      * @return string
      */
-    public function getDateIssued()
-    {
+    public function getDateIssued() {
         return empty($this->dateIssued) ? '' : $this->dateIssued;
     }
 
@@ -689,8 +651,7 @@ 
      * @param string $dateIssued
      * @return void
      */
-    public function setDateIssued($dateIssued)
-    {
+    public function setDateIssued($dateIssued) {
         $this->dateIssued = empty($dateIssued) ? '' : $dateIssued;
     }
 
@@ -700,8 +661,7 @@ 
      *
      * @return string
      */
-    public function getProcessNumber()
-    {
+    public function getProcessNumber() {
         return $this->processNumber;
     }
 
@@ -711,8 +671,7 @@ 
      * @param string $processNumber
      * @return void
      */
-    public function setProcessNumber($processNumber)
-    {
+    public function setProcessNumber($processNumber) {
         $this->processNumber = trim($processNumber);
     }
 
@@ -721,8 +680,7 @@ 
      *
      * @return string
      */
-    public function getSubmitterName()
-    {
+    public function getSubmitterName() {
         try {
             $internalFormat = new InternalFormat($this->getXmlData(), $this->getPid());
             return $internalFormat->getSubmitterName();
@@ -736,8 +694,7 @@ 
      *
      * @return string
      */
-    public function getPrimaryUrn()
-    {
+    public function getPrimaryUrn() {
         $internalFormat = new InternalFormat($this->getXmlData(), $this->getPid());
         return $internalFormat->getPrimaryUrn();
     }
@@ -747,8 +704,7 @@ 
      *
      * @return int
      */
-    public function getCreator()
-    {
+    public function getCreator() {
         return $this->creator? $this->creator : 0;
     }
 
@@ -758,24 +714,20 @@ 
      * @param int $creator
      * @return void
      */
-    public function setCreator($creator)
-    {
+    public function setCreator($creator) {
         $this->creator = $creator;
     }
 
-    public function getState()
-    {
+    public function getState() {
         return $this->state;
     }
 
-    public function setState($state)
-    {
+    public function setState($state) {
         $this->stateChange = $this->state != $state;
         $this->state = $state;
     }
 
-    public function getRemoteState()
-    {
+    public function getRemoteState() {
         $state = explode(':', $this->state);
         if (is_array($state) && array_key_exists(1, $state)) {
             return $state[1];
@@ -813,8 +765,7 @@ 
     /**
      * @return string
      */
-    public function getRemoteLastModDate()
-    {
+    public function getRemoteLastModDate() {
         return $this->remoteLastModDate;
     }
 
@@ -822,24 +773,21 @@ 
      * @param string $remoteLastModDate
      * @return void
      */
-    public function setRemoteLastModDate($remoteLastModDate)
-    {
+    public function setRemoteLastModDate($remoteLastModDate) {
         $this->remoteLastModDate = $remoteLastModDate;
     }
 
     /**
      * @return integer
      */
-    public function getTstamp()
-    {
+    public function getTstamp() {
         return $this->tstamp;
     }
 
     /**
      * @return integer
      */
-    public function getPid()
-    {
+    public function getPid() {
         return $this->pid;
     }
 
@@ -854,8 +802,7 @@ 
     /**
      * @param bool $suggestion
      */
-    public function setSuggestion(bool $suggestion)
-    {
+    public function setSuggestion(bool $suggestion) {
         $this->suggestion = boolval($suggestion);
     }
 
@@ -870,8 +817,7 @@ 
     /**
      * @param string $linkedUid
      */
-    public function setLinkedUid(string $linkedUid)
-    {
+    public function setLinkedUid(string $linkedUid) {
         $this->linkedUid = $linkedUid;
     }
 
@@ -886,8 +832,7 @@ 
     /**
      * @param string $comment
      */
-    public function setComment(string $comment)
-    {
+    public function setComment(string $comment) {
         $this->comment = $comment;
     }
 
@@ -924,8 +869,7 @@ 
      *
      * @return string|int
      */
-    public function getDocumentIdentifier()
-    {
+    public function getDocumentIdentifier() {
         return $this->getObjectIdentifier()? $this->getObjectIdentifier() : $this->getUid();
     }
 
@@ -934,8 +878,7 @@ 
      *
      * @return bool
      */
-    public function isWorkingCopy()
-    {
+    public function isWorkingCopy() {
         return $this->getObjectIdentifier() && !$this->isTemporary() && !$this->isSuggestion();
     }
 
@@ -945,8 +888,7 @@ 
      *
      * @return bool
      */
-    public function isTemporaryCopy()
-    {
+    public function isTemporaryCopy() {
         return $this->getObjectIdentifier() && $this->isTemporary() && !$this->isSuggestion();
     }
 
@@ -956,8 +898,7 @@ 
      *
      * @return string|null
      */
-    public function getPublicationYear()
-    {
+    public function getPublicationYear() {
         $internalFormat = new InternalFormat($this->getXmlData(), $this->getPid());
         $year =  $internalFormat->getPublishingYear();
         return $year? $year : "";
@@ -968,8 +909,7 @@ 
      *
      * @return string|null
      */
-    public function getSourceDetails()
-    {
+    public function getSourceDetails() {
         $internalFormat = new InternalFormat($this->getXmlData(), $this->getPid());
         $data = $internalFormat->getSourceDetails();
         return $data;
@@ -986,8 +926,7 @@ 
     /**
      * @param \DateTime|null $embargoDate
      */
-    public function setEmbargoDate(?\DateTime $embargoDate)
-    {
+    public function setEmbargoDate(?\DateTime $embargoDate) {
         $this->embargoDate = $embargoDate;
     }
 
@@ -1010,8 +949,7 @@ 
     /**
      * @return array
      */
-    public function getPreviouslyAssignedFobIdentifiers()
-    {
+    public function getPreviouslyAssignedFobIdentifiers() {
         return array_diff(
             $this->getAssignedFobIdentifiers(), $this->getNewlyAssignedFobIdentifiers()
         );
@@ -1037,8 +975,7 @@ 
     /**
      * @return mixed
      */
-    public function getDepositLicense()
-    {
+    public function getDepositLicense() {
         $internalFormat = new InternalFormat($this->getXmlData(), $this->getPid());
         $data = $internalFormat->getDepositLicense();
         return $data;

Classes/Controller/BackendAdminController.php

Braces +7 added lines, -14 removed lines

@@ -32,8 +32,7 @@ 
 /**
 * Backend module user/group action controller
 */
-class BackendAdminController extends ActionController
-{
+class BackendAdminController extends ActionController {
     /**
      * documentRepository
      *
@@ -95,8 +94,7 @@ 
      * @param ViewInterface $view
      * @return void
      */
-    protected function initializeView(ViewInterface $view)
-    {
+    protected function initializeView(ViewInterface $view) {
         /** @var BackendTemplateView $view */
         parent::initializeView($view);
         if ($this->actionMethodName == 'indexAction'
@@ -114,8 +112,7 @@ 
     /**
      * @param string $identifier
      */
-    public function searchDocumentAction(string $identifier = '')
-    {
+    public function searchDocumentAction(string $identifier = '') {
         $identifier = trim($identifier);
         $this->view->assign('identifier', $identifier);
 
@@ -147,8 +144,7 @@ 
      * @param Document $document
      * @param string $identifier
      */
-    public function chooseNewClientAction(Document $document, string $identifier)
-    {
+    public function chooseNewClientAction(Document $document, string $identifier) {
         if ($document) {
             if ($this->canChangeClient($document)) {
                 /** @var Client $currentClient */
@@ -201,8 +197,7 @@ 
      * @param string $identifier
      * @param DocumentType $documentType
      */
-    public function changeClientAction(Document $document, Client $client, string $identifier, DocumentType $documentType = null)
-    {
+    public function changeClientAction(Document $document, Client $client, string $identifier, DocumentType $documentType = null) {
         if ($documentType instanceof DocumentType) {
             if ($this->canChangeClient($document)) {
 
@@ -303,8 +298,7 @@ 
     /**
      * @param Document $document
      */
-    protected function canChangeClient(Document $document)
-    {
+    protected function canChangeClient(Document $document) {
         return (
             in_array(
              $document->getState(),
@@ -335,8 +329,7 @@ 
         array $headerArguments,
         array $bodyArguments,
         bool $storeInSession = false
-    )
-    {
+    ) {
         $messageHeader = LocalizationUtility::translate(
             'LLL:EXT:dpf/Resources/Private/Language/locallang_mod.xlf:admin_module.'.$headerKey,
             'dpf',