kitodo / kitodo-publication

Classes/Domain/Model/StoredSearch.php

Braces +5 added lines, -10 removed lines

@@ -17,8 +17,7 @@ 
 /**
  * StoredSearch
  */
-class StoredSearch extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity
-{
+class StoredSearch extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity {
 
     /**
      * name
@@ -42,8 +41,7 @@ 
      *
      * @return string $name
      */
-    public function getName()
-    {
+    public function getName() {
         return $this->name;
     }
 
@@ -53,8 +51,7 @@ 
      * @param string $name
      * @return void
      */
-    public function setName($name)
-    {
+    public function setName($name) {
         $this->name = $name;
     }
 
@@ -64,8 +61,7 @@ 
      *
      * @return string $query
      */
-    public function getQuery()
-    {
+    public function getQuery() {
         return $this->query;
     }
 
@@ -76,8 +72,7 @@ 
      * @param string $query
      * @return void
      */
-    public function setQuery($query)
-    {
+    public function setQuery($query) {
         $this->query = $query;
     }
 

Classes/Controller/SearchController.php

Indentation +2 added lines, -2 removed lines

@@ -327,8 +327,8 @@
     }
 
         /**
-     * extended search action
-     */
+         * extended search action
+         */
     public function extendedSearchAction()
     {
         /** @var FrontendUser $feUser */

Braces +13 added lines, -26 removed lines

@@ -26,8 +26,7 @@ 
 /**
  * SearchController
  */
-class SearchController extends \EWW\Dpf\Controller\AbstractController
-{
+class SearchController extends \EWW\Dpf\Controller\AbstractController {
 
     /**
      * documentRepository
@@ -182,8 +181,7 @@ 
      *
      * @return void
      */
-    public function searchAction()
-    {
+    public function searchAction() {
         $args = $this->request->getArguments();
 
         /** @var SearchSessionData $workspaceSessionData */
@@ -245,8 +243,7 @@ 
     protected function getSearchQuery(
         $from = 0, $bookmarkIdentifiers = [], $filters= [], $excludeFilters = [],
         $sortField = null, $sortOrder = null, $queryString = null
-    )
-    {
+    ) {
         $workspaceFilter = [
             'bool' => [
                 'must' => [
@@ -287,8 +284,7 @@ 
      * Batch operations action.
      * @param array $listData
      */
-    public function batchAction($listData)
-    {
+    public function batchAction($listData) {
         if (array_key_exists('action', $listData)) {
             $this->forward($listData['action'], null, null, ['listData' => $listData]);
         }
@@ -299,8 +295,7 @@ 
      * Batch operation, bookmark documents.
      * @param array $listData
      */
-    public function batchBookmarkAction($listData)
-    {
+    public function batchBookmarkAction($listData) {
         $successful = [];
         $checkedDocumentIdentifiers = [];
 
@@ -353,8 +348,7 @@ 
         /**
      * extended search action
      */
-    public function extendedSearchAction()
-    {
+    public function extendedSearchAction() {
         /** @var FrontendUser $feUser */
         $feUser = $this->security->getUser();
 
@@ -432,8 +426,7 @@ 
     /**
      * gets a list of latest documents
      */
-    public function latestAction()
-    {
+    public function latestAction() {
         try {
             $query = $this->searchLatest();
 
@@ -476,8 +469,7 @@ 
      * @param  string $objectState
      * @return void
      */
-    public function importAction($documentObjectIdentifier, $objectState)
-    {
+    public function importAction($documentObjectIdentifier, $objectState) {
         $documentTransferManager = $this->objectManager->get(DocumentTransferManager::class);
         $remoteRepository        = $this->objectManager->get(FedoraRepository::class);
         $documentTransferManager->setRemoteRepository($remoteRepository);
@@ -523,8 +515,7 @@ 
      * @param  string $documentObjectIdentifier
      * @return void
      */
-    public function updateIndexAction($documentObjectIdentifier)
-    {
+    public function updateIndexAction($documentObjectIdentifier) {
         $document = $this->documentRepository->findByObjectIdentifier($documentObjectIdentifier);
 
         if (is_a($document, Document::class)) {
@@ -545,8 +536,7 @@ 
      * @param  \EWW\Dpf\Domain\Model\Document $document
      * @return void
      */
-    public function doubletCheckAction(\EWW\Dpf\Domain\Model\Document $document)
-    {
+    public function doubletCheckAction(\EWW\Dpf\Domain\Model\Document $document) {
         $this->authorizationChecker->denyAccessUnlessGranted(DocumentVoter::DOUBLET_CHECK, $document);
 
         try {
@@ -629,8 +619,7 @@ 
      * returns the query to get latest documents
      * @return mixed
      */
-    public function searchLatest()
-    {
+    public function searchLatest() {
         $client = $this->clientRepository->findAll()->current();
 
         // get the latest documents /CREATED_DATE
@@ -656,8 +645,7 @@ 
      *
      * @return int
      */
-    protected function itemsPerPage()
-    {
+    protected function itemsPerPage() {
         /** @var SearchSessionData $workspaceData */
         $workspaceData = $this->session->getWorkspaceData();
         $itemsPerPage = $workspaceData->getItemsPerPage();
@@ -672,8 +660,7 @@ 
      * @param $string
      * @return mixed
      */
-    private function escapeQuery($string)
-    {
+    private function escapeQuery($string) {
         $luceneReservedCharacters = preg_quote('+-&|!(){}[]^~?:\\');
         $string                   = preg_replace_callback(
             '/([' . $luceneReservedCharacters . '])/',

Spacing +22 added lines, -22 removed lines

@@ -224,7 +224,7 @@ 
         }
 
         $this->list(
-            (empty($currentPage)? 0 : ($currentPage-1) * $this->itemsPerPage()),
+            (empty($currentPage) ? 0 : ($currentPage - 1) * $this->itemsPerPage()),
             $this->escapeQuery(trim($simpleSearch))
         );
 
@@ -249,7 +249,7 @@ 
      * @return array
      */
     protected function getSearchQuery(
-        $from = 0, $bookmarkIdentifiers = [], $filters= [], $excludeFilters = [],
+        $from = 0, $bookmarkIdentifiers = [], $filters = [], $excludeFilters = [],
         $sortField = null, $sortOrder = null, $queryString = null
     )
     {
@@ -310,12 +310,12 @@ 
         $successful = [];
         $checkedDocumentIdentifiers = [];
 
-        if (array_key_exists('documentIdentifiers', $listData) && is_array($listData['documentIdentifiers']) ) {
+        if (array_key_exists('documentIdentifiers', $listData) && is_array($listData['documentIdentifiers'])) {
             $checkedDocumentIdentifiers = $listData['documentIdentifiers'];
 
             foreach ($listData['documentIdentifiers'] as $documentIdentifier) {
 
-                if ( $listData['documentAliasState'][$documentIdentifier] != DocumentWorkflow::ALIAS_STATE_NEW) {
+                if ($listData['documentAliasState'][$documentIdentifier] != DocumentWorkflow::ALIAS_STATE_NEW) {
                     if (
                         $this->bookmarkRepository->addBookmark(
                             $documentIdentifier,
@@ -353,7 +353,7 @@ 
         list($redirectAction, $redirectController) = $this->session->getStoredAction();
         $this->redirect(
             $redirectAction, $redirectController, null,
-            array('message' => $message, 'checkedDocumentIdentifiers' =>  $checkedDocumentIdentifiers));
+            array ('message' => $message, 'checkedDocumentIdentifiers' =>  $checkedDocumentIdentifiers));
     }
 
         /**
@@ -393,22 +393,22 @@ 
         $this->view->assign('documentTypes', $docTypes);
 
         $states[DocumentWorkflow::ALIAS_STATE_NEW] = LocalizationUtility::translate(
-            "manager.documentList.state.".DocumentWorkflow::ALIAS_STATE_NEW, 'dpf'
+            "manager.documentList.state." . DocumentWorkflow::ALIAS_STATE_NEW, 'dpf'
         );
         $states[DocumentWorkflow::ALIAS_STATE_REGISTERED] = LocalizationUtility::translate(
-            "manager.documentList.state.".DocumentWorkflow::ALIAS_STATE_REGISTERED, 'dpf'
+            "manager.documentList.state." . DocumentWorkflow::ALIAS_STATE_REGISTERED, 'dpf'
         );
         $states[DocumentWorkflow::ALIAS_STATE_IN_PROGRESS] = LocalizationUtility::translate(
-            "manager.documentList.state.".DocumentWorkflow::ALIAS_STATE_IN_PROGRESS, 'dpf'
+            "manager.documentList.state." . DocumentWorkflow::ALIAS_STATE_IN_PROGRESS, 'dpf'
         );
         $states[DocumentWorkflow::ALIAS_STATE_RELEASED] = LocalizationUtility::translate(
-            "manager.documentList.state.".DocumentWorkflow::ALIAS_STATE_RELEASED, 'dpf'
+            "manager.documentList.state." . DocumentWorkflow::ALIAS_STATE_RELEASED, 'dpf'
         );
         $states[DocumentWorkflow::ALIAS_STATE_POSTPONED] = LocalizationUtility::translate(
-            "manager.documentList.state.".DocumentWorkflow::ALIAS_STATE_POSTPONED, 'dpf'
+            "manager.documentList.state." . DocumentWorkflow::ALIAS_STATE_POSTPONED, 'dpf'
         );
         $states[DocumentWorkflow::ALIAS_STATE_DISCARDED] = LocalizationUtility::translate(
-            "manager.documentList.state.".DocumentWorkflow::ALIAS_STATE_DISCARDED, 'dpf'
+            "manager.documentList.state." . DocumentWorkflow::ALIAS_STATE_DISCARDED, 'dpf'
         );
 
         $this->view->assign('states', $states);
@@ -427,7 +427,7 @@ 
             $currentPage = 1;
         }
 
-        $this->list((empty($currentPage)? 0 : ($currentPage-1) * $this->itemsPerPage()), $simpleSearch);
+        $this->list((empty($currentPage) ? 0 : ($currentPage - 1) * $this->itemsPerPage()), $simpleSearch);
 
         $this->view->assign('simpleSearch', $simpleSearch);
         $this->view->assign('currentPage', $currentPage);
@@ -468,10 +468,10 @@ 
 
         if ($extSearch) {
             // redirect to extended search view
-            $this->forward("extendedSearch", null, null, array('results' => $results, 'query' => $args['query']));
+            $this->forward("extendedSearch", null, null, array ('results' => $results, 'query' => $args['query']));
         } else {
             // redirect to list view
-            $this->forward("list", null, null, array('results' => $results, 'query' => $args['query']));
+            $this->forward("list", null, null, array ('results' => $results, 'query' => $args['query']));
         }
     }
 
@@ -488,14 +488,14 @@ 
         $remoteRepository        = $this->objectManager->get(FedoraRepository::class);
         $documentTransferManager->setRemoteRepository($remoteRepository);
 
-        $args = array();
+        $args = array ();
 
         try {
             if ($documentTransferManager->retrieve($documentObjectIdentifier)) {
                 $key      = 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:document_retrieve.success';
                 $severity = \TYPO3\CMS\Core\Messaging\AbstractMessage::OK;
                 $document = $this->documentRepository->findOneByObjectIdentifier($documentObjectIdentifier);
-                $args[] = $document->getObjectIdentifier()." (".$document->getTitle().")";
+                $args[] = $document->getObjectIdentifier() . " (" . $document->getTitle() . ")";
             } else {
                 $severity = \TYPO3\CMS\Core\Messaging\AbstractMessage::ERROR;
                 $key = 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:error.retrieve_failed';
@@ -521,7 +521,7 @@ 
             true
         );
 
-        $this->forward('updateIndex', null, null, array('documentObjectIdentifier' => $documentObjectIdentifier));
+        $this->forward('updateIndex', null, null, array ('documentObjectIdentifier' => $documentObjectIdentifier));
     }
 
     /**
@@ -584,7 +584,7 @@ 
 
             $results = $elasticSearch->search($query, '');
 
-            $searchList = array();
+            $searchList = array ();
 
             // filter out identical document from the search result list
             foreach ($results['hits'] as $entry) {
@@ -640,7 +640,7 @@ 
         $client = $this->clientRepository->findAll()->current();
 
         // get the latest documents /CREATED_DATE
-        $query['body']['sort'] = array('CREATED_DATE' => array('order' => 'desc'));
+        $query['body']['sort'] = array ('CREATED_DATE' => array ('order' => 'desc'));
 
         // add owner id
         $query['body']['query']['bool']['must']['term']['OWNER_ID'] = $client->getOwnerId();
@@ -668,8 +668,8 @@ 
         $workspaceData = $this->session->getWorkspaceData();
         $itemsPerPage = $workspaceData->getItemsPerPage();
 
-        $default = ($this->settings['workspaceItemsPerPage'])? $this->settings['workspaceItemsPerPage'] : 10;
-        return ($itemsPerPage)? $itemsPerPage : $default;
+        $default = ($this->settings['workspaceItemsPerPage']) ? $this->settings['workspaceItemsPerPage'] : 10;
+        return ($itemsPerPage) ? $itemsPerPage : $default;
     }
 
 
@@ -683,7 +683,7 @@ 
         $luceneReservedCharacters = preg_quote('+-&|!(){}[]^~?:\\');
         $string                   = preg_replace_callback(
             '/([' . $luceneReservedCharacters . '])/',
-            function ($matches) {
+            function($matches) {
                 return '\\' . $matches[0];
             },
             $string

Upper-Lower-Casing +18 added lines, -18 removed lines

@@ -35,7 +35,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentRepository = null;
+    protected $documentRepository = NULL;
 
     /**
      * documenTypeRepository
@@ -51,7 +51,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\ClientRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $clientRepository = null;
+    protected $clientRepository = NULL;
 
 
     /**
@@ -60,7 +60,7 @@ 
      * @var \EWW\Dpf\Services\ElasticSearch\ElasticSearch
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $elasticSearch = null;
+    protected $elasticSearch = NULL;
 
 
     /**
@@ -69,7 +69,7 @@ 
      * @var \EWW\Dpf\Services\ElasticSearch\QueryBuilder
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $queryBuilder = null;
+    protected $queryBuilder = NULL;
 
 
     /**
@@ -87,7 +87,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\BookmarkRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $bookmarkRepository = null;
+    protected $bookmarkRepository = NULL;
 
     /**
      * fisDataService
@@ -95,7 +95,7 @@ 
      * @var \EWW\Dpf\Services\FeUser\FisDataService
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $fisDataService = null;
+    protected $fisDataService = NULL;
 
     /**
      * metadataGroupRepository
@@ -213,7 +213,7 @@ 
             $this->uriBuilder->getRequest()->getRequestUri()
         );
 
-        $currentPage = null;
+        $currentPage = NULL;
         $checkedDocumentIdentifiers = [];
         $pagination = $this->getParametersSafely('@widget_0');
         if ($pagination) {
@@ -250,7 +250,7 @@ 
      */
     protected function getSearchQuery(
         $from = 0, $bookmarkIdentifiers = [], $filters= [], $excludeFilters = [],
-        $sortField = null, $sortOrder = null, $queryString = null
+        $sortField = NULL, $sortOrder = NULL, $queryString = NULL
     )
     {
         $workspaceFilter = [
@@ -296,7 +296,7 @@ 
     public function batchAction($listData)
     {
         if (array_key_exists('action', $listData)) {
-            $this->forward($listData['action'], null, null, ['listData' => $listData]);
+            $this->forward($listData['action'], NULL, NULL, ['listData' => $listData]);
         }
     }
 
@@ -352,7 +352,7 @@ 
 
         list($redirectAction, $redirectController) = $this->session->getStoredAction();
         $this->redirect(
-            $redirectAction, $redirectController, null,
+            $redirectAction, $redirectController, NULL,
             array('message' => $message, 'checkedDocumentIdentifiers' =>  $checkedDocumentIdentifiers));
     }
 
@@ -417,7 +417,7 @@ 
             $this->uriBuilder->getRequest()->getRequestUri()
         );
 
-        $currentPage = null;
+        $currentPage = NULL;
         $checkedDocumentIdentifiers = [];
         $pagination = $this->getParametersSafely('@widget_0');
         if ($pagination) {
@@ -462,16 +462,16 @@ 
                 $message,
                 '',
                 $severity,
-                true
+                TRUE
             );
         }
 
         if ($extSearch) {
             // redirect to extended search view
-            $this->forward("extendedSearch", null, null, array('results' => $results, 'query' => $args['query']));
+            $this->forward("extendedSearch", NULL, NULL, array('results' => $results, 'query' => $args['query']));
         } else {
             // redirect to list view
-            $this->forward("list", null, null, array('results' => $results, 'query' => $args['query']));
+            $this->forward("list", NULL, NULL, array('results' => $results, 'query' => $args['query']));
         }
     }
 
@@ -518,10 +518,10 @@ 
             $message,
             '',
             $severity,
-            true
+            TRUE
         );
 
-        $this->forward('updateIndex', null, null, array('documentObjectIdentifier' => $documentObjectIdentifier));
+        $this->forward('updateIndex', NULL, NULL, array('documentObjectIdentifier' => $documentObjectIdentifier));
     }
 
     /**
@@ -623,10 +623,10 @@ 
                 $message,
                 '',
                 $severity,
-                true
+                TRUE
             );
 
-            $this->redirect('list', 'Document', null);
+            $this->redirect('list', 'Document', NULL);
         }
 
     }

Classes/Services/Settings/PluginSettings.php

Braces +2 added lines, -4 removed lines

@@ -14,8 +14,7 @@ 
  * The TYPO3 project - inspiring people to share!
  */
 
-class PluginSettings
-{
+class PluginSettings {
     /**
      *
      * @var \TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface
@@ -28,8 +27,7 @@ 
      *
      * @return mixed
      */
-    public function getSettings()
-    {
+    public function getSettings() {
         $frameworkConfiguration = $this->configurationManager->getConfiguration(
             \TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface::CONFIGURATION_TYPE_FRAMEWORK
         );

Classes/Services/Document/DocumentCleaner.php

Braces +4 added lines, -8 removed lines

@@ -14,8 +14,7 @@ 
  * The TYPO3 project - inspiring people to share!
  */
 
-class DocumentCleaner
-{
+class DocumentCleaner {
 
     /**
      * clientRepository
@@ -55,8 +54,7 @@ 
      * @param \EWW\Dpf\Domain\Model\Document $openedDocument
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException
      */
-    public function cleanUpDocuments($actionMethodName, $controllerClass)
-    {
+    public function cleanUpDocuments($actionMethodName, $controllerClass) {
         $excludeActions = [
             \EWW\Dpf\Controller\DocumentController::class => [
                 'showDetailsAction',
@@ -105,8 +103,7 @@ 
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\UnknownObjectException
      */
-    protected function cleanUpOutdatedTemporaryDocuments()
-    {
+    protected function cleanUpOutdatedTemporaryDocuments() {
         // Remove outdated temporary documents from the document table.
         $outdatedTemporaryDocuments = $this->documentRepository->findOutdatedTemporaryDocuments(3600);
         foreach ($outdatedTemporaryDocuments as $outdatedTemporaryDocument) {
@@ -119,8 +116,7 @@ 
     /**
      * Unlocks all editing locks of the current user.
      */
-    protected function cleanUpEditingLocks($actionMethodName, $controllerClass)
-    {
+    protected function cleanUpEditingLocks($actionMethodName, $controllerClass) {
         $excludeActions = [
             \EWW\Dpf\Controller\DocumentController::class => [
                 'duplicateAction'

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -23,7 +23,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentRepository = null;
+    protected $documentRepository = NULL;
 
     /**
      * editingLockService
@@ -31,7 +31,7 @@ 
      * @var \EWW\Dpf\Services\Document\EditingLockService
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $editingLockService = null;
+    protected $editingLockService = NULL;
 
     /**
      * persistence manager
@@ -47,7 +47,7 @@ 
      * @var \EWW\Dpf\Security\Security
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $security = null;
+    protected $security = NULL;
 
     /**
      * @param string $actionMethodName

Classes/Services/Transfer/FedoraRepository.php

Upper-Lower-Casing +15 added lines, -15 removed lines

@@ -81,12 +81,12 @@ 
             if (!$response->hasErrors() && $response->code == 201) {
                 return $this->getRemoteDocumentId($response);
             } else {
-                TransferLogger::Log('INGEST', $document->getUid(), null, $response);
+                TransferLogger::Log('INGEST', $document->getUid(), NULL, $response);
                 throw new \EWW\Dpf\Exceptions\IngestDocumentErrorException("Fedora error while ingest document.");
             }
         }
         catch (\Exception $exception) {
-            TransferLogger::Log('INGEST', $document->getUid(), null, $exception->getMessage());
+            TransferLogger::Log('INGEST', $document->getUid(), NULL, $exception->getMessage());
 
             if ($exception instanceof \Httpful\Exception\ConnectionErrorException) {
                 $message = $exception->getMessage();
@@ -96,7 +96,7 @@ 
             }
         }
 
-        return null;
+        return NULL;
     }
 
     /**
@@ -129,7 +129,7 @@ 
                 throw new \EWW\Dpf\Exceptions\UpdateDocumentErrorException("Fedora error while update document.");
             }
         } catch (\Exception $exception) {
-            TransferLogger::Log('UPDATE', $document->getUid(), null, $exception->getMessage());
+            TransferLogger::Log('UPDATE', $document->getUid(), NULL, $exception->getMessage());
 
             if ($exception instanceof \Httpful\Exception\ConnectionErrorException) {
                 $message = $exception->getMessage();
@@ -139,7 +139,7 @@ 
             }
         }
 
-        return null;
+        return NULL;
     }
 
     /**
@@ -162,11 +162,11 @@ 
             if (!$response->hasErrors() && $response->code == 200) {
                 return $response->__toString();
             } else {
-                TransferLogger::Log('RETRIEVE', null, $remoteId, $response);
+                TransferLogger::Log('RETRIEVE', NULL, $remoteId, $response);
                 throw new \EWW\Dpf\Exceptions\RetrieveDocumentErrorException("Fedora has returned an error.");
             }
         } catch (\Exception $exception) {
-            TransferLogger::Log('RETRIEVE', null, $remoteId, $exception->getMessage());
+            TransferLogger::Log('RETRIEVE', NULL, $remoteId, $exception->getMessage());
 
             if ($exception instanceof \Httpful\Exception\ConnectionErrorException) {
                 $message = $exception->getMessage();
@@ -176,7 +176,7 @@ 
             }
         }
 
-        return null;
+        return NULL;
     }
 
     /**
@@ -199,11 +199,11 @@ 
             if (!$response->hasErrors() && $response->code == 200) {
                 return $response->__toString();
             } else {
-                TransferLogger::Log('GET_NEXT_DOCUMENT_ID', null, null, $response);
+                TransferLogger::Log('GET_NEXT_DOCUMENT_ID', NULL, NULL, $response);
                 throw new \EWW\Dpf\Exceptions\NextDocumentIdErrorException("Fedora error while getting a document id.");
             }
         } catch (\Exception $exception) {
-            TransferLogger::Log('GET_NEXT_DOCUMENT_ID', null, null, $exception->getMessage());
+            TransferLogger::Log('GET_NEXT_DOCUMENT_ID', NULL, NULL, $exception->getMessage());
 
             if ($exception instanceof \Httpful\Exception\ConnectionErrorException) {
                 $message = $exception->getMessage();
@@ -213,7 +213,7 @@ 
             }
         }
 
-        return null;
+        return NULL;
     }
 
     /**
@@ -239,7 +239,7 @@ 
 
             // if transfer successful
             if (!$response->hasErrors() && $response->code == 204) {
-                return true;
+                return TRUE;
             } else {
                 TransferLogger::Log('DELETE', $document->getUid(), $remoteId, $response);
                 switch ($state) {
@@ -255,7 +255,7 @@ 
                 }
             }
         } catch (\Exception $exception) {
-            TransferLogger::Log('DELETE', $document->getUid(), null, $exception->getMessage());
+            TransferLogger::Log('DELETE', $document->getUid(), NULL, $exception->getMessage());
 
             if ($exception instanceof \Httpful\Exception\ConnectionErrorException) {
                 $message = $exception->getMessage();
@@ -265,7 +265,7 @@ 
             }
         }
 
-        return false;
+        return FALSE;
     }
 
     /**
@@ -289,7 +289,7 @@ 
             return $objectIdentifier;
         }
 
-        return null;
+        return NULL;
     }
 
     protected function getOwnerId($pid = NULL)

Indentation +5 added lines, -5 removed lines

@@ -34,11 +34,11 @@
     protected $documentTransferLogRepository;
 
     /**
-    * clientConfigurationManager
-    *
-    * @var \EWW\Dpf\Configuration\ClientConfigurationManager
-    * @TYPO3\CMS\Extbase\Annotation\Inject
-    */
+     * clientConfigurationManager
+     *
+     * @var \EWW\Dpf\Configuration\ClientConfigurationManager
+     * @TYPO3\CMS\Extbase\Annotation\Inject
+     */
     protected $clientConfigurationManager;
 
     /**

Spacing +3 added lines, -3 removed lines

@@ -51,13 +51,13 @@ 
 
     protected $response;
 
-    protected $errors = array();
+    protected $errors = array ();
 
     const X_ON_BEHALF_OF = 'X-On-Behalf-Of';
 
     protected function getFedoraType()
     {
-        return 'application/vnd.'. $this->clientConfigurationManager->getFedoraNamespace().'.mets+xml';
+        return 'application/vnd.' . $this->clientConfigurationManager->getFedoraNamespace() . '.mets+xml';
     }
 
     /**
@@ -244,7 +244,7 @@ 
 
         $remoteId = $document->getObjectIdentifier();
 
-        $stateParam = ($state)? "?" . $state : "";
+        $stateParam = ($state) ? "?" . $state : "";
 
         try {
             $response = Request::delete($this->clientConfigurationManager->getSwordHost() . "/sword/" . $this->getSWORDCollection() . "/" . $remoteId . $stateParam)

Braces +11 added lines, -22 removed lines

@@ -22,8 +22,7 @@ 
 use \EWW\Dpf\Services\Logger\TransferLogger;
 use \Httpful\Request;
 
-class FedoraRepository implements Repository
-{
+class FedoraRepository implements Repository {
 
     /**
      * documentTransferLogRepository
@@ -55,8 +54,7 @@ 
 
     const X_ON_BEHALF_OF = 'X-On-Behalf-Of';
 
-    protected function getFedoraType()
-    {
+    protected function getFedoraType() {
         return 'application/vnd.'. $this->clientConfigurationManager->getFedoraNamespace().'.mets+xml';
     }
 
@@ -68,8 +66,7 @@ 
      * @return string
      * @throws \Exception
      */
-    public function ingest($document, $metsXml)
-    {
+    public function ingest($document, $metsXml) {
         try {
 
             $response = Request::post($this->clientConfigurationManager->getSwordHost() . "/sword/" . $this->getSWORDCollection())
@@ -88,8 +85,7 @@ 
                 TransferLogger::Log('INGEST', $document->getUid(), null, $response);
                 throw new \EWW\Dpf\Exceptions\IngestDocumentErrorException("Fedora error while ingest document.");
             }
-        }
-        catch (\Exception $exception) {
+        } catch (\Exception $exception) {
             TransferLogger::Log('INGEST', $document->getUid(), null, $exception->getMessage());
 
             if ($exception instanceof \Httpful\Exception\ConnectionErrorException) {
@@ -111,8 +107,7 @@ 
      * @return string
      * @throws \Exception
      */
-    public function update($document, $metsXml)
-    {
+    public function update($document, $metsXml) {
 
         $remoteId = $document->getObjectIdentifier();
 
@@ -153,8 +148,7 @@ 
      * @return string
      * @throws \Exception
      */
-    public function retrieve($remoteId)
-    {
+    public function retrieve($remoteId) {
         try {
             $response = Request::get(
                 $this->clientConfigurationManager->getFedoraHost()
@@ -196,8 +190,7 @@ 
      * @return string
      * @throws \Exception
      */
-    public function getNextDocumentId()
-    {
+    public function getNextDocumentId() {
         try {
             $response = Request::get(
                 $this->clientConfigurationManager->getFedoraHost()
@@ -239,8 +232,7 @@ 
      * @return boolean
      * @throws \Exception
      */
-    public function delete($document, $state)
-    {
+    public function delete($document, $state) {
 
         $remoteId = $document->getObjectIdentifier();
 
@@ -289,8 +281,7 @@ 
      * @param  \Httpful\Response $response
      * @return string
      */
-    protected function getRemoteDocumentId($response)
-    {
+    protected function getRemoteDocumentId($response) {
 
         // Get repository ID and write into document
         $responseDom = new \DOMDocument();
@@ -307,8 +298,7 @@ 
         return null;
     }
 
-    protected function getOwnerId($pid = NULL)
-    {
+    protected function getOwnerId($pid = NULL) {
         if ($pid) {
             $this->clientConfigurationManager->setConfigurationPid($pid);
         }
@@ -321,8 +311,7 @@ 
         return $ownerId;
     }
 
-    protected function getSWORDCollection()
-    {
+    protected function getSWORDCollection() {
         return $this->clientConfigurationManager->getSwordCollectionNamespace();
     }
 }

Classes/Tasks/EmbargoTask.php

Braces +1 added lines, -2 removed lines

@@ -9,8 +9,7 @@
 use EWW\Dpf\Domain\Repository\DocumentRepository;
 
 
-class EmbargoTask extends \TYPO3\CMS\Scheduler\Task\AbstractTask
-{
+class EmbargoTask extends \TYPO3\CMS\Scheduler\Task\AbstractTask {
 
     public function execute() {
 

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -23,11 +23,11 @@
         foreach ($embargoDocuments as $document) {
             if ($currentDate > $document->getEmbargoDate()) {
 
-                if ($document->getRemoteState() == DocumentWorkflow::REMOTE_STATE_ACTIVE OR
-                    $document->getRemoteState() == DocumentWorkflow::REMOTE_STATE_DELETED OR
-                    $document->getRemoteState() == DocumentWorkflow::REMOTE_STATE_INACTIVE OR
-                    $document->getLocalState() == DocumentWorkflow::LOCAL_STATE_IN_PROGRESS OR
-                    $document->getLocalState() == DocumentWorkflow::LOCAL_STATE_POSTPONED OR
+                if ($document->getRemoteState() == DocumentWorkflow::REMOTE_STATE_ACTIVE or
+                    $document->getRemoteState() == DocumentWorkflow::REMOTE_STATE_DELETED or
+                    $document->getRemoteState() == DocumentWorkflow::REMOTE_STATE_INACTIVE or
+                    $document->getLocalState() == DocumentWorkflow::LOCAL_STATE_IN_PROGRESS or
+                    $document->getLocalState() == DocumentWorkflow::LOCAL_STATE_POSTPONED or
                     $document->getLocalState() == DocumentWorkflow::LOCAL_STATE_DISCARDED) {
                     // send message
                     $notifier = $objectManager->get(Notifier::class);

Classes/Controller/UserController.php

Braces +1 added lines, -2 removed lines

@@ -19,8 +19,7 @@
 /**
  * Controller for the "workspace"/"my publications" area.
  */
-class UserController  extends AbstractController
-{
+class UserController  extends AbstractController {
     /**
      * benutzerRepository
      *

Spacing +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
                 $this->addFlashMessage(
                     LocalizationUtility::translate("manager.locallang.user.settings.message.invalidFisId", "dpf"),
                     '',
-                    $severity,false
+                    $severity, false
                 );
             }
         }
@@ -61,7 +61,7 @@ 
         $this->addFlashMessage(
             LocalizationUtility::translate("manager.locallang.user.settings.message.successfullySaved", "dpf"),
             '',
-            $severity,false
+            $severity, false
         );
 
         $this->forward('settings');

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
                 $this->addFlashMessage(
                     LocalizationUtility::translate("manager.locallang.user.settings.message.invalidFisId", "dpf"),
                     '',
-                    $severity,false
+                    $severity,FALSE
                 );
             }
         }
@@ -61,7 +61,7 @@ 
         $this->addFlashMessage(
             LocalizationUtility::translate("manager.locallang.user.settings.message.successfullySaved", "dpf"),
             '',
-            $severity,false
+            $severity,FALSE
         );
 
         $this->forward('settings');

Configuration/TCA/Overrides/fe_users.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
 
 $temporaryColumns = array (
     'stored_searches' => [
-        'exclude' => true,
+        'exclude' => TRUE,
         'label' => 'stored_searches',
         'config' => [
             'type' => 'inline',

Spacing +6 added lines, -6 removed lines

@@ -86,28 +86,28 @@
             ),
         )
     ),
-    'fis_pers_id' => array(
+    'fis_pers_id' => array (
         'exclude' => 0,
         'label'   => 'LLL:EXT:dpf/Resources/Private/Language/locallang_db.xlf:tx_dpf_domain_model_feuser.fis_pers_id',
-        'config'  => array(
+        'config'  => array (
             'type' => 'input',
             'size' => '30',
             'eval' => 'trim',
         ),
     ),
-    'orga_name' => array(
+    'orga_name' => array (
         'exclude' => 0,
         'label'   => 'LLL:EXT:dpf/Resources/Private/Language/locallang_db.xlf:tx_dpf_domain_model_feuser.orga_name',
-        'config'  => array(
+        'config'  => array (
             'type' => 'input',
             'size' => '30',
             'eval' => 'trim',
         ),
     ),
-    'api_token' => array(
+    'api_token' => array (
         'exclude' => 0,
         'label'   => 'LLL:EXT:dpf/Resources/Private/Language/locallang_db.xlf:tx_dpf_domain_model_feuser.api_token',
-        'config'  => array(
+        'config'  => array (
             'type' => 'input',
             'size' => '30',
             'eval' => 'trim',

class.ext_update.php

Indentation +1 added lines, -1 removed lines

@@ -146,7 +146,7 @@
             }
         }
 
-       // $GLOBALS['TYPO3_DB']->sql_query("ALTER TABLE tx_dpf_domain_model_documenttype CHANGE virtual zzz_deleted_virtual SMALLINT UNSIGNED DEFAULT 0 NOT NULL");
+        // $GLOBALS['TYPO3_DB']->sql_query("ALTER TABLE tx_dpf_domain_model_documenttype CHANGE virtual zzz_deleted_virtual SMALLINT UNSIGNED DEFAULT 0 NOT NULL");
 
     }
 }
\ No newline at end of file

Spacing +5 added lines, -5 removed lines

@@ -30,7 +30,7 @@ 
 
     public function access() {
         $registry = GeneralUtility::makeInstance(Registry::class);
-        $version = $registry->get('tx_dpf','updatescript-'.self::VERSION);
+        $version = $registry->get('tx_dpf', 'updatescript-' . self::VERSION);
 
         // If the version has already been registered in the table sys_register the updatscript will be blocked.
         if ($version) {
@@ -43,7 +43,7 @@ 
     public function main() {
         // This script registers itself into the sys_registry table to prevent a re-run with the same version number.
         $registry = GeneralUtility::makeInstance(Registry::class);
-        $version = $registry->get('tx_dpf','updatescript-'.self::VERSION);
+        $version = $registry->get('tx_dpf', 'updatescript-' . self::VERSION);
         if ($version) {
             return FALSE;
         } else {
@@ -55,10 +55,10 @@ 
                 (new UpdateVirtualType)->execute();
                 //$GLOBALS['TYPO3_DB']->sql_query("update tx_dpf_domain_model_document set creator = owner");
             } catch (\Throwable $throwable) {
-                return "Error while updating the extension: ".($throwable->getMessage());
+                return "Error while updating the extension: " . ($throwable->getMessage());
             }
 
-            $registry->set('tx_dpf','updatescript-'.self::VERSION,TRUE);
+            $registry->set('tx_dpf', 'updatescript-' . self::VERSION, TRUE);
         }
 
         return "The extension has been successfully updated.";
@@ -123,7 +123,7 @@ 
             foreach ($repository->crossClientFindAll() as $record) {
                 if ($record['backend_only']) {
                     $recordObject = $repository->findByUid($record['uid']);
-                    $recordObject->setAccessRestrictionRoles(array(Security::ROLE_LIBRARIAN, Security::ROLE_RESEARCHER));
+                    $recordObject->setAccessRestrictionRoles(array (Security::ROLE_LIBRARIAN, Security::ROLE_RESEARCHER));
                     $repository->update($recordObject);
                 }
             }

Braces +4 added lines, -8 removed lines

@@ -66,16 +66,14 @@ 
 }
 
 
-class UpdateState
-{
+class UpdateState {
     const OBJECT_STATE_NEW             = "NEW";
     const OBJECT_STATE_ACTIVE          = "ACTIVE";
     const OBJECT_STATE_INACTIVE        = "INACTIVE";
     const OBJECT_STATE_DELETED         = "DELETED";
     const OBJECT_STATE_LOCALLY_DELETED = "LOCALLY_DELETED";
 
-    public function execute()
-    {
+    public function execute() {
         $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
         $documentRepository = $objectManager->get(DocumentRepository::class);
 
@@ -110,8 +108,7 @@ 
     }
 }
 
-class UpdateAccessRestrictions
-{
+class UpdateAccessRestrictions {
     public function execute() {
 
         $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
@@ -131,8 +128,7 @@ 
     }
 }
 
-class UpdateVirtualType
-{
+class UpdateVirtualType {
     public function execute() {
 
         $objectManager = GeneralUtility::makeInstance(ObjectManager::class);