Inspection of "add a test to make sure we handle fine binaries cr..." - kaliop-uk/ezmigrationbundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9143b7...9280dc )

by Gaetano

created 2021-01-06 22:58 UTC

Status

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -108,12 +108,12 @@  discard block
 block discarded – undo
         $users = [];
 
         foreach ($userIds as $userId) {
-            try{
+            try {
                 // return unique contents
                 $user = $this->repository->getUserService()->loadUser($userId);
 
                 $users[$user->id] = $user;
-            } catch(NotFoundException $e) {
+            } catch (NotFoundException $e) {
                 if (!$tolerateMisses) {
                     throw $e;
                 }
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
                 $user = $this->repository->getUserService()->loadUserByLogin($login);
 
                 $users[$user->id] = $user;
-            } catch(NotFoundException $e) {
+            } catch (NotFoundException $e) {
                 if (!$tolerateMisses) {
                     throw $e;
                 }
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
 
             try {
                 $group = $this->repository->getUserService()->loadUserGroup($groupId);
-            } catch(NotFoundException $e) {
+            } catch (NotFoundException $e) {
                 if ($tolerateMisses) {
                     continue;
                 } else {

Please login to merge, or discard this patch.

Core/Matcher/ObjectStateGroupMatcher.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -100,7 +100,7 @@
 block discarded – undo
                 // return unique contents
                 $objectStateGroup = $this->repository->getObjectStateService()->loadObjectStateGroup($objectStateGroupId);
                 $objectStateGroups[$objectStateGroup->id] = $objectStateGroup;
-            } catch(NotFoundException $e) {
+            } catch (NotFoundException $e) {
                 if (!$tolerateMisses) {
                     throw $e;
                 }

Please login to merge, or discard this patch.

Core/Matcher/LocationMatcherDirectLoad.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -36,11 +36,11 @@  discard block
 block discarded – undo
             $locations = array();
             switch ($key) {
                 case self::MATCH_LOCATION_ID:
-                    foreach($match as $locationId) {
+                    foreach ($match as $locationId) {
                         try {
                             $location = $this->repository->getLocationService()->loadLocation($locationId);
                             $locations[$location->id] = $location;
-                        } catch(NotFoundException $e) {
+                        } catch (NotFoundException $e) {
                             if (!$tolerateMisses) {
                                 throw $e;
                             }
@@ -48,11 +48,11 @@  discard block
 block discarded – undo
                     }
                     break;
                 case self::MATCH_LOCATION_REMOTE_ID:
-                    foreach($match as $locationRemoteId) {
+                    foreach ($match as $locationRemoteId) {
                         try {
                             $location = $this->repository->getLocationService()->loadLocationByRemoteId($locationRemoteId);
                             $locations[$location->id] = $location;
-                        } catch(NotFoundException $e) {
+                        } catch (NotFoundException $e) {
                             if (!$tolerateMisses) {
                                 throw $e;
                             }

Please login to merge, or discard this patch.

Core/Matcher/SectionMatcher.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -103,7 +103,7 @@  discard block
 block discarded – undo
                 // return unique contents
                 $section = $this->repository->getSectionService()->loadSection($sectionId);
                 $sections[$section->id] = $section;
-            } catch(NotFoundException $e) {
+            } catch (NotFoundException $e) {
                 if (!$tolerateMisses) {
                     throw $e;
                 }
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
                 // return unique contents
                 $section = $this->repository->getSectionService()->loadSectionByIdentifier($sectionIdentifier);
                 $sections[$section->id] = $section;
-            } catch(NotFoundException $e) {
+            } catch (NotFoundException $e) {
                 if (!$tolerateMisses) {
                     throw $e;
                 }

Please login to merge, or discard this patch.

Core/Matcher/UserGroupMatcher.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -106,7 +106,7 @@  discard block
 block discarded – undo
                 $userGroup = $this->repository->getUserService()->loadUserGroup($userGroupId);
 
                 $userGroups[$userGroup->id] = $userGroup;
-            } catch(NotFoundException $e) {
+            } catch (NotFoundException $e) {
                 if (!$tolerateMisses) {
                     throw $e;
                 }
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
                 $userGroup = $this->repository->getUserService()->loadUserGroup($content->id);
 
                 $userGroups[$userGroup->id] = $userGroup;
-            } catch(NotFoundException $e) {
+            } catch (NotFoundException $e) {
                 if (!$tolerateMisses) {
                     throw $e;
                 }

Please login to merge, or discard this patch.

Core/Matcher/LanguageMatcher.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -99,7 +99,7 @@  discard block
 block discarded – undo
                 // return unique contents
                 $language = $this->repository->getContentLanguageService()->loadLanguageById($languageId);
                 $languages[$language->id] = $language;
-            } catch(NotFoundException $e) {
+            } catch (NotFoundException $e) {
                 if (!$tolerateMisses) {
                     throw $e;
                 }
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
                 // return unique contents
                 $language = $this->repository->getContentLanguageService()->loadLanguage($languageIdentifier);
                 $languages[$language->id] = $language;
-            } catch(NotFoundException $e) {
+            } catch (NotFoundException $e) {
                 if (!$tolerateMisses) {
                     throw $e;
                 }

Please login to merge, or discard this patch.

Core/Matcher/ObjectStateMatcher.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -100,7 +100,7 @@
 block discarded – undo
                 // return unique contents
                 $objectState = $this->repository->getObjectStateService()->loadObjectState($objectStateId);
                 $objectStates[$objectState->id] = $objectState;
-            } catch(NotFoundException $e) {
+            } catch (NotFoundException $e) {
                 if (!$tolerateMisses) {
                     throw $e;
                 }

Please login to merge, or discard this patch.

Core/Matcher/ContentTypeGroupMatcher.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -100,7 +100,7 @@  discard block
 block discarded – undo
                 // return unique contents
                 $contentTypeGroup = $this->repository->getContentTypeService()->loadContentTypeGroup($contentTypeGroupId);
                 $contentTypeGroups[$contentTypeGroup->id] = $contentTypeGroup;
-            } catch(NotFoundException $e) {
+            } catch (NotFoundException $e) {
                 if (!$tolerateMisses) {
                     throw $e;
                 }
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
                 // return unique contents
                 $contentTypeGroup = $this->repository->getContentTypeService()->loadContentTypeGroupByIdentifier($contentTypeGroupIdentifier);
                 $contentTypeGroups[$contentTypeGroup->id] = $contentTypeGroup;
-            } catch(NotFoundException $e) {
+            } catch (NotFoundException $e) {
                 if (!$tolerateMisses) {
                     throw $e;
                 }

Please login to merge, or discard this patch.

Core/Matcher/ContentMatcherDirectLoad.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -37,11 +37,11 @@  discard block
 block discarded – undo
             $contents = array();
             switch ($key) {
                 case self::MATCH_CONTENT_ID:
-                    foreach($match as $contentId) {
+                    foreach ($match as $contentId) {
                         try {
                             $content = $this->repository->getContentService()->loadContent($contentId);
                             $contents[$content->id] = $content;
-                        } catch(NotFoundException $e) {
+                        } catch (NotFoundException $e) {
                             if (!$tolerateMisses) {
                                 throw $e;
                             }
@@ -49,11 +49,11 @@  discard block
 block discarded – undo
                     }
                     break;
                 case self::MATCH_CONTENT_REMOTE_ID:
-                    foreach($match as $contentRemoteId) {
+                    foreach ($match as $contentRemoteId) {
                         try {
                             $content = $this->repository->getContentService()->loadContentByRemoteId($contentRemoteId);
                             $contents[$content->id] = $content;
-                        } catch(NotFoundException $e) {
+                        } catch (NotFoundException $e) {
                             if (!$tolerateMisses) {
                                 throw $e;
                             }

Please login to merge, or discard this patch.

		@@ -108,12 +108,12 @@ discard block
		block discarded – undo
108	108	$users = [];
109	109
110	110	foreach ($userIds as $userId) {
111		- try{
	111	+ try {
112	112	// return unique contents
113	113	$user = $this->repository->getUserService()->loadUser($userId);
114	114
115	115	$users[$user->id] = $user;
116		- } catch(NotFoundException $e) {
	116	+ } catch (NotFoundException $e) {
117	117	if (!$tolerateMisses) {
118	118	throw $e;
119	119	}
		@@ -139,7 +139,7 @@ discard block
		block discarded – undo
139	139	$user = $this->repository->getUserService()->loadUserByLogin($login);
140	140
141	141	$users[$user->id] = $user;
142		- } catch(NotFoundException $e) {
	142	+ } catch (NotFoundException $e) {
143	143	if (!$tolerateMisses) {
144	144	throw $e;
145	145	}
		@@ -188,7 +188,7 @@ discard block
		block discarded – undo
188	188
189	189	try {
190	190	$group = $this->repository->getUserService()->loadUserGroup($groupId);
191		- } catch(NotFoundException $e) {
	191	+ } catch (NotFoundException $e) {
192	192	if ($tolerateMisses) {
193	193	continue;
194	194	} else {

		@@ -100,7 +100,7 @@
		block discarded – undo
100	100	// return unique contents
101	101	$objectStateGroup = $this->repository->getObjectStateService()->loadObjectStateGroup($objectStateGroupId);
102	102	$objectStateGroups[$objectStateGroup->id] = $objectStateGroup;
103		- } catch(NotFoundException $e) {
	103	+ } catch (NotFoundException $e) {
104	104	if (!$tolerateMisses) {
105	105	throw $e;
106	106	}

		@@ -36,11 +36,11 @@ discard block
		block discarded – undo
36	36	$locations = array();
37	37	switch ($key) {
38	38	case self::MATCH_LOCATION_ID:
39		- foreach($match as $locationId) {
	39	+ foreach ($match as $locationId) {
40	40	try {
41	41	$location = $this->repository->getLocationService()->loadLocation($locationId);
42	42	$locations[$location->id] = $location;
43		- } catch(NotFoundException $e) {
	43	+ } catch (NotFoundException $e) {
44	44	if (!$tolerateMisses) {
45	45	throw $e;
46	46	}
		@@ -48,11 +48,11 @@ discard block
		block discarded – undo
48	48	}
49	49	break;
50	50	case self::MATCH_LOCATION_REMOTE_ID:
51		- foreach($match as $locationRemoteId) {
	51	+ foreach ($match as $locationRemoteId) {
52	52	try {
53	53	$location = $this->repository->getLocationService()->loadLocationByRemoteId($locationRemoteId);
54	54	$locations[$location->id] = $location;
55		- } catch(NotFoundException $e) {
	55	+ } catch (NotFoundException $e) {
56	56	if (!$tolerateMisses) {
57	57	throw $e;
58	58	}

		@@ -103,7 +103,7 @@ discard block
		block discarded – undo
103	103	// return unique contents
104	104	$section = $this->repository->getSectionService()->loadSection($sectionId);
105	105	$sections[$section->id] = $section;
106		- } catch(NotFoundException $e) {
	106	+ } catch (NotFoundException $e) {
107	107	if (!$tolerateMisses) {
108	108	throw $e;
109	109	}
		@@ -128,7 +128,7 @@ discard block
		block discarded – undo
128	128	// return unique contents
129	129	$section = $this->repository->getSectionService()->loadSectionByIdentifier($sectionIdentifier);
130	130	$sections[$section->id] = $section;
131		- } catch(NotFoundException $e) {
	131	+ } catch (NotFoundException $e) {
132	132	if (!$tolerateMisses) {
133	133	throw $e;
134	134	}

		@@ -106,7 +106,7 @@ discard block
		block discarded – undo
106	106	$userGroup = $this->repository->getUserService()->loadUserGroup($userGroupId);
107	107
108	108	$userGroups[$userGroup->id] = $userGroup;
109		- } catch(NotFoundException $e) {
	109	+ } catch (NotFoundException $e) {
110	110	if (!$tolerateMisses) {
111	111	throw $e;
112	112	}
		@@ -136,7 +136,7 @@ discard block
		block discarded – undo
136	136	$userGroup = $this->repository->getUserService()->loadUserGroup($content->id);
137	137
138	138	$userGroups[$userGroup->id] = $userGroup;
139		- } catch(NotFoundException $e) {
	139	+ } catch (NotFoundException $e) {
140	140	if (!$tolerateMisses) {
141	141	throw $e;
142	142	}

		@@ -99,7 +99,7 @@ discard block
		block discarded – undo
99	99	// return unique contents
100	100	$language = $this->repository->getContentLanguageService()->loadLanguageById($languageId);
101	101	$languages[$language->id] = $language;
102		- } catch(NotFoundException $e) {
	102	+ } catch (NotFoundException $e) {
103	103	if (!$tolerateMisses) {
104	104	throw $e;
105	105	}
		@@ -124,7 +124,7 @@ discard block
		block discarded – undo
124	124	// return unique contents
125	125	$language = $this->repository->getContentLanguageService()->loadLanguage($languageIdentifier);
126	126	$languages[$language->id] = $language;
127		- } catch(NotFoundException $e) {
	127	+ } catch (NotFoundException $e) {
128	128	if (!$tolerateMisses) {
129	129	throw $e;
130	130	}

		@@ -100,7 +100,7 @@ discard block
		block discarded – undo
100	100	// return unique contents
101	101	$contentTypeGroup = $this->repository->getContentTypeService()->loadContentTypeGroup($contentTypeGroupId);
102	102	$contentTypeGroups[$contentTypeGroup->id] = $contentTypeGroup;
103		- } catch(NotFoundException $e) {
	103	+ } catch (NotFoundException $e) {
104	104	if (!$tolerateMisses) {
105	105	throw $e;
106	106	}
		@@ -125,7 +125,7 @@ discard block
		block discarded – undo
125	125	// return unique contents
126	126	$contentTypeGroup = $this->repository->getContentTypeService()->loadContentTypeGroupByIdentifier($contentTypeGroupIdentifier);
127	127	$contentTypeGroups[$contentTypeGroup->id] = $contentTypeGroup;
128		- } catch(NotFoundException $e) {
	128	+ } catch (NotFoundException $e) {
129	129	if (!$tolerateMisses) {
130	130	throw $e;
131	131	}

		@@ -37,11 +37,11 @@ discard block
		block discarded – undo
37	37	$contents = array();
38	38	switch ($key) {
39	39	case self::MATCH_CONTENT_ID:
40		- foreach($match as $contentId) {
	40	+ foreach ($match as $contentId) {
41	41	try {
42	42	$content = $this->repository->getContentService()->loadContent($contentId);
43	43	$contents[$content->id] = $content;
44		- } catch(NotFoundException $e) {
	44	+ } catch (NotFoundException $e) {
45	45	if (!$tolerateMisses) {
46	46	throw $e;
47	47	}
		@@ -49,11 +49,11 @@ discard block
		block discarded – undo
49	49	}
50	50	break;
51	51	case self::MATCH_CONTENT_REMOTE_ID:
52		- foreach($match as $contentRemoteId) {
	52	+ foreach ($match as $contentRemoteId) {
53	53	try {
54	54	$content = $this->repository->getContentService()->loadContentByRemoteId($contentRemoteId);
55	55	$contents[$content->id] = $content;
56		- } catch(NotFoundException $e) {
	56	+ } catch (NotFoundException $e) {
57	57	if (!$tolerateMisses) {
58	58	throw $e;
59	59	}

kaliop-uk / ezmigrationbundle

Push — master ( 9143b7...9280dc )

Status

Category

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch