joenilson / fsRepublicaDominicana

Model/Join/FiscalReport608.php

Spacing +10 added lines, -10 removed lines

@@ -39,14 +39,14 @@ 
             'idempresa' => static::MAIN_TABLE.'.idempresa',
             'codalmacen' => static::MAIN_TABLE.'.codalmacen',
             'ncf' => static::MAIN_TABLE.'.numeroncf',
-            'tipoanulacion' => 'CASE WHEN ' .
-                                static::ESTADOSDOC_TABLE . '.nombre = \'Anulada\' AND ' .
-                                static::MAIN_TABLE.'.ncftipoanulacion is null ' .
-                                'THEN CONCAT(\'05\',\' - \',\'Corrección de la Información\') ELSE ' .
-                                'concat(' . static::MAIN_TABLE.'.ncftipoanulacion, \' - \', ' .
+            'tipoanulacion' => 'CASE WHEN '.
+                                static::ESTADOSDOC_TABLE.'.nombre = \'Anulada\' AND '.
+                                static::MAIN_TABLE.'.ncftipoanulacion is null '.
+                                'THEN CONCAT(\'05\',\' - \',\'Corrección de la Información\') ELSE '.
+                                'concat('.static::MAIN_TABLE.'.ncftipoanulacion, \' - \', '.
                                 static::NCFCANCELTYPE_TABLE.'.descripcion) END',
             'fecha' => $dateFormat.'('.static::MAIN_TABLE.'.fecha,\''.$dateFormatString.'\')',
-            'estado' => 'CASE WHEN ' . static::ESTADOSDOC_TABLE .
+            'estado' => 'CASE WHEN '.static::ESTADOSDOC_TABLE.
                         '.nombre = \'Emitida\' THEN \'Activo\' ELSE \'Anulado\' END',
         ];
         return $data;
@@ -59,10 +59,10 @@ 
     protected function getSQLFrom(): string
     {
         return static::MAIN_TABLE
-            . ' JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado AND '.static::ESTADOSDOC_TABLE.'.nombre = \'Anulada\')'
-            . ' LEFT JOIN ' . static::NCFCANCELTYPE_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.ncftipoanulacion = ' . static::NCFCANCELTYPE_TABLE . '.codigo)';
+            . ' JOIN '.static::ESTADOSDOC_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado AND '.static::ESTADOSDOC_TABLE.'.nombre = \'Anulada\')'
+            . ' LEFT JOIN '.static::NCFCANCELTYPE_TABLE.' ON ('
+            . static::MAIN_TABLE.'.ncftipoanulacion = '.static::NCFCANCELTYPE_TABLE.'.codigo)';
     }
 
     /**

Mod/SalesFooterMod.php

Spacing +20 added lines, -24 removed lines

@@ -28,21 +28,21 @@ 
 
 class SalesFooterMod implements SalesModInterface
 {
-    public function apply(SalesDocument &$model, array $formData, User $user)
+    public function apply(SalesDocument & $model, array $formData, User $user)
     {
         // TODO: Implement apply() method.
     }
 
-    public function applyBefore(SalesDocument &$model, array $formData, User $user)
+    public function applyBefore(SalesDocument & $model, array $formData, User $user)
     {
         // TODO: Implement applyBefore() method.
         if ($model->modelClassName() === 'FacturaCliente') {
-            $model->numeroncf = isset($formData['numeroncf']) ? (string)$formData['numeroncf'] : $model->numeroncf;
-            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string)$formData['tipocomprobante'] : $model->tipocomprobante;
-            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string)$formData['ncffechavencimiento'] : $model->ncffechavencimiento;
-            $model->ncftipopago = isset($formData['ncftipopago']) ? (string)$formData['ncftipopago'] : $model->ncftipopago;
-            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string)$formData['ncftipomovimiento'] : $model->ncftipomovimiento;
-            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string)$formData['ncftipoanulacion'] : $model->ncftipoanulacion;
+            $model->numeroncf = isset($formData['numeroncf']) ? (string) $formData['numeroncf'] : $model->numeroncf;
+            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string) $formData['tipocomprobante'] : $model->tipocomprobante;
+            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string) $formData['ncffechavencimiento'] : $model->ncffechavencimiento;
+            $model->ncftipopago = isset($formData['ncftipopago']) ? (string) $formData['ncftipopago'] : $model->ncftipopago;
+            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string) $formData['ncftipomovimiento'] : $model->ncftipomovimiento;
+            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string) $formData['ncftipoanulacion'] : $model->ncftipoanulacion;
         }
     }
 
@@ -105,7 +105,7 @@ 
         if (!$model->editable) {
             $invoiceTipoComprobante = $model->tipocomprobante;
         } elseif ($model->editable === true && ($cliente->tipocomprobante !== $model->tipocomprobante) && $model->tipocomprobante !== null) {
-            $invoiceTipoComprobante =  $model->tipocomprobante;
+            $invoiceTipoComprobante = $model->tipocomprobante;
         } elseif ($model->editable === true && ($cliente->tipocomprobante === $model->tipocomprobante) && $model->tipocomprobante !== null) {
             $invoiceTipoComprobante = $cliente->tipocomprobante;
         }
@@ -113,15 +113,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoComprobante as $row) {
             $options[] = ($row->tipocomprobante === $invoiceTipoComprobante) ?
-                '<option value="' . $row->tipocomprobante . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->tipocomprobante . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->tipocomprobante.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->tipocomprobante.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = ($model->editable || $model->numeroncf === '') ? 'id="tipocomprobante" name="tipocomprobante" required="" onChange="verificarCorrelativoNCF(this.value,\'Ventas\')"' : 'disabled=""';
         return '<div class="col-sm-3">'
             . '<div class="form-group">'
             .  $i18n->trans('tipocomprobante')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -145,15 +144,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoPago as $row) {
             $options[] = ($row->codigo === $invoiceTipoPago) ?
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = $model->editable ? 'name="ncftipopago" required=""' : 'disabled=""';
         return '<div class="col-sm-2">'
             . '<div class="form-group">'
             .  $i18n->trans('ncf-payment-type')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -173,15 +171,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoMovimiento as $row) {
             $options[] = ($row->codigo === $invoiceTipoMovimiento) ?
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = $model->editable ? 'name="ncftipomovimiento" required=""' : 'disabled=""';
         return '<div class="col-sm-3">'
             . '<div class="form-group">'
             .  $i18n->trans('ncf-movement-type')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -199,15 +196,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoAnulacion as $row) {
             $options[] = ($row->codigo === $invoiceTipoAnulacion) ?
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = $model->editable ? 'name="ncftipoanulacion"' : 'disabled=""';
         return '<div class="col-sm-2">'
             . '<div class="form-group">'
             .  $i18n->trans('ncf-cancellation-type')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -216,8 +212,8 @@ 
     {
         $attributes = ($model->editable && $model->numero2 === '') ? 'name="ncffechavencimiento"' : 'name="ncffechavencimiento" disabled=""';
         return '<div class="col-sm-2">'
-            . '<div class="form-group">' . $i18n->trans('due-date')
-            . '<input type="date" ' . $attributes . ' value="' . date('Y-m-d', strtotime($model->ncffechavencimiento)) . '" class="form-control"/>'
+            . '<div class="form-group">'.$i18n->trans('due-date')
+            . '<input type="date" '.$attributes.' value="'.date('Y-m-d', strtotime($model->ncffechavencimiento)).'" class="form-control"/>'
             . '</div>'
             . '</div>';
     }
@@ -236,7 +232,7 @@ 
             . '<div class="form-group">'
             . $i18n->trans('desc-numeroncf-sales')
             //. '<div class="input-group">'
-            . '<input type="text" ' . $attributes . ' value="' . $model->numeroncf . '" class="form-control"/>'
+            . '<input type="text" '.$attributes.' value="'.$model->numeroncf.'" class="form-control"/>'
 //            . '<div class="input-group-append">'
 //            . '<button class="btn ' . $btnColor .' btn-spin-action" id="btnVerifyNCF"'
 //            . 'onclick="purchasesNCFVerify()" '

Lib/Export/DgiiExport.php

Spacing +2 added lines, -2 removed lines

@@ -82,10 +82,10 @@
     /**
      * @inheritDoc
      */
-    public function show(Response &$response)
+    public function show(Response & $response)
     {
         $response->headers->set('Content-Type', 'text/text; charset=utf-8');
-        $response->headers->set('Content-Disposition', 'attachment;filename=' . $this->getFileName() . '.txt');
+        $response->headers->set('Content-Disposition', 'attachment;filename='.$this->getFileName().'.txt');
         $response->setContent($this->getDoc());
     }
 }
\ No newline at end of file

Model/Join/FiscalReport607.php

Spacing +4 added lines, -4 removed lines

@@ -92,10 +92,10 @@
     protected function getSQLFrom(): string
     {
         return static::MAIN_TABLE
-            . ' LEFT JOIN '. static::SECONDARY_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idfacturarect = ' . static::SECONDARY_TABLE_ALIAS . '.idfactura)'
-            . ' LEFT JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado AND '
+            . ' LEFT JOIN '.static::SECONDARY_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idfacturarect = '.static::SECONDARY_TABLE_ALIAS.'.idfactura)'
+            . ' LEFT JOIN '.static::ESTADOSDOC_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado AND '
             . static::ESTADOSDOC_TABLE.'.nombre != \'Anulada\')';
     }
 

Controller/FiscalReports.php

Spacing +3 added lines, -3 removed lines

@@ -115,8 +115,8 @@ 
             $fileName = 'DGII_'.$reportCode.'_'.$this->empresa->cifnif.'_'.$year.'_'.$month.'.txt';
             $commonFunctions->exportTXT($reportCode, $fileName, $this->empresa->cifnif, $year, $month, $whereReport);
             $this->response->headers->set('Content-type', 'text/plain');
-            $this->response->headers->set('Content-Disposition', 'attachment;filename=' . $fileName);
-            $this->response->setContent(file_get_contents(\FS_FOLDER . DIRECTORY_SEPARATOR . $fileName));
+            $this->response->headers->set('Content-Disposition', 'attachment;filename='.$fileName);
+            $this->response->setContent(file_get_contents(\FS_FOLDER.DIRECTORY_SEPARATOR.$fileName));
         }
     }
 
@@ -210,7 +210,7 @@ 
         $periodStartDate = \date('Y-m-01');
         $periodEndDate = \date('Y-m-d');
         PeriodTools::applyPeriod('last-month', $periodStartDate, $periodEndDate);
-        if (in_array($this->request->request->get('filterfecha'), ['',null], true) === false) {
+        if (in_array($this->request->request->get('filterfecha'), ['', null], true) === false) {
             PeriodTools::applyPeriod($this->request->request->get('filterfecha'), $periodStartDate, $periodEndDate);
         } else {
             $periodStartDate = $this->request->request->get('filterstartfecha') ?? $periodStartDate;

Extension/Model/FacturaCliente.php

Spacing +3 added lines, -3 removed lines

@@ -65,7 +65,7 @@ 
 
     public function saveBefore(): Closure
     {
-        return function () {
+        return function() {
 
             $ncfrango = new NCFRango();
             $cliente = new Cliente();
@@ -103,11 +103,11 @@ 
 
     public function all(): Closure
     {
-        return function () {
+        return function() {
             $this->facturarectnumero2 = '';
             if ($this->idfacturarect !== '') {
                 $facturaRectificativa = $this->get($this->idfacturarect);
-                $this->loadFromData(['facturarectnumero2' => 'SI' ]);
+                $this->loadFromData(['facturarectnumero2' => 'SI']);
                 $this->facturarectnumero2 = $facturaRectificativa->numero2;
             } else {
                 $this->loadFromData(['facturarectnumero2' => 'NO HAY']);