Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 18 | View Code Duplication | class TaxonomyTermDrupal8 extends DriverEntityPluginDrupal8Base |
|
|
|
|||
| 19 | { |
||
| 20 | |||
| 21 | /** |
||
| 22 | * The id of the attached term. |
||
| 23 | * |
||
| 24 | * @var integer; |
||
| 25 | * |
||
| 26 | * @deprecated Use id() instead. |
||
| 27 | */ |
||
| 28 | public $tid; |
||
| 29 | |||
| 30 | /** |
||
| 31 | * {@inheritdoc} |
||
| 32 | */ |
||
| 33 | public function load($entityId) |
||
| 39 | |||
| 40 | /** |
||
| 41 | * {@inheritdoc} |
||
| 42 | */ |
||
| 43 | public function save() |
||
| 48 | |||
| 49 | /** |
||
| 50 | * {@inheritdoc} |
||
| 51 | */ |
||
| 52 | public function getBundleKeyLabels() |
||
| 62 | } |
||
| 63 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.