Completed
Push — master ( 44c0fb...ccd5fd )
by Sinnarasa
01:52
created
src/Routing/Matcher/ArrayMatcher.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -125,7 +125,9 @@  discard block
 block discarded – undo
125 125
         $url = (isset($_SERVER['REQUEST_SCHEME']) ? $_SERVER['REQUEST_SCHEME'] : 'http') . '://' . ($host = (isset($_SERVER['SERVER_NAME']) ? $_SERVER['SERVER_NAME'] : $_SERVER['HTTP_HOST']));
126 126
         $host = explode(':', $host)[0];
127 127
         $domain = $this->router->collection->getDomain($url);
128
-        if (!empty($this->request['subdomain']) && $route[0] == '/') $route = trim($this->request['subdomain'], '.') . '.' . $domain . $route;
128
+        if (!empty($this->request['subdomain']) && $route[0] == '/') {
129
+            $route = trim($this->request['subdomain'], '.') . '.' . $domain . $route;
130
+        }
129 131
         if ($route[0] == '/') {
130 132
             return ($host != $domain) ? false : true;
131 133
         } elseif ($route[0] != '/' && $host != $domain) {
@@ -333,14 +335,18 @@  discard block
 block discarded – undo
333 335
     {
334 336
         if (is_string($callback) && strpos($callback, '@') !== false) {
335 337
             $routes = explode('@', $callback);
336
-            if (!isset($routes[1])) $routes[1] = 'index';
338
+            if (!isset($routes[1])) {
339
+                $routes[1] = 'index';
340
+            }
337 341
             if ($routes[1] == '{method}') {
338 342
                 $params = explode('/', preg_replace('#' . str_replace('*', '', $this->request['route']) . '#', '', $this->router->route->getUrl()));
339 343
                 $routes[1] = empty($params[0]) ? 'index' : $params[0];
340 344
                 $this->request['@method'] = $routes[1];
341 345
                 array_shift($params);
342 346
                 array_merge($this->request['parameters'], $params);
343
-                if (preg_match('/[A-Z]/', $routes[1])) return false;
347
+                if (preg_match('/[A-Z]/', $routes[1])) {
348
+                    return false;
349
+                }
344 350
                 $routes[1] = lcfirst(str_replace(' ', '', ucwords(str_replace('-', ' ', $routes[1]))));
345 351
             }
346 352
             $index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
Please login to merge, or discard this patch.
src/Routing/RouteCollection.php 1 patch
Braces   +53 added lines, -24 removed lines patch added patch discarded remove patch
@@ -33,7 +33,9 @@  discard block
 block discarded – undo
33 33
      */
34 34
     public function __construct($routes = null, $options = [])
35 35
     {
36
-        if (!is_null($routes) || !empty($options)) $this->addRoutes($routes, $options);
36
+        if (!is_null($routes) || !empty($options)) {
37
+            $this->addRoutes($routes, $options);
38
+        }
37 39
     }
38 40
 
39 41
     /**
@@ -43,10 +45,16 @@  discard block
 block discarded – undo
43 45
     public function addRoutes($routes = null, $options = [])
44 46
     {
45 47
         if (!is_null($routes) && !is_array($routes)) {
46
-            if (strpos($routes, '.php') === false) $routes = trim($routes, '/') . '/';
47
-            if (is_file($routes . '/routes.php') && is_array($routesFile = include $routes . '/routes.php')) $routes = $routesFile;
48
-            elseif (is_file($routes) && is_array($routesFile = include $routes)) $routes = $routesFile;
49
-            else throw new \InvalidArgumentException('Argument for "' . get_called_class() . '" constructor is not recognized. Expected argument array or file containing array but "' . $routes . '" given');
48
+            if (strpos($routes, '.php') === false) {
49
+                $routes = trim($routes, '/') . '/';
50
+            }
51
+            if (is_file($routes . '/routes.php') && is_array($routesFile = include $routes . '/routes.php')) {
52
+                $routes = $routesFile;
53
+            } elseif (is_file($routes) && is_array($routesFile = include $routes)) {
54
+                $routes = $routesFile;
55
+            } else {
56
+                throw new \InvalidArgumentException('Argument for "' . get_called_class() . '" constructor is not recognized. Expected argument array or file containing array but "' . $routes . '" given');
57
+            }
50 58
         }
51 59
         $this->routes['routes_' . $this->countRoutes] = is_array($routes) ? $routes : [];
52 60
         $this->setRoutes($options, $this->countRoutes);
@@ -59,8 +67,9 @@  discard block
 block discarded – undo
59 67
      */
60 68
     public function getRoutes($key = null)
61 69
     {
62
-        if (!is_null($key))
63
-            return isset($this->routes[$key]) ? $this->routes[$key] : '';
70
+        if (!is_null($key)) {
71
+                    return isset($this->routes[$key]) ? $this->routes[$key] : '';
72
+        }
64 73
         return $this->routes;
65 74
     }
66 75
 
@@ -71,12 +80,18 @@  discard block
 block discarded – undo
71 80
     {
72 81
         if (is_array($args)) {
73 82
             $nbrArgs = count($args);
74
-            for ($i = 0; $i < $nbrArgs; ++$i)
75
-                $this->routes['prefix_' . $i] = '/' . trim($args[$i], '/');
76
-        } elseif (is_string($args))
77
-            for ($i = 0; $i < $this->countRoutes; ++$i)
78
-                $this->routes['prefix_' . $i] = '/' . trim($args, '/');
79
-        if ($this->countRoutes == 0) $this->countRoutes++;
83
+            for ($i = 0; $i < $nbrArgs; ++$i) {
84
+                            $this->routes['prefix_' . $i] = '/' . trim($args[$i], '/');
85
+            }
86
+        } elseif (is_string($args)) {
87
+                    for ($i = 0;
88
+        }
89
+        $i < $this->countRoutes; ++$i) {
90
+                            $this->routes['prefix_' . $i] = '/' . trim($args, '/');
91
+            }
92
+        if ($this->countRoutes == 0) {
93
+            $this->countRoutes++;
94
+        }
80 95
     }
81 96
 
82 97
     /**
@@ -88,10 +103,14 @@  discard block
 block discarded – undo
88 103
         for ($i = 0; $i < $nbrArgs; ++$i) {
89 104
             if (is_array($args[$i])) {
90 105
                 $this->setRoutes($args[$i], $i);
91
-                if (!isset($this->routes['routes_' . $i])) $this->routes['routes_' . $i] = [];
106
+                if (!isset($this->routes['routes_' . $i])) {
107
+                    $this->routes['routes_' . $i] = [];
108
+                }
92 109
             }
93 110
         }
94
-        if ($this->countRoutes == 0) $this->countRoutes++;
111
+        if ($this->countRoutes == 0) {
112
+            $this->countRoutes++;
113
+        }
95 114
     }
96 115
 
97 116
     /**
@@ -122,7 +141,7 @@  discard block
 block discarded – undo
122 141
         if(!is_null($root)){
123 142
             $protocol = explode('://', $root);
124 143
             $protocol = $protocol[0];
125
-        }else{
144
+        } else{
126 145
             $root = $protocol . '://' . $domain . ((!empty($_SERVER['SERVER_PORT']) && $_SERVER['SERVER_PORT'] != 80) ? ':' . $_SERVER['SERVER_PORT'] : '') . str_replace('/' . $script_file, '', $_SERVER['SCRIPT_NAME']);
127 146
         }
128 147
 
@@ -137,10 +156,11 @@  discard block
 block discarded – undo
137 156
             $subdomain = (isset($this->routes['subdomain_' . $i])) ? $this->routes['subdomain_' . $i] : '';
138 157
             $block_protocol = (isset($this->routes['protocol_' . $i])) ? $this->routes['protocol_' . $i] : 'http';
139 158
             $url = (!empty($subdomain)) ? str_replace($protocol . '://', $block_protocol . '://' . $subdomain . '.', $root) : $root;
140
-            if (isset($this->routes['routes_' . $i]))
141
-                foreach ($this->routes['routes_' . $i] as $route => $dependencies) {
159
+            if (isset($this->routes['routes_' . $i])) {
160
+                            foreach ($this->routes['routes_' . $i] as $route => $dependencies) {
142 161
                     if (is_array($dependencies) && isset($dependencies['use']) && !is_array($dependencies['use'])) {
143
-                        $use = (is_callable($dependencies['use'])) ? 'closure-' . $count : trim($dependencies['use'], '/');
162
+                        $use = (is_callable($dependencies['use'])) ? 'closure-' . $count : trim($dependencies['use'], '/');
163
+            }
144 164
                     } elseif (!is_array($dependencies)) {
145 165
                         $use = (is_callable($dependencies)) ? 'closure-' . $count : trim($dependencies, '/');
146 166
                     } else {
@@ -186,11 +206,20 @@  discard block
 block discarded – undo
186 206
     {
187 207
         foreach ($this->routesByName as $key => $route) {
188 208
             $param = explode('#', $key);
189
-            if(isset($params['{subdomain}'])) $route = str_replace('*', $params['{subdomain}'], $route);
190
-            if(isset($params['{method}'])) $route = str_replace('*', $params['{method}'], $route);
191
-            foreach ($params as $key2 => $value) $route = str_replace(':' . $key2, $value, $route);
192
-            if ($param[0] == trim($name, '/')) return $route;
193
-            else if (isset($param[1]) && $param[1] == $name) return $route;
209
+            if(isset($params['{subdomain}'])) {
210
+                $route = str_replace('*', $params['{subdomain}'], $route);
211
+            }
212
+            if(isset($params['{method}'])) {
213
+                $route = str_replace('*', $params['{method}'], $route);
214
+            }
215
+            foreach ($params as $key2 => $value) {
216
+                $route = str_replace(':' . $key2, $value, $route);
217
+            }
218
+            if ($param[0] == trim($name, '/')) {
219
+                return $route;
220
+            } else if (isset($param[1]) && $param[1] == $name) {
221
+                return $route;
222
+            }
194 223
         }
195 224
         return null;
196 225
     }
Please login to merge, or discard this patch.