Jaxon\Container\Traits\ResponseTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getResponseManager()	0	3	1
A	registerResponses()	0	12	1
A	newResponse()	0	3	1
A	getResponse()	0	3	1

<?php

Missing file doc comment

namespace Jaxon\Container\Traits;

use Jaxon\Jaxon;
use Jaxon\Response\Response;
use Jaxon\Response\Manager as ResponseManager;

trait ResponseTrait

Missing doc comment for trait ResponseTrait

{
    /**
     * Register the values into the container
     *
     * @return void
     */
    private function registerResponses()

Expected 2 blank lines before function; 0 found

    {
        /*
         * Core library objects
         */

Empty line required after block comment

        // Global Response
        $this->set(Response::class, function() {

It seems like set() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return new Response();
        });
        // Response Manager
        $this->set(ResponseManager::class, function($c) {
            return new ResponseManager($c->g(Jaxon::class));
        });
    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the response manager
     *
     * @return ResponseManager
     */
    public function getResponseManager()
    {
        return $this->g(ResponseManager::class);

It seems like g() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the global Response object
     *
     * @return Response
     */
    public function getResponse()
    {
        return $this->g(Response::class);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Create a new Jaxon response object
     *
     * @return Response
     */
    public function newResponse()
    {
        return new Response();
    }

Expected 2 blank lines after function; 0 found

}