Issues in AwsS3v3Factory.php - Fixed Issues - Inspection of "- Drop PHP 5.4" - iPublikuj/flysystem - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 543e5f...eade68 )

by Adam

created 2016-04-27 07:19 UTC

Flysystem/Factories/Adapters/AwsS3v3Factory.php (2 issues)

Labels

Severity

Adam Kadlec 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * AwsS3v3Factory.php
 *
 * @copyright      More in license.md
 * @license        http://www.ipublikuj.eu
 * @author         Adam Kadlec http://www.ipublikuj.eu
 * @package        iPublikuj:Flysystem!
 * @subpackage     Adapters
 * @since          1.0.0
 *
 * @date           19.04.16
 */

namespace IPub\Flysystem\Factories\Adapters;

use Nette;
use Nette\Utils;

use League\Flysystem;
use League\Flysystem\AwsS3v3;

use Aws\S3\S3Client;

/**
 * AWS S3 v3 adapter filesystem factory
 *
 * @package        iPublikuj:Flysystem!
 * @subpackage     Adapters
 *
 * @author         Adam Kadlec <[email protected]>
 */
class AwsS3v3Factory
{
	/**
	 * @param Utils\ArrayHash $parameters
	 *
	 * @return AwsS3v3\AwsS3Adapter
	 */
	public static function create(Utils\ArrayHash $parameters)
	{
		$client = new S3Client(

			[
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				'credentials' => [
					'key'    => $parameters->accessKey,
					'secret' => $parameters->accessSecret,
				],
				'region'      => $parameters->region,
				'version'     => $parameters->version,
			]
		);

		return new AwsS3v3\AwsS3Adapter(
			$client,
			$parameters->bucket,
			$parameters->prefix
		);
	}
}


1			<?php
2			/**
3			* AwsS3v3Factory.php
4			*
5			* @copyright More in license.md
6			* @license http://www.ipublikuj.eu
7			* @author Adam Kadlec http://www.ipublikuj.eu
8			* @package iPublikuj:Flysystem!
9			* @subpackage Adapters
10			* @since 1.0.0
11			*
12			* @date 19.04.16
13			*/
14
15			namespace IPub\Flysystem\Factories\Adapters;
16
17			use Nette;
18			use Nette\Utils;
19
20			use League\Flysystem;
21			use League\Flysystem\AwsS3v3;
22
23			use Aws\S3\S3Client;
24
25			/**
26			* AWS S3 v3 adapter filesystem factory
27			*
28			* @package iPublikuj:Flysystem!
29			* @subpackage Adapters
30			*
31			* @author Adam Kadlec <[email protected]>
32			*/
33			class AwsS3v3Factory
34			{
35			/**
36			* @param Utils\ArrayHash $parameters
37			*
38			* @return AwsS3v3\AwsS3Adapter
39			*/
40			public static function create(Utils\ArrayHash $parameters)
41			{
42			$client = new S3Client(
			0 ignored issues – show Bug introduced 2016-04-27 07:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `S3Client::__construct()` misses some required arguments starting with `$signature`. Loading history...
43			[
			0 ignored issues – show Documentation introduced 2016-04-27 07:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('credentials' => a...> $parameters->version)` is of type `array<string,?,{"credent...on":"?","version":"?"}>`, but the function expects a `object<Aws\Common\Creden...s\CredentialsInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44			'credentials' => [
45			'key' => $parameters->accessKey,
46			'secret' => $parameters->accessSecret,
47			],
48			'region' => $parameters->region,
49			'version' => $parameters->version,
50			]
51			);
52
53			return new AwsS3v3\AwsS3Adapter(
54			$client,
55			$parameters->bucket,
56			$parameters->prefix
57			);
58			}
59			}
60

iPublikuj / flysystem

Push — master ( 543e5f...eade68 )

Flysystem/Factories/Adapters/AwsS3v3Factory.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like