CronRule::getDates() - Code Metrics - Inspection of "reduce CronRule::getRecurrences complexity" - hutnikau/job-scheduler - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/cron_notation_support ( ddb1da...9d1836 )

by Aleh

created 2018-02-15 14:37 UTC

CronRule::getDates() B

↳ Parent: CronRule

Complexity

Conditions	5
Paths	2

Size

Total Lines	14
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	5

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	14
ccs	11
cts	11
cp	1
rs	8.8571
cc	5
eloc	11
nc	2
nop	4
crap	5

<?php

namespace Scheduler\Job;

use DateTimeInterface;
use Cron\CronExpression;

/**
 * Class CronRule
 * @package Scheduler\Job
 * @author Aleh Hutnikau, <[email protected]>
 */
class CronRule extends AbstractRule
{

    /**
     * @param DateTimeInterface $from
     * @param DateTimeInterface $to
     * @param boolean $inc
     * @throws
     * @return DateTimeInterface[]
     */
    public function getRecurrences(DateTimeInterface $from, DateTimeInterface $to, $inc = true)
    {
        $rRule = CronExpression::factory($this->getRrule());
        $result = [];

        if ($from->getTimestamp() < $this->getStartDate()->getTimestamp()) {
            $from = clone $this->getStartDate();
        }

        if (($to->getTimestamp() + (int) $inc) > $this->getStartDate()->getTimestamp()) {
            $result = $this->getDates($rRule, $from, $to, $inc);
        }

        return $result;
    }

    /**
     * @param CronExpression $rRule
     * @param DateTimeInterface $from
     * @param DateTimeInterface $to
     * @param $inc
     * @return DateTimeInterface[]
     */
    private function getDates(CronExpression $rRule, DateTimeInterface $from, DateTimeInterface $to, $inc)
    {
        $firstIteration = true;
        $result = [];
        do {
            $nextRunDate = $rRule->getNextRunDate($from, 0, $firstIteration && $inc);

            if ($nextRunDate->getTimestamp() < ($to->getTimestamp() + (int) $inc) && $from->getTimestamp() <= $nextRunDate->getTimestamp()) {
                $result[] = $nextRunDate;
            }
            $firstIteration = false;
            $from = $nextRunDate;
        } while ($nextRunDate->getTimestamp() < ($to->getTimestamp() + (int) $inc));
        return $result;
    }
}

1		<?php
2
3		namespace Scheduler\Job;
4
5		use DateTimeInterface;
6		use Cron\CronExpression;
7
8		/**
9		* Class CronRule
10		* @package Scheduler\Job
11		* @author Aleh Hutnikau, <[email protected]>
12		*/
13		class CronRule extends AbstractRule
14		{
15
16		/**
17		* @param DateTimeInterface $from
18		* @param DateTimeInterface $to
19		* @param boolean $inc
20		* @throws
21		* @return DateTimeInterface[]
22		*/
23	1	public function getRecurrences(DateTimeInterface $from, DateTimeInterface $to, $inc = true)
24		{
25	1	$rRule = CronExpression::factory($this->getRrule());
26	1	$result = [];
27
28	1	if ($from->getTimestamp() < $this->getStartDate()->getTimestamp()) {
29	1	$from = clone $this->getStartDate();
30	1	}
31
32	1	if (($to->getTimestamp() + (int) $inc) > $this->getStartDate()->getTimestamp()) {
33	1	$result = $this->getDates($rRule, $from, $to, $inc);
34	1	}
35
36	1	return $result;
37		}
38
39		/**
40		* @param CronExpression $rRule
41		* @param DateTimeInterface $from
42		* @param DateTimeInterface $to
43		* @param $inc
44		* @return DateTimeInterface[]
45		*/
46	1	private function getDates(CronExpression $rRule, DateTimeInterface $from, DateTimeInterface $to, $inc)
47		{
48	1	$firstIteration = true;
49	1	$result = [];
50		do {
51	1	$nextRunDate = $rRule->getNextRunDate($from, 0, $firstIteration && $inc);
		0 ignored issues – show Bug introduced 2018-02-15 14:39 UTC by Report Bug Copy Issue Report It seems like `$from` defined by parameter `$from` on line 46 can also be of type `object<DateTimeInterface>`; however, `Cron\CronExpression::getNextRunDate()` does only seem to accept `string\|object<DateTime>`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
52	1	if ($nextRunDate->getTimestamp() < ($to->getTimestamp() + (int) $inc) && $from->getTimestamp() <= $nextRunDate->getTimestamp()) {
53	1	$result[] = $nextRunDate;
54	1	}
55	1	$firstIteration = false;
56	1	$from = $nextRunDate;
57	1	} while ($nextRunDate->getTimestamp() < ($to->getTimestamp() + (int) $inc));
58	1	return $result;
59		}
60		}

hutnikau / job-scheduler

GitHub Access Token became invalid

Push — feature/cron_notation_support ( ddb1da...9d1836 )

CronRule::getDates() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like