Issues in HdomainController.php (master) - Issues in master - hiqdev/hipanel-module-hosting - Measure and Improve Code Quality continuously with Scrutinizer

Issues (256)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/controllers/HdomainController.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Hosting Plugin for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-hosting
 * @package   hipanel-module-hosting
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\hosting\controllers;

use hipanel\actions\ComboSearchAction;
use hipanel\actions\IndexAction;
use hipanel\actions\PrepareBulkAction;
use hipanel\actions\RedirectAction;
use hipanel\actions\RenderJsonAction;
use hipanel\actions\SmartCreateAction;
use hipanel\actions\SmartDeleteAction;
use hipanel\actions\SmartPerformAction;
use hipanel\actions\SmartUpdateAction;
use hipanel\actions\ValidateFormAction;
use hipanel\actions\ViewAction;
use hipanel\filters\EasyAccessControl;
use Yii;
use yii\base\Event;

class HdomainController extends \hipanel\base\CrudController
{
    public function behaviors()

    {
        return array_merge(parent::behaviors(), [
            [
                'class' => EasyAccessControl::class,
                'actions' => [
                    'create' => 'account.create',
                    'delete' => 'account.delete',
                    '*' => 'account.read',
                ],
            ],
        ]);
    }

    public function actions()
    {
        return array_merge(parent::actions(), [
            'search' => [
                'class' => ComboSearchAction::class,
            ],
            'index' => [
                'class' => IndexAction::class,
                'findOptions' => [
                    'with_vhosts' => true,
                    'with_aliases' => true,
                    'with_request' => true,
                ],
                'data' => function ($action) {
                    return [
                        'stateData' => $action->controller->getStateData(),
                        'typeData' => $action->controller->getTypeData(),
                    ];
                },
                'filterStorageMap' => [
                    'domain_like' => 'domain.hdomain.domain_like',
                    'state'       => 'hosting.hdomain.state',
                    'server'      => 'server.server.name',
                    'account'     => 'hosting.account.login',
                    'client_id'   => 'client.client.id',
                    'seller_id'   => 'client.client.seller_id',
                ],
            ],
            'view' => [
                'class' => ViewAction::class,
                'findOptions' => [
                    'with_vhosts'   => true,
                    'with_aliases'  => true,
                    'with_request'  => true,
                    'show_deleted'  => true,
                    'show_aliases'  => true,
                    'with_blocking' => true,
                ],
                'on beforePerform' => function (Event $event) {

                    /** @var \hipanel\actions\SearchAction $action */
                    $action = $event->sender;
                    $dataProvider = $action->getDataProvider();
                    $dataProvider->query->joinWith(['blocking']);
                },
                'data' => function ($action) {

                    return [
                        'blockReasons' => $this->getBlockReasons(),
                    ];
                },
            ],
            'create' => [
                'class' => SmartCreateAction::class,
                'success' => Yii::t('hipanel:hosting', 'Domain has been created successfully'),
            ],
            'create-alias' => [
                'class' => SmartCreateAction::class,
                'view' => 'create-alias',
                'success' => Yii::t('hipanel:hosting', 'Domain has been created successfully'),
            ],
            'enable-block' => [
                'class' => SmartUpdateAction::class,
                'success' => Yii::t('hipanel:hosting', 'Domain has been blocked successfully'),
            ],
            'disable-block' => [
                'class' => SmartUpdateAction::class,
                'success' => Yii::t('hipanel:hosting', 'Domain has been unblocked successfully'),
            ],
            'validate-form' => [
                'class' => ValidateFormAction::class,
            ],
            'enable-paid-feature-autorenewal' => [
                'class' => SmartPerformAction::class,
                'success' => Yii::t('hipanel:hosting', 'Premium autorenewal has been enabled'),
            ],
            'disable-paid-feature-autorenewal' => [
                'class' => SmartPerformAction::class,
                'success' => Yii::t('hipanel:hosting', 'Premium autorenewal has been disabled'),
            ],
            'delete' => [
                'class' => SmartDeleteAction::class,
                'success' => Yii::t('hipanel:hosting', 'Domain has been deleted successfully'),
            ],
            'delete-alias' => [
                'class' => SmartDeleteAction::class,
                'scenario' => 'delete',
                'success' => Yii::t('hipanel:hosting', 'Domain has been deleted successfully'),
            ],
            'bulk-enable-block' => [
                'class' => SmartUpdateAction::class,
                'scenario' => 'enable-block',
                'success' => Yii::t('hipanel:hosting', 'Domains have been blocked successfully'),
                'POST html' => [
                    'save'    => true,
                    'success' => [
                        'class' => RedirectAction::class,
                    ],
                ],
                'on beforeSave' => function (Event $event) {

                    /** @var \hipanel\actions\Action $action */
                    $action = $event->sender;
                    $type = Yii::$app->request->post('type');
                    $comment = Yii::$app->request->post('comment');
                    if (!empty($type)) {
                        foreach ($action->collection->models as $model) {
                            $model->setAttributes([
                                'type' => $type,
                                'comment' => $comment,
                            ]);
                        }
                    }
                },
            ],
            'bulk-enable-block-modal' => [
                'class' => PrepareBulkAction::class,
                'scenario' => 'enable-block',
                'view' => '_bulkEnableBlock',
                'data' => function ($action, $data) {
                    return array_merge($data, [
                        'blockReasons' => $this->getBlockReasons(),
                    ]);
                },
            ],
            'bulk-disable-block' => [
                'class' => SmartUpdateAction::class,
                'scenario' => 'disable-block',
                'success' => Yii::t('hipanel:hosting', 'Domains have been unblocked successfully'),
                'POST html' => [
                    'save'    => true,
                    'success' => [
                        'class' => RedirectAction::class,
                    ],
                ],
                'on beforeSave' => function (Event $event) {
                    /** @var \hipanel\actions\Action $action */
                    $action = $event->sender;
                    $comment = Yii::$app->request->post('comment');
                    if (!empty($type)) {

                        foreach ($action->collection->models as $model) {
                            $model->setAttribute('comment', $comment);
                        }
                    }
                },
            ],
            'bulk-disable-block-modal' => [
                'class' => PrepareBulkAction::class,
                'scenario' => 'disable-block',
                'view' => '_bulkDisableBlock',
            ],
            'set-dns-on' => [
                'class' => SmartUpdateAction::class,
                'success' => Yii::t('hipanel:hosting', 'DNS settings were changed'),
                'POST html' => [
                    'save'    => true,
                    'success' => [
                        'class' => RedirectAction::class,
                    ],
                ],
            ],
            'enable-backuping' => [
                'class' => SmartPerformAction::class,
                'success' => Yii::t('hipanel:hosting', 'Backups were enabled for the domain'),
                'on beforeSave' => function (Event $event) {
                    /** @var \hipanel\actions\Action $action */
                    $action = $event->sender;
                    foreach ($action->collection->models as $model) {
                        $model->setAttribute('backuping_type', 'week');
                    }
                },
            ],
            'set-premium-autorenewal' => [
                'class' => SmartPerformAction::class,
                'success' => Yii::t('hipanel', 'Premium autorenewal has been changed'),
                'scenario' => 'set-paid-feature-autorenewal',
                'queryOptions' => [
                    'batch' => false,
                ],
                'POST ajax' => [
                    'save' => true,
                    'flash' => true,
                    'success' => [
                        'class' => RenderJsonAction::class,
                        'return' => function ($action) {

                            $message = Yii::$app->session->removeFlash('success');

                            return [
                                'success' => true,
                                'text' => Yii::t('hipanel', reset($message)['text']),
                            ];
                        },
                    ],
                    'error' => [
                        'class' => RenderJsonAction::class,
                        'return' => function ($action) {

                            $message = Yii::$app->session->removeFlash('error');

                            return [
                                'success' => false,
                                'text' => reset($message)['text'],
                            ];
                        },
                    ],
                ],
            ],
            'enable-premium-autorenewal' => [
                'class' => SmartPerformAction::class,
                'scenario' => 'enable-paid-feature-autorenewal',
                'success' => Yii::t('hipanel', 'Autorenewal has been enabled'),
                'error' => Yii::t('hipanel', 'Failed enabling Autorenewal'),
            ],
            'disable-premium-autorenewal' => [
                'class' => SmartPerformAction::class,
                'scenario' => 'disable-paid-feature-autorenewal',
                'success' => Yii::t('hipanel', 'Autorenewal has been disabled'),
                'error' => Yii::t('hipanel', 'Failed disabling Autorenewal'),
            ],
        ]);
    }

    public function getStateData()
    {
        return $this->getRefs('state,hdomain', 'hipanel:hosting');
    }

    public function getTypeData()
    {
        return [
            0 => Yii::t('hipanel', 'Domain'),
            1 => Yii::t('hipanel', 'Alias'),
        ];
    }
}


1		<?php
2		/**
3		* Hosting Plugin for HiPanel
4		*
5		* @link https://github.com/hiqdev/hipanel-module-hosting
6		* @package hipanel-module-hosting
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hipanel\modules\hosting\controllers;
12
13		use hipanel\actions\ComboSearchAction;
14		use hipanel\actions\IndexAction;
15		use hipanel\actions\PrepareBulkAction;
16		use hipanel\actions\RedirectAction;
17		use hipanel\actions\RenderJsonAction;
18		use hipanel\actions\SmartCreateAction;
19		use hipanel\actions\SmartDeleteAction;
20		use hipanel\actions\SmartPerformAction;
21		use hipanel\actions\SmartUpdateAction;
22		use hipanel\actions\ValidateFormAction;
23		use hipanel\actions\ViewAction;
24		use hipanel\filters\EasyAccessControl;
25		use Yii;
26		use yii\base\Event;
27
28		class HdomainController extends \hipanel\base\CrudController
29		{
30	View Code Duplication	public function behaviors()
		0 ignored issues – show Duplication introduced 2017-09-07 15:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		return array_merge(parent::behaviors(), [
33		[
34		'class' => EasyAccessControl::class,
35		'actions' => [
36		'create' => 'account.create',
37		'delete' => 'account.delete',
38		'*' => 'account.read',
39		],
40		],
41		]);
42		}
43
44		public function actions()
45		{
46		return array_merge(parent::actions(), [
47		'search' => [
48		'class' => ComboSearchAction::class,
49		],
50		'index' => [
51		'class' => IndexAction::class,
52		'findOptions' => [
53		'with_vhosts' => true,
54		'with_aliases' => true,
55		'with_request' => true,
56		],
57		'data' => function ($action) {
58		return [
59		'stateData' => $action->controller->getStateData(),
60		'typeData' => $action->controller->getTypeData(),
61		];
62		},
63		'filterStorageMap' => [
64		'domain_like' => 'domain.hdomain.domain_like',
65		'state' => 'hosting.hdomain.state',
66		'server' => 'server.server.name',
67		'account' => 'hosting.account.login',
68		'client_id' => 'client.client.id',
69		'seller_id' => 'client.client.seller_id',
70		],
71		],
72		'view' => [
73		'class' => ViewAction::class,
74		'findOptions' => [
75		'with_vhosts' => true,
76		'with_aliases' => true,
77		'with_request' => true,
78		'show_deleted' => true,
79		'show_aliases' => true,
80		'with_blocking' => true,
81		],
82	View Code Duplication	'on beforePerform' => function (Event $event) {
		0 ignored issues – show Duplication introduced 2018-02-12 14:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
83		/** @var \hipanel\actions\SearchAction $action */
84		$action = $event->sender;
85		$dataProvider = $action->getDataProvider();
86		$dataProvider->query->joinWith(['blocking']);
87		},
88		'data' => function ($action) {
		0 ignored issues – show Unused Code introduced 2016-06-24 07:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$action` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
89		return [
90		'blockReasons' => $this->getBlockReasons(),
91		];
92		},
93		],
94		'create' => [
95		'class' => SmartCreateAction::class,
96		'success' => Yii::t('hipanel:hosting', 'Domain has been created successfully'),
97		],
98		'create-alias' => [
99		'class' => SmartCreateAction::class,
100		'view' => 'create-alias',
101		'success' => Yii::t('hipanel:hosting', 'Domain has been created successfully'),
102		],
103		'enable-block' => [
104		'class' => SmartUpdateAction::class,
105		'success' => Yii::t('hipanel:hosting', 'Domain has been blocked successfully'),
106		],
107		'disable-block' => [
108		'class' => SmartUpdateAction::class,
109		'success' => Yii::t('hipanel:hosting', 'Domain has been unblocked successfully'),
110		],
111		'validate-form' => [
112		'class' => ValidateFormAction::class,
113		],
114		'enable-paid-feature-autorenewal' => [
115		'class' => SmartPerformAction::class,
116		'success' => Yii::t('hipanel:hosting', 'Premium autorenewal has been enabled'),
117		],
118		'disable-paid-feature-autorenewal' => [
119		'class' => SmartPerformAction::class,
120		'success' => Yii::t('hipanel:hosting', 'Premium autorenewal has been disabled'),
121		],
122		'delete' => [
123		'class' => SmartDeleteAction::class,
124		'success' => Yii::t('hipanel:hosting', 'Domain has been deleted successfully'),
125		],
126		'delete-alias' => [
127		'class' => SmartDeleteAction::class,
128		'scenario' => 'delete',
129		'success' => Yii::t('hipanel:hosting', 'Domain has been deleted successfully'),
130		],
131		'bulk-enable-block' => [
132		'class' => SmartUpdateAction::class,
133		'scenario' => 'enable-block',
134		'success' => Yii::t('hipanel:hosting', 'Domains have been blocked successfully'),
135		'POST html' => [
136		'save' => true,
137		'success' => [
138		'class' => RedirectAction::class,
139		],
140		],
141	View Code Duplication	'on beforeSave' => function (Event $event) {
		0 ignored issues – show Duplication introduced 2016-06-24 07:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
142		/** @var \hipanel\actions\Action $action */
143		$action = $event->sender;
144		$type = Yii::$app->request->post('type');
145		$comment = Yii::$app->request->post('comment');
146		if (!empty($type)) {
147		foreach ($action->collection->models as $model) {
148		$model->setAttributes([
149		'type' => $type,
150		'comment' => $comment,
151		]);
152		}
153		}
154		},
155		],
156		'bulk-enable-block-modal' => [
157		'class' => PrepareBulkAction::class,
158		'scenario' => 'enable-block',
159		'view' => '_bulkEnableBlock',
160		'data' => function ($action, $data) {
161		return array_merge($data, [
162		'blockReasons' => $this->getBlockReasons(),
163		]);
164		},
165		],
166		'bulk-disable-block' => [
167		'class' => SmartUpdateAction::class,
168		'scenario' => 'disable-block',
169		'success' => Yii::t('hipanel:hosting', 'Domains have been unblocked successfully'),
170		'POST html' => [
171		'save' => true,
172		'success' => [
173		'class' => RedirectAction::class,
174		],
175		],
176		'on beforeSave' => function (Event $event) {
177		/** @var \hipanel\actions\Action $action */
178		$action = $event->sender;
179		$comment = Yii::$app->request->post('comment');
180		if (!empty($type)) {
		0 ignored issues – show Bug introduced 2016-06-24 07:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$type` seems to never exist, and therefore `empty` should always return `true`. Did you maybe rename this variable? This check looks for calls to `isset(...)` or `empty()` on variables that are yet undefined. These calls will always produce the same result and can be removed. This is most likely caused by the renaming of a variable or the removal of a function/method parameter. Loading history...
181		foreach ($action->collection->models as $model) {
182		$model->setAttribute('comment', $comment);
183		}
184		}
185		},
186		],
187		'bulk-disable-block-modal' => [
188		'class' => PrepareBulkAction::class,
189		'scenario' => 'disable-block',
190		'view' => '_bulkDisableBlock',
191		],
192		'set-dns-on' => [
193		'class' => SmartUpdateAction::class,
194		'success' => Yii::t('hipanel:hosting', 'DNS settings were changed'),
195		'POST html' => [
196		'save' => true,
197		'success' => [
198		'class' => RedirectAction::class,
199		],
200		],
201		],
202		'enable-backuping' => [
203		'class' => SmartPerformAction::class,
204		'success' => Yii::t('hipanel:hosting', 'Backups were enabled for the domain'),
205		'on beforeSave' => function (Event $event) {
206		/** @var \hipanel\actions\Action $action */
207		$action = $event->sender;
208		foreach ($action->collection->models as $model) {
209		$model->setAttribute('backuping_type', 'week');
210		}
211		},
212		],
213		'set-premium-autorenewal' => [
214		'class' => SmartPerformAction::class,
215		'success' => Yii::t('hipanel', 'Premium autorenewal has been changed'),
216		'scenario' => 'set-paid-feature-autorenewal',
217		'queryOptions' => [
218		'batch' => false,
219		],
220		'POST ajax' => [
221		'save' => true,
222		'flash' => true,
223		'success' => [
224		'class' => RenderJsonAction::class,
225	View Code Duplication	'return' => function ($action) {
		0 ignored issues – show Unused Code introduced 2017-11-24 13:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$action` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2017-11-24 13:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
226		$message = Yii::$app->session->removeFlash('success');
227
228		return [
229		'success' => true,
230		'text' => Yii::t('hipanel', reset($message)['text']),
231		];
232		},
233		],
234		'error' => [
235		'class' => RenderJsonAction::class,
236	View Code Duplication	'return' => function ($action) {
		0 ignored issues – show Unused Code introduced 2017-11-24 13:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$action` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2017-11-24 13:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
237		$message = Yii::$app->session->removeFlash('error');
238
239		return [
240		'success' => false,
241		'text' => reset($message)['text'],
242		];
243		},
244		],
245		],
246		],
247		'enable-premium-autorenewal' => [
248		'class' => SmartPerformAction::class,
249		'scenario' => 'enable-paid-feature-autorenewal',
250		'success' => Yii::t('hipanel', 'Autorenewal has been enabled'),
251		'error' => Yii::t('hipanel', 'Failed enabling Autorenewal'),
252		],
253		'disable-premium-autorenewal' => [
254		'class' => SmartPerformAction::class,
255		'scenario' => 'disable-paid-feature-autorenewal',
256		'success' => Yii::t('hipanel', 'Autorenewal has been disabled'),
257		'error' => Yii::t('hipanel', 'Failed disabling Autorenewal'),
258		],
259		]);
260		}
261
262		public function getStateData()
263		{
264		return $this->getRefs('state,hdomain', 'hipanel:hosting');
265		}
266
267		public function getTypeData()
268		{
269		return [
270		0 => Yii::t('hipanel', 'Domain'),
271		1 => Yii::t('hipanel', 'Alias'),
272		];
273		}
274		}
275

hiqdev / hipanel-module-hosting

Issues (256)

Security Analysis not enabled

src/controllers/HdomainController.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like