Issues (426)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/models/CertificatePrice.php (2 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 * Finance module for HiPanel
4
 *
5
 * @link      https://github.com/hiqdev/hipanel-module-finance
6
 * @package   hipanel-module-finance
7
 * @license   BSD-3-Clause
8
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9
 */
10
11
namespace hipanel\modules\finance\models;
12
13
use hipanel\base\ModelTrait;
14
use Money\Currencies\ISOCurrencies;
15
use Money\Currency;
0 ignored issues
show
This use statement conflicts with another class in this namespace, hipanel\modules\finance\models\Currency.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
16
use Money\Formatter\DecimalMoneyFormatter;
17
use Money\Money;
18
use Money\Parser\DecimalMoneyParser;
19
use Yii;
20
use yii\behaviors\AttributeTypecastBehavior;
21
use yii\validators\NumberValidator;
22
23
/**
24
 * @property array $sums
25
 */
26
class CertificatePrice extends Price
27
{
28
    use ModelTrait;
29
30
    public const TYPE_CERT_PURCHASE = 'certificate,certificate_purchase';
31
    public const TYPE_CERT_RENEWAL = 'certificate,certificate_renewal';
32
33
    /**
34
     * @var DecimalMoneyFormatter
35
     */
36
    private $moneyFormatter;
37
38
    /**
39
     * @var DecimalMoneyParser
40
     */
41
    private $moneyParser;
42
43
    public function __construct(array $config = [])
44
    {
45
        parent::__construct($config);
46
        $this->moneyFormatter = new DecimalMoneyFormatter(new ISOCurrencies());
47
        $this->moneyParser = new DecimalMoneyParser(new ISOCurrencies());
48
    }
49
50
    public static function tableName()
51
    {
52
        return 'price';
53
    }
54
55
    public function behaviors()
56
    {
57
        return [
58
            'typecastAfterFind' => [
59
                'class' => AttributeTypecastBehavior::class,
60
                'attributeTypes' => [
61
                    'sums' => function ($sums) {
62
                        foreach ($sums as $key => $value) {
63
                            $sums[$key] = new Money($value, new Currency(strtoupper($this->currency)));
64
                        }
65
66
                        return $sums;
67
                    }, ],
68
                'typecastAfterFind' => true,
69
                'typecastAfterValidate' => false,
70
                'typecastBeforeSave' => false,
71
            ],
72
            'typecastBeforeSave' => [
73
                'class' => AttributeTypecastBehavior::class,
74
                'attributeTypes' => [
75
                    'sums' => function ($sums) {
76
                        foreach ($sums as $key => $value) {
77
                            $sums[$key] = $this->moneyParser
78
                                ->parse($value, strtoupper($this->currency))
79
                                ->getAmount();
80
                        }
81
82
                        return $sums;
83
                    }, ],
84
                'typecastAfterFind' => false,
85
                'typecastAfterValidate' => false,
86
                'typecastBeforeSave' => true,
87
            ],
88
        ];
89
    }
90
91
    public function rules()
92
    {
93
        $rules = parent::rules();
94
        $rules['create-required'] = [
95
            ['object_id'],
96
            'required',
97
            'on' => ['create', 'update'],
98
            'when' => function ($model) {
99
                /** @var self $model */
100
                return $model->isTypeCorrect();
0 ignored issues
show
Documentation Bug introduced by pkolomiy
The method isTypeCorrect does not exist on object<hipanel\modules\f...nce\models\Calculation>? Since you implemented __call, maybe consider adding a @method annotation.

If you implement __call and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class.

This is often the case, when __call is implemented by a parent class and only the child class knows which methods exist:

class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
Loading history...
101
            },
102
        ];
103
        $rules[] = [['certificateType'], 'safe'];
104
        $rules[] = [['sums'], 'validatePrices', 'on' => ['create', 'update']];
105
        $rules[] = [['sums'], 'number', 'min' => 0, 'when' => function () {
106
            return false;
107
        }];
108
        $rules[] = [['sums'], 'each', 'rule' => ['number', 'min' => 0]];
109
110
        return $rules;
111
    }
112
113
    /**
114
     * @return bool
115
     */
116
    public function isTypeCorrect(): bool
117
    {
118
        return isset($this->getTypes()[$this->type]);
119
    }
120
121
    /**
122
     * @return array
123
     */
124
    public static function getPeriods()
125
    {
126
        return [
127
            1 => Yii::t('hipanel:finance:tariff', '{n, plural, one{# year} other{# years}}', ['n' => 1]),
128
            2 => Yii::t('hipanel:finance:tariff', '{n, plural, one{# year} other{# years}}', ['n' => 2]),
129
        ];
130
    }
131
132
    /**
133
     * @return array
134
     */
135
    public function getAvailablePeriods()
136
    {
137
        $periods = [];
138
        foreach ([1, 2] as $period) {
139
            if ($this->hasPriceForPeriod($period)) {
140
                $periods[$period] = Yii::t('hipanel:finance:tariff', '{n, plural, one{# year} other{# years}}', ['n' => $period]);
141
            }
142
        }
143
144
        return $periods;
145
    }
146
147
    /**
148
     * @param int $period
149
     * @return string|null
150
     */
151
    public function getPriceForPeriod(int $period)
152
    {
153
        return $this->moneyFormatter->format($this->getMoneyForPeriod($period));
154
    }
155
156
    public function getMoneyForPeriod(int $period): ?Money
157
    {
158
        if (!$this->hasPriceForPeriod($period)) {
159
            return null;
160
        }
161
162
        return $this->sums[$period];
163
    }
164
165
    /**
166
     * @param int $period
167
     * @return bool
168
     */
169
    public function hasPriceForPeriod(int $period)
170
    {
171
        return !empty($this->sums[$period]);
172
    }
173
174
    public function validatePrices(): bool
175
    {
176
        $periods = $this->getPeriods();
177
        $validator = new NumberValidator();
178
179
        foreach (array_keys($periods) as $period) {
180
            $validation = $validator->validate($this->sums[$period]);
181
            if ($validation === false) {
182
                unset($this->sums[$period]);
183
            }
184
        }
185
186
        return true;
187
    }
188
189
    /**
190
     * @return array
191
     */
192
    public static function getTypes()
193
    {
194
        return [
195
            static::TYPE_CERT_PURCHASE => Yii::t('hipanel:finance:tariff', 'Purchase'),
196
            static::TYPE_CERT_RENEWAL => Yii::t('hipanel:finance:tariff', 'Renewal'),
197
        ];
198
    }
199
}
200