Issues (434)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/logic/AbstractTariffManager.php (1 issue)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 * Finance module for HiPanel
4
 *
5
 * @link      https://github.com/hiqdev/hipanel-module-finance
6
 * @package   hipanel-module-finance
7
 * @license   BSD-3-Clause
8
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9
 */
10
11
namespace hipanel\modules\finance\logic;
12
13
use hipanel\modules\finance\forms\AbstractTariffForm;
14
use hipanel\modules\finance\models\Tariff;
15
use hiqdev\hiart\ResponseErrorException;
16
use Yii;
17
use yii\base\BaseObject;
18
use yii\base\InvalidConfigException;
19
use yii\web\UnprocessableEntityHttpException;
20
21
abstract class AbstractTariffManager extends BaseObject
22
{
23
    /**
24
     * @var int Parent tariff ID
25
     */
26
    public $parent_id;
27
28
    /**
29
     * @var AbstractTariffForm
30
     */
31
    public $form;
32
33
    /**
34
     * @var array options used to build [[form]]
35
     * @see buildForm()
36
     */
37
    public $formOptions = [];
38
39
    /**
40
     * @var string
41
     */
42
    public $scenario;
43
44
    /**
45
     * @var Tariff The actual tariff
46
     */
47
    protected $tariff;
48
49
    /**
50
     * @var Tariff Parent tariff
51
     */
52
    protected $parentTariff;
53
54
    /**
55
     * @var string The type used to find parent tariffs
56
     */
57
    protected $type;
58
59
    public function init()
60
    {
61
        if (!isset($this->type)) {
62
            throw new InvalidConfigException('Property "type" must be set');
63
        }
64
65
        $this->initParentTariff();
66
        $this->buildForm();
67
    }
68
69
    /**
70
     * Fills [[form]] property with a proper [[AbstractTariffForm]] object.
71
     */
72
    protected function buildForm()
73
    {
74
        $this->form = Yii::createObject(array_merge([
75
            'scenario' => $this->scenario,
76
            'parent_id' => $this->parent_id,
77
            'parentTariff' => $this->parentTariff,
78
            'tariff' => $this->tariff,
79
        ], $this->getFormOptions()));
80
    }
81
82
    protected function getFormOptions()
83
    {
84
        return $this->formOptions;
85
    }
86
87
    protected function initParentTariff()
88
    {
89
        $id = $this->determineParentTariff();
90
91
        if ($id === null) {
92
            return;
93
        }
94
95
        $this->parent_id = $id;
96
        $this->parentTariff = Tariff::find()
97
            ->where(['id' => $id])
98
            ->details()
99
            ->one();
100
101
        // In case parent tariff is not available - use current tariff as the last hope fallback
102
        if ($this->parentTariff === null && $this->tariff !== null) {
103
            $this->parentTariff = clone $this->tariff;
104
        }
105
    }
106
107
    /**
108
     * Finds parent tariff ID.
109
     *
110
     * @return int
111
     */
112
    protected function determineParentTariff()
113
    {
114
        if ($this->tariff === null) {
115
            if (!empty($this->parent_id)) {
116
                return $this->parent_id;
117
            }
118
119
            return null;
120
        }
121
122
        if ($this->tariff->parent_id !== null) {
123
            return $this->tariff->parent_id;
124
        }
125
126
        return $this->tariff->id;
127
    }
128
129
    public function getType()
130
    {
131
        return $this->type;
132
    }
133
134
    /**
135
     * @param Tariff $tariff
136
     */
137
    public function setTariff($tariff)
138
    {
139
        $this->tariff = $tariff;
140
    }
141
142 View Code Duplication
    public function insert(): bool
143
    {
144
        $data = $this->form->toArray();
145
146
        try {
147
            $result = Tariff::perform('create', $data);
148
        } catch (ResponseErrorException $e) {
149
            throw new UnprocessableEntityHttpException($e->getMessage(), 0, $e);
150
        }
151
152
        $this->form->id = $result['id'];
153
154
        return true;
155
    }
156
157 View Code Duplication
    public function update(): bool
158
    {
159
        $data = $this->form->toArray();
160
161
        try {
162
            $result = Tariff::perform('update', $data);
0 ignored issues
show
$result is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
163
        } catch (ResponseErrorException $e) {
164
            throw new UnprocessableEntityHttpException($e->getMessage(), 0, $e);
165
        }
166
167
        return true;
168
    }
169
}
170