Issues in CartFinisher.php - All Issues - Inspection of "added deposit link (#118)" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( db50e7...7354ed )

by Dmitry

created 2019-08-05 09:12 UTC

src/cart/CartFinisher.php (1 issue)

Labels

Unused Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\cart;

use hiqdev\yii2\cart\ShoppingCart;
use Yii;
use yii\base\BaseObject;

class CartFinisher extends BaseObject
{
    /**
     * @var ShoppingCart
     */
    public $cart;

    /**
     * @var PurchaseStrategyInterface[]
     */
    protected $purchasers = [];

    /**
     * @var AbstractPurchase[] array of successful purchases
     */
    protected $_success = [];

    /**
     * @var ErrorPurchaseException[] array of failed purchases
     */
    protected $_error = [];

    /**
     * @var PendingPurchaseException[] array of purchases that are pending
     */
    protected $_pending = [];

    /**
     * Getter for array of successful purchases.
     * @return AbstractPurchase[]
     */
    public function getSuccess()
    {
        return $this->_success;
    }

    /**
     * Getter for array of failed purchases.
     * @return ErrorPurchaseException[]
     */
    public function getError()
    {
        return $this->_error;
    }

    /**
     * Getter for array of failed purchases.
     * @return PendingPurchaseException[]
     */
    public function getPending()
    {
        return $this->_pending;
    }

    /**
     * Runs the purchase.
     * Purchases the positions in the [[cart]].
     */
    public function run()
    {
        if ($this->cart->isEmpty) {
            return;
        }

        $this->ensureCanBeFinished();
        $this->createPurchasers();

        foreach ($this->purchasers as $purchaser) {
            $purchaser->run();

            $this->_success = array_merge($this->_success, $purchaser->getSuccessPurchases());
            foreach ($purchaser->getSuccessPurchases() as $purchase) {
                $this->cart->remove($purchase->position);
            }
            $this->_pending = array_merge($this->_pending, $purchaser->getPendingPurchaseExceptions());
            foreach ($purchaser->getPendingPurchaseExceptions() as $exception) {
                $this->cart->remove($exception->position);
            }
            $this->_error = array_merge($this->_error, $purchaser->getErrorPurchaseExceptions());
        }
    }

    protected function ensureCanBeFinished()
    {
        /** @var PositionPurchasabilityValidatorInterface[] $validators */
        $validators = [];

        foreach ($this->cart->positions as $position) {
            $purchase = $position->getPurchaseModel();

            foreach ($purchase->getPurchasabilityRules() as $validator) {
                if (!isset($validators[$validator])) {
                    $validators[$validator] = Yii::createObject($validator);
                }
            }
        }

        try {
            foreach ($validators as $validator) {
                $validator->validate($this->cart->positions);
            }
        } catch (NotPurchasablePositionException $e) {
            $e->resolve();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        }
    }

    protected function createPurchasers()
    {
        foreach ($this->cart->positions as $position) {
            if ($position instanceof BatchPurchasablePositionInterface) {
                $purchaser = $this->getPurchaser(get_class($position), $position->getBatchPurchaseStrategyClass());
            } else {
                $purchaser = $this->getPurchaser(get_class($position), OneByOnePurchaseStrategy::class);
            }

            $purchaser->addPosition($position);
        }
    }

    /**
     * @param string $positionClass
     * @param string $purchaserClass
     * @return PurchaseStrategyInterface
     */
    protected function getPurchaser($positionClass, $purchaserClass)
    {
        if (!isset($this->purchasers[$positionClass])) {
            $this->purchasers[$positionClass] = new $purchaserClass($this->cart);
        }

        return $this->purchasers[$positionClass];
    }
}


1			<?php
2			/**
3			* Finance module for HiPanel
4			*
5			* @link https://github.com/hiqdev/hipanel-module-finance
6			* @package hipanel-module-finance
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hipanel\modules\finance\cart;
12
13			use hiqdev\yii2\cart\ShoppingCart;
14			use Yii;
15			use yii\base\BaseObject;
16
17			class CartFinisher extends BaseObject
18			{
19			/**
20			* @var ShoppingCart
21			*/
22			public $cart;
23
24			/**
25			* @var PurchaseStrategyInterface[]
26			*/
27			protected $purchasers = [];
28
29			/**
30			* @var AbstractPurchase[] array of successful purchases
31			*/
32			protected $_success = [];
33
34			/**
35			* @var ErrorPurchaseException[] array of failed purchases
36			*/
37			protected $_error = [];
38
39			/**
40			* @var PendingPurchaseException[] array of purchases that are pending
41			*/
42			protected $_pending = [];
43
44			/**
45			* Getter for array of successful purchases.
46			* @return AbstractPurchase[]
47			*/
48			public function getSuccess()
49			{
50			return $this->_success;
51			}
52
53			/**
54			* Getter for array of failed purchases.
55			* @return ErrorPurchaseException[]
56			*/
57			public function getError()
58			{
59			return $this->_error;
60			}
61
62			/**
63			* Getter for array of failed purchases.
64			* @return PendingPurchaseException[]
65			*/
66			public function getPending()
67			{
68			return $this->_pending;
69			}
70
71			/**
72			* Runs the purchase.
73			* Purchases the positions in the [[cart]].
74			*/
75			public function run()
76			{
77			if ($this->cart->isEmpty) {
78			return;
79			}
80
81			$this->ensureCanBeFinished();
82			$this->createPurchasers();
83
84			foreach ($this->purchasers as $purchaser) {
85			$purchaser->run();
86
87			$this->_success = array_merge($this->_success, $purchaser->getSuccessPurchases());
88			foreach ($purchaser->getSuccessPurchases() as $purchase) {
89			$this->cart->remove($purchase->position);
90			}
91			$this->_pending = array_merge($this->_pending, $purchaser->getPendingPurchaseExceptions());
92			foreach ($purchaser->getPendingPurchaseExceptions() as $exception) {
93			$this->cart->remove($exception->position);
94			}
95			$this->_error = array_merge($this->_error, $purchaser->getErrorPurchaseExceptions());
96			}
97			}
98
99			protected function ensureCanBeFinished()
100			{
101			/** @var PositionPurchasabilityValidatorInterface[] $validators */
102			$validators = [];
103
104			foreach ($this->cart->positions as $position) {
105			$purchase = $position->getPurchaseModel();
106
107			foreach ($purchase->getPurchasabilityRules() as $validator) {
108			if (!isset($validators[$validator])) {
109			$validators[$validator] = Yii::createObject($validator);
110			}
111			}
112			}
113
114			try {
115			foreach ($validators as $validator) {
116			$validator->validate($this->cart->positions);
117			}
118			} catch (NotPurchasablePositionException $e) {
119			$e->resolve();
			0 ignored issues – show Unused Code introduced 2017-09-14 10:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to the method `hipanel\modules\finance\...ionException::resolve()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
120			}
121			}
122
123			protected function createPurchasers()
124			{
125			foreach ($this->cart->positions as $position) {
126			if ($position instanceof BatchPurchasablePositionInterface) {
127			$purchaser = $this->getPurchaser(get_class($position), $position->getBatchPurchaseStrategyClass());
128			} else {
129			$purchaser = $this->getPurchaser(get_class($position), OneByOnePurchaseStrategy::class);
130			}
131
132			$purchaser->addPosition($position);
133			}
134			}
135
136			/**
137			* @param string $positionClass
138			* @param string $purchaserClass
139			* @return PurchaseStrategyInterface
140			*/
141			protected function getPurchaser($positionClass, $purchaserClass)
142			{
143			if (!isset($this->purchasers[$positionClass])) {
144			$this->purchasers[$positionClass] = new $purchaserClass($this->cart);
145			}
146
147			return $this->purchasers[$positionClass];
148			}
149			}
150

hiqdev / hipanel-module-finance

Push — master ( db50e7...7354ed )

src/cart/CartFinisher.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like