SaleSort::bySaleClass() - Code Metrics - Inspection of "Update bill form to follow ObjectCombo API changes" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ab8769...6ede23 )

by Dmitry

created 2018-12-07 15:20 UTC

SaleSort::bySaleClass() A

↳ Parent: SaleSort

Complexity

Conditions	3
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	0
cts	16
cp	0
rs	9.6333
c	0
b	0
f	0
cc	3
nc	1
nop	0
crap	12

<?php

namespace hipanel\modules\finance\helpers;

use hipanel\modules\finance\models\FakeGroupingSale;
use hipanel\modules\finance\models\FakeSale;
use hipanel\modules\finance\models\FakeSharedSale;
use hipanel\modules\finance\models\Price;
use hipanel\modules\finance\models\Sale;
use Tuck\Sort\Sort;
use Tuck\Sort\SortChain;

/**
 * Class SaleSort
 *
 * @author Dmytro Naumenko <[email protected]>
 */
class SaleSort
{
    public static function toDisplayInPlan(): SortChain
    {
        return Sort::chain()
            ->asc(self::bySaleClass())
            ->compare(self::byTargetObjectName());
    }

    private static function bySaleClass(): \Closure
    {
        $map = [
            FakeSharedSale::class => 1,
            FakeGroupingSale::class => 2,
            FakeSale::class => 4,
            Sale::class => 3,
        ];

        return function (Sale $sale) use ($map) {
            foreach ($map as $class => $order) {
                if ($sale instanceof $class) {
                    return $order;
                }
            }

            return INF;
        };
    }

    private static function byTargetObjectName(): \Closure
    {
        return function (Sale $a, Sale $b) {
            return strnatcasecmp($a->object, $b->object);
        };
    }
}


1			<?php
2
3			namespace hipanel\modules\finance\helpers;
4
5			use hipanel\modules\finance\models\FakeGroupingSale;
6			use hipanel\modules\finance\models\FakeSale;
7			use hipanel\modules\finance\models\FakeSharedSale;
8			use hipanel\modules\finance\models\Price;
9			use hipanel\modules\finance\models\Sale;
10			use Tuck\Sort\Sort;
11			use Tuck\Sort\SortChain;
12
13			/**
14			* Class SaleSort
15			*
16			* @author Dmytro Naumenko <[email protected]>
17			*/
18			class SaleSort
19			{
20			public static function toDisplayInPlan(): SortChain
21			{
22			return Sort::chain()
23			->asc(self::bySaleClass())
24			->compare(self::byTargetObjectName());
25			}
26
27			private static function bySaleClass(): \Closure
28			{
29			$map = [
30			FakeSharedSale::class => 1,
31			FakeGroupingSale::class => 2,
32			FakeSale::class => 4,
33			Sale::class => 3,
34			];
35
36			return function (Sale $sale) use ($map) {
37			foreach ($map as $class => $order) {
38			if ($sale instanceof $class) {
39			return $order;
40			}
41			}
42
43			return INF;
44			};
45			}
46
47			private static function byTargetObjectName(): \Closure
48			{
49			return function (Sale $a, Sale $b) {
50			return strnatcasecmp($a->object, $b->object);
51			};
52			}
53			}
54

hiqdev / hipanel-module-finance

Push — master ( ab8769...6ede23 )

SaleSort::bySaleClass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like