gyselroth / balloon

src/app/Balloon.App.ClamAv/Hook.php

Doc Comments -1 removed lines

@@ -28,7 +28,6 @@
     /**
      * Constructor.
      *
-     * @param App   $app
      * @param Async $async
      */
     public function __construct(Async $async)

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon

src/app/Balloon.App.ClamAv/Job.php

Doc Comments -1 removed lines

@@ -35,7 +35,6 @@
     /**
      * Constructor.
      *
-     * @param App    $app
      * @param Server $server
      */
     public function __construct(Scanner $scanner, Server $server)

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon

src/app/Balloon.App.ClamAv/Scanner.php

Doc Comments -1 removed lines

@@ -79,7 +79,6 @@
     /**
      * Constructor.
      *
-     * @param Database        $db
      * @param LoggerInterface $logger
      */
     public function __construct(SocketFactory $factory, LoggerInterface $logger, ?Iterable $config = null)

Spacing +8 added lines, -8 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -96,7 +96,7 @@ 
      *
      * @return Scanner
      */
-    public function setOptions(?Iterable $config = null): self
+    public function setOptions(?Iterable $config = null) : self
     {
         if (null === $config) {
             return $this;
@@ -105,22 +105,22 @@ 
         foreach ($config as $option => $value) {
             switch ($option) {
                 case 'socket':
-                    $this->socket = (string) $value;
+                    $this->socket = (string)$value;
 
                     break;
                 case 'max_stream_size':
-                    $this->max_stream_size = (int) $value;
+                    $this->max_stream_size = (int)$value;
 
                     break;
                 case 'aggressiveness':
-                    if ((int) $value > 3 || (int) $value < 0) {
-                        throw new Exception('invalid config value ['.(int) $value.'] for aggressiveness');
+                    if ((int)$value > 3 || (int)$value < 0) {
+                        throw new Exception('invalid config value ['.(int)$value.'] for aggressiveness');
                     }
-                    $this->aggressiveness = (int) $value;
+                    $this->aggressiveness = (int)$value;
 
                     break;
                 case 'timeout':
-                    $this->timeout = (int) $value;
+                    $this->timeout = (int)$value;
 
                     break;
                 break;

src/app/Balloon.App.Convert/Job.php

Doc Comments -3 removed lines

@@ -45,7 +45,6 @@ 
     /**
      * Constructor.
      *
-     * @param Async $async
      */
     public function __construct(Converter $converter, Server $server, LoggerInterface $logger)
     {
@@ -57,8 +56,6 @@ 
     /**
      * Start job.
      *
-     * @param Server          $server
-     * @param LoggerInterface $logger
      *
      * @return bool
      */

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -72,8 +72,8 @@ 
 
         $slaves = $file->getAppAttribute(__NAMESPACE__, 'slaves');
 
-        if (is_array($slaves) && isset($slaves[(string) $this->data['slave']])) {
-            $slave = $slaves[(string) $this->data['slave']];
+        if (is_array($slaves) && isset($slaves[(string)$this->data['slave']])) {
+            $slave = $slaves[(string)$this->data['slave']];
         } else {
             throw new Exception('unknown slave node');
         }
@@ -121,7 +121,7 @@ 
 
         $node->setReadonly();
 
-        $slaves[(string) $this->data['slave']]['node'] = $node->getId();
+        $slaves[(string)$this->data['slave']]['node'] = $node->getId();
         $file->setAppAttribute(__NAMESPACE__, 'slaves', $slaves);
 
         return true;

src/app/Balloon.App.Elasticsearch/Elasticsearch.php

Doc Comments +2 added lines, -2 removed lines

@@ -204,7 +204,7 @@ 
     /**
      * Get es client.
      *
-     * @return Elasticsearch
+     * @return Client
      */
     protected function getEsClient(): Client
     {
@@ -221,7 +221,7 @@ 
      * Search.
      *
      * @param array $query
-     * @param array $share
+     * @param array $shares
      *
      * @return array
      */

Spacing +9 added lines, -9 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -85,7 +85,7 @@ 
      *
      * @return Elasticsearch
      */
-    public function setOptions(?Iterable $config = null): self
+    public function setOptions(?Iterable $config = null) : self
     {
         if (null === $config) {
             return $this;
@@ -94,11 +94,11 @@ 
         foreach ($config as $option => $value) {
             switch ($option) {
                 case 'server':
-                    $this->es_server = (array) $value;
+                    $this->es_server = (array)$value;
 
                 break;
                 case 'index':
-                    $this->es_index = (string) $value;
+                    $this->es_index = (string)$value;
 
                 break;
                 default:
@@ -148,7 +148,7 @@ 
             ],
         ]);
 
-        $user = (string) $this->user->getId();
+        $user = (string)$this->user->getId();
         foreach ($result['hits']['hits'] as $node) {
             $id = false;
 
@@ -159,8 +159,8 @@ 
                     $_node = $this->fs->findNodeWithId($id);
                     if ($_node->isDeleted() && (1 === $deleted || 2 === $deleted)
                      || !$_node->isDeleted() && (0 === $deleted || 2 === $deleted)) {
-                        if (!($_node->isShared() && !$_node->isOwnerRequest()) && !isset($list[(string) $_node->getId()])) {
-                            $list[(string) $_node->getId()] = $_node;
+                        if (!($_node->isShared() && !$_node->isOwnerRequest()) && !isset($list[(string)$_node->getId()])) {
+                            $list[(string)$_node->getId()] = $_node;
                         }
                     }
                 } catch (\Exception $e) {
@@ -230,8 +230,8 @@ 
         $bool = $query['body']['query'];
 
         $filter1 = [];
-        $filter1['bool']['should'][]['term']['owner'] = (string) $this->user->getId();
-        $filter1['bool']['should'][]['term']['metadata.ref.owner'] = (string) $this->user->getId();
+        $filter1['bool']['should'][]['term']['owner'] = (string)$this->user->getId();
+        $filter1['bool']['should'][]['term']['metadata.ref.owner'] = (string)$this->user->getId();
 
         $share_filter = [
             'bool' => [

src/app/Balloon.App.Notification/App/Http.php

Doc Comments -2 removed lines

@@ -22,9 +22,7 @@
     /**
      * Constructor.
      *
-     * @param LoggerInterace $logger
      * @param Router         $router
-     * @param iterable       $config
      */
     public function __construct(Router $router)
     {

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon

src/app/Balloon.App.Notification/Hook/NewShareAdded.php

Doc Comments +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
     /**
      * Constructor.
      *
-     * @param Notification $notifier
+     * @param Notifier $notifier
      * @param Server       $server
      */
     public function __construct(Notifier $notifier, Server $server, LoggerInterface $logger, ?Iterable $config = null)
@@ -160,7 +160,7 @@ 
      * @param NodeInterface $node
      * @param User          $user
      *
-     * @return string
+     * @return boolean
      */
     protected function checkNotify(NodeInterface $node, User $user): bool
     {

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 
 use Balloon\App\Notification\Exception;
 use Balloon\App\Notification\Notifier;
-use Balloon\Async\Mail;
 use Balloon\Filesystem\Node\Collection;
 use Balloon\Filesystem\Node\NodeInterface;
 use Balloon\Hook\AbstractHook;

Spacing +10 added lines, -10 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -81,7 +81,7 @@ 
      *
      * @return AbstractHook
      */
-    public function setOptions(?Iterable $config = null): AbstractHook
+    public function setOptions(?Iterable $config = null) : AbstractHook
     {
         if (null === $config) {
             return $this;
@@ -91,7 +91,7 @@ 
             switch ($option) {
                 case 'body':
                 case 'subject':
-                    $this->{$option} = (string) $value;
+                    $this->{$option} = (string)$value;
 
                 break;
                 default:
@@ -113,7 +113,7 @@ 
      * @param string        $recursion
      * @param bool          $recursion_first
      */
-    public function postSaveNodeAttributes(NodeInterface $node, array $attributes, array $remove, ?string $recursion, bool $recursion_first): void
+    public function postSaveNodeAttributes(NodeInterface $node, array $attributes, array $remove, ?string $recursion, bool $recursion_first) : void
     {
         if (!($node instanceof Collection)) {
             return;
@@ -130,23 +130,23 @@ 
         foreach ($node->getShareAcl() as $rule) {
             if ('user' === $rule['type']) {
                 $user = $this->server->getUserById(new ObjectId($rule['id']));
-                if (!isset($receiver[(string) $user->getId()]) && $this->checkNotify($node, $user)) {
-                    $receiver[(string) $user->getId()] = $user;
+                if (!isset($receiver[(string)$user->getId()]) && $this->checkNotify($node, $user)) {
+                    $receiver[(string)$user->getId()] = $user;
                 }
             } elseif ('group' === $rule['type']) {
                 foreach ($this->server->getGroupById($rule['id'])->getResolvedMember() as $user) {
-                    if (!isset($receiver[(string) $user->getId()]) && $this->checkNotify($node, $user)) {
-                        $receiver[(string) $user->getId()] = $user;
+                    if (!isset($receiver[(string)$user->getId()]) && $this->checkNotify($node, $user)) {
+                        $receiver[(string)$user->getId()] = $user;
                     }
                 }
             }
         }
 
         if (!empty($receiver)) {
-            $body = preg_replace_callback('/(\{(([a-z]\.*)+)\})/', function ($match) use ($node) {
+            $body = preg_replace_callback('/(\{(([a-z]\.*)+)\})/', function($match) use ($node) {
                 return $node->getAttribute($match[2]);
             }, $this->body);
-            $subject = preg_replace_callback('/(\{(([a-z]\.*)+)\})/', function ($match) use ($node) {
+            $subject = preg_replace_callback('/(\{(([a-z]\.*)+)\})/', function($match) use ($node) {
                 return $node->getAttribute($match[2]);
             }, $this->subject);
 

src/app/Balloon.App.Notification/Notifier.php

Doc Comments +3 added lines, -3 removed lines

@@ -73,7 +73,7 @@ 
      * Constructor.
      *
      * @param Database $db
-     * @param LoggerInterace $logger
+     * @param LoggerInterface $logger
      * @param iterable       $config
      */
     public function __construct(Database $db, LoggerInterface $logger, ?Iterable $config = null)
@@ -171,7 +171,7 @@ 
      *
      * @param AdapterInterface $adapter
      *
-     * @return AdapterInterface
+     * @return Notifier
      */
     public function injectAdapter($adapter, ?string $name = null): AdapterAwareInterface
     {
@@ -241,10 +241,10 @@ 
      * Add notification
      *
      * @param array $receiver
-     * @param User $user
      * @param string $subject
      * @param string $body
      * @param array $context
+     * @param User $sender
      * @return ObjectId
      */
     public function postNotification(array $receiver, ?User $sender, string $subject, string $body, array $context = []): ObjectId

Spacing +9 added lines, -9 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -90,7 +90,7 @@ 
      *
      * @return Notifier
      */
-    public function setOptions(?Iterable $config = null): self
+    public function setOptions(?Iterable $config = null) : self
     {
         if (null === $config) {
             return $this;
@@ -133,7 +133,7 @@ 
      *
      * @return bool
      */
-    public function notify(array $receiver, ?User $sender, string $subject, string $body, array $context = []): bool
+    public function notify(array $receiver, ?User $sender, string $subject, string $body, array $context = []) : bool
     {
         if (0 === count($this->adapter)) {
             $this->logger->warning('there are no notification adapter enabled, notification can not be sent', [
@@ -173,7 +173,7 @@ 
      *
      * @return AdapterInterface
      */
-    public function injectAdapter($adapter, ?string $name = null): AdapterAwareInterface
+    public function injectAdapter($adapter, ?string $name = null) : AdapterAwareInterface
     {
         if (!($adapter instanceof AdapterInterface)) {
             throw new Exception('adapter needs to implement AdapterInterface');
@@ -247,7 +247,7 @@ 
      * @param array $context
      * @return ObjectId
      */
-    public function postNotification(array $receiver, ?User $sender, string $subject, string $body, array $context = []): ObjectId
+    public function postNotification(array $receiver, ?User $sender, string $subject, string $body, array $context = []) : ObjectId
     {
         $data = [
             'subject' => $subject,
@@ -256,11 +256,11 @@ 
             'receiver' => [],
         ];
 
-        if($sender instanceof User) {
+        if ($sender instanceof User) {
             $data['sender'] = $sender->getId();
         }
 
-        foreach($receiver as $user) {
+        foreach ($receiver as $user) {
             $data['receiver'][] = $user->getId();
         }
 
@@ -296,11 +296,11 @@ 
             'receiver' => $user->getId()
         ]);
 
-        if($result === null) {
+        if ($result === null) {
             throw new Exception('notification not found');
         }
 
-        if(count($result['receiver']) <= 1) {
+        if (count($result['receiver']) <= 1) {
             $this->logger->debug('notification ['.$id.'] has only one member left, remove it', [
                 'category' => get_class($this)
             ]);

src/app/Balloon.App.Office/Api/v1/Document.php

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use Balloon\Filesystem\Node\Collection;
 use Balloon\Filesystem\Node\File;
 use Balloon\Server;
-use Balloon\Server\User;
 use Micro\Http\Response;
 
 class Document extends Controller

Spacing +6 added lines, -6 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -86,7 +86,7 @@ 
      *
      * @return Response
      */
-    public function get(?string $id = null, ?string $p = null): Response
+    public function get(?string $id = null, ?string $p = null) : Response
     {
         $node = $this->fs->getNode($id, $p, File::class);
         $document = new OfficeDoc($this->fs->getDatabase(), $node);
@@ -94,10 +94,10 @@ 
 
         foreach ($document->getSessions() as $session) {
             $sessions[] = [
-                'id' => (string) $session['_id'],
+                'id' => (string)$session['_id'],
                 'created' => $session['_id']->getTimestamp(),
                 'user' => [
-                    'id' => (string) $session['user'],
+                    'id' => (string)$session['user'],
                     'name' => $this->server->getUserById($session['user'])->getUsername(),
                 ],
             ];
@@ -158,12 +158,12 @@ 
      *
      * @return Response
      */
-    public function put(string $name, string $type, ?string $collection = null, array $attributes = [], int $conflict = 0): Response
+    public function put(string $name, string $type, ?string $collection = null, array $attributes = [], int $conflict = 0) : Response
     {
         $parent = $this->fs->getNode($collection, null, Collection::class, false, true);
         $tpl = new Template($type);
         $result = $parent->addFile($name, $tpl->get(), $attributes);
 
-        return (new Response())->setCode(201)->setBody((string) $result->getId());
+        return (new Response())->setCode(201)->setBody((string)$result->getId());
     }
 }