Conditions | 34 |
Paths | 1 |
Total Lines | 114 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
71 | public function format(RequestInterface $request, ?ResponseInterface $response = null, ?\Throwable $error = null): string |
||
72 | { |
||
73 | $cache = []; |
||
74 | |||
75 | /** @var string */ |
||
76 | return \preg_replace_callback( |
||
77 | '/{\s*([A-Za-z_\-\.0-9]+)\s*}/', |
||
78 | function (array $matches) use ($request, $response, $error, &$cache) { |
||
79 | if (isset($cache[$matches[1]])) { |
||
80 | return $cache[$matches[1]]; |
||
81 | } |
||
82 | |||
83 | $result = ''; |
||
84 | switch ($matches[1]) { |
||
85 | case 'request': |
||
86 | $result = Psr7\Message::toString($request); |
||
87 | break; |
||
88 | case 'response': |
||
89 | $result = $response ? Psr7\Message::toString($response) : ''; |
||
90 | break; |
||
91 | case 'req_headers': |
||
92 | $result = \trim($request->getMethod() |
||
93 | . ' ' . $request->getRequestTarget()) |
||
94 | . ' HTTP/' . $request->getProtocolVersion() . "\r\n" |
||
95 | . $this->headers($request); |
||
96 | break; |
||
97 | case 'res_headers': |
||
98 | $result = $response ? |
||
99 | \sprintf( |
||
100 | 'HTTP/%s %d %s', |
||
101 | $response->getProtocolVersion(), |
||
102 | $response->getStatusCode(), |
||
103 | $response->getReasonPhrase() |
||
104 | ) . "\r\n" . $this->headers($response) |
||
105 | : 'NULL'; |
||
106 | break; |
||
107 | case 'req_body': |
||
108 | $result = $request->getBody()->__toString(); |
||
109 | break; |
||
110 | case 'res_body': |
||
111 | if (!$response instanceof ResponseInterface) { |
||
112 | $result = 'NULL'; |
||
113 | break; |
||
114 | } |
||
115 | |||
116 | $body = $response->getBody(); |
||
117 | |||
118 | if (!$body->isSeekable()) { |
||
119 | $result = 'RESPONSE_NOT_LOGGEABLE'; |
||
120 | break; |
||
121 | } |
||
122 | |||
123 | $result = $response->getBody()->__toString(); |
||
124 | break; |
||
125 | case 'ts': |
||
126 | case 'date_iso_8601': |
||
127 | $result = \gmdate('c'); |
||
128 | break; |
||
129 | case 'date_common_log': |
||
130 | $result = \date('d/M/Y:H:i:s O'); |
||
131 | break; |
||
132 | case 'method': |
||
133 | $result = $request->getMethod(); |
||
134 | break; |
||
135 | case 'version': |
||
136 | $result = $request->getProtocolVersion(); |
||
137 | break; |
||
138 | case 'uri': |
||
139 | case 'url': |
||
140 | $result = $request->getUri(); |
||
141 | break; |
||
142 | case 'target': |
||
143 | $result = $request->getRequestTarget(); |
||
144 | break; |
||
145 | case 'req_version': |
||
146 | $result = $request->getProtocolVersion(); |
||
147 | break; |
||
148 | case 'res_version': |
||
149 | $result = $response |
||
150 | ? $response->getProtocolVersion() |
||
151 | : 'NULL'; |
||
152 | break; |
||
153 | case 'host': |
||
154 | $result = $request->getHeaderLine('Host'); |
||
155 | break; |
||
156 | case 'hostname': |
||
157 | $result = \gethostname(); |
||
158 | break; |
||
159 | case 'code': |
||
160 | $result = $response ? $response->getStatusCode() : 'NULL'; |
||
161 | break; |
||
162 | case 'phrase': |
||
163 | $result = $response ? $response->getReasonPhrase() : 'NULL'; |
||
164 | break; |
||
165 | case 'error': |
||
166 | $result = $error ? $error->getMessage() : 'NULL'; |
||
167 | break; |
||
168 | default: |
||
169 | // handle prefixed dynamic headers |
||
170 | if (\strpos($matches[1], 'req_header_') === 0) { |
||
171 | $result = $request->getHeaderLine(\substr($matches[1], 11)); |
||
172 | } elseif (\strpos($matches[1], 'res_header_') === 0) { |
||
173 | $result = $response |
||
174 | ? $response->getHeaderLine(\substr($matches[1], 11)) |
||
175 | : 'NULL'; |
||
176 | } |
||
177 | } |
||
178 | |||
179 | $cache[$matches[1]] = $result; |
||
180 | return $result; |
||
181 | }, |
||
182 | $this->template |
||
183 | ); |
||
184 | } |
||
185 | |||
199 |