@@ -76,7 +76,7 @@ discard block |
||
76 | 76 | */ |
77 | 77 | public static function remove() { |
78 | 78 | $shortcode = new static(); |
79 | - unset( self::$shortcodes[$shortcode->name] ); |
|
79 | + unset( self::$shortcodes[ $shortcode->name ] ); |
|
80 | 80 | remove_shortcode( $shortcode->name ); |
81 | 81 | } |
82 | 82 | |
@@ -108,14 +108,14 @@ discard block |
||
108 | 108 | preg_match_all( '/' . get_shortcode_regex() . '/', $content, $matches, PREG_SET_ORDER ); |
109 | 109 | |
110 | 110 | foreach ( $matches as $shortcode ) { |
111 | - $shortcode_name = $shortcode[2]; |
|
111 | + $shortcode_name = $shortcode[ 2 ]; |
|
112 | 112 | |
113 | - $shortcode_atts = shortcode_parse_atts( $shortcode[3] ); |
|
114 | - $shortcode_content = $shortcode[5]; |
|
113 | + $shortcode_atts = shortcode_parse_atts( $shortcode[ 3 ] ); |
|
114 | + $shortcode_content = $shortcode[ 5 ]; |
|
115 | 115 | |
116 | 116 | /** This is a registered GravityView shortcode. */ |
117 | - if ( !empty( self::$shortcodes[$shortcode_name] ) ) { |
|
118 | - $shortcode = clone self::$shortcodes[$shortcode_name]; |
|
117 | + if ( ! empty( self::$shortcodes[ $shortcode_name ] ) ) { |
|
118 | + $shortcode = clone self::$shortcodes[ $shortcode_name ]; |
|
119 | 119 | } else { |
120 | 120 | /** This is some generic shortcode. */ |
121 | 121 | $shortcode = new self; |
@@ -62,7 +62,6 @@ |
||
62 | 62 | * |
63 | 63 | * Internal static cache for gets, and whatnot. |
64 | 64 | * This is not persistent, resets across requests. |
65 | - |
|
66 | 65 | * @internal |
67 | 66 | */ |
68 | 67 | private static $cache = array(); |
@@ -209,7 +209,7 @@ discard block |
||
209 | 209 | $slug = apply_filters( 'gravityview_slug', 'view' ); |
210 | 210 | $rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' ); |
211 | 211 | |
212 | - add_filter( 'query_vars', function( $query_vars ) { |
|
212 | + add_filter( 'query_vars', function( $query_vars ) { |
|
213 | 213 | $query_vars[] = 'csv'; |
214 | 214 | return $query_vars; |
215 | 215 | } ); |
@@ -254,8 +254,9 @@ discard block |
||
254 | 254 | * Check permissions. |
255 | 255 | */ |
256 | 256 | while ( $error = $view->can_render( null, $request ) ) { |
257 | - if ( ! is_wp_error( $error ) ) |
|
258 | - break; |
|
257 | + if ( ! is_wp_error( $error ) ) { |
|
258 | + break; |
|
259 | + } |
|
259 | 260 | |
260 | 261 | switch ( str_replace( 'gravityview/', '', $error->get_error_code() ) ) { |
261 | 262 | case 'post_password_required': |
@@ -795,6 +795,7 @@ |
||
795 | 795 | * Retrieve the entries for the current view and request. |
796 | 796 | * |
797 | 797 | * @param \GV\Request The request. Unused for now. |
798 | + * @param Request $request |
|
798 | 799 | * |
799 | 800 | * @return \GV\Entry_Collection The entries. |
800 | 801 | */ |
@@ -125,7 +125,7 @@ discard block |
||
125 | 125 | $supports = array( 'title', 'revisions' ); |
126 | 126 | |
127 | 127 | if ( $is_hierarchical ) { |
128 | - $supports[] = 'page-attributes'; |
|
128 | + $supports[ ] = 'page-attributes'; |
|
129 | 129 | } |
130 | 130 | |
131 | 131 | /** |
@@ -227,11 +227,11 @@ discard block |
||
227 | 227 | $rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' ); |
228 | 228 | |
229 | 229 | add_filter( 'query_vars', function( $query_vars ) { |
230 | - $query_vars[] = 'csv'; |
|
230 | + $query_vars[ ] = 'csv'; |
|
231 | 231 | return $query_vars; |
232 | 232 | } ); |
233 | 233 | |
234 | - if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) { |
|
234 | + if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) { |
|
235 | 235 | call_user_func_array( 'add_rewrite_rule', $rule ); |
236 | 236 | } |
237 | 237 | } |
@@ -300,13 +300,13 @@ discard block |
||
300 | 300 | return $content; |
301 | 301 | } |
302 | 302 | |
303 | - $is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID ); |
|
303 | + $is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID ); |
|
304 | 304 | |
305 | 305 | /** |
306 | 306 | * Editing a single entry. |
307 | 307 | */ |
308 | 308 | if ( $entry = $request->is_edit_entry( $view->form ? $view->form->ID : 0 ) ) { |
309 | - if ( $entry['status'] != 'active' ) { |
|
309 | + if ( $entry[ 'status' ] != 'active' ) { |
|
310 | 310 | gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) ); |
311 | 311 | return __( 'You are not allowed to view this content.', 'gravityview' ); |
312 | 312 | } |
@@ -317,7 +317,7 @@ discard block |
||
317 | 317 | } |
318 | 318 | |
319 | 319 | if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) { |
320 | - if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) { |
|
320 | + if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) { |
|
321 | 321 | gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) ); |
322 | 322 | return __( 'You are not allowed to view this content.', 'gravityview' ); |
323 | 323 | } |
@@ -340,7 +340,7 @@ discard block |
||
340 | 340 | |
341 | 341 | foreach ( $entryset as $e ) { |
342 | 342 | |
343 | - if ( 'active' !== $e['status'] ) { |
|
343 | + if ( 'active' !== $e[ 'status' ] ) { |
|
344 | 344 | gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $e->ID ) ); |
345 | 345 | return __( 'You are not allowed to view this content.', 'gravityview' ); |
346 | 346 | } |
@@ -351,7 +351,7 @@ discard block |
||
351 | 351 | } |
352 | 352 | |
353 | 353 | if ( $show_only_approved && ! $is_admin_and_can_view ) { |
354 | - if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) ) ) { |
|
354 | + if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) ) ) { |
|
355 | 355 | gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $e->ID ) ); |
356 | 356 | return __( 'You are not allowed to view this content.', 'gravityview' ); |
357 | 357 | } |
@@ -526,7 +526,7 @@ discard block |
||
526 | 526 | $join_column = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field::by_id( $join_column ); |
527 | 527 | $join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field::by_id( $join_on_column ); |
528 | 528 | |
529 | - $joins [] = new Join( $join, $join_column, $join_on, $join_on_column ); |
|
529 | + $joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column ); |
|
530 | 530 | } |
531 | 531 | |
532 | 532 | return $joins; |
@@ -621,13 +621,13 @@ discard block |
||
621 | 621 | } |
622 | 622 | |
623 | 623 | foreach ( $_fields as $field ) { |
624 | - if ( ! empty( $field['unions'] ) ) { |
|
625 | - foreach ( $field['unions'] as $form_id => $field_id ) { |
|
624 | + if ( ! empty( $field[ 'unions' ] ) ) { |
|
625 | + foreach ( $field[ 'unions' ] as $form_id => $field_id ) { |
|
626 | 626 | if ( ! isset( $unions[ $form_id ] ) ) { |
627 | 627 | $unions[ $form_id ] = array(); |
628 | 628 | } |
629 | 629 | |
630 | - $unions[ $form_id ][ $field['id'] ] = |
|
630 | + $unions[ $form_id ][ $field[ 'id' ] ] = |
|
631 | 631 | is_numeric( $field_id ) ? \GV\GF_Field::by_id( \GV\GF_Form::by_id( $form_id ), $field_id ) : \GV\Internal_Field::by_id( $field_id ); |
632 | 632 | } |
633 | 633 | } |
@@ -676,7 +676,7 @@ discard block |
||
676 | 676 | if ( ! $view->form ) { |
677 | 677 | gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array( |
678 | 678 | 'view_id' => $view->ID, |
679 | - 'form_id' => $view->_gravityview_form_id ? : 0, |
|
679 | + 'form_id' => $view->_gravityview_form_id ?: 0, |
|
680 | 680 | ) ); |
681 | 681 | } |
682 | 682 | |
@@ -915,11 +915,11 @@ discard block |
||
915 | 915 | * Remove multiple sorting before calling legacy filters. |
916 | 916 | * This allows us to fake it till we make it. |
917 | 917 | */ |
918 | - if ( ! empty( $parameters['sort_field'] ) && is_array( $parameters['sort_field'] ) ) { |
|
918 | + if ( ! empty( $parameters[ 'sort_field' ] ) && is_array( $parameters[ 'sort_field' ] ) ) { |
|
919 | 919 | $has_multisort = true; |
920 | - $parameters['sort_field'] = reset( $parameters['sort_field'] ); |
|
921 | - if ( ! empty( $parameters['sort_direction'] ) && is_array( $parameters['sort_direction'] ) ) { |
|
922 | - $parameters['sort_direction'] = reset( $parameters['sort_direction'] ); |
|
920 | + $parameters[ 'sort_field' ] = reset( $parameters[ 'sort_field' ] ); |
|
921 | + if ( ! empty( $parameters[ 'sort_direction' ] ) && is_array( $parameters[ 'sort_direction' ] ) ) { |
|
922 | + $parameters[ 'sort_direction' ] = reset( $parameters[ 'sort_direction' ] ); |
|
923 | 923 | } |
924 | 924 | } |
925 | 925 | |
@@ -927,34 +927,33 @@ discard block |
||
927 | 927 | * @todo: Stop using _frontend and use something like $request->get_search_criteria() instead |
928 | 928 | */ |
929 | 929 | $parameters = \GravityView_frontend::get_view_entries_parameters( $parameters, $this->form->ID ); |
930 | - $parameters['context_view_id'] = $this->ID; |
|
930 | + $parameters[ 'context_view_id' ] = $this->ID; |
|
931 | 931 | $parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID ); |
932 | 932 | |
933 | 933 | if ( $request instanceof REST\Request ) { |
934 | 934 | $atts = $this->settings->as_atts(); |
935 | 935 | $paging_parameters = wp_parse_args( $request->get_paging(), array( |
936 | - 'paging' => array( 'page_size' => $atts['page_size'] ), |
|
936 | + 'paging' => array( 'page_size' => $atts[ 'page_size' ] ), |
|
937 | 937 | ) ); |
938 | - $parameters['paging'] = $paging_parameters['paging']; |
|
938 | + $parameters[ 'paging' ] = $paging_parameters[ 'paging' ]; |
|
939 | 939 | } |
940 | 940 | |
941 | - $page = Utils::get( $parameters['paging'], 'current_page' ) ? |
|
942 | - : ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / $parameters['paging']['page_size'] ) + 1 ); |
|
941 | + $page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / $parameters[ 'paging' ][ 'page_size' ] ) + 1 ); |
|
943 | 942 | |
944 | 943 | /** |
945 | 944 | * Cleanup duplicate field_filter parameters to simplify the query. |
946 | 945 | */ |
947 | 946 | $unique_field_filters = array(); |
948 | - foreach ( $parameters['search_criteria']['field_filters'] as $key => $filter ) { |
|
947 | + foreach ( $parameters[ 'search_criteria' ][ 'field_filters' ] as $key => $filter ) { |
|
949 | 948 | if ( 'mode' === $key ) { |
950 | - $unique_field_filters['mode'] = $filter; |
|
949 | + $unique_field_filters[ 'mode' ] = $filter; |
|
951 | 950 | } else if ( ! in_array( $filter, $unique_field_filters ) ) { |
952 | - $unique_field_filters[] = $filter; |
|
951 | + $unique_field_filters[ ] = $filter; |
|
953 | 952 | } |
954 | 953 | } |
955 | - $parameters['search_criteria']['field_filters'] = $unique_field_filters; |
|
954 | + $parameters[ 'search_criteria' ][ 'field_filters' ] = $unique_field_filters; |
|
956 | 955 | |
957 | - if ( ! empty( $parameters['search_criteria']['field_filters'] ) ) { |
|
956 | + if ( ! empty( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) { |
|
958 | 957 | gravityview()->log->notice( 'search_criteria/field_filters is not empty, third-party code may be using legacy search_criteria filters.' ); |
959 | 958 | } |
960 | 959 | |
@@ -963,7 +962,7 @@ discard block |
||
963 | 962 | $query_class = $this->get_query_class(); |
964 | 963 | |
965 | 964 | /** @var \GF_Query $query */ |
966 | - $query = new $query_class( $this->form->ID, $parameters['search_criteria'], $parameters['sorting'] ); |
|
965 | + $query = new $query_class( $this->form->ID, $parameters[ 'search_criteria' ], $parameters[ 'sorting' ] ); |
|
967 | 966 | |
968 | 967 | /** |
969 | 968 | * Apply multisort. |
@@ -974,15 +973,15 @@ discard block |
||
974 | 973 | $view_setting_sort_field_ids = \GV\Utils::get( $atts, 'sort_field', array() ); |
975 | 974 | $view_setting_sort_directions = \GV\Utils::get( $atts, 'sort_direction', array() ); |
976 | 975 | |
977 | - $has_sort_query_param = ! empty( $_GET['sort'] ) && is_array( $_GET['sort'] ); |
|
976 | + $has_sort_query_param = ! empty( $_GET[ 'sort' ] ) && is_array( $_GET[ 'sort' ] ); |
|
978 | 977 | |
979 | - if( $has_sort_query_param ) { |
|
980 | - $has_sort_query_param = array_filter( array_values( $_GET['sort'] ) ); |
|
978 | + if ( $has_sort_query_param ) { |
|
979 | + $has_sort_query_param = array_filter( array_values( $_GET[ 'sort' ] ) ); |
|
981 | 980 | } |
982 | 981 | |
983 | 982 | if ( $this->settings->get( 'sort_columns' ) && $has_sort_query_param ) { |
984 | - $sort_field_ids = array_keys( $_GET['sort'] ); |
|
985 | - $sort_directions = array_values( $_GET['sort'] ); |
|
983 | + $sort_field_ids = array_keys( $_GET[ 'sort' ] ); |
|
984 | + $sort_directions = array_values( $_GET[ 'sort' ] ); |
|
986 | 985 | } else { |
987 | 986 | $sort_field_ids = $view_setting_sort_field_ids; |
988 | 987 | $sort_directions = $view_setting_sort_directions; |
@@ -990,7 +989,7 @@ discard block |
||
990 | 989 | |
991 | 990 | $skip_first = false; |
992 | 991 | |
993 | - foreach ( (array) $sort_field_ids as $key => $sort_field_id ) { |
|
992 | + foreach ( (array)$sort_field_ids as $key => $sort_field_id ) { |
|
994 | 993 | |
995 | 994 | if ( ! $skip_first && ! $has_sort_query_param ) { |
996 | 995 | $skip_first = true; // Skip the first one, it's already in the query |
@@ -1020,15 +1019,15 @@ discard block |
||
1020 | 1019 | |
1021 | 1020 | $merged_time = false; |
1022 | 1021 | |
1023 | - foreach ( $q['order'] as $oid => $order ) { |
|
1024 | - if ( $order[0] instanceof \GF_Query_Column ) { |
|
1025 | - $column = $order[0]; |
|
1026 | - } else if ( $order[0] instanceof \GF_Query_Call ) { |
|
1027 | - if ( count( $order[0]->columns ) != 1 || ! $order[0]->columns[0] instanceof \GF_Query_Column ) { |
|
1022 | + foreach ( $q[ 'order' ] as $oid => $order ) { |
|
1023 | + if ( $order[ 0 ] instanceof \GF_Query_Column ) { |
|
1024 | + $column = $order[ 0 ]; |
|
1025 | + } else if ( $order[ 0 ] instanceof \GF_Query_Call ) { |
|
1026 | + if ( count( $order[ 0 ]->columns ) != 1 || ! $order[ 0 ]->columns[ 0 ] instanceof \GF_Query_Column ) { |
|
1028 | 1027 | $orders[ $oid ] = $order; |
1029 | 1028 | continue; // Need something that resembles a single sort |
1030 | 1029 | } |
1031 | - $column = $order[0]->columns[0]; |
|
1030 | + $column = $order[ 0 ]->columns[ 0 ]; |
|
1032 | 1031 | } |
1033 | 1032 | |
1034 | 1033 | if ( ( ! $field = \GFAPI::get_field( $column->source, $column->field_id ) ) || $field->type !== 'time' ) { |
@@ -1042,7 +1041,7 @@ discard block |
||
1042 | 1041 | |
1043 | 1042 | $orders[ $oid ] = array( |
1044 | 1043 | new \GV\Mocks\GF_Query_Call_TIMESORT( 'timesort', array( $column, $sql ) ), |
1045 | - $order[1] // Mock it! |
|
1044 | + $order[ 1 ] // Mock it! |
|
1046 | 1045 | ); |
1047 | 1046 | |
1048 | 1047 | $merged_time = true; |
@@ -1053,15 +1052,15 @@ discard block |
||
1053 | 1052 | * ORDER again. |
1054 | 1053 | */ |
1055 | 1054 | if ( ! empty( $orders ) && $_orders = $query->_order_generate( $orders ) ) { |
1056 | - $sql['order'] = 'ORDER BY ' . implode( ', ', $_orders ); |
|
1055 | + $sql[ 'order' ] = 'ORDER BY ' . implode( ', ', $_orders ); |
|
1057 | 1056 | } |
1058 | 1057 | } |
1059 | 1058 | |
1060 | 1059 | return $sql; |
1061 | 1060 | } ); |
1062 | 1061 | |
1063 | - $query->limit( $parameters['paging']['page_size'] ) |
|
1064 | - ->offset( ( ( $page - 1 ) * $parameters['paging']['page_size'] ) + $this->settings->get( 'offset' ) ); |
|
1062 | + $query->limit( $parameters[ 'paging' ][ 'page_size' ] ) |
|
1063 | + ->offset( ( ( $page - 1 ) * $parameters[ 'paging' ][ 'page_size' ] ) + $this->settings->get( 'offset' ) ); |
|
1065 | 1064 | |
1066 | 1065 | /** |
1067 | 1066 | * Any joins? |
@@ -1084,7 +1083,7 @@ discard block |
||
1084 | 1083 | |
1085 | 1084 | $query_parameters = $query->_introspect(); |
1086 | 1085 | |
1087 | - $query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) ); |
|
1086 | + $query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) ); |
|
1088 | 1087 | } |
1089 | 1088 | |
1090 | 1089 | /** |
@@ -1118,7 +1117,7 @@ discard block |
||
1118 | 1117 | } |
1119 | 1118 | |
1120 | 1119 | $q = $query->_introspect(); |
1121 | - $query->where( \GF_Query_Condition::_and( $q['where'], $condition ) ); |
|
1120 | + $query->where( \GF_Query_Condition::_and( $q[ 'where' ], $condition ) ); |
|
1122 | 1121 | |
1123 | 1122 | if ( $this->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) { |
1124 | 1123 | |
@@ -1143,7 +1142,7 @@ discard block |
||
1143 | 1142 | |
1144 | 1143 | $query_parameters = $query->_introspect(); |
1145 | 1144 | |
1146 | - $query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) ); |
|
1145 | + $query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) ); |
|
1147 | 1146 | } |
1148 | 1147 | } |
1149 | 1148 | |
@@ -1167,7 +1166,7 @@ discard block |
||
1167 | 1166 | $conditions = array(); |
1168 | 1167 | |
1169 | 1168 | foreach ( $condition->expressions as $_condition ) { |
1170 | - $conditions[] = $recurse( $_condition, $fields, $recurse ); |
|
1169 | + $conditions[ ] = $recurse( $_condition, $fields, $recurse ); |
|
1171 | 1170 | } |
1172 | 1171 | |
1173 | 1172 | return call_user_func_array( |
@@ -1196,10 +1195,10 @@ discard block |
||
1196 | 1195 | $q = new $query_class( $form_id ); |
1197 | 1196 | |
1198 | 1197 | // Copy the WHERE clauses but substitute the field_ids to the respective ones |
1199 | - $q->where( $where_union_substitute( $query_parameters['where'], $fields, $where_union_substitute ) ); |
|
1198 | + $q->where( $where_union_substitute( $query_parameters[ 'where' ], $fields, $where_union_substitute ) ); |
|
1200 | 1199 | |
1201 | 1200 | // Copy the ORDER clause and substitute the field_ids to the respective ones |
1202 | - foreach ( $query_parameters['order'] as $order ) { |
|
1201 | + foreach ( $query_parameters[ 'order' ] as $order ) { |
|
1203 | 1202 | list( $column, $_order ) = $order; |
1204 | 1203 | |
1205 | 1204 | if ( $column && $column instanceof \GF_Query_Column ) { |
@@ -1213,15 +1212,15 @@ discard block |
||
1213 | 1212 | |
1214 | 1213 | add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( &$unions_sql ) { |
1215 | 1214 | // Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses |
1216 | - $select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] ); |
|
1215 | + $select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] ); |
|
1217 | 1216 | |
1218 | 1217 | // Record the SQL |
1219 | - $unions_sql[] = array( |
|
1218 | + $unions_sql[ ] = array( |
|
1220 | 1219 | // Remove columns, we'll rebuild them |
1221 | 1220 | 'select' => preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $select ), |
1222 | - 'from' => $sql['from'], |
|
1223 | - 'join' => $sql['join'], |
|
1224 | - 'where' => $sql['where'], |
|
1221 | + 'from' => $sql[ 'from' ], |
|
1222 | + 'join' => $sql[ 'join' ], |
|
1223 | + 'where' => $sql[ 'where' ], |
|
1225 | 1224 | // Remove order and limit |
1226 | 1225 | ); |
1227 | 1226 | |
@@ -1238,11 +1237,11 @@ discard block |
||
1238 | 1237 | |
1239 | 1238 | add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( $unions_sql ) { |
1240 | 1239 | // Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses |
1241 | - $sql['select'] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] ); |
|
1240 | + $sql[ 'select' ] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] ); |
|
1242 | 1241 | |
1243 | 1242 | // Remove columns, we'll rebuild them |
1244 | - preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql['select'], $select_match ); |
|
1245 | - $sql['select'] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql['select'] ); |
|
1243 | + preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql[ 'select' ], $select_match ); |
|
1244 | + $sql[ 'select' ] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql[ 'select' ] ); |
|
1246 | 1245 | |
1247 | 1246 | $unions = array(); |
1248 | 1247 | |
@@ -1253,30 +1252,30 @@ discard block |
||
1253 | 1252 | }; |
1254 | 1253 | |
1255 | 1254 | // Add all the order columns into the selects, so we can order by the whole union group |
1256 | - preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql['order'], $order_matches ); |
|
1255 | + preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql[ 'order' ], $order_matches ); |
|
1257 | 1256 | |
1258 | 1257 | $columns = array( |
1259 | - sprintf( '%s AS %s', $select_match[1], $column_to_alias( $select_match[1] ) ) |
|
1258 | + sprintf( '%s AS %s', $select_match[ 1 ], $column_to_alias( $select_match[ 1 ] ) ) |
|
1260 | 1259 | ); |
1261 | 1260 | |
1262 | 1261 | foreach ( array_slice( $order_matches, 1 ) as $match ) { |
1263 | - $columns[] = sprintf( '%s AS %s', $match[0], $column_to_alias( $match[0] ) ); |
|
1262 | + $columns[ ] = sprintf( '%s AS %s', $match[ 0 ], $column_to_alias( $match[ 0 ] ) ); |
|
1264 | 1263 | |
1265 | 1264 | // Rewrite the order columns to the shared aliases |
1266 | - $sql['order'] = str_replace( $match[0], $column_to_alias( $match[0] ), $sql['order'] ); |
|
1265 | + $sql[ 'order' ] = str_replace( $match[ 0 ], $column_to_alias( $match[ 0 ] ), $sql[ 'order' ] ); |
|
1267 | 1266 | } |
1268 | 1267 | |
1269 | 1268 | $columns = array_unique( $columns ); |
1270 | 1269 | |
1271 | 1270 | // Add the columns to every UNION |
1272 | 1271 | foreach ( $unions_sql as $union_sql ) { |
1273 | - $union_sql['select'] .= implode( ', ', $columns ); |
|
1274 | - $unions []= implode( ' ', $union_sql ); |
|
1272 | + $union_sql[ 'select' ] .= implode( ', ', $columns ); |
|
1273 | + $unions [ ] = implode( ' ', $union_sql ); |
|
1275 | 1274 | } |
1276 | 1275 | |
1277 | 1276 | // Add the columns to the main SELECT, but only grab the entry id column |
1278 | - $sql['select'] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql['select'] . implode( ', ', $columns ); |
|
1279 | - $sql['order'] = implode( ' ', $unions ) . ') AS u ' . $sql['order']; |
|
1277 | + $sql[ 'select' ] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql[ 'select' ] . implode( ', ', $columns ); |
|
1278 | + $sql[ 'order' ] = implode( ' ', $unions ) . ') AS u ' . $sql[ 'order' ]; |
|
1280 | 1279 | |
1281 | 1280 | return $sql; |
1282 | 1281 | } ); |
@@ -1321,20 +1320,20 @@ discard block |
||
1321 | 1320 | } ); |
1322 | 1321 | } else { |
1323 | 1322 | $entries = $this->form->entries |
1324 | - ->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) ) |
|
1323 | + ->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) ) |
|
1325 | 1324 | ->offset( $this->settings->get( 'offset' ) ) |
1326 | - ->limit( $parameters['paging']['page_size'] ) |
|
1325 | + ->limit( $parameters[ 'paging' ][ 'page_size' ] ) |
|
1327 | 1326 | ->page( $page ); |
1328 | 1327 | |
1329 | - if ( ! empty( $parameters['sorting'] ) && is_array( $parameters['sorting'] && ! isset( $parameters['sorting']['key'] ) ) ) { |
|
1328 | + if ( ! empty( $parameters[ 'sorting' ] ) && is_array( $parameters[ 'sorting' ] && ! isset( $parameters[ 'sorting' ][ 'key' ] ) ) ) { |
|
1330 | 1329 | // Pluck off multisort arrays |
1331 | - $parameters['sorting'] = $parameters['sorting'][0]; |
|
1330 | + $parameters[ 'sorting' ] = $parameters[ 'sorting' ][ 0 ]; |
|
1332 | 1331 | } |
1333 | 1332 | |
1334 | - if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) { |
|
1333 | + if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) { |
|
1335 | 1334 | $field = new \GV\Field(); |
1336 | - $field->ID = $parameters['sorting']['key']; |
|
1337 | - $direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC; |
|
1335 | + $field->ID = $parameters[ 'sorting' ][ 'key' ]; |
|
1336 | + $direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC; |
|
1338 | 1337 | $entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) ); |
1339 | 1338 | } |
1340 | 1339 | } |
@@ -1409,7 +1408,7 @@ discard block |
||
1409 | 1408 | $allowed = $headers = array(); |
1410 | 1409 | |
1411 | 1410 | foreach ( $view->fields->by_position( "directory_*" )->by_visible()->all() as $id => $field ) { |
1412 | - $allowed[] = $field; |
|
1411 | + $allowed[ ] = $field; |
|
1413 | 1412 | } |
1414 | 1413 | |
1415 | 1414 | $renderer = new Field_Renderer(); |
@@ -1431,17 +1430,17 @@ discard block |
||
1431 | 1430 | } ); |
1432 | 1431 | |
1433 | 1432 | foreach ( array_diff( $allowed_field_ids, wp_list_pluck( $allowed, 'ID' ) ) as $field_id ) { |
1434 | - $allowed[] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id ); |
|
1433 | + $allowed[ ] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id ); |
|
1435 | 1434 | } |
1436 | 1435 | |
1437 | 1436 | foreach ( $allowed as $field ) { |
1438 | 1437 | $source = is_numeric( $field->ID ) ? $view->form : new \GV\Internal_Source(); |
1439 | 1438 | |
1440 | - $return[] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' ); |
|
1439 | + $return[ ] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' ); |
|
1441 | 1440 | |
1442 | 1441 | if ( ! $headers_done ) { |
1443 | 1442 | $label = $field->get_label( $view, $source, $entry ); |
1444 | - $headers[] = $label ? $label : $field->ID; |
|
1443 | + $headers[ ] = $label ? $label : $field->ID; |
|
1445 | 1444 | } |
1446 | 1445 | } |
1447 | 1446 |
@@ -163,14 +163,14 @@ |
||
163 | 163 | return $settings; |
164 | 164 | } |
165 | 165 | |
166 | - /** |
|
166 | + /** |
|
167 | 167 | * Get the Widget ID. |
168 | 168 | * |
169 | - * @return string The Widget ID. |
|
170 | - */ |
|
171 | - public function get_widget_id() { |
|
172 | - return $this->widget_id; |
|
173 | - } |
|
169 | + * @return string The Widget ID. |
|
170 | + */ |
|
171 | + public function get_widget_id() { |
|
172 | + return $this->widget_id; |
|
173 | + } |
|
174 | 174 | |
175 | 175 | /** |
176 | 176 | * Get the widget settings |
@@ -151,7 +151,7 @@ discard block |
||
151 | 151 | $enable_custom_class = apply_filters( 'gravityview/widget/enable_custom_class', false, $this ); |
152 | 152 | |
153 | 153 | if ( $enable_custom_class ) { |
154 | - $settings['custom_class'] = array( |
|
154 | + $settings[ 'custom_class' ] = array( |
|
155 | 155 | 'type' => 'text', |
156 | 156 | 'label' => __( 'Custom CSS Class:', 'gravityview' ), |
157 | 157 | 'desc' => __( 'This class will be added to the widget container', 'gravityview' ), |
@@ -203,8 +203,8 @@ discard block |
||
203 | 203 | */ |
204 | 204 | public static function get_default_widget_areas() { |
205 | 205 | $default_areas = array( |
206 | - array( '1-1' => array( array( 'areaid' => 'top', 'title' => __( 'Top', 'gravityview' ) , 'subtitle' => '' ) ) ), |
|
207 | - array( '1-2' => array( array( 'areaid' => 'left', 'title' => __( 'Left', 'gravityview' ) , 'subtitle' => '' ) ), '2-2' => array( array( 'areaid' => 'right', 'title' => __( 'Right', 'gravityview' ) , 'subtitle' => '' ) ) ), |
|
206 | + array( '1-1' => array( array( 'areaid' => 'top', 'title' => __( 'Top', 'gravityview' ), 'subtitle' => '' ) ) ), |
|
207 | + array( '1-2' => array( array( 'areaid' => 'left', 'title' => __( 'Left', 'gravityview' ), 'subtitle' => '' ) ), '2-2' => array( array( 'areaid' => 'right', 'title' => __( 'Right', 'gravityview' ), 'subtitle' => '' ) ) ), |
|
208 | 208 | ); |
209 | 209 | |
210 | 210 | /** |
@@ -234,7 +234,7 @@ discard block |
||
234 | 234 | } |
235 | 235 | |
236 | 236 | $widgets[ $this->get_widget_id() ] = array( |
237 | - 'label' => $this->widget_label , |
|
237 | + 'label' => $this->widget_label, |
|
238 | 238 | 'description' => $this->widget_description, |
239 | 239 | 'subtitle' => $this->widget_subtitle, |
240 | 240 | 'class' => get_called_class(), |
@@ -255,7 +255,7 @@ discard block |
||
255 | 255 | */ |
256 | 256 | public function assign_widget_options( $options = array(), $template = '', $widget = '' ) { |
257 | 257 | if ( $this->get_widget_id() === $widget ) { |
258 | - if( $settings = $this->get_settings() ) { |
|
258 | + if ( $settings = $this->get_settings() ) { |
|
259 | 259 | $options = array_merge( $options, $settings ); |
260 | 260 | } |
261 | 261 | } |
@@ -306,7 +306,7 @@ discard block |
||
306 | 306 | return; |
307 | 307 | } |
308 | 308 | |
309 | - add_shortcode( $this->shortcode_name, array( $this, 'render_shortcode') ); |
|
309 | + add_shortcode( $this->shortcode_name, array( $this, 'render_shortcode' ) ); |
|
310 | 310 | } |
311 | 311 | |
312 | 312 | /** |
@@ -393,7 +393,7 @@ |
||
393 | 393 | * @internal |
394 | 394 | * @since 2.0 |
395 | 395 | * |
396 | - * @return \GV\Widget|null The widget implementation from configuration or none. |
|
396 | + * @return Widget The widget implementation from configuration or none. |
|
397 | 397 | */ |
398 | 398 | public static function from_configuration( $configuration ) { |
399 | 399 | $registered_widgets = self::registered(); |
@@ -34,7 +34,7 @@ |
||
34 | 34 | global $post; |
35 | 35 | |
36 | 36 | if ( $post ) { |
37 | - $context['post'] = $post; |
|
37 | + $context[ 'post' ] = $post; |
|
38 | 38 | } |
39 | 39 | |
40 | 40 | \GV\Mocks\Legacy_Context::push( $context ); |
@@ -113,14 +113,14 @@ |
||
113 | 113 | |
114 | 114 | /** Require critical legacy core files. @todo Deprecate */ |
115 | 115 | require_once $this->plugin->dir( 'includes/helper-functions.php' ); |
116 | - require_once $this->plugin->dir( 'includes/class-common.php'); |
|
117 | - require_once $this->plugin->dir( 'includes/connector-functions.php'); |
|
116 | + require_once $this->plugin->dir( 'includes/class-common.php' ); |
|
117 | + require_once $this->plugin->dir( 'includes/connector-functions.php' ); |
|
118 | 118 | require_once $this->plugin->dir( 'includes/class-gravityview-compatibility.php' ); |
119 | 119 | require_once $this->plugin->dir( 'includes/class-gravityview-roles-capabilities.php' ); |
120 | 120 | require_once $this->plugin->dir( 'includes/class-gravityview-admin-notices.php' ); |
121 | 121 | require_once $this->plugin->dir( 'includes/class-admin.php' ); |
122 | - require_once $this->plugin->dir( 'includes/class-post-types.php'); |
|
123 | - require_once $this->plugin->dir( 'includes/class-cache.php'); |
|
122 | + require_once $this->plugin->dir( 'includes/class-post-types.php' ); |
|
123 | + require_once $this->plugin->dir( 'includes/class-cache.php' ); |
|
124 | 124 | |
125 | 125 | /** |
126 | 126 | * GravityView extensions and widgets. |
@@ -78,7 +78,7 @@ |
||
78 | 78 | if ( $this->field ) { |
79 | 79 | return array( |
80 | 80 | 'key' => $this->field->ID, |
81 | - 'direction' => $this->direction ? : self::ASC, |
|
81 | + 'direction' => $this->direction ?: self::ASC, |
|
82 | 82 | 'is_numeric' => self::ALPHA ? true : false, |
83 | 83 | ); |
84 | 84 | } |
@@ -50,8 +50,8 @@ |
||
50 | 50 | /** |
51 | 51 | * By array. |
52 | 52 | */ |
53 | - if ( is_array( $view ) && ! empty( $view['id'] ) ) { |
|
54 | - return $this->get( $view['id'] ); |
|
53 | + if ( is_array( $view ) && ! empty( $view[ 'id' ] ) ) { |
|
54 | + return $this->get( $view[ 'id' ] ); |
|
55 | 55 | } |
56 | 56 | |
57 | 57 | /** |
@@ -266,7 +266,7 @@ discard block |
||
266 | 266 | ) ); |
267 | 267 | |
268 | 268 | if ( version_compare( \GFCommon::$version, '2.3-beta-4', '>=' ) ) { |
269 | - $default_settings['sort_direction']['options']['RAND'] = __( 'Random', 'gravityview' ); |
|
269 | + $default_settings[ 'sort_direction' ][ 'options' ][ 'RAND' ] = __( 'Random', 'gravityview' ); |
|
270 | 270 | } |
271 | 271 | |
272 | 272 | /** |
@@ -286,8 +286,8 @@ discard block |
||
286 | 286 | // By default, we only want the key => value pairing, not the whole array. |
287 | 287 | if ( ! $detailed ) { |
288 | 288 | $defaults = array(); |
289 | - foreach( $default_settings as $key => $value ) { |
|
290 | - $defaults[ $key ] = $value['value']; |
|
289 | + foreach ( $default_settings as $key => $value ) { |
|
290 | + $defaults[ $key ] = $value[ 'value' ]; |
|
291 | 291 | } |
292 | 292 | return $defaults; |
293 | 293 | |
@@ -298,7 +298,7 @@ discard block |
||
298 | 298 | // If the $group argument is set for the method, |
299 | 299 | // ignore any settings that aren't in that group. |
300 | 300 | if ( ! empty( $group ) && is_string( $group ) ) { |
301 | - if ( empty( $value['group'] ) || $value['group'] !== $group ) { |
|
301 | + if ( empty( $value[ 'group' ] ) || $value[ 'group' ] !== $group ) { |
|
302 | 302 | unset( $default_settings[ $key ] ); |
303 | 303 | } |
304 | 304 | } |
@@ -21,7 +21,7 @@ |
||
21 | 21 | require_once gravityview()->plugin->dir( 'future/includes/rest/class-gv-rest-route.php' ); |
22 | 22 | require_once gravityview()->plugin->dir( 'future/includes/rest/class-gv-rest-views-route.php' ); |
23 | 23 | |
24 | - self::$routes['views'] = $views = new Views_Route(); |
|
24 | + self::$routes[ 'views' ] = $views = new Views_Route(); |
|
25 | 25 | $views->register_routes(); |
26 | 26 | } |
27 | 27 |