Inspection of "Issue/1217 add options when no entries in view" - gravityview/GravityView - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#1810)

unknown

created 2023-02-13 16:08 UTC

Status

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -6,8 +6,7 @@  discard block
 block discarded – undo
 use Gettext\Utils\DictionaryTrait;
 use Symfony\Component\Yaml\Yaml as YamlDumper;
 
-class YamlDictionary extends Generator implements GeneratorInterface
-{
+class YamlDictionary extends Generator implements GeneratorInterface {
     use DictionaryTrait;
 
     public static $options = [
@@ -19,8 +18,7 @@  discard block
 block discarded – undo
     /**
      * {@inheritdoc}
      */
-    public static function toString(Translations $translations, array $options = [])
-    {
+    public static function toString(Translations $translations, array $options = []) {
         $options += static::$options;
 
         return YamlDumper::dump(

Please login to merge, or discard this patch.

vendor/gettext/gettext/src/Generators/Csv.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -9,8 +9,7 @@  discard block
 block discarded – undo
 /**
  * Class to export translations to csv.
  */
-class Csv extends Generator implements GeneratorInterface
-{
+class Csv extends Generator implements GeneratorInterface {
     use HeadersGeneratorTrait;
     use CsvTrait;
 
@@ -24,8 +23,7 @@  discard block
 block discarded – undo
     /**
      * {@parentDoc}.
      */
-    public static function toString(Translations $translations, array $options = [])
-    {
+    public static function toString(Translations $translations, array $options = []) {
         $options += static::$options;
         $handle = fopen('php://memory', 'w');
 

Please login to merge, or discard this patch.

vendor/gettext/gettext/src/Generators/JsonDictionary.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -5,8 +5,7 @@  discard block
 block discarded – undo
 use Gettext\Translations;
 use Gettext\Utils\DictionaryTrait;
 
-class JsonDictionary extends Generator implements GeneratorInterface
-{
+class JsonDictionary extends Generator implements GeneratorInterface {
     use DictionaryTrait;
 
     public static $options = [
@@ -17,8 +16,7 @@  discard block
 block discarded – undo
     /**
      * {@parentDoc}.
      */
-    public static function toString(Translations $translations, array $options = [])
-    {
+    public static function toString(Translations $translations, array $options = []) {
         $options += static::$options;
 
         return json_encode(static::toArray($translations, $options['includeHeaders']), $options['json']);

Please login to merge, or discard this patch.

vendor/gettext/gettext/src/Generators/Mo.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -5,8 +5,7 @@  discard block
 block discarded – undo
 use Gettext\Translations;
 use Gettext\Utils\HeadersGeneratorTrait;
 
-class Mo extends Generator implements GeneratorInterface
-{
+class Mo extends Generator implements GeneratorInterface {
     use HeadersGeneratorTrait;
 
     public static $options = [
@@ -16,8 +15,7 @@  discard block
 block discarded – undo
     /**
      * {@parentDoc}.
      */
-    public static function toString(Translations $translations, array $options = [])
-    {
+    public static function toString(Translations $translations, array $options = []) {
         $options += static::$options;
         $messages = [];
 

Please login to merge, or discard this patch.

vendor/gettext/gettext/src/Generators/Jed.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -4,8 +4,7 @@  discard block
 block discarded – undo
 
 use Gettext\Translations;
 
-class Jed extends Generator implements GeneratorInterface
-{
+class Jed extends Generator implements GeneratorInterface {
     public static $options = [
         'json' => 0,
     ];
@@ -13,8 +12,7 @@  discard block
 block discarded – undo
     /**
      * {@parentDoc}.
      */
-    public static function toString(Translations $translations, array $options = [])
-    {
+    public static function toString(Translations $translations, array $options = []) {
         $domain = $translations->getDomain() ?: 'messages';
         $options += static::$options;
 
@@ -36,8 +34,7 @@  discard block
 block discarded – undo
      *
      * @return array
      */
-    protected static function buildMessages(Translations $translations)
-    {
+    protected static function buildMessages(Translations $translations) {
         $pluralForm = $translations->getPluralForms();
         $pluralSize = is_array($pluralForm) ? ($pluralForm[0] - 1) : null;
         $messages = [];

Please login to merge, or discard this patch.

vendor/gettext/gettext/src/Generators/Po.php 1 patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

@@ -4,8 +4,7 @@  discard block
 block discarded – undo
 
 use Gettext\Translations;
 
-class Po extends Generator implements GeneratorInterface
-{
+class Po extends Generator implements GeneratorInterface {
     public static $options = [
         'noLocation' => false,
     ];
@@ -13,8 +12,7 @@  discard block
 block discarded – undo
     /**
      * {@parentDoc}.
      */
-    public static function toString(Translations $translations, array $options = [])
-    {
+    public static function toString(Translations $translations, array $options = []) {
         $options += static::$options;
 
         $pluralForm = $translations->getPluralForms();
@@ -83,8 +81,7 @@  discard block
 block discarded – undo
      *
      * @return string
      */
-    protected static function multilineQuote($string)
-    {
+    protected static function multilineQuote($string) {
         $lines = explode("\n", $string);
         $last = count($lines) - 1;
 
@@ -106,8 +103,7 @@  discard block
 block discarded – undo
      * @param string $name
      * @param string $value
      */
-    protected static function addLines(array &$lines, $name, $value)
-    {
+    protected static function addLines(array &$lines, $name, $value) {
         $newLines = static::multilineQuote($value);
 
         if (count($newLines) === 1) {
@@ -128,8 +124,7 @@  discard block
 block discarded – undo
      *
      * @return string
      */
-    public static function convertString($value)
-    {
+    public static function convertString($value) {
         return '"'.strtr(
             $value,
             [

Please login to merge, or discard this patch.

vendor/gettext/gettext/src/Generators/Json.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -5,8 +5,7 @@  discard block
 block discarded – undo
 use Gettext\Translations;
 use Gettext\Utils\MultidimensionalArrayTrait;
 
-class Json extends Generator implements GeneratorInterface
-{
+class Json extends Generator implements GeneratorInterface {
     use MultidimensionalArrayTrait;
 
     public static $options = [
@@ -17,8 +16,7 @@  discard block
 block discarded – undo
     /**
      * {@inheritdoc}
      */
-    public static function toString(Translations $translations, array $options = [])
-    {
+    public static function toString(Translations $translations, array $options = []) {
         $options += static::$options;
 
         return json_encode(static::toArray($translations, $options['includeHeaders'], true), $options['json']);

Please login to merge, or discard this patch.

vendor/gettext/gettext/src/Generators/Generator.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -4,13 +4,11 @@
 block discarded – undo
 
 use Gettext\Translations;
 
-abstract class Generator implements GeneratorInterface
-{
+abstract class Generator implements GeneratorInterface {
     /**
      * {@inheritdoc}
      */
-    public static function toFile(Translations $translations, $file, array $options = [])
-    {
+    public static function toFile(Translations $translations, $file, array $options = []) {
         $content = static::toString($translations, $options);
 
         if (file_put_contents($file, $content) === false) {

Please login to merge, or discard this patch.

vendor/gettext/gettext/src/Generators/Yaml.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -6,8 +6,7 @@  discard block
 block discarded – undo
 use Gettext\Utils\MultidimensionalArrayTrait;
 use Symfony\Component\Yaml\Yaml as YamlDumper;
 
-class Yaml extends Generator implements GeneratorInterface
-{
+class Yaml extends Generator implements GeneratorInterface {
     use MultidimensionalArrayTrait;
 
     public static $options = [
@@ -19,8 +18,7 @@  discard block
 block discarded – undo
     /**
      * {@inheritdoc}
      */
-    public static function toString(Translations $translations, array $options = [])
-    {
+    public static function toString(Translations $translations, array $options = []) {
         $options += static::$options;
 
         return YamlDumper::dump(

Please login to merge, or discard this patch.

		@@ -6,8 +6,7 @@ discard block
		block discarded – undo
6	6	use Gettext\Utils\DictionaryTrait;
7	7	use Symfony\Component\Yaml\Yaml as YamlDumper;
8	8
9		-class YamlDictionary extends Generator implements GeneratorInterface
10		-{
	9	+class YamlDictionary extends Generator implements GeneratorInterface {
11	10	use DictionaryTrait;
12	11
13	12	public static $options = [
		@@ -19,8 +18,7 @@ discard block
		block discarded – undo
19	18	/**
20	19	* {@inheritdoc}
21	20	*/
22		- public static function toString(Translations $translations, array $options = [])
23		- {
	21	+ public static function toString(Translations $translations, array $options = []) {
24	22	$options += static::$options;
25	23
26	24	return YamlDumper::dump(

		@@ -9,8 +9,7 @@ discard block
		block discarded – undo
9	9	/**
10	10	* Class to export translations to csv.
11	11	*/
12		-class Csv extends Generator implements GeneratorInterface
13		-{
	12	+class Csv extends Generator implements GeneratorInterface {
14	13	use HeadersGeneratorTrait;
15	14	use CsvTrait;
16	15
		@@ -24,8 +23,7 @@ discard block
		block discarded – undo
24	23	/**
25	24	* {@parentDoc}.
26	25	*/
27		- public static function toString(Translations $translations, array $options = [])
28		- {
	26	+ public static function toString(Translations $translations, array $options = []) {
29	27	$options += static::$options;
30	28	$handle = fopen('php://memory', 'w');
31	29

		@@ -5,8 +5,7 @@ discard block
		block discarded – undo
5	5	use Gettext\Translations;
6	6	use Gettext\Utils\DictionaryTrait;
7	7
8		-class JsonDictionary extends Generator implements GeneratorInterface
9		-{
	8	+class JsonDictionary extends Generator implements GeneratorInterface {
10	9	use DictionaryTrait;
11	10
12	11	public static $options = [
		@@ -17,8 +16,7 @@ discard block
		block discarded – undo
17	16	/**
18	17	* {@parentDoc}.
19	18	*/
20		- public static function toString(Translations $translations, array $options = [])
21		- {
	19	+ public static function toString(Translations $translations, array $options = []) {
22	20	$options += static::$options;
23	21
24	22	return json_encode(static::toArray($translations, $options['includeHeaders']), $options['json']);

		@@ -4,8 +4,7 @@ discard block
		block discarded – undo
4	4
5	5	use Gettext\Translations;
6	6
7		-class Jed extends Generator implements GeneratorInterface
8		-{
	7	+class Jed extends Generator implements GeneratorInterface {
9	8	public static $options = [
10	9	'json' => 0,
11	10	];
		@@ -13,8 +12,7 @@ discard block
		block discarded – undo
13	12	/**
14	13	* {@parentDoc}.
15	14	*/
16		- public static function toString(Translations $translations, array $options = [])
17		- {
	15	+ public static function toString(Translations $translations, array $options = []) {
18	16	$domain = $translations->getDomain() ?: 'messages';
19	17	$options += static::$options;
20	18
		@@ -36,8 +34,7 @@ discard block
		block discarded – undo
36	34	*
37	35	* @return array
38	36	*/
39		- protected static function buildMessages(Translations $translations)
40		- {
	37	+ protected static function buildMessages(Translations $translations) {
41	38	$pluralForm = $translations->getPluralForms();
42	39	$pluralSize = is_array($pluralForm) ? ($pluralForm[0] - 1) : null;
43	40	$messages = [];

		@@ -4,13 +4,11 @@
		block discarded – undo
4	4
5	5	use Gettext\Translations;
6	6
7		-abstract class Generator implements GeneratorInterface
8		-{
	7	+abstract class Generator implements GeneratorInterface {
9	8	/**
10	9	* {@inheritdoc}
11	10	*/
12		- public static function toFile(Translations $translations, $file, array $options = [])
13		- {
	11	+ public static function toFile(Translations $translations, $file, array $options = []) {
14	12	$content = static::toString($translations, $options);
15	13
16	14	if (file_put_contents($file, $content) === false) {

		@@ -6,8 +6,7 @@ discard block
		block discarded – undo
6	6	use Gettext\Utils\MultidimensionalArrayTrait;
7	7	use Symfony\Component\Yaml\Yaml as YamlDumper;
8	8
9		-class Yaml extends Generator implements GeneratorInterface
10		-{
	9	+class Yaml extends Generator implements GeneratorInterface {
11	10	use MultidimensionalArrayTrait;
12	11
13	12	public static $options = [
		@@ -19,8 +18,7 @@ discard block
		block discarded – undo
19	18	/**
20	19	* {@inheritdoc}
21	20	*/
22		- public static function toString(Translations $translations, array $options = [])
23		- {
	21	+ public static function toString(Translations $translations, array $options = []) {
24	22	$options += static::$options;
25	23
26	24	return YamlDumper::dump(

gravityview / GravityView

Pull Request — develop (#1810)

Status

Category

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch