Completed
Pull Request — develop (#1347)
by Gennady
37:05 queued 21:19
created
includes/widgets/search-widget/templates/search-field-entry_id.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -7,13 +7,13 @@
 block discarded – undo
7 7
 
8 8
 $gravityview_view = GravityView_View::getInstance();
9 9
 $view_id = $gravityview_view->getViewId();
10
-$value = $gravityview_view->search_field['value'];
11
-$label = $gravityview_view->search_field['label'];
10
+$value = $gravityview_view->search_field[ 'value' ];
11
+$label = $gravityview_view->search_field[ 'label' ];
12 12
 ?>
13 13
 
14 14
 <div class="gv-search-box gv-search-field-entry_id">
15 15
 	<div class="gv-search">
16
-		<?php if( ! gv_empty( $label, false, false ) ) { ?>
16
+		<?php if ( ! gv_empty( $label, false, false ) ) { ?>
17 17
 		<label for="gv_entry_id_<?php echo $view_id; ?>"><?php echo esc_html( $label ); ?></label>
18 18
 		<?php } ?>
19 19
 		<p><input type="text" name="gv_id" id="gv_entry_id_<?php echo $view_id; ?>" value="<?php echo esc_attr( $value ); ?>" /></p>
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/search-field-entry_date.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -7,17 +7,17 @@
 block discarded – undo
7 7
 
8 8
 $gravityview_view = GravityView_View::getInstance();
9 9
 $view_id = $gravityview_view->getViewId();
10
-$value = $gravityview_view->search_field['value'];
11
-$label = $gravityview_view->search_field['label'];
10
+$value = $gravityview_view->search_field[ 'value' ];
11
+$label = $gravityview_view->search_field[ 'label' ];
12 12
 
13 13
 ?>
14 14
 
15 15
 <div class="gv-search-box gv-search-date gv-search-date-range gv-search-field-entry_date">
16
-	<?php if( ! gv_empty( $label, false, false ) ) { ?>
16
+	<?php if ( ! gv_empty( $label, false, false ) ) { ?>
17 17
 	<label for="gv_start_date_<?php echo $view_id; ?>"><?php echo esc_html( $label ); ?></label>
18 18
 	<?php } ?>
19 19
 	<p>
20
-		<input name="gv_start" id="gv_start_date_<?php echo $view_id; ?>" type="text" class="<?php echo esc_attr( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e('Start date', 'gravityview' ); ?>" value="<?php echo $value['start']; ?>">
21
-		<input name="gv_end" id="gv_end_date_<?php echo $view_id; ?>" type="text" class="<?php echo esc_attr( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e('End date', 'gravityview' ); ?>" value="<?php echo $value['end']; ?>">
20
+		<input name="gv_start" id="gv_start_date_<?php echo $view_id; ?>" type="text" class="<?php echo esc_attr( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e( 'Start date', 'gravityview' ); ?>" value="<?php echo $value[ 'start' ]; ?>">
21
+		<input name="gv_end" id="gv_end_date_<?php echo $view_id; ?>" type="text" class="<?php echo esc_attr( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e( 'End date', 'gravityview' ); ?>" value="<?php echo $value[ 'end' ]; ?>">
22 22
 	</p>
23 23
 </div>
24 24
\ No newline at end of file
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/search-field-date_range.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -7,17 +7,17 @@
 block discarded – undo
7 7
 
8 8
 $gravityview_view = GravityView_View::getInstance();
9 9
 $view_id = $gravityview_view->getViewId();
10
-$value = $gravityview_view->search_field['value'];
11
-$label = $gravityview_view->search_field['label'];
12
-$name = $gravityview_view->search_field['name'];
10
+$value = $gravityview_view->search_field[ 'value' ];
11
+$label = $gravityview_view->search_field[ 'label' ];
12
+$name = $gravityview_view->search_field[ 'name' ];
13 13
 ?>
14 14
 
15 15
 <div class="gv-search-box gv-search-date gv-search-date-range">
16
-	<?php if( ! gv_empty( $label, false, false ) ) { ?>
17
-	<label for="search-box-<?php echo esc_attr( $name ).'-start'; ?>"><?php echo esc_html( $label ); ?></label>
16
+	<?php if ( ! gv_empty( $label, false, false ) ) { ?>
17
+	<label for="search-box-<?php echo esc_attr( $name ) . '-start'; ?>"><?php echo esc_html( $label ); ?></label>
18 18
 	<?php } ?>
19 19
 	<p>
20
-		<input name="<?php echo esc_attr( $name ).'[start]'; ?>" id="search-box-<?php echo esc_attr( $name ).'-start'; ?>" type="text" class="<?php echo esc_html( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e('Start date', 'gravityview' ); ?>" value="<?php echo esc_attr( $value['start'] ); ?>">
21
-		<input name="<?php echo esc_attr( $name ).'[end]'; ?>" id="search-box-<?php echo esc_attr( $name ).'-end'; ?>" type="text" class="<?php echo esc_html( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e('End date', 'gravityview' ); ?>" value="<?php echo esc_attr( $value['end'] ); ?>">
20
+		<input name="<?php echo esc_attr( $name ) . '[start]'; ?>" id="search-box-<?php echo esc_attr( $name ) . '-start'; ?>" type="text" class="<?php echo esc_html( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e( 'Start date', 'gravityview' ); ?>" value="<?php echo esc_attr( $value[ 'start' ] ); ?>">
21
+		<input name="<?php echo esc_attr( $name ) . '[end]'; ?>" id="search-box-<?php echo esc_attr( $name ) . '-end'; ?>" type="text" class="<?php echo esc_html( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e( 'End date', 'gravityview' ); ?>" value="<?php echo esc_attr( $value[ 'end' ] ); ?>">
22 22
 	</p>
23 23
 </div>
24 24
\ No newline at end of file
Please login to merge, or discard this patch.
future/includes/class-gv-entry.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 
114 114
 		$args = array();
115 115
 
116
-		$view_id = is_null ( $view ) ? null : $view->ID;
116
+		$view_id = is_null( $view ) ? null : $view->ID;
117 117
 
118 118
 		$permalink = null;
119 119
 
@@ -126,8 +126,8 @@  discard block
 block discarded – undo
126 126
 
127 127
 				$view_collection = View_Collection::from_post( $post );
128 128
 
129
-				if( 1 < $view_collection->count() ) {
130
-					$args['gvid'] = $view_id;
129
+				if ( 1 < $view_collection->count() ) {
130
+					$args[ 'gvid' ] = $view_id;
131 131
 				}
132 132
 			}
133 133
 		}
@@ -156,21 +156,21 @@  discard block
 block discarded – undo
156 156
 			 */
157 157
 			$link_parts = explode( '?', $permalink );
158 158
 
159
-			$query = ! empty( $link_parts[1] ) ? '?' . $link_parts[1] : '';
159
+			$query = ! empty( $link_parts[ 1 ] ) ? '?' . $link_parts[ 1 ] : '';
160 160
 
161
-			$permalink = trailingslashit( $link_parts[0] ) . $entry_endpoint_name . '/'. $entry_slug .'/' . $query;
161
+			$permalink = trailingslashit( $link_parts[ 0 ] ) . $entry_endpoint_name . '/' . $entry_slug . '/' . $query;
162 162
 		} else {
163 163
 			$args[ $entry_endpoint_name ] = $entry_slug;
164 164
 		}
165 165
 
166 166
 		if ( $track_directory ) {
167
-			if ( ! empty( $_GET['pagenum'] ) ) {
168
-				$args['pagenum'] = intval( $_GET['pagenum'] );
167
+			if ( ! empty( $_GET[ 'pagenum' ] ) ) {
168
+				$args[ 'pagenum' ] = intval( $_GET[ 'pagenum' ] );
169 169
 			}
170 170
 
171 171
 			if ( $sort = Utils::_GET( 'sort' ) ) {
172
-				$args['sort'] = $sort;
173
-				$args['dir'] = Utils::_GET( 'dir' );
172
+				$args[ 'sort' ] = $sort;
173
+				$args[ 'dir' ] = Utils::_GET( 'dir' );
174 174
 			}
175 175
 		}
176 176
 
Please login to merge, or discard this patch.
future/includes/class-gv-shortcode-gravityview.php 2 patches
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,8 +79,9 @@
 block discarded – undo
79 79
 		 * Check permissions.
80 80
 		 */
81 81
 		while ( $error = $view->can_render( array( 'shortcode' ), $request ) ) {
82
-			if ( ! is_wp_error( $error ) )
83
-				break;
82
+			if ( ! is_wp_error( $error ) ) {
83
+							break;
84
+			}
84 85
 
85 86
 			switch ( str_replace( 'gravityview/', '', $error->get_error_code() ) ) {
86 87
 				case 'post_password_required':
Please login to merge, or discard this patch.
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
41 41
 			'detail' => null,
42 42
 		) );
43 43
 		
44
-		if ( ! $view_id = $atts['id'] ? : $atts['view_id'] ) {
45
-			if ( $atts['detail'] && $view = $request->is_view() ) {
44
+		if ( ! $view_id = $atts[ 'id' ] ?: $atts[ 'view_id' ] ) {
45
+			if ( $atts[ 'detail' ] && $view = $request->is_view() ) {
46 46
 				$view_id = $view->ID;
47 47
 			}
48 48
 		}
@@ -111,12 +111,12 @@  discard block
 block discarded – undo
111 111
 			}
112 112
 		}
113 113
 
114
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
114
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
115 115
 
116 116
 		/**
117 117
 		 * View details.
118 118
 		 */
119
-		if ( $atts['detail'] ) {
119
+		if ( $atts[ 'detail' ] ) {
120 120
 			$entries = $view->get_entries( $request );
121 121
 			return self::_return( $this->detail( $view, $entries, $atts ) );
122 122
 
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 				return self::_return( '' );
134 134
 			}
135 135
 
136
-			if ( $entry['status'] != 'active' ) {
136
+			if ( $entry[ 'status' ] != 'active' ) {
137 137
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
138 138
 				return self::_return( __( 'You are not allowed to view this content.', 'gravityview' ) );
139 139
 			}
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 			}
145 145
 
146 146
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
147
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
147
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
148 148
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
149 149
 					return self::_return( __( 'You are not allowed to view this content.', 'gravityview' ) );
150 150
 				}
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 			$entryset = $entry->is_multi() ? $entry->entries : array( $entry );
168 168
 
169 169
 			foreach ( $entryset as $e ) {
170
-				if ( $e['status'] != 'active' ) {
170
+				if ( $e[ 'status' ] != 'active' ) {
171 171
 					gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $e->ID ) );
172 172
 					return self::_return( __( 'You are not allowed to view this content.', 'gravityview' ) );
173 173
 				}
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 				}
179 179
 
180 180
 				if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
181
-					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
181
+					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
182 182
 						gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $e->ID ) );
183 183
 						return self::_return( __( 'You are not allowed to view this content.', 'gravityview' ) );
184 184
 					}
@@ -203,10 +203,10 @@  discard block
 block discarded – undo
203 203
 				
204 204
 				// Mock the request with the actual View, not the global one
205 205
 				$mock_request = new \GV\Mock_Request();
206
-				$mock_request->returns['is_view'] = $view;
207
-				$mock_request->returns['is_entry'] = $request->is_entry( $view->form ? $view->form->ID : 0 );
208
-				$mock_request->returns['is_edit_entry'] = $request->is_edit_entry( $view->form ? $view->form->ID : 0 );
209
-				$mock_request->returns['is_search'] = $request->is_search();
206
+				$mock_request->returns[ 'is_view' ] = $view;
207
+				$mock_request->returns[ 'is_entry' ] = $request->is_entry( $view->form ? $view->form->ID : 0 );
208
+				$mock_request->returns[ 'is_edit_entry' ] = $request->is_edit_entry( $view->form ? $view->form->ID : 0 );
209
+				$mock_request->returns[ 'is_search' ] = $request->is_search();
210 210
 
211 211
 				$request = $mock_request;
212 212
 			}
@@ -242,16 +242,16 @@  discard block
 block discarded – undo
242 242
 		$filtered_atts = shortcode_atts( $supported_atts, $passed_atts, 'gravityview' );
243 243
 
244 244
 		// Only keep the passed attributes after making sure that they're valid pairs
245
-		$filtered_atts = array_intersect_key( (array) $passed_atts, $filtered_atts );
245
+		$filtered_atts = array_intersect_key( (array)$passed_atts, $filtered_atts );
246 246
 
247 247
 		$atts = array();
248 248
 
249
-		foreach( $filtered_atts as $key => $passed_value ) {
249
+		foreach ( $filtered_atts as $key => $passed_value ) {
250 250
 
251 251
 			// Allow using GravityView merge tags in shortcode attributes, like {get} and {created_by}
252 252
 			$passed_value = \GravityView_Merge_Tags::replace_variables( $passed_value );
253 253
 
254
-			switch( $defaults[ $key ]['type'] ) {
254
+			switch ( $defaults[ $key ][ 'type' ] ) {
255 255
 
256 256
 				/**
257 257
 				 * Make sure number fields are numeric.
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 				 * @see http://php.net/manual/en/function.is-numeric.php#107326
260 260
 				 */
261 261
 				case 'number':
262
-					if( is_numeric( $passed_value ) ) {
262
+					if ( is_numeric( $passed_value ) ) {
263 263
 						$atts[ $key ] = ( $passed_value + 0 );
264 264
 					}
265 265
 					break;
@@ -274,8 +274,8 @@  discard block
 block discarded – undo
274 274
 				 */
275 275
 				case 'select':
276 276
 				case 'radio':
277
-					$options = isset( $defaults[ $key ]['choices'] ) ? $defaults[ $key ]['choices'] : $defaults[ $key ]['options'];
278
-					if( in_array( $passed_value, array_keys( $options ) ) ) {
277
+					$options = isset( $defaults[ $key ][ 'choices' ] ) ? $defaults[ $key ][ 'choices' ] : $defaults[ $key ][ 'options' ];
278
+					if ( in_array( $passed_value, array_keys( $options ) ) ) {
279 279
 						$atts[ $key ] = $passed_value;
280 280
 					}
281 281
 					break;
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
 			}
288 288
 		}
289 289
 
290
-		$atts['detail'] = \GV\Utils::get( $passed_atts, 'detail', null );
290
+		$atts[ 'detail' ] = \GV\Utils::get( $passed_atts, 'detail', null );
291 291
 
292 292
 		return $atts;
293 293
 	}
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
 	private function detail( $view, $entries, $atts ) {
305 305
 		$output = '';
306 306
 
307
-		switch ( $key = $atts['detail'] ):
307
+		switch ( $key = $atts[ 'detail' ] ):
308 308
 			case 'total_entries':
309 309
 				$output = number_format_i18n( $entries->total() );
310 310
 				break;
Please login to merge, or discard this patch.
includes/class-admin-installer.php 4 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
 	 *
50 50
 	 * @param array $items Scripts or styles to exclude from no-conflict
51 51
 	 *
52
-	 * @return array
52
+	 * @return string[]
53 53
 	 */
54 54
 	public function register_noconflict( $items ) {
55 55
 
Please login to merge, or discard this patch.
Indentation   +94 added lines, -94 removed lines patch added patch discarded remove patch
@@ -66,9 +66,9 @@  discard block
 block discarded – undo
66 66
 	 */
67 67
 	public function add_downloads_data_filters() {
68 68
 
69
-	    $downloads_data = get_site_transient( self::DOWNLOADS_DATA_TRANSIENT );
69
+		$downloads_data = get_site_transient( self::DOWNLOADS_DATA_TRANSIENT );
70 70
 
71
-	    if ( ! $downloads_data ) {
71
+		if ( ! $downloads_data ) {
72 72
 			return;
73 73
 		}
74 74
 
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 	 */
98 98
 	public function add_admin_menu() {
99 99
 
100
-	    $menu_text = _x( 'Extensions', 'Extensions are WordPress plugins that add functionality to GravityView and Gravity Forms', 'gravityview' );
100
+		$menu_text = _x( 'Extensions', 'Extensions are WordPress plugins that add functionality to GravityView and Gravity Forms', 'gravityview' );
101 101
 
102 102
 		$menu_text = sprintf( '<span title="%s">%s</span>', esc_attr__( 'Plugins that extend GravityView and Gravity Forms functionality.', 'gravityview' ), $menu_text );
103 103
 
@@ -112,8 +112,8 @@  discard block
 block discarded – undo
112 112
 	}
113 113
 
114 114
 	/**
115
-     * When on the Installer page, show a different notice than on the Settings page
116
-     *
115
+	 * When on the Installer page, show a different notice than on the Settings page
116
+	 *
117 117
 	 * @param array $notice
118 118
 	 *
119 119
 	 * @return string License notice
@@ -121,10 +121,10 @@  discard block
 block discarded – undo
121 121
 	public function maybe_modify_license_notice( $notice = '' ) {
122 122
 
123 123
 		if ( ! gravityview()->request->is_admin( '', 'downloads' ) ) {
124
-            return $notice;
125
-        }
124
+			return $notice;
125
+		}
126 126
 
127
-        return esc_html__( 'Your license %s. Do you want access to these plugins? %sActivate your license%s or %sget a license here%s.', 'gravityview' );
127
+		return esc_html__( 'Your license %s. Do you want access to these plugins? %sActivate your license%s or %sget a license here%s.', 'gravityview' );
128 128
 	}
129 129
 
130 130
 	/**
@@ -162,43 +162,43 @@  discard block
 block discarded – undo
162 162
 	 * Get downloads data from transient or from API; save transient after getting data from API
163 163
 	 *
164 164
 	 * @return WP_Error|array If error, returns WP_Error. If not valid JSON, empty array. Otherwise, this structure: {
165
-     *   @type array  $info {
166
-     *       @type string $id int 17
167
-     *       @type string $slug Extension slug
168
-     *       @type string $title Extension title
169
-     *       @type string $create_date in '2018-07-19 20:03:10' format
170
-     *       @type string $modified_date
171
-     *       @type string $status
172
-     *       @type string $link URL to public plugin page
173
-     *       @type string $content
174
-     *       @type string $excerpt
175
-     *       @type string $thumbnail URL to thumbnail
176
-     *       @type array  $category Taxonomy details for the plugin's category {
177
-     *         @type int $term_id => int 30
178
-     *         @type string $name => string 'Plugins' (length=7)
179
-     *         @type string $slug => string 'plugins' (length=7)
180
-     *         @type int $term_group => int 0
181
-     *         @type int $term_taxonomy_id => int 30
182
-     *         @type string $taxonomy => string 'download_category' (length=17)
183
-     *         @type string $description => string '' (length=0)
184
-     *         @type int $parent => int 0
185
-     *         @type int $count => int 4
186
-     *         @type string $filter => string 'raw' (length=3)
187
-     *       }
188
-     *       @type array $tags {see $category above}
189
-     *       @type string $textdomain string 'gravityview' (length=11)
190
-     *   }
191
-     *   @type array $pricing array of `price_name_slugs` => '00.00' values, if price options exist
192
-     *   @type array $licensing {
193
-     *       @type bool   $enabled Is licensing enabled for the extension
194
-     *       @type string $version Version number
195
-     *       @type string $exp_unit Expiration unit ('years')
196
-     *       @type string $exp_length Expiration length ('1')
197
-     *   }
198
-     *   @type array $files Array of files. Empty if user has no access to the file. {
199
-     *       @type string $file string URL of the file download
200
-     *   }
201
-     * }
165
+	 *   @type array  $info {
166
+	 *       @type string $id int 17
167
+	 *       @type string $slug Extension slug
168
+	 *       @type string $title Extension title
169
+	 *       @type string $create_date in '2018-07-19 20:03:10' format
170
+	 *       @type string $modified_date
171
+	 *       @type string $status
172
+	 *       @type string $link URL to public plugin page
173
+	 *       @type string $content
174
+	 *       @type string $excerpt
175
+	 *       @type string $thumbnail URL to thumbnail
176
+	 *       @type array  $category Taxonomy details for the plugin's category {
177
+	 *         @type int $term_id => int 30
178
+	 *         @type string $name => string 'Plugins' (length=7)
179
+	 *         @type string $slug => string 'plugins' (length=7)
180
+	 *         @type int $term_group => int 0
181
+	 *         @type int $term_taxonomy_id => int 30
182
+	 *         @type string $taxonomy => string 'download_category' (length=17)
183
+	 *         @type string $description => string '' (length=0)
184
+	 *         @type int $parent => int 0
185
+	 *         @type int $count => int 4
186
+	 *         @type string $filter => string 'raw' (length=3)
187
+	 *       }
188
+	 *       @type array $tags {see $category above}
189
+	 *       @type string $textdomain string 'gravityview' (length=11)
190
+	 *   }
191
+	 *   @type array $pricing array of `price_name_slugs` => '00.00' values, if price options exist
192
+	 *   @type array $licensing {
193
+	 *       @type bool   $enabled Is licensing enabled for the extension
194
+	 *       @type string $version Version number
195
+	 *       @type string $exp_unit Expiration unit ('years')
196
+	 *       @type string $exp_length Expiration length ('1')
197
+	 *   }
198
+	 *   @type array $files Array of files. Empty if user has no access to the file. {
199
+	 *       @type string $file string URL of the file download
200
+	 *   }
201
+	 * }
202 202
 	 */
203 203
 	public function get_downloads_data() {
204 204
 
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 		) );
227 227
 
228 228
 		if ( is_wp_error( $response ) ) {
229
-		    gravityview()->log->error( "Extension data response is an error", array( 'data' => $response ) );
229
+			gravityview()->log->error( "Extension data response is an error", array( 'data' => $response ) );
230 230
 			return $response;
231 231
 		}
232 232
 
@@ -279,10 +279,10 @@  discard block
 block discarded – undo
279 279
                 <div class="gv-admin-installer-notice notice inline error">
280 280
                     <h3><?php esc_html_e( 'Extensions and plugins data cannot be loaded at the moment. Please try again later.', 'gravityview' ); ?></h3>
281 281
                     <?php
282
-                    if ( is_wp_error( $downloads_data ) ) {
283
-	                    echo wpautop( '<pre>' . esc_html( $downloads_data->get_error_message() ) . '</pre>' );
284
-                    }
285
-                    ?>
282
+					if ( is_wp_error( $downloads_data ) ) {
283
+						echo wpautop( '<pre>' . esc_html( $downloads_data->get_error_message() ) . '</pre>' );
284
+					}
285
+					?>
286 286
                 </div>
287 287
             </div>
288 288
 			<?php
@@ -338,9 +338,9 @@  discard block
 block discarded – undo
338 338
 	protected function render_download( $download, $wp_plugins ) {
339 339
 
340 340
 
341
-        $details = $this->get_download_display_details( $download, $wp_plugins );
341
+		$details = $this->get_download_display_details( $download, $wp_plugins );
342 342
 
343
-        $download_info = $details['download_info'];
343
+		$download_info = $details['download_info'];
344 344
 
345 345
 		?>
346 346
         <div class="item <?php echo esc_attr( $details['item_class'] ); ?>">
@@ -362,43 +362,43 @@  discard block
 block discarded – undo
362 362
 
363 363
                 <div class="addon-excerpt"><?php
364 364
 
365
-                    $excerpt = \GV\Utils::get( $download_info, 'installer_excerpt', $download_info['excerpt'] );
365
+					$excerpt = \GV\Utils::get( $download_info, 'installer_excerpt', $download_info['excerpt'] );
366 366
 
367
-                    // Allow some pure HTML tags, but remove everything else from the excerpt.
368
-                    $tags = array( '<strong>', '</strong>', '<em>', '</em>', '<code>', '</code>' );
369
-                    $replacements = array( '[b]', '[/b]', '[i]', '[/i]', '[code]', '[/code]' );
367
+					// Allow some pure HTML tags, but remove everything else from the excerpt.
368
+					$tags = array( '<strong>', '</strong>', '<em>', '</em>', '<code>', '</code>' );
369
+					$replacements = array( '[b]', '[/b]', '[i]', '[/i]', '[code]', '[/code]' );
370 370
 
371
-                    $excerpt = str_replace( $tags, $replacements, $excerpt );
372
-                    $excerpt = esc_html( strip_tags( $excerpt ) );
371
+					$excerpt = str_replace( $tags, $replacements, $excerpt );
372
+					$excerpt = esc_html( strip_tags( $excerpt ) );
373 373
 					$excerpt = str_replace( $replacements, $tags, $excerpt );
374 374
 
375 375
 					echo wpautop( $excerpt );
376
-                ?></div>
376
+				?></div>
377 377
             </div>
378 378
         </div>
379 379
 		<?php
380 380
 	}
381 381
 
382 382
 	/**
383
-     * Generates details array for the download to keep the render_download() method a bit tidier
384
-     *
383
+	 * Generates details array for the download to keep the render_download() method a bit tidier
384
+	 *
385 385
 	 * @param array $download Single download, as returned by {@see get_downloads_data}
386 386
 	 * @param array $wp_plugins All active plugins, as returned by {@see get_plugins()}
387 387
 	 *
388 388
 	 * @return array {
389
-     *   @type array $download_info
390
-     *   @type string $plugin_path
391
-     *   @type string $status License status returned by Easy Digital Downloads ("active", "inactive", "expired", "revoked", etc)
392
-     *   @type string $status_label
393
-     *   @type string $button_title Title attribute to show when hovering over the download's button
394
-     *   @type string $button_class CSS class to use for the button
395
-     *   @type string $button_label Text to use for the download's anchor link
396
-     *   @type string $href URL for the download's button
397
-     *   @type bool   $spinner Whether to show the spinner icon
398
-     *   @type string $item_class CSS class for the download container
399
-     *   @type string $required_license The name of the required license for the download ("All Access" or "Core + Extensions")
400
-     *   @type bool   $is_active Is the current GravityView license (as entered in Settings) active?
401
-     * }
389
+	 *   @type array $download_info
390
+	 *   @type string $plugin_path
391
+	 *   @type string $status License status returned by Easy Digital Downloads ("active", "inactive", "expired", "revoked", etc)
392
+	 *   @type string $status_label
393
+	 *   @type string $button_title Title attribute to show when hovering over the download's button
394
+	 *   @type string $button_class CSS class to use for the button
395
+	 *   @type string $button_label Text to use for the download's anchor link
396
+	 *   @type string $href URL for the download's button
397
+	 *   @type bool   $spinner Whether to show the spinner icon
398
+	 *   @type string $item_class CSS class for the download container
399
+	 *   @type string $required_license The name of the required license for the download ("All Access" or "Core + Extensions")
400
+	 *   @type bool   $is_active Is the current GravityView license (as entered in Settings) active?
401
+	 * }
402 402
 	 */
403 403
 	private function get_download_display_details( $download, $wp_plugins ) {
404 404
 
@@ -409,7 +409,7 @@  discard block
 block discarded – undo
409 409
 			'slug' => '',
410 410
 			'excerpt' => '',
411 411
 			'link' => '',
412
-            'coming_soon' => false,
412
+			'coming_soon' => false,
413 413
 			'installer_title' => null, // May not be defined
414 414
 			'installer_excerpt' => null, // May not be defined
415 415
 		) );
@@ -451,14 +451,14 @@  discard block
 block discarded – undo
451 451
 			$href         = 'https://gravityview.co/pricing/?utm_source=admin-installer&utm_medium=admin&utm_campaign=Admin%20Notice&utm_content=' . $required_license;
452 452
 		}
453 453
 
454
-        elseif ( ! empty( $download_info['coming_soon'] ) ) {
455
-	        $spinner      = false;
456
-	        $status       = 'notinstalled';
457
-	        $status_label = __( 'Coming Soon', 'gravityview' );
458
-	        $button_label = __( 'Learn More', 'gravityview' );
459
-	        $button_class = 'button-primary button-large';
460
-	        $href         = \GV\Utils::get( $download_info, 'link', 'https://gravityview.co/extensions/' );
461
-        }
454
+		elseif ( ! empty( $download_info['coming_soon'] ) ) {
455
+			$spinner      = false;
456
+			$status       = 'notinstalled';
457
+			$status_label = __( 'Coming Soon', 'gravityview' );
458
+			$button_label = __( 'Learn More', 'gravityview' );
459
+			$button_class = 'button-primary button-large';
460
+			$href         = \GV\Utils::get( $download_info, 'link', 'https://gravityview.co/extensions/' );
461
+		}
462 462
 
463 463
 		// Access but the plugin is not installed
464 464
 		elseif ( ! $wp_plugin ) {
@@ -498,18 +498,18 @@  discard block
 block discarded – undo
498 498
 		}
499 499
 
500 500
 		return compact( 'download_info','plugin_path', 'status', 'status_label', 'button_title', 'button_class', 'button_label', 'href', 'spinner', 'item_class', 'required_license', 'is_active' );
501
-    }
501
+	}
502 502
 
503 503
 	/**
504
-     * Returns the base price for an extension
505
-     *
504
+	 * Returns the base price for an extension
505
+	 *
506 506
 	 * @param array $download
507 507
 	 *
508 508
 	 * @return float Base price for an extension. If not for sale separately, returns 0
509 509
 	 */
510 510
 	private function get_download_base_price( $download ) {
511 511
 
512
-	    $base_price = \GV\Utils::get( $download, 'pricing/amount', 0 );
512
+		$base_price = \GV\Utils::get( $download, 'pricing/amount', 0 );
513 513
 		$base_price = \GFCommon::to_number( $base_price );
514 514
 
515 515
 		unset( $download['pricing']['amount'] );
@@ -520,7 +520,7 @@  discard block
 block discarded – undo
520 520
 		}
521 521
 
522 522
 		return floatval( $base_price );
523
-    }
523
+	}
524 524
 
525 525
 	/**
526 526
 	 * Handle AJAX request to activate extension
@@ -538,8 +538,8 @@  discard block
 block discarded – undo
538 538
 
539 539
 		if ( is_wp_error( $result ) || ! is_plugin_active( $data['path'] ) ) {
540 540
 			wp_send_json_error( array(
541
-                'error' => sprintf( __( 'Plugin activation failed: %s', 'gravityview' ), $result->get_error_message() )
542
-            ) );
541
+				'error' => sprintf( __( 'Plugin activation failed: %s', 'gravityview' ), $result->get_error_message() )
542
+			) );
543 543
 		}
544 544
 
545 545
 		wp_send_json_success();
@@ -560,10 +560,10 @@  discard block
 block discarded – undo
560 560
 		deactivate_plugins( $data['path'] );
561 561
 
562 562
 		if( is_plugin_active( $data['path'] ) ) {
563
-            wp_send_json_error( array(
564
-                'error' => sprintf( __( 'Plugin deactivation failed.', 'gravityview' ) )
565
-            ) );
566
-        }
563
+			wp_send_json_error( array(
564
+				'error' => sprintf( __( 'Plugin deactivation failed.', 'gravityview' ) )
565
+			) );
566
+		}
567 567
 
568 568
 		wp_send_json_success();
569 569
 	}
Please login to merge, or discard this patch.
Braces   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -449,9 +449,7 @@
 block discarded – undo
449 449
 			$button_label = sprintf( __( 'Upgrade to %s for Access', 'gravityview' ), $required_license );
450 450
 			$button_class = 'button-primary button-large';
451 451
 			$href         = 'https://gravityview.co/pricing/?utm_source=admin-installer&utm_medium=admin&utm_campaign=Admin%20Notice&utm_content=' . $required_license;
452
-		}
453
-
454
-        elseif ( ! empty( $download_info['coming_soon'] ) ) {
452
+		} elseif ( ! empty( $download_info['coming_soon'] ) ) {
455 453
 	        $spinner      = false;
456 454
 	        $status       = 'notinstalled';
457 455
 	        $status_label = __( 'Coming Soon', 'gravityview' );
Please login to merge, or discard this patch.
Spacing   +48 added lines, -48 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 	 */
54 54
 	public function register_noconflict( $items ) {
55 55
 
56
-		$items[] = 'gravityview-admin-installer';
56
+		$items[ ] = 'gravityview-admin-installer';
57 57
 
58 58
 		return $items;
59 59
 	}
@@ -72,17 +72,17 @@  discard block
 block discarded – undo
72 72
 			return;
73 73
 		}
74 74
 
75
-		add_filter( 'plugins_api', function ( $data, $action, $args ) use ( $downloads_data ) {
75
+		add_filter( 'plugins_api', function( $data, $action, $args ) use ( $downloads_data ) {
76 76
 			foreach ( $downloads_data as $extension ) {
77
-				if ( empty( $extension['info'] ) || empty( $args->slug ) || $args->slug !== $extension['info']['slug'] ) {
77
+				if ( empty( $extension[ 'info' ] ) || empty( $args->slug ) || $args->slug !== $extension[ 'info' ][ 'slug' ] ) {
78 78
 					continue;
79 79
 				}
80 80
 
81
-				return (object) array(
82
-					'slug'          => $extension['info']['slug'],
83
-					'name'          => $extension['info']['title'],
84
-					'version'       => $extension['licensing']['version'],
85
-					'download_link' => $extension['files'][0]['file'],
81
+				return (object)array(
82
+					'slug'          => $extension[ 'info' ][ 'slug' ],
83
+					'name'          => $extension[ 'info' ][ 'title' ],
84
+					'version'       => $extension[ 'licensing' ][ 'version' ],
85
+					'download_link' => $extension[ 'files' ][ 0 ][ 'file' ],
86 86
 				);
87 87
 			}
88 88
 
@@ -144,13 +144,13 @@  discard block
 block discarded – undo
144 144
 
145 145
 		foreach ( $all_plugins as $path => $plugin ) {
146 146
 
147
-			if ( empty( $plugin['TextDomain'] ) ) {
147
+			if ( empty( $plugin[ 'TextDomain' ] ) ) {
148 148
 				continue;
149 149
 			}
150 150
 
151
-			$wp_plugins[ $plugin['TextDomain'] ] = array(
151
+			$wp_plugins[ $plugin[ 'TextDomain' ] ] = array(
152 152
 				'path'      => $path,
153
-				'version'   => $plugin['Version'],
153
+				'version'   => $plugin[ 'Version' ],
154 154
 				'activated' => is_plugin_active( $path )
155 155
 			);
156 156
 		}
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
 			return $downloads_data;
209 209
 		}
210 210
 
211
-		if( \GV\Plugin::is_network_activated() ) {
211
+		if ( \GV\Plugin::is_network_activated() ) {
212 212
 			$home_url = network_home_url();
213 213
 		} else {
214 214
 			$home_url = home_url();
@@ -236,13 +236,13 @@  discard block
 block discarded – undo
236 236
 
237 237
 		$downloads_data = json_decode( wp_remote_retrieve_body( $response ), true );
238 238
 
239
-		if ( empty( $downloads_data['products'] ) ) {
239
+		if ( empty( $downloads_data[ 'products' ] ) ) {
240 240
 			return array();
241 241
 		}
242 242
 
243
-		$this->set_downloads_data( $downloads_data['products'] );
243
+		$this->set_downloads_data( $downloads_data[ 'products' ] );
244 244
 
245
-		return $downloads_data['products'];
245
+		return $downloads_data[ 'products' ];
246 246
 	}
247 247
 
248 248
 	/**
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
 
316 316
 				foreach ( $downloads_data as $extension ) {
317 317
 
318
-					if ( empty( $extension['info'] ) ) {
318
+					if ( empty( $extension[ 'info' ] ) ) {
319 319
 						continue;
320 320
 					}
321 321
 
@@ -344,29 +344,29 @@  discard block
 block discarded – undo
344 344
 
345 345
         $details = $this->get_download_display_details( $download, $wp_plugins );
346 346
 
347
-        $download_info = $details['download_info'];
347
+        $download_info = $details[ 'download_info' ];
348 348
 
349 349
 		?>
350
-        <div class="item <?php echo esc_attr( $details['item_class'] ); ?>">
350
+        <div class="item <?php echo esc_attr( $details[ 'item_class' ] ); ?>">
351 351
             <div class="addon-inner">
352
-                <a href="<?php echo esc_url( $download_info['link'] ); ?>" rel="external noreferrer noopener" title="<?php esc_html_e( 'Visit the plugin page', 'gravityview' ); ?>"><img class="thumbnail" src="<?php echo esc_attr( $download_info['thumbnail'] ); ?>" alt="" /></a>
353
-                <h3><?php echo esc_html( \GV\Utils::get( $download_info, 'installer_title', $download_info['title'] ) ); ?></h3>
352
+                <a href="<?php echo esc_url( $download_info[ 'link' ] ); ?>" rel="external noreferrer noopener" title="<?php esc_html_e( 'Visit the plugin page', 'gravityview' ); ?>"><img class="thumbnail" src="<?php echo esc_attr( $download_info[ 'thumbnail' ] ); ?>" alt="" /></a>
353
+                <h3><?php echo esc_html( \GV\Utils::get( $download_info, 'installer_title', $download_info[ 'title' ] ) ); ?></h3>
354 354
                 <div>
355
-                    <?php if( ! empty( $details['status_label'] ) ) { ?>
356
-                    <div class="status <?php echo esc_attr( $details['status'] ); ?>" title="<?php printf( esc_attr__( 'Plugin status: %s', 'gravityview' ), esc_html( $details['status_label'] ) ); ?>">
357
-                        <span class="dashicons dashicons-admin-plugins"></span> <span class="status-label"><?php echo esc_html( $details['status_label'] ); ?></span>
355
+                    <?php if ( ! empty( $details[ 'status_label' ] ) ) { ?>
356
+                    <div class="status <?php echo esc_attr( $details[ 'status' ] ); ?>" title="<?php printf( esc_attr__( 'Plugin status: %s', 'gravityview' ), esc_html( $details[ 'status_label' ] ) ); ?>">
357
+                        <span class="dashicons dashicons-admin-plugins"></span> <span class="status-label"><?php echo esc_html( $details[ 'status_label' ] ); ?></span>
358 358
                     </div>
359 359
 			        <?php } ?>
360 360
 
361
-                    <a data-status="<?php echo esc_attr( $details['status'] ); ?>" data-plugin-path="<?php echo esc_attr( $details['plugin_path'] ); ?>" href="<?php echo esc_url( $details['href'] ); ?>" class="button <?php echo esc_attr( $details['button_class'] ); ?>" title="<?php echo esc_attr( $details['button_title'] ); ?>">
362
-                        <span class="title"><?php echo esc_html( $details['button_label'] ); ?></span>
363
-                        <?php if( $details['spinner'] ) { ?><span class="spinner"></span><?php } ?>
361
+                    <a data-status="<?php echo esc_attr( $details[ 'status' ] ); ?>" data-plugin-path="<?php echo esc_attr( $details[ 'plugin_path' ] ); ?>" href="<?php echo esc_url( $details[ 'href' ] ); ?>" class="button <?php echo esc_attr( $details[ 'button_class' ] ); ?>" title="<?php echo esc_attr( $details[ 'button_title' ] ); ?>">
362
+                        <span class="title"><?php echo esc_html( $details[ 'button_label' ] ); ?></span>
363
+                        <?php if ( $details[ 'spinner' ] ) { ?><span class="spinner"></span><?php } ?>
364 364
                     </a>
365 365
                 </div>
366 366
 
367 367
                 <div class="addon-excerpt"><?php
368 368
 
369
-                    $excerpt = \GV\Utils::get( $download_info, 'installer_excerpt', $download_info['excerpt'] );
369
+                    $excerpt = \GV\Utils::get( $download_info, 'installer_excerpt', $download_info[ 'excerpt' ] );
370 370
 
371 371
                     // Allow some pure HTML tags, but remove everything else from the excerpt.
372 372
                     $tags = array( '<strong>', '</strong>', '<em>', '</em>', '<code>', '</code>' );
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
 	 */
407 407
 	private function get_download_display_details( $download, $wp_plugins ) {
408 408
 
409
-		$download_info = wp_parse_args( (array) $download['info'], array(
409
+		$download_info = wp_parse_args( (array)$download[ 'info' ], array(
410 410
 			'thumbnail' => '',
411 411
 			'title' => '',
412 412
 			'textdomain' => '',
@@ -418,9 +418,9 @@  discard block
 block discarded – undo
418 418
 			'installer_excerpt' => null, // May not be defined
419 419
 		) );
420 420
 
421
-		$wp_plugin = \GV\Utils::get( $wp_plugins, $download_info['textdomain'], false );
421
+		$wp_plugin = \GV\Utils::get( $wp_plugins, $download_info[ 'textdomain' ], false );
422 422
 
423
-		$has_access = ! empty( $download['files'] );
423
+		$has_access = ! empty( $download[ 'files' ] );
424 424
 		$spinner = true;
425 425
 		$href = $plugin_path = '#';
426 426
 		$status = $item_class = $button_title = $button_class = '';
@@ -430,7 +430,7 @@  discard block
 block discarded – undo
430 430
 		$required_license = $galactic_only ? __( 'All Access', 'gravityview' ) : __( 'Core + Extensions', 'gravityview' );
431 431
 
432 432
 		// The license is not active - no matter what level, this should not work
433
-		if( ! $is_active  && empty( $base_price ) ) {
433
+		if ( ! $is_active && empty( $base_price ) ) {
434 434
 			$spinner      = false;
435 435
 			$status_label = '';
436 436
 			$button_class = 'disabled disabled-license';
@@ -443,7 +443,7 @@  discard block
 block discarded – undo
443 443
 			$status_label = '';
444 444
 			$button_label = sprintf( __( 'Purchase Now for %s', 'gravityview' ), '$' . $base_price );
445 445
 			$button_class = 'button-primary button-large';
446
-			$href         = $download_info['link'];
446
+			$href         = $download_info[ 'link' ];
447 447
 			$item_class   = 'featured';
448 448
 		}
449 449
 
@@ -456,7 +456,7 @@  discard block
 block discarded – undo
456 456
 			$href         = 'https://gravityview.co/pricing/?utm_source=admin-installer&utm_medium=admin&utm_campaign=Admin%20Notice&utm_content=' . $required_license;
457 457
 		}
458 458
 
459
-        elseif ( ! empty( $download_info['coming_soon'] ) ) {
459
+        elseif ( ! empty( $download_info[ 'coming_soon' ] ) ) {
460 460
 	        $spinner      = false;
461 461
 	        $status       = 'notinstalled';
462 462
 	        $status_label = __( 'Coming Soon', 'gravityview' );
@@ -471,8 +471,8 @@  discard block
 block discarded – undo
471 471
 			$href = add_query_arg(
472 472
 				array(
473 473
 					'action'   => 'install-plugin',
474
-					'plugin'   => $download_info['slug'],
475
-					'_wpnonce' => wp_create_nonce( 'install-plugin_' . $download_info['slug'] ),
474
+					'plugin'   => $download_info[ 'slug' ],
475
+					'_wpnonce' => wp_create_nonce( 'install-plugin_' . $download_info[ 'slug' ] ),
476 476
 				),
477 477
 				self_admin_url( 'update.php' )
478 478
 			);
@@ -484,25 +484,25 @@  discard block
 block discarded – undo
484 484
 		}
485 485
 
486 486
 		// Access and the plugin is installed but not active
487
-		elseif ( false === $wp_plugin['activated'] ) {
487
+		elseif ( false === $wp_plugin[ 'activated' ] ) {
488 488
 			$status = 'inactive';
489 489
 			$status_label = __( 'Inactive', 'gravityview' );
490 490
 			$button_label = __( 'Activate', 'gravityview' );
491
-			$plugin_path = $wp_plugin['path'];
491
+			$plugin_path = $wp_plugin[ 'path' ];
492 492
 
493 493
 		}
494 494
 
495 495
 		// Access and the plugin is installed and active
496 496
 		else {
497 497
 
498
-			$plugin_path = $wp_plugin['path'];
498
+			$plugin_path = $wp_plugin[ 'path' ];
499 499
 			$status = 'active';
500 500
 			$status_label = __( 'Active', 'gravityview' );
501 501
 			$button_label = __( 'Deactivate', 'gravityview' );
502 502
 
503 503
 		}
504 504
 
505
-		return compact( 'download_info','plugin_path', 'status', 'status_label', 'button_title', 'button_class', 'button_label', 'href', 'spinner', 'item_class', 'required_license', 'is_active' );
505
+		return compact( 'download_info', 'plugin_path', 'status', 'status_label', 'button_title', 'button_class', 'button_label', 'href', 'spinner', 'item_class', 'required_license', 'is_active' );
506 506
     }
507 507
 
508 508
 	/**
@@ -517,11 +517,11 @@  discard block
 block discarded – undo
517 517
 	    $base_price = \GV\Utils::get( $download, 'pricing/amount', 0 );
518 518
 		$base_price = \GFCommon::to_number( $base_price );
519 519
 
520
-		unset( $download['pricing']['amount'] );
520
+		unset( $download[ 'pricing' ][ 'amount' ] );
521 521
 
522 522
 		// Price options array, not single price
523
-		if ( ! $base_price && ! empty( $download['pricing'] ) ) {
524
-			$base_price = array_shift( $download['pricing'] );
523
+		if ( ! $base_price && ! empty( $download[ 'pricing' ] ) ) {
524
+			$base_price = array_shift( $download[ 'pricing' ] );
525 525
 		}
526 526
 
527 527
 		return floatval( $base_price );
@@ -535,13 +535,13 @@  discard block
 block discarded – undo
535 535
 	public function activate_download() {
536 536
 		$data = \GV\Utils::_POST( 'data', array() );
537 537
 
538
-		if ( empty( $data['path'] ) ) {
538
+		if ( empty( $data[ 'path' ] ) ) {
539 539
 			return;
540 540
 		}
541 541
 
542
-		$result = activate_plugin( $data['path'] );
542
+		$result = activate_plugin( $data[ 'path' ] );
543 543
 
544
-		if ( is_wp_error( $result ) || ! is_plugin_active( $data['path'] ) ) {
544
+		if ( is_wp_error( $result ) || ! is_plugin_active( $data[ 'path' ] ) ) {
545 545
 			wp_send_json_error( array(
546 546
                 'error' => sprintf( __( 'Plugin activation failed: %s', 'gravityview' ), $result->get_error_message() )
547 547
             ) );
@@ -558,13 +558,13 @@  discard block
 block discarded – undo
558 558
 	public function deactivate_download() {
559 559
 		$data = \GV\Utils::_POST( 'data', array() );
560 560
 
561
-		if ( empty( $data['path'] ) ) {
561
+		if ( empty( $data[ 'path' ] ) ) {
562 562
 			return;
563 563
 		}
564 564
 
565
-		deactivate_plugins( $data['path'] );
565
+		deactivate_plugins( $data[ 'path' ] );
566 566
 
567
-		if( is_plugin_active( $data['path'] ) ) {
567
+		if ( is_plugin_active( $data[ 'path' ] ) ) {
568 568
             wp_send_json_error( array(
569 569
                 'error' => sprintf( __( 'Plugin deactivation failed.', 'gravityview' ) )
570 570
             ) );
Please login to merge, or discard this patch.
future/includes/rest/class-gv-rest-route.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 
133 133
 		$format = '(?:\.(?P<format>html|json))?';
134 134
 
135
-		register_rest_route( $namespace, sprintf( '/%s/(?P<id>[\d]+)/%s/(?P<s_id>[\w-]+)%s', $base, $sub_type, $format ) , array(
135
+		register_rest_route( $namespace, sprintf( '/%s/(?P<id>[\d]+)/%s/(?P<s_id>[\w-]+)%s', $base, $sub_type, $format ), array(
136 136
 			array(
137 137
 				'methods'         => \WP_REST_Server::READABLE,
138 138
 				'callback'        => array( $this, 'get_sub_item' ),
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
 	 * @return \WP_REST_Response
384 384
 	 */
385 385
 	protected function not_implemented(  ) {
386
-		$error = new \WP_Error( 'not-implemented-yet', __( 'Endpoint Not Yet Implemented.', 'gravityview' )  );
386
+		$error = new \WP_Error( 'not-implemented-yet', __( 'Endpoint Not Yet Implemented.', 'gravityview' ) );
387 387
 		return new \WP_REST_Response( $error, 501 );
388 388
 	}
389 389
 
Please login to merge, or discard this patch.
includes/extensions/edit-entry/class-edit-entry-render.php 4 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -282,7 +282,7 @@
 block discarded – undo
282 282
 	/**
283 283
 	 * Process edit entry form save
284 284
 	 *
285
-	 * @param array $gv_data The View data.
285
+	 * @param GravityView_View_Data $gv_data The View data.
286 286
 	 */
287 287
 	private function process_save( $gv_data ) {
288 288
 
Please login to merge, or discard this patch.
Braces   +4 added lines, -5 removed lines patch added patch discarded remove patch
@@ -573,7 +573,8 @@  discard block
 block discarded – undo
573 573
 
574 574
 							// Only allow quantity to be set if it's allowed to be edited
575 575
 							if ( in_array( $field_id, $allowed_fields ) && $input_id == 3 ) {
576
-							} else { // otherwise set to what it previously was
576
+							} else {
577
+// otherwise set to what it previously was
577 578
 								$_POST[ $input_name ] = $entry[ $input['id'] ];
578 579
 							}
579 580
 						} else {
@@ -958,7 +959,7 @@  discard block
 block discarded – undo
958 959
 
959 960
 			$back_link = remove_query_arg( array( 'page', 'view', 'edit' ) );
960 961
 
961
-			if( ! $this->is_valid ){
962
+			if( ! $this->is_valid ) {
962 963
 
963 964
 				// Keeping this compatible with Gravity Forms.
964 965
 				$validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
@@ -2070,9 +2071,7 @@  discard block
 block discarded – undo
2070 2071
 		// Verify
2071 2072
 		else if( ! $this->is_edit_entry() ) {
2072 2073
 			$valid = false;
2073
-		}
2074
-
2075
-		else {
2074
+		} else {
2076 2075
 			$valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
2077 2076
 		}
2078 2077
 
Please login to merge, or discard this patch.
Spacing   +230 added lines, -230 removed lines patch added patch discarded remove patch
@@ -123,16 +123,16 @@  discard block
 block discarded – undo
123 123
 	function load() {
124 124
 
125 125
 		/** @define "GRAVITYVIEW_DIR" "../../../" */
126
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
126
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-approve-entries.php' );
127 127
 
128 128
 		// Don't display an embedded form when editing an entry
129 129
 		add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
130 130
 		add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
131 131
 
132 132
 		// Stop Gravity Forms processing what is ours!
133
-		add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
133
+		add_filter( 'wp', array( $this, 'prevent_maybe_process_form' ), 8 );
134 134
 
135
-		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
135
+		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry' ) );
136 136
 
137 137
 		add_action( 'gravityview_edit_entry', array( $this, 'init' ), 10, 4 );
138 138
 
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 		add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
144 144
 
145 145
 		// Add fields expected by GFFormDisplay::validate()
146
-		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
146
+		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation' ) );
147 147
 
148 148
 		// Fix multiselect value for GF 2.2
149 149
 		add_filter( 'gravityview/edit_entry/field_value_multiselect', array( $this, 'fix_multiselect_value_serialization' ), 10, 3 );
@@ -160,8 +160,8 @@  discard block
 block discarded – undo
160 160
 	 * @return void
161 161
 	 */
162 162
 	public function prevent_render_form() {
163
-		if( $this->is_edit_entry() ) {
164
-			if( 'wp_head' === current_filter() ) {
163
+		if ( $this->is_edit_entry() ) {
164
+			if ( 'wp_head' === current_filter() ) {
165 165
 				add_filter( 'gform_shortcode_form', '__return_empty_string' );
166 166
 			} else {
167 167
 				remove_filter( 'gform_shortcode_form', '__return_empty_string' );
@@ -176,14 +176,14 @@  discard block
 block discarded – undo
176 176
 	 */
177 177
 	public function prevent_maybe_process_form() {
178 178
 
179
-	    if( ! $this->is_edit_entry_submission() ) {
179
+	    if ( ! $this->is_edit_entry_submission() ) {
180 180
 			return;
181 181
 		}
182 182
 
183 183
 		gravityview()->log->debug( 'GravityView_Edit_Entry[prevent_maybe_process_form] Removing GFForms::maybe_process_form() action.' );
184 184
 
185
-		remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
186
-		remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
185
+		remove_action( 'wp', array( 'RGForms', 'maybe_process_form' ), 9 );
186
+		remove_action( 'wp', array( 'GFForms', 'maybe_process_form' ), 9 );
187 187
 	}
188 188
 
189 189
 	/**
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 	 */
193 193
 	public function is_edit_entry() {
194 194
 
195
-		$is_edit_entry = GravityView_frontend::is_single_entry() && ! empty( $_GET['edit'] );
195
+		$is_edit_entry = GravityView_frontend::is_single_entry() && ! empty( $_GET[ 'edit' ] );
196 196
 
197 197
 		return ( $is_edit_entry || $this->is_edit_entry_submission() );
198 198
 	}
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 	 * @return boolean
204 204
 	 */
205 205
 	public function is_edit_entry_submission() {
206
-		return !empty( $_POST[ self::$nonce_field ] );
206
+		return ! empty( $_POST[ self::$nonce_field ] );
207 207
 	}
208 208
 
209 209
 	/**
@@ -216,16 +216,16 @@  discard block
 block discarded – undo
216 216
 
217 217
 
218 218
 		$entries = $gravityview_view->getEntries();
219
-	    self::$original_entry = $entries[0];
220
-	    $this->entry = $entries[0];
219
+	    self::$original_entry = $entries[ 0 ];
220
+	    $this->entry = $entries[ 0 ];
221 221
 
222 222
 		self::$original_form = $gravityview_view->getForm();
223 223
 		$this->form = $gravityview_view->getForm();
224
-		$this->form_id = $this->entry['form_id'];
224
+		$this->form_id = $this->entry[ 'form_id' ];
225 225
 		$this->view_id = $gravityview_view->getViewId();
226 226
 		$this->post_id = \GV\Utils::get( $post, 'ID', null );
227 227
 
228
-		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
228
+		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry[ 'id' ] );
229 229
 	}
230 230
 
231 231
 
@@ -284,9 +284,9 @@  discard block
 block discarded – undo
284 284
 	private function print_scripts() {
285 285
 		$gravityview_view = GravityView_View::getInstance();
286 286
 
287
-		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
287
+		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url() . '/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
288 288
 
289
-		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false);
289
+		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false );
290 290
 
291 291
 		wp_localize_script( 'gravityview-fe-view', 'gvGlobals', array( 'cookiepath' => COOKIEPATH ) );
292 292
 
@@ -302,19 +302,19 @@  discard block
 block discarded – undo
302 302
 	 */
303 303
 	private function process_save( $gv_data ) {
304 304
 
305
-		if ( empty( $_POST ) || ! isset( $_POST['lid'] ) ) {
305
+		if ( empty( $_POST ) || ! isset( $_POST[ 'lid' ] ) ) {
306 306
 			return;
307 307
 		}
308 308
 
309 309
 		// Make sure the entry, view, and form IDs are all correct
310 310
 		$valid = $this->verify_nonce();
311 311
 
312
-		if ( !$valid ) {
312
+		if ( ! $valid ) {
313 313
 			gravityview()->log->error( 'Nonce validation failed.' );
314 314
 			return;
315 315
 		}
316 316
 
317
-		if ( $this->entry['id'] !== $_POST['lid'] ) {
317
+		if ( $this->entry[ 'id' ] !== $_POST[ 'lid' ] ) {
318 318
 			gravityview()->log->error( 'Entry ID did not match posted entry ID.' );
319 319
 			return;
320 320
 		}
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 
326 326
 		$this->validate();
327 327
 
328
-		if( $this->is_valid ) {
328
+		if ( $this->is_valid ) {
329 329
 
330 330
 			gravityview()->log->debug( 'Submission is valid.' );
331 331
 
@@ -337,15 +337,15 @@  discard block
 block discarded – undo
337 337
 			/**
338 338
 			 * @hack to avoid the capability validation of the method save_lead for GF 1.9+
339 339
 			 */
340
-			unset( $_GET['page'] );
340
+			unset( $_GET[ 'page' ] );
341 341
 
342
-			$date_created = $this->entry['date_created'];
342
+			$date_created = $this->entry[ 'date_created' ];
343 343
 
344 344
 			/**
345 345
 			 * @hack to force Gravity Forms to use $read_value_from_post in GFFormsModel::save_lead()
346 346
 			 * @since 1.17.2
347 347
 			 */
348
-			unset( $this->entry['date_created'] );
348
+			unset( $this->entry[ 'date_created' ] );
349 349
 
350 350
 			/**
351 351
 			 * @action `gravityview/edit_entry/before_update` Perform an action after the entry has been updated using Edit Entry
@@ -355,14 +355,14 @@  discard block
 block discarded – undo
355 355
 			 * @param GravityView_Edit_Entry_Render $this This object
356 356
 			 * @param GravityView_View_Data $gv_data The View data
357 357
 			 */
358
-			do_action( 'gravityview/edit_entry/before_update', $form, $this->entry['id'], $this, $gv_data );
358
+			do_action( 'gravityview/edit_entry/before_update', $form, $this->entry[ 'id' ], $this, $gv_data );
359 359
 
360 360
 			GFFormsModel::save_lead( $form, $this->entry );
361 361
 
362 362
 	        // Delete the values for hidden inputs
363 363
 	        $this->unset_hidden_field_values();
364 364
 			
365
-			$this->entry['date_created'] = $date_created;
365
+			$this->entry[ 'date_created' ] = $date_created;
366 366
 
367 367
 			// Process calculation fields
368 368
 			$this->update_calculation_fields();
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
 			 * @param GravityView_Edit_Entry_Render $this This object
385 385
 			 * @param GravityView_View_Data $gv_data The View data
386 386
 			 */
387
-			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'], $this, $gv_data );
387
+			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry[ 'id' ], $this, $gv_data );
388 388
 
389 389
 		} else {
390 390
 			gravityview()->log->error( 'Submission is NOT valid.', array( 'entry' => $this->entry ) );
@@ -412,16 +412,16 @@  discard block
 block discarded – undo
412 412
 		 */
413 413
 		$unset_hidden_field_values = apply_filters( 'gravityview/edit_entry/unset_hidden_field_values', true, $this );
414 414
 
415
-		if( ! $unset_hidden_field_values ) {
415
+		if ( ! $unset_hidden_field_values ) {
416 416
 			return;
417 417
 		}
418 418
 
419 419
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
420 420
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
421
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $this->entry['id'] ) );
421
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $this->entry[ 'id' ] ) );
422 422
 		} else {
423 423
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
424
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry['id'] ) );
424
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry[ 'id' ] ) );
425 425
 		}
426 426
 
427 427
 	    foreach ( $this->entry as $input_id => $field_value ) {
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
 
435 435
 				$empty_value = $field->get_value_save_entry(
436 436
 					is_array( $field->get_entry_inputs() ) ? array() : '',
437
-					$this->form, '', $this->entry['id'], $this->entry
437
+					$this->form, '', $this->entry[ 'id' ], $this->entry
438 438
 				);
439 439
 
440 440
 			    $lead_detail_id = GFFormsModel::get_lead_detail_id( $current_fields, $input_id );
@@ -504,7 +504,7 @@  discard block
 block discarded – undo
504 504
 		}
505 505
 
506 506
 		/** No file is being uploaded. */
507
-		if ( empty( $_FILES[ $input_name ]['name'] ) ) {
507
+		if ( empty( $_FILES[ $input_name ][ 'name' ] ) ) {
508 508
 			/** So return the original upload */
509 509
 			return $entry[ $input_id ];
510 510
 		}
@@ -522,11 +522,11 @@  discard block
 block discarded – undo
522 522
 	 * @return mixed
523 523
 	 */
524 524
 	public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
525
-		if( ! $this->is_edit_entry() ) {
525
+		if ( ! $this->is_edit_entry() ) {
526 526
 			return $plupload_init;
527 527
 		}
528 528
 
529
-		$plupload_init['gf_vars']['max_files'] = 0;
529
+		$plupload_init[ 'gf_vars' ][ 'max_files' ] = 0;
530 530
 
531 531
 		return $plupload_init;
532 532
 	}
@@ -541,27 +541,27 @@  discard block
 block discarded – undo
541 541
 		$form = $this->filter_conditional_logic( $this->form );
542 542
 
543 543
 	    /** @var GF_Field $field */
544
-		foreach( $form['fields'] as $k => &$field ) {
544
+		foreach ( $form[ 'fields' ] as $k => &$field ) {
545 545
 
546 546
 			/**
547 547
 			 * Remove the fields with calculation formulas before save to avoid conflicts with GF logic
548 548
 			 * @since 1.16.3
549 549
 			 * @var GF_Field $field
550 550
 			 */
551
-			if( $field->has_calculation() ) {
552
-				unset( $form['fields'][ $k ] );
551
+			if ( $field->has_calculation() ) {
552
+				unset( $form[ 'fields' ][ $k ] );
553 553
 			}
554 554
 
555 555
 			$field->adminOnly = false;
556 556
 
557
-			if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
558
-				foreach( $field->inputs as $key => $input ) {
559
-				    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
557
+			if ( isset( $field->inputs ) && is_array( $field->inputs ) ) {
558
+				foreach ( $field->inputs as $key => $input ) {
559
+				    $field->inputs[ $key ][ 'id' ] = (string)$input[ 'id' ];
560 560
 				}
561 561
 			}
562 562
 		}
563 563
 
564
-		$form['fields'] = array_values( $form['fields'] );
564
+		$form[ 'fields' ] = array_values( $form[ 'fields' ] );
565 565
 
566 566
 		return $form;
567 567
 	}
@@ -573,14 +573,14 @@  discard block
 block discarded – undo
573 573
 		$update = false;
574 574
 
575 575
 		// get the most up to date entry values
576
-		$entry = GFAPI::get_entry( $this->entry['id'] );
576
+		$entry = GFAPI::get_entry( $this->entry[ 'id' ] );
577 577
 
578 578
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
579 579
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
580
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry['id'] ) );
580
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry[ 'id' ] ) );
581 581
 		} else {
582 582
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
583
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry['id'] ) );
583
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry[ 'id' ] ) );
584 584
 		}
585 585
 
586 586
 
@@ -592,24 +592,24 @@  discard block
 block discarded – undo
592 592
 				$inputs = $field->get_entry_inputs();
593 593
 				if ( is_array( $inputs ) ) {
594 594
 				    foreach ( $inputs as $input ) {
595
-						list( $field_id, $input_id ) = rgexplode( '.', $input['id'], 2 );
595
+						list( $field_id, $input_id ) = rgexplode( '.', $input[ 'id' ], 2 );
596 596
 
597 597
 						if ( 'product' === $field->type ) {
598
-							$input_name = 'input_' . str_replace( '.', '_', $input['id'] );
598
+							$input_name = 'input_' . str_replace( '.', '_', $input[ 'id' ] );
599 599
 
600 600
 							// Only allow quantity to be set if it's allowed to be edited
601 601
 							if ( in_array( $field_id, $allowed_fields ) && $input_id == 3 ) {
602 602
 							} else { // otherwise set to what it previously was
603
-								$_POST[ $input_name ] = $entry[ $input['id'] ];
603
+								$_POST[ $input_name ] = $entry[ $input[ 'id' ] ];
604 604
 							}
605 605
 						} else {
606 606
 							// Set to what it previously was if it's not editable
607 607
 							if ( ! in_array( $field_id, $allowed_fields ) ) {
608
-								$_POST[ $input_name ] = $entry[ $input['id'] ];
608
+								$_POST[ $input_name ] = $entry[ $input[ 'id' ] ];
609 609
 							}
610 610
 						}
611 611
 
612
-						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input['id'] );
612
+						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input[ 'id' ] );
613 613
 				    }
614 614
 				} else {
615 615
 					// Set to what it previously was if it's not editable
@@ -649,19 +649,19 @@  discard block
 block discarded – undo
649 649
 
650 650
 		$input_name = 'input_' . $field_id;
651 651
 
652
-		if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
652
+		if ( ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
653 653
 
654 654
 			// We have a new image
655 655
 
656
-			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
656
+			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ] );
657 657
 
658 658
 			$ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
659 659
 	        $ary = stripslashes_deep( $ary );
660 660
 			$img_url = \GV\Utils::get( $ary, 0 );
661 661
 
662
-			$img_title       = count( $ary ) > 1 ? $ary[1] : '';
663
-			$img_caption     = count( $ary ) > 2 ? $ary[2] : '';
664
-			$img_description = count( $ary ) > 3 ? $ary[3] : '';
662
+			$img_title       = count( $ary ) > 1 ? $ary[ 1 ] : '';
663
+			$img_caption     = count( $ary ) > 2 ? $ary[ 2 ] : '';
664
+			$img_description = count( $ary ) > 3 ? $ary[ 3 ] : '';
665 665
 
666 666
 			$image_meta = array(
667 667
 				'post_excerpt' => $img_caption,
@@ -670,7 +670,7 @@  discard block
 block discarded – undo
670 670
 
671 671
 			//adding title only if it is not empty. It will default to the file name if it is not in the array
672 672
 			if ( ! empty( $img_title ) ) {
673
-				$image_meta['post_title'] = $img_title;
673
+				$image_meta[ 'post_title' ] = $img_title;
674 674
 			}
675 675
 
676 676
 			/**
@@ -728,15 +728,15 @@  discard block
 block discarded – undo
728 728
 	 */
729 729
 	private function maybe_update_post_fields( $form ) {
730 730
 
731
-		if( empty( $this->entry['post_id'] ) ) {
731
+		if ( empty( $this->entry[ 'post_id' ] ) ) {
732 732
 	        gravityview()->log->debug( 'This entry has no post fields. Continuing...' );
733 733
 			return;
734 734
 		}
735 735
 
736
-		$post_id = $this->entry['post_id'];
736
+		$post_id = $this->entry[ 'post_id' ];
737 737
 
738 738
 		// Security check
739
-		if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
739
+		if ( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
740 740
 			gravityview()->log->error( 'The current user does not have the ability to edit Post #{post_id}', array( 'post_id' => $post_id ) );
741 741
 			return;
742 742
 		}
@@ -749,25 +749,25 @@  discard block
 block discarded – undo
749 749
 
750 750
 			$field = RGFormsModel::get_field( $form, $field_id );
751 751
 
752
-			if( ! $field ) {
752
+			if ( ! $field ) {
753 753
 				continue;
754 754
 			}
755 755
 
756
-			if( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
756
+			if ( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
757 757
 
758 758
 				// Get the value of the field, including $_POSTed value
759 759
 				$value = RGFormsModel::get_field_value( $field );
760 760
 
761 761
 				// Use temporary entry variable, to make values available to fill_post_template() and update_post_image()
762 762
 				$entry_tmp = $this->entry;
763
-				$entry_tmp["{$field_id}"] = $value;
763
+				$entry_tmp[ "{$field_id}" ] = $value;
764 764
 
765
-				switch( $field->type ) {
765
+				switch ( $field->type ) {
766 766
 
767 767
 				    case 'post_title':
768 768
 				        $post_title = $value;
769 769
 				        if ( \GV\Utils::get( $form, 'postTitleTemplateEnabled' ) ) {
770
-				            $post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
770
+				            $post_title = $this->fill_post_template( $form[ 'postTitleTemplate' ], $form, $entry_tmp );
771 771
 				        }
772 772
 				        $updated_post->post_title = $post_title;
773 773
 				        $updated_post->post_name  = $post_title;
@@ -777,7 +777,7 @@  discard block
 block discarded – undo
777 777
 				    case 'post_content':
778 778
 				        $post_content = $value;
779 779
 				        if ( \GV\Utils::get( $form, 'postContentTemplateEnabled' ) ) {
780
-				            $post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
780
+				            $post_content = $this->fill_post_template( $form[ 'postContentTemplate' ], $form, $entry_tmp, true );
781 781
 				        }
782 782
 				        $updated_post->post_content = $post_content;
783 783
 				        unset( $post_content );
@@ -795,11 +795,11 @@  discard block
 block discarded – undo
795 795
 							$value = $value[ $field_id ];
796 796
 						}
797 797
 
798
-				        if( ! empty( $field->customFieldTemplateEnabled ) ) {
798
+				        if ( ! empty( $field->customFieldTemplateEnabled ) ) {
799 799
 				            $value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
800 800
 				        }
801 801
 
802
-						$value = $field->get_value_save_entry( $value, $form, '', $this->entry['id'], $this->entry );
802
+						$value = $field->get_value_save_entry( $value, $form, '', $this->entry[ 'id' ], $this->entry );
803 803
 
804 804
 				        update_post_meta( $post_id, $field->postCustomFieldName, $value );
805 805
 				        break;
@@ -811,7 +811,7 @@  discard block
 block discarded – undo
811 811
 				}
812 812
 
813 813
 				// update entry after
814
-				$this->entry["{$field_id}"] = $value;
814
+				$this->entry[ "{$field_id}" ] = $value;
815 815
 
816 816
 				$update_entry = true;
817 817
 
@@ -820,11 +820,11 @@  discard block
 block discarded – undo
820 820
 
821 821
 		}
822 822
 
823
-		if( $update_entry ) {
823
+		if ( $update_entry ) {
824 824
 
825 825
 			$return_entry = GFAPI::update_entry( $this->entry );
826 826
 
827
-			if( is_wp_error( $return_entry ) ) {
827
+			if ( is_wp_error( $return_entry ) ) {
828 828
 				gravityview()->log->error( 'Updating the entry post fields failed', array( 'data' => array( '$this->entry' => $this->entry, '$return_entry' => $return_entry ) ) );
829 829
 			} else {
830 830
 				gravityview()->log->debug( 'Updating the entry post fields for post #{post_id} succeeded', array( 'post_id' => $post_id ) );
@@ -834,7 +834,7 @@  discard block
 block discarded – undo
834 834
 
835 835
 		$return_post = wp_update_post( $updated_post, true );
836 836
 
837
-		if( is_wp_error( $return_post ) ) {
837
+		if ( is_wp_error( $return_post ) ) {
838 838
 			$return_post->add_data( $updated_post, '$updated_post' );
839 839
 			gravityview()->log->error( 'Updating the post content failed', array( 'data' => compact( 'updated_post', 'return_post' ) ) );
840 840
 		} else {
@@ -868,7 +868,7 @@  discard block
 block discarded – undo
868 868
 		$output = GFCommon::replace_variables( $output, $form, $entry, false, false, false );
869 869
 
870 870
 		// replace conditional shortcodes
871
-		if( $do_shortcode ) {
871
+		if ( $do_shortcode ) {
872 872
 			$output = do_shortcode( $output );
873 873
 		}
874 874
 
@@ -887,19 +887,19 @@  discard block
 block discarded – undo
887 887
 	 */
888 888
 	private function after_update() {
889 889
 
890
-		do_action( 'gform_after_update_entry', $this->form, $this->entry['id'], self::$original_entry );
891
-		do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'], self::$original_entry );
890
+		do_action( 'gform_after_update_entry', $this->form, $this->entry[ 'id' ], self::$original_entry );
891
+		do_action( "gform_after_update_entry_{$this->form[ 'id' ]}", $this->form, $this->entry[ 'id' ], self::$original_entry );
892 892
 
893 893
 		// Re-define the entry now that we've updated it.
894
-		$entry = RGFormsModel::get_lead( $this->entry['id'] );
894
+		$entry = RGFormsModel::get_lead( $this->entry[ 'id' ] );
895 895
 
896 896
 		$entry = GFFormsModel::set_entry_meta( $entry, self::$original_form );
897 897
 
898 898
 		if ( version_compare( GFFormsModel::get_database_version(), '2.3-dev-1', '<' ) ) {
899 899
 			// We need to clear the cache because Gravity Forms caches the field values, which
900 900
 			// we have just updated.
901
-			foreach ($this->form['fields'] as $key => $field) {
902
-				GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
901
+			foreach ( $this->form[ 'fields' ] as $key => $field ) {
902
+				GFFormsModel::refresh_lead_field_value( $entry[ 'id' ], $field->id );
903 903
 			}
904 904
 		}
905 905
 
@@ -909,11 +909,11 @@  discard block
 block discarded – undo
909 909
 		 * @since develop
910 910
 		 */
911 911
 		if ( $allowed_feeds = $this->view->settings->get( 'edit_feeds', array() ) ) {
912
-			$feeds = GFAPI::get_feeds( null, $entry['form_id'] );
912
+			$feeds = GFAPI::get_feeds( null, $entry[ 'form_id' ] );
913 913
 			if ( ! is_wp_error( $feeds ) ) {
914 914
 				$registered_feeds = array();
915 915
 				foreach ( GFAddOn::get_registered_addons() as $registered_feed ) {
916
-					if ( is_subclass_of( $registered_feed,  'GFFeedAddOn' ) ) {
916
+					if ( is_subclass_of( $registered_feed, 'GFFeedAddOn' ) ) {
917 917
 						if ( method_exists( $registered_feed, 'get_instance' ) ) {
918 918
 							$registered_feed = call_user_func( array( $registered_feed, 'get_instance' ) );
919 919
 							$registered_feeds[ $registered_feed->get_slug() ] = $registered_feed;
@@ -921,8 +921,8 @@  discard block
 block discarded – undo
921 921
 					}
922 922
 				}
923 923
 				foreach ( $feeds as $feed ) {
924
-					if ( in_array( $feed['id'], $allowed_feeds ) ) {
925
-						if ( $feed_object = \GV\Utils::get( $registered_feeds, $feed['addon_slug'] ) ) {
924
+					if ( in_array( $feed[ 'id' ], $allowed_feeds ) ) {
925
+						if ( $feed_object = \GV\Utils::get( $registered_feeds, $feed[ 'addon_slug' ] ) ) {
926 926
 							$returned_entry = $feed_object->process_feed( $feed, $entry, self::$original_form );
927 927
 							if ( is_array( $returned_entry ) && rgar( $returned_entry, 'id' ) ) {
928 928
 								$entry = $returned_entry;
@@ -952,7 +952,7 @@  discard block
 block discarded – undo
952 952
 
953 953
 		<div class="gv-edit-entry-wrapper"><?php
954 954
 
955
-			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
955
+			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/inline-javascript.php', $this );
956 956
 
957 957
 			/**
958 958
 			 * Fixes weird wpautop() issue
@@ -968,7 +968,7 @@  discard block
 block discarded – undo
968 968
 				     * @param string $edit_entry_title Modify the "Edit Entry" title
969 969
 				     * @param GravityView_Edit_Entry_Render $this This object
970 970
 				     */
971
-				    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
971
+				    $edit_entry_title = apply_filters( 'gravityview_edit_entry_title', __( 'Edit Entry', 'gravityview' ), $this );
972 972
 
973 973
 				    echo esc_attr( $edit_entry_title );
974 974
 			?></span>
@@ -1018,13 +1018,13 @@  discard block
 block discarded – undo
1018 1018
 
1019 1019
 			$back_link = remove_query_arg( array( 'page', 'view', 'edit' ) );
1020 1020
 
1021
-			if( ! $this->is_valid ){
1021
+			if ( ! $this->is_valid ) {
1022 1022
 
1023 1023
 				// Keeping this compatible with Gravity Forms.
1024
-				$validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
1025
-				$message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
1024
+				$validation_message = "<div class='validation_error'>" . __( 'There was a problem with your submission.', 'gravityview' ) . " " . __( 'Errors have been highlighted below.', 'gravityview' ) . "</div>";
1025
+				$message = apply_filters( "gform_validation_message_{$this->form[ 'id' ]}", apply_filters( "gform_validation_message", $validation_message, $this->form ), $this->form );
1026 1026
 
1027
-				echo GVCommon::generate_notice( $message , 'gv-error' );
1027
+				echo GVCommon::generate_notice( $message, 'gv-error' );
1028 1028
 
1029 1029
 			} else {
1030 1030
 				$view = \GV\View::by_id( $this->view_id );
@@ -1035,23 +1035,23 @@  discard block
 block discarded – undo
1035 1035
 
1036 1036
                     case '0':
1037 1037
 	                    $redirect_url = $back_link;
1038
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview'), '<a href="'. esc_url( $redirect_url ) .'">', '</a>' );
1038
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', '</a>' );
1039 1039
                         break;
1040 1040
 
1041 1041
                     case '1':
1042 1042
 	                    $redirect_url = $directory_link = GravityView_API::directory_link();
1043
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1043
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1044 1044
 	                    break;
1045 1045
 
1046 1046
                     case '2':
1047 1047
 	                    $redirect_url = $edit_redirect_url;
1048 1048
 	                    $redirect_url = GFCommon::replace_variables( $redirect_url, $this->form, $this->entry, false, false, false, 'text' );
1049
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1049
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1050 1050
                         break;
1051 1051
 
1052 1052
                     case '':
1053 1053
                     default:
1054
-					    $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. esc_url( $back_link ) .'">', '</a>' );
1054
+					    $entry_updated_message = sprintf( esc_attr__( 'Entry Updated. %sReturn to Entry%s', 'gravityview' ), '<a href="' . esc_url( $back_link ) . '">', '</a>' );
1055 1055
                         break;
1056 1056
 				}
1057 1057
 
@@ -1067,7 +1067,7 @@  discard block
 block discarded – undo
1067 1067
 				 * @param array $entry Gravity Forms entry array
1068 1068
 				 * @param string $back_link URL to return to the original entry. @since 1.6
1069 1069
 				 */
1070
-				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
1070
+				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message, $this->view_id, $this->entry, $back_link );
1071 1071
 
1072 1072
 				echo GVCommon::generate_notice( $message );
1073 1073
 			}
@@ -1091,21 +1091,21 @@  discard block
 block discarded – undo
1091 1091
 		 */
1092 1092
 		do_action( 'gravityview/edit-entry/render/before', $this );
1093 1093
 
1094
-		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
1095
-		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
1094
+		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000, 3 );
1095
+		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
1096 1096
 		add_filter( 'gform_disable_view_counter', '__return_true' );
1097 1097
 
1098 1098
 		add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
1099 1099
 		add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
1100 1100
 
1101 1101
 		// We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
1102
-		unset( $_GET['page'] );
1102
+		unset( $_GET[ 'page' ] );
1103 1103
 
1104 1104
 		// TODO: Verify multiple-page forms
1105 1105
 
1106 1106
 		ob_start(); // Prevent PHP warnings possibly caused by prefilling list fields for conditional logic
1107 1107
 
1108
-		$html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
1108
+		$html = GFFormDisplay::get_form( $this->form[ 'id' ], false, false, true, $this->entry );
1109 1109
 
1110 1110
 		ob_get_clean();
1111 1111
 
@@ -1131,7 +1131,7 @@  discard block
 block discarded – undo
1131 1131
 	 * @return string
1132 1132
 	 */
1133 1133
 	public function render_form_buttons() {
1134
-		return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
1134
+		return gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/form-buttons.php', $this );
1135 1135
 	}
1136 1136
 
1137 1137
 
@@ -1151,10 +1151,10 @@  discard block
 block discarded – undo
1151 1151
 	public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
1152 1152
 
1153 1153
 		// In case we have validated the form, use it to inject the validation results into the form render
1154
-		if( isset( $this->form_after_validation ) ) {
1154
+		if ( isset( $this->form_after_validation ) ) {
1155 1155
 			$form = $this->form_after_validation;
1156 1156
 		} else {
1157
-			$form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
1157
+			$form[ 'fields' ] = $this->get_configured_edit_fields( $form, $this->view_id );
1158 1158
 		}
1159 1159
 
1160 1160
 		$form = $this->filter_conditional_logic( $form );
@@ -1162,8 +1162,8 @@  discard block
 block discarded – undo
1162 1162
 		$form = $this->prefill_conditional_logic( $form );
1163 1163
 
1164 1164
 		// for now we don't support Save and Continue feature.
1165
-		if( ! self::$supports_save_and_continue ) {
1166
-	        unset( $form['save'] );
1165
+		if ( ! self::$supports_save_and_continue ) {
1166
+	        unset( $form[ 'save' ] );
1167 1167
 		}
1168 1168
 
1169 1169
 		$form = $this->unselect_default_values( $form );
@@ -1186,31 +1186,31 @@  discard block
 block discarded – undo
1186 1186
 	 */
1187 1187
 	public function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
1188 1188
 
1189
-		if( ! GFCommon::is_post_field( $field ) ) {
1189
+		if ( ! GFCommon::is_post_field( $field ) ) {
1190 1190
 			return $field_content;
1191 1191
 		}
1192 1192
 
1193 1193
         $message = null;
1194 1194
 
1195 1195
         // First, make sure they have the capability to edit the post.
1196
-        if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1196
+        if ( false === current_user_can( 'edit_post', $this->entry[ 'post_id' ] ) ) {
1197 1197
 
1198 1198
             /**
1199 1199
              * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1200 1200
              * @param string $message The existing "You don't have permission..." text
1201 1201
              */
1202
-            $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1202
+            $message = apply_filters( 'gravityview/edit_entry/unsupported_post_field_text', __( 'You don&rsquo;t have permission to edit this post.', 'gravityview' ) );
1203 1203
 
1204
-        } elseif( null === get_post( $this->entry['post_id'] ) ) {
1204
+        } elseif ( null === get_post( $this->entry[ 'post_id' ] ) ) {
1205 1205
             /**
1206 1206
              * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1207 1207
              * @param string $message The existing "This field is not editable; the post no longer exists." text
1208 1208
              */
1209
-            $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1209
+            $message = apply_filters( 'gravityview/edit_entry/no_post_text', __( 'This field is not editable; the post no longer exists.', 'gravityview' ) );
1210 1210
         }
1211 1211
 
1212
-        if( $message ) {
1213
-            $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1212
+        if ( $message ) {
1213
+            $field_content = sprintf( '<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1214 1214
         }
1215 1215
 
1216 1216
         return $field_content;
@@ -1234,8 +1234,8 @@  discard block
 block discarded – undo
1234 1234
 
1235 1235
 		// If the form has been submitted, then we don't need to pre-fill the values,
1236 1236
 		// Except for fileupload type and when a field input is overridden- run always!!
1237
-		if(
1238
-			( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1237
+		if (
1238
+			( $this->is_edit_entry_submission() && ! in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1239 1239
 			&& false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
1240 1240
 			&& ! GFCommon::is_product_field( $field->type )
1241 1241
 			|| ! empty( $field_content )
@@ -1255,7 +1255,7 @@  discard block
 block discarded – undo
1255 1255
 	    $return = null;
1256 1256
 
1257 1257
 		/** @var GravityView_Field $gv_field */
1258
-		if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1258
+		if ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1259 1259
 			$return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1260 1260
 		} else {
1261 1261
 	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
@@ -1264,7 +1264,7 @@  discard block
 block discarded – undo
1264 1264
 	    // If there was output, it's an error
1265 1265
 	    $warnings = ob_get_clean();
1266 1266
 
1267
-	    if( !empty( $warnings ) ) {
1267
+	    if ( ! empty( $warnings ) ) {
1268 1268
 		    gravityview()->log->error( '{warning}', array( 'warning' => $warnings, 'data' => $field_value ) );
1269 1269
 	    }
1270 1270
 
@@ -1289,7 +1289,7 @@  discard block
 block discarded – undo
1289 1289
 		$override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
1290 1290
 
1291 1291
 		// We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
1292
-		if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
1292
+		if ( isset( $field->inputs ) && is_array( $field->inputs ) && ! in_array( $field->type, array( 'time', 'date' ) ) ) {
1293 1293
 
1294 1294
 			$field_value = array();
1295 1295
 
@@ -1298,10 +1298,10 @@  discard block
 block discarded – undo
1298 1298
 
1299 1299
 			foreach ( (array)$field->inputs as $input ) {
1300 1300
 
1301
-				$input_id = strval( $input['id'] );
1301
+				$input_id = strval( $input[ 'id' ] );
1302 1302
 
1303 1303
 				if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1304
-				    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1304
+				    $field_value[ $input_id ] = 'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1305 1305
 				    $allow_pre_populated = false;
1306 1306
 				}
1307 1307
 
@@ -1309,7 +1309,7 @@  discard block
 block discarded – undo
1309 1309
 
1310 1310
 			$pre_value = $field->get_value_submission( array(), false );
1311 1311
 
1312
-			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1312
+			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1313 1313
 
1314 1314
 		} else {
1315 1315
 
@@ -1320,13 +1320,13 @@  discard block
 block discarded – undo
1320 1320
 
1321 1321
 			// saved field entry value (if empty, fallback to the pre-populated value, if exists)
1322 1322
 			// or pre-populated value if not empty and set to override saved value
1323
-			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1323
+			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1324 1324
 
1325 1325
 			// in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1326
-			if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1326
+			if ( 'post_category' === $field->type && ! gv_empty( $field_value, false, false ) ) {
1327 1327
 				$categories = array();
1328 1328
 				foreach ( explode( ',', $field_value ) as $cat_string ) {
1329
-				    $categories[] = GFCommon::format_post_category( $cat_string, true );
1329
+				    $categories[ ] = GFCommon::format_post_category( $cat_string, true );
1330 1330
 				}
1331 1331
 				$field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1332 1332
 			}
@@ -1354,7 +1354,7 @@  discard block
 block discarded – undo
1354 1354
 	     * @param GF_Field $field Gravity Forms field object
1355 1355
 	     * @param GravityView_Edit_Entry_Render $this Current object
1356 1356
 	     */
1357
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1357
+	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type, $field_value, $field, $this );
1358 1358
 
1359 1359
 		return $field_value;
1360 1360
 	}
@@ -1371,12 +1371,12 @@  discard block
 block discarded – undo
1371 1371
 	 */
1372 1372
 	public function gform_pre_validation( $form ) {
1373 1373
 
1374
-		if( ! $this->verify_nonce() ) {
1374
+		if ( ! $this->verify_nonce() ) {
1375 1375
 			return $form;
1376 1376
 		}
1377 1377
 
1378 1378
 		// Fix PHP warning regarding undefined index.
1379
-		foreach ( $form['fields'] as &$field) {
1379
+		foreach ( $form[ 'fields' ] as &$field ) {
1380 1380
 
1381 1381
 			// This is because we're doing admin form pretending to be front-end, so Gravity Forms
1382 1382
 			// expects certain field array items to be set.
@@ -1384,7 +1384,7 @@  discard block
 block discarded – undo
1384 1384
 	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1385 1385
 			}
1386 1386
 
1387
-			switch( RGFormsModel::get_input_type( $field ) ) {
1387
+			switch ( RGFormsModel::get_input_type( $field ) ) {
1388 1388
 
1389 1389
 				/**
1390 1390
 				 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
@@ -1398,26 +1398,26 @@  discard block
 block discarded – undo
1398 1398
 				    // Set the previous value
1399 1399
 				    $entry = $this->get_entry();
1400 1400
 
1401
-				    $input_name = 'input_'.$field->id;
1402
-				    $form_id = $form['id'];
1401
+				    $input_name = 'input_' . $field->id;
1402
+				    $form_id = $form[ 'id' ];
1403 1403
 
1404 1404
 				    $value = NULL;
1405 1405
 
1406 1406
 				    // Use the previous entry value as the default.
1407
-				    if( isset( $entry[ $field->id ] ) ) {
1407
+				    if ( isset( $entry[ $field->id ] ) ) {
1408 1408
 				        $value = $entry[ $field->id ];
1409 1409
 				    }
1410 1410
 
1411 1411
 				    // If this is a single upload file
1412
-				    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1413
-				        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1414
-				        $value = $file_path['url'];
1412
+				    if ( ! empty( $_FILES[ $input_name ] ) && ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
1413
+				        $file_path = GFFormsModel::get_file_upload_path( $form[ 'id' ], $_FILES[ $input_name ][ 'name' ] );
1414
+				        $value = $file_path[ 'url' ];
1415 1415
 
1416 1416
 				    } else {
1417 1417
 
1418 1418
 				        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1419 1419
 				        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1420
-				        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1420
+				        $_FILES[ $input_name ] = array( 'name' => '', 'size' => '' );
1421 1421
 
1422 1422
 				    }
1423 1423
 
@@ -1425,10 +1425,10 @@  discard block
 block discarded – undo
1425 1425
 
1426 1426
 				        // If there are fresh uploads, process and merge them.
1427 1427
 				        // Otherwise, use the passed values, which should be json-encoded array of URLs
1428
-				        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1428
+				        if ( isset( GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] ) ) {
1429 1429
 				            $value = empty( $value ) ? '[]' : $value;
1430 1430
 				            $value = stripslashes_deep( $value );
1431
-				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1431
+				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ], array() );
1432 1432
 				        }
1433 1433
 
1434 1434
 				    } else {
@@ -1446,8 +1446,8 @@  discard block
 block discarded – undo
1446 1446
 
1447 1447
 				case 'number':
1448 1448
 				    // Fix "undefined index" issue at line 1286 in form_display.php
1449
-				    if( !isset( $_POST['input_'.$field->id ] ) ) {
1450
-				        $_POST['input_'.$field->id ] = NULL;
1449
+				    if ( ! isset( $_POST[ 'input_' . $field->id ] ) ) {
1450
+				        $_POST[ 'input_' . $field->id ] = NULL;
1451 1451
 				    }
1452 1452
 				    break;
1453 1453
 			}
@@ -1484,7 +1484,7 @@  discard block
 block discarded – undo
1484 1484
 		 * You can enter whatever you want!
1485 1485
 		 * We try validating, and customize the results using `self::custom_validation()`
1486 1486
 		 */
1487
-		add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1487
+		add_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10, 4 );
1488 1488
 
1489 1489
 		// Needed by the validate funtion
1490 1490
 		$failed_validation_page = NULL;
@@ -1492,14 +1492,14 @@  discard block
 block discarded – undo
1492 1492
 
1493 1493
 		// Prevent entry limit from running when editing an entry, also
1494 1494
 		// prevent form scheduling from preventing editing
1495
-		unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1495
+		unset( $this->form[ 'limitEntries' ], $this->form[ 'scheduleForm' ] );
1496 1496
 
1497 1497
 		// Hide fields depending on Edit Entry settings
1498
-		$this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1498
+		$this->form[ 'fields' ] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1499 1499
 
1500 1500
 		$this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1501 1501
 
1502
-		remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1502
+		remove_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10 );
1503 1503
 	}
1504 1504
 
1505 1505
 
@@ -1522,7 +1522,7 @@  discard block
 block discarded – undo
1522 1522
 
1523 1523
 		$gv_valid = true;
1524 1524
 
1525
-		foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1525
+		foreach ( $validation_results[ 'form' ][ 'fields' ] as $key => &$field ) {
1526 1526
 
1527 1527
 			$value = RGFormsModel::get_field_value( $field );
1528 1528
 			$field_type = RGFormsModel::get_input_type( $field );
@@ -1535,22 +1535,22 @@  discard block
 block discarded – undo
1535 1535
 				case 'post_image':
1536 1536
 
1537 1537
 				    // in case nothing is uploaded but there are already files saved
1538
-				    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1538
+				    if ( ! empty( $field->failed_validation ) && ! empty( $field->isRequired ) && ! empty( $value ) ) {
1539 1539
 				        $field->failed_validation = false;
1540 1540
 				        unset( $field->validation_message );
1541 1541
 				    }
1542 1542
 
1543 1543
 				    // validate if multi file upload reached max number of files [maxFiles] => 2
1544
-				    if( \GV\Utils::get( $field, 'maxFiles') && \GV\Utils::get( $field, 'multipleFiles') ) {
1544
+				    if ( \GV\Utils::get( $field, 'maxFiles' ) && \GV\Utils::get( $field, 'multipleFiles' ) ) {
1545 1545
 
1546 1546
 				        $input_name = 'input_' . $field->id;
1547 1547
 				        //uploaded
1548
-				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1548
+				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] : array();
1549 1549
 
1550 1550
 				        //existent
1551 1551
 				        $entry = $this->get_entry();
1552 1552
 				        $value = NULL;
1553
-				        if( isset( $entry[ $field->id ] ) ) {
1553
+				        if ( isset( $entry[ $field->id ] ) ) {
1554 1554
 				            $value = json_decode( $entry[ $field->id ], true );
1555 1555
 				        }
1556 1556
 
@@ -1558,13 +1558,13 @@  discard block
 block discarded – undo
1558 1558
 				        $count_files = ( is_array( $file_names ) ? count( $file_names ) : 0 ) +
1559 1559
 						               ( is_array( $value ) ? count( $value ) : 0 );
1560 1560
 
1561
-				        if( $count_files > $field->maxFiles ) {
1561
+				        if ( $count_files > $field->maxFiles ) {
1562 1562
 				            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1563 1563
 				            $field->failed_validation = 1;
1564 1564
 				            $gv_valid = false;
1565 1565
 
1566 1566
 				            // in case of error make sure the newest upload files are removed from the upload input
1567
-				            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1567
+				            GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ] = null;
1568 1568
 				        }
1569 1569
 
1570 1570
 				    }
@@ -1575,7 +1575,7 @@  discard block
 block discarded – undo
1575 1575
 			}
1576 1576
 
1577 1577
 			// This field has failed validation.
1578
-			if( !empty( $field->failed_validation ) ) {
1578
+			if ( ! empty( $field->failed_validation ) ) {
1579 1579
 
1580 1580
 				gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'data' => array( 'field' => $field, 'value' => $value ) ) );
1581 1581
 
@@ -1593,19 +1593,19 @@  discard block
 block discarded – undo
1593 1593
 				}
1594 1594
 
1595 1595
 				// You can't continue inside a switch, so we do it after.
1596
-				if( empty( $field->failed_validation ) ) {
1596
+				if ( empty( $field->failed_validation ) ) {
1597 1597
 				    continue;
1598 1598
 				}
1599 1599
 
1600 1600
 				// checks if the No Duplicates option is not validating entry against itself, since
1601 1601
 				// we're editing a stored entry, it would also assume it's a duplicate.
1602
-				if( !empty( $field->noDuplicates ) ) {
1602
+				if ( ! empty( $field->noDuplicates ) ) {
1603 1603
 
1604 1604
 				    $entry = $this->get_entry();
1605 1605
 
1606 1606
 				    // If the value of the entry is the same as the stored value
1607 1607
 				    // Then we can assume it's not a duplicate, it's the same.
1608
-				    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1608
+				    if ( ! empty( $entry ) && $value == $entry[ $field->id ] ) {
1609 1609
 				        //if value submitted was not changed, then don't validate
1610 1610
 				        $field->failed_validation = false;
1611 1611
 
@@ -1618,7 +1618,7 @@  discard block
 block discarded – undo
1618 1618
 				}
1619 1619
 
1620 1620
 				// if here then probably we are facing the validation 'At least one field must be filled out'
1621
-				if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1621
+				if ( GFFormDisplay::is_empty( $field, $this->form_id ) && empty( $field->isRequired ) ) {
1622 1622
 				    unset( $field->validation_message );
1623 1623
 	                $field->validation_message = false;
1624 1624
 				    continue;
@@ -1630,12 +1630,12 @@  discard block
 block discarded – undo
1630 1630
 
1631 1631
 		}
1632 1632
 
1633
-		$validation_results['is_valid'] = $gv_valid;
1633
+		$validation_results[ 'is_valid' ] = $gv_valid;
1634 1634
 
1635 1635
 		gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Validation results.', array( 'data' => $validation_results ) );
1636 1636
 
1637 1637
 		// We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1638
-		$this->form_after_validation = $validation_results['form'];
1638
+		$this->form_after_validation = $validation_results[ 'form' ];
1639 1639
 
1640 1640
 		return $validation_results;
1641 1641
 	}
@@ -1648,7 +1648,7 @@  discard block
 block discarded – undo
1648 1648
 	 */
1649 1649
 	public function get_entry() {
1650 1650
 
1651
-		if( empty( $this->entry ) ) {
1651
+		if ( empty( $this->entry ) ) {
1652 1652
 			// Get the database value of the entry that's being edited
1653 1653
 			$this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1654 1654
 		}
@@ -1680,10 +1680,10 @@  discard block
 block discarded – undo
1680 1680
 		}
1681 1681
 
1682 1682
 		// If edit tab not yet configured, show all fields
1683
-		$edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1683
+		$edit_fields = ! empty( $properties[ 'edit_edit-fields' ] ) ? $properties[ 'edit_edit-fields' ] : NULL;
1684 1684
 
1685 1685
 		// Hide fields depending on admin settings
1686
-		$fields = $this->filter_fields( $form['fields'], $edit_fields );
1686
+		$fields = $this->filter_fields( $form[ 'fields' ], $edit_fields );
1687 1687
 
1688 1688
 	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1689 1689
 	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
@@ -1716,7 +1716,7 @@  discard block
 block discarded – undo
1716 1716
 	 */
1717 1717
 	private function filter_fields( $fields, $configured_fields ) {
1718 1718
 
1719
-		if( empty( $fields ) || !is_array( $fields ) ) {
1719
+		if ( empty( $fields ) || ! is_array( $fields ) ) {
1720 1720
 			return $fields;
1721 1721
 		}
1722 1722
 
@@ -1729,12 +1729,12 @@  discard block
 block discarded – undo
1729 1729
 
1730 1730
 			// Remove the fields that have calculation properties and keep them to be used later
1731 1731
 			// @since 1.16.2
1732
-			if( $field->has_calculation() ) {
1733
-				$this->fields_with_calculation[] = $field;
1732
+			if ( $field->has_calculation() ) {
1733
+				$this->fields_with_calculation[ ] = $field;
1734 1734
 				// don't remove the calculation fields on form render.
1735 1735
 			}
1736 1736
 
1737
-			if( in_array( $field->type, $field_type_blacklist ) ) {
1737
+			if ( in_array( $field->type, $field_type_blacklist ) ) {
1738 1738
 				unset( $fields[ $key ] );
1739 1739
 			}
1740 1740
 		}
@@ -1752,7 +1752,7 @@  discard block
 block discarded – undo
1752 1752
 					continue; // Same
1753 1753
 				}
1754 1754
 
1755
-				$out_fields[] = $field;
1755
+				$out_fields[ ] = $field;
1756 1756
 			}
1757 1757
 
1758 1758
 			return array_values( $out_fields );
@@ -1763,8 +1763,8 @@  discard block
 block discarded – undo
1763 1763
 
1764 1764
 	        /** @var GF_Field $field */
1765 1765
 	        foreach ( $fields as $field ) {
1766
-				if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1767
-				    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1766
+				if ( intval( $configured_field[ 'id' ] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1767
+				    $edit_fields[ ] = $this->merge_field_properties( $field, $configured_field );
1768 1768
 				    break;
1769 1769
 				}
1770 1770
 
@@ -1787,14 +1787,14 @@  discard block
 block discarded – undo
1787 1787
 
1788 1788
 		$return_field = $field;
1789 1789
 
1790
-		if( empty( $field_setting['show_label'] ) ) {
1790
+		if ( empty( $field_setting[ 'show_label' ] ) ) {
1791 1791
 			$return_field->label = '';
1792
-		} elseif ( !empty( $field_setting['custom_label'] ) ) {
1793
-			$return_field->label = $field_setting['custom_label'];
1792
+		} elseif ( ! empty( $field_setting[ 'custom_label' ] ) ) {
1793
+			$return_field->label = $field_setting[ 'custom_label' ];
1794 1794
 		}
1795 1795
 
1796
-		if( !empty( $field_setting['custom_class'] ) ) {
1797
-			$return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1796
+		if ( ! empty( $field_setting[ 'custom_class' ] ) ) {
1797
+			$return_field->cssClass .= ' ' . gravityview_sanitize_html_class( $field_setting[ 'custom_class' ] );
1798 1798
 		}
1799 1799
 
1800 1800
 		/**
@@ -1832,16 +1832,16 @@  discard block
 block discarded – undo
1832 1832
 	     */
1833 1833
 	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1834 1834
 
1835
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1836
-			foreach( $fields as $k => $field ) {
1837
-				if( $field->adminOnly ) {
1835
+	    if ( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry[ 'id' ] ) ) {
1836
+			foreach ( $fields as $k => $field ) {
1837
+				if ( $field->adminOnly ) {
1838 1838
 				    unset( $fields[ $k ] );
1839 1839
 				}
1840 1840
 			}
1841 1841
 			return array_values( $fields );
1842 1842
 		}
1843 1843
 
1844
-	    foreach( $fields as &$field ) {
1844
+	    foreach ( $fields as &$field ) {
1845 1845
 		    $field->adminOnly = false;
1846 1846
 		}
1847 1847
 
@@ -1862,7 +1862,7 @@  discard block
 block discarded – undo
1862 1862
 	 */
1863 1863
 	private function unselect_default_values( $form ) {
1864 1864
 
1865
-	    foreach ( $form['fields'] as &$field ) {
1865
+	    foreach ( $form[ 'fields' ] as &$field ) {
1866 1866
 
1867 1867
 			if ( empty( $field->choices ) ) {
1868 1868
                 continue;
@@ -1870,7 +1870,7 @@  discard block
 block discarded – undo
1870 1870
 
1871 1871
             foreach ( $field->choices as &$choice ) {
1872 1872
 				if ( \GV\Utils::get( $choice, 'isSelected' ) ) {
1873
-					$choice['isSelected'] = false;
1873
+					$choice[ 'isSelected' ] = false;
1874 1874
 				}
1875 1875
 			}
1876 1876
 		}
@@ -1895,22 +1895,22 @@  discard block
 block discarded – undo
1895 1895
 	 */
1896 1896
 	function prefill_conditional_logic( $form ) {
1897 1897
 
1898
-		if( ! GFFormDisplay::has_conditional_logic( $form ) ) {
1898
+		if ( ! GFFormDisplay::has_conditional_logic( $form ) ) {
1899 1899
 			return $form;
1900 1900
 		}
1901 1901
 
1902 1902
 		// Have Conditional Logic pre-fill fields as if the data were default values
1903 1903
 		/** @var GF_Field $field */
1904
-		foreach ( $form['fields'] as &$field ) {
1904
+		foreach ( $form[ 'fields' ] as &$field ) {
1905 1905
 
1906
-			if( 'checkbox' === $field->type ) {
1906
+			if ( 'checkbox' === $field->type ) {
1907 1907
 				foreach ( $field->get_entry_inputs() as $key => $input ) {
1908
-				    $input_id = $input['id'];
1908
+				    $input_id = $input[ 'id' ];
1909 1909
 				    $choice = $field->choices[ $key ];
1910 1910
 				    $value = \GV\Utils::get( $this->entry, $input_id );
1911 1911
 				    $match = RGFormsModel::choice_value_match( $field, $choice, $value );
1912
-				    if( $match ) {
1913
-				        $field->choices[ $key ]['isSelected'] = true;
1912
+				    if ( $match ) {
1913
+				        $field->choices[ $key ][ 'isSelected' ] = true;
1914 1914
 				    }
1915 1915
 				}
1916 1916
 			} else {
@@ -1918,15 +1918,15 @@  discard block
 block discarded – undo
1918 1918
 				// We need to run through each field to set the default values
1919 1919
 				foreach ( $this->entry as $field_id => $field_value ) {
1920 1920
 
1921
-				    if( floatval( $field_id ) === floatval( $field->id ) ) {
1921
+				    if ( floatval( $field_id ) === floatval( $field->id ) ) {
1922 1922
 
1923
-				        if( 'list' === $field->type ) {
1923
+				        if ( 'list' === $field->type ) {
1924 1924
 				            $list_rows = maybe_unserialize( $field_value );
1925 1925
 
1926 1926
 				            $list_field_value = array();
1927
-				            foreach ( (array) $list_rows as $row ) {
1928
-				                foreach ( (array) $row as $column ) {
1929
-				                    $list_field_value[] = $column;
1927
+				            foreach ( (array)$list_rows as $row ) {
1928
+				                foreach ( (array)$row as $column ) {
1929
+				                    $list_field_value[ ] = $column;
1930 1930
 				                }
1931 1931
 				            }
1932 1932
 
@@ -1959,32 +1959,32 @@  discard block
 block discarded – undo
1959 1959
 		 * @see https://github.com/gravityview/GravityView/issues/840
1960 1960
 		 * @since develop
1961 1961
 		 */
1962
-		$the_form = GFAPI::get_form( $form['id'] );
1962
+		$the_form = GFAPI::get_form( $form[ 'id' ] );
1963 1963
 		$editable_ids = array();
1964
-		foreach ( $form['fields'] as $field ) {
1965
-			$editable_ids[] = $field['id']; // wp_list_pluck is destructive in this context
1964
+		foreach ( $form[ 'fields' ] as $field ) {
1965
+			$editable_ids[ ] = $field[ 'id' ]; // wp_list_pluck is destructive in this context
1966 1966
 		}
1967 1967
 		$remove_conditions_rule = array();
1968
-		foreach ( $the_form['fields'] as $field ) {
1969
-			if ( ! empty( $field->conditionalLogic ) && ! empty( $field->conditionalLogic['rules'] ) ) {
1970
-				foreach ( $field->conditionalLogic['rules'] as $i => $rule ) {
1971
-					if ( ! in_array( $rule['fieldId'], $editable_ids ) ) {
1968
+		foreach ( $the_form[ 'fields' ] as $field ) {
1969
+			if ( ! empty( $field->conditionalLogic ) && ! empty( $field->conditionalLogic[ 'rules' ] ) ) {
1970
+				foreach ( $field->conditionalLogic[ 'rules' ] as $i => $rule ) {
1971
+					if ( ! in_array( $rule[ 'fieldId' ], $editable_ids ) ) {
1972 1972
 						/**
1973 1973
 						 * This conditional field is not editable in this View.
1974 1974
 						 * We need to remove the rule, but only if it matches.
1975 1975
 						 */
1976
-						if ( $_field = GFAPI::get_field( $the_form, $rule['fieldId'] ) ) {
1976
+						if ( $_field = GFAPI::get_field( $the_form, $rule[ 'fieldId' ] ) ) {
1977 1977
 							$value = $_field->get_value_export( $this->entry );
1978
-						} elseif ( isset( $this->entry[ $rule['fieldId'] ] ) ) {
1979
-							$value = $this->entry[ $rule['fieldId'] ];
1978
+						} elseif ( isset( $this->entry[ $rule[ 'fieldId' ] ] ) ) {
1979
+							$value = $this->entry[ $rule[ 'fieldId' ] ];
1980 1980
 						} else {
1981
-							$value = gform_get_meta( $this->entry['id'], $rule['fieldId'] );
1981
+							$value = gform_get_meta( $this->entry[ 'id' ], $rule[ 'fieldId' ] );
1982 1982
 						}
1983 1983
 
1984
-						$match = GFFormsModel::matches_operation( $value, $rule['value'], $rule['operator'] );
1984
+						$match = GFFormsModel::matches_operation( $value, $rule[ 'value' ], $rule[ 'operator' ] );
1985 1985
 						
1986 1986
 						if ( $match ) {
1987
-							$remove_conditions_rule[] = array( $field['id'], $i );
1987
+							$remove_conditions_rule[ ] = array( $field[ 'id' ], $i );
1988 1988
 						}
1989 1989
 					}
1990 1990
 				}
@@ -1992,21 +1992,21 @@  discard block
 block discarded – undo
1992 1992
 		}
1993 1993
 
1994 1994
 		if ( $remove_conditions_rule ) {
1995
-			foreach ( $form['fields'] as &$field ) {
1995
+			foreach ( $form[ 'fields' ] as &$field ) {
1996 1996
 				foreach ( $remove_conditions_rule as $_remove_conditions_r ) {
1997 1997
 
1998 1998
 				    list( $rule_field_id, $rule_i ) = $_remove_conditions_r;
1999 1999
 
2000
-					if ( $field['id'] == $rule_field_id ) {
2001
-						unset( $field->conditionalLogic['rules'][ $rule_i ] );
2002
-						gravityview()->log->debug( 'Removed conditional rule #{rule} for field {field_id}', array( 'rule' => $rule_i, 'field_id' => $field['id'] ) );
2000
+					if ( $field[ 'id' ] == $rule_field_id ) {
2001
+						unset( $field->conditionalLogic[ 'rules' ][ $rule_i ] );
2002
+						gravityview()->log->debug( 'Removed conditional rule #{rule} for field {field_id}', array( 'rule' => $rule_i, 'field_id' => $field[ 'id' ] ) );
2003 2003
 					}
2004 2004
 				}
2005 2005
 			}
2006 2006
 		}
2007 2007
 
2008 2008
 		/** Normalize the indices... */
2009
-		$form['fields'] = array_values( $form['fields'] );
2009
+		$form[ 'fields' ] = array_values( $form[ 'fields' ] );
2010 2010
 
2011 2011
 		/**
2012 2012
 		 * @filter `gravityview/edit_entry/conditional_logic` Should the Edit Entry form use Gravity Forms conditional logic showing/hiding of fields?
@@ -2016,16 +2016,16 @@  discard block
 block discarded – undo
2016 2016
 		 */
2017 2017
 		$use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
2018 2018
 
2019
-		if( $use_conditional_logic ) {
2019
+		if ( $use_conditional_logic ) {
2020 2020
 			return $form;
2021 2021
 		}
2022 2022
 
2023
-		foreach( $form['fields'] as &$field ) {
2023
+		foreach ( $form[ 'fields' ] as &$field ) {
2024 2024
 			/* @var GF_Field $field */
2025 2025
 			$field->conditionalLogic = null;
2026 2026
 		}
2027 2027
 
2028
-		unset( $form['button']['conditionalLogic'] );
2028
+		unset( $form[ 'button' ][ 'conditionalLogic' ] );
2029 2029
 
2030 2030
 		return $form;
2031 2031
 
@@ -2042,7 +2042,7 @@  discard block
 block discarded – undo
2042 2042
 	 */
2043 2043
 	public function manage_conditional_logic( $has_conditional_logic, $form ) {
2044 2044
 
2045
-		if( ! $this->is_edit_entry() ) {
2045
+		if ( ! $this->is_edit_entry() ) {
2046 2046
 			return $has_conditional_logic;
2047 2047
 		}
2048 2048
 
@@ -2074,44 +2074,44 @@  discard block
 block discarded – undo
2074 2074
 		 *  2. There are two entries embedded using oEmbed
2075 2075
 		 *  3. One of the entries has just been saved
2076 2076
 		 */
2077
-		if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
2077
+		if ( ! empty( $_POST[ 'lid' ] ) && ! empty( $_GET[ 'entry' ] ) && ( $_POST[ 'lid' ] !== $_GET[ 'entry' ] ) ) {
2078 2078
 
2079 2079
 			$error = true;
2080 2080
 
2081 2081
 		}
2082 2082
 
2083
-		if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
2083
+		if ( ! empty( $_GET[ 'entry' ] ) && (string)$this->entry[ 'id' ] !== $_GET[ 'entry' ] ) {
2084 2084
 
2085 2085
 			$error = true;
2086 2086
 
2087
-		} elseif( ! $this->verify_nonce() ) {
2087
+		} elseif ( ! $this->verify_nonce() ) {
2088 2088
 
2089 2089
 			/**
2090 2090
 			 * If the Entry is embedded, there may be two entries on the same page.
2091 2091
 			 * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
2092 2092
 			 */
2093
-			if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
2093
+			if ( GravityView_oEmbed::getInstance()->get_entry_id() ) {
2094 2094
 				$error = true;
2095 2095
 			} else {
2096
-				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
2096
+				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview' );
2097 2097
 			}
2098 2098
 
2099 2099
 		}
2100 2100
 
2101
-		if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
2102
-			$error = __( 'You do not have permission to edit this entry.', 'gravityview');
2101
+		if ( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
2102
+			$error = __( 'You do not have permission to edit this entry.', 'gravityview' );
2103 2103
 		}
2104 2104
 
2105
-		if( $this->entry['status'] === 'trash' ) {
2106
-			$error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
2105
+		if ( $this->entry[ 'status' ] === 'trash' ) {
2106
+			$error = __( 'You cannot edit the entry; it is in the trash.', 'gravityview' );
2107 2107
 		}
2108 2108
 
2109 2109
 		// No errors; everything's fine here!
2110
-		if( empty( $error ) ) {
2110
+		if ( empty( $error ) ) {
2111 2111
 			return true;
2112 2112
 		}
2113 2113
 
2114
-		if( $echo && $error !== true ) {
2114
+		if ( $echo && $error !== true ) {
2115 2115
 
2116 2116
 	        $error = esc_html( $error );
2117 2117
 
@@ -2119,10 +2119,10 @@  discard block
 block discarded – undo
2119 2119
 	         * @since 1.9
2120 2120
 	         */
2121 2121
 	        if ( ! empty( $this->entry ) ) {
2122
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2122
+		        $error .= ' ' . gravityview_get_link( '#', _x( 'Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2123 2123
 	        }
2124 2124
 
2125
-			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
2125
+			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error' );
2126 2126
 		}
2127 2127
 
2128 2128
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2142,17 +2142,17 @@  discard block
 block discarded – undo
2142 2142
 
2143 2143
 		$error = NULL;
2144 2144
 
2145
-		if( ! $this->check_user_cap_edit_field( $field ) ) {
2146
-			$error = __( 'You do not have permission to edit this field.', 'gravityview');
2145
+		if ( ! $this->check_user_cap_edit_field( $field ) ) {
2146
+			$error = __( 'You do not have permission to edit this field.', 'gravityview' );
2147 2147
 		}
2148 2148
 
2149 2149
 		// No errors; everything's fine here!
2150
-		if( empty( $error ) ) {
2150
+		if ( empty( $error ) ) {
2151 2151
 			return true;
2152 2152
 		}
2153 2153
 
2154
-		if( $echo ) {
2155
-			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
2154
+		if ( $echo ) {
2155
+			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error' );
2156 2156
 		}
2157 2157
 
2158 2158
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2173,14 +2173,14 @@  discard block
 block discarded – undo
2173 2173
 	private function check_user_cap_edit_field( $field ) {
2174 2174
 
2175 2175
 		// If they can edit any entries (as defined in Gravity Forms), we're good.
2176
-		if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2176
+		if ( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2177 2177
 			return true;
2178 2178
 		}
2179 2179
 
2180
-		$field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
2180
+		$field_cap = isset( $field[ 'allow_edit_cap' ] ) ? $field[ 'allow_edit_cap' ] : false;
2181 2181
 
2182
-		if( $field_cap ) {
2183
-			return GVCommon::has_cap( $field['allow_edit_cap'] );
2182
+		if ( $field_cap ) {
2183
+			return GVCommon::has_cap( $field[ 'allow_edit_cap' ] );
2184 2184
 		}
2185 2185
 
2186 2186
 		return false;
@@ -2194,17 +2194,17 @@  discard block
 block discarded – undo
2194 2194
 	public function verify_nonce() {
2195 2195
 
2196 2196
 		// Verify form submitted for editing single
2197
-		if( $this->is_edit_entry_submission() ) {
2197
+		if ( $this->is_edit_entry_submission() ) {
2198 2198
 			$valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
2199 2199
 		}
2200 2200
 
2201 2201
 		// Verify
2202
-		else if( ! $this->is_edit_entry() ) {
2202
+		else if ( ! $this->is_edit_entry() ) {
2203 2203
 			$valid = false;
2204 2204
 		}
2205 2205
 
2206 2206
 		else {
2207
-			$valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
2207
+			$valid = wp_verify_nonce( $_GET[ 'edit' ], self::$nonce_key );
2208 2208
 		}
2209 2209
 
2210 2210
 		/**
Please login to merge, or discard this patch.
Indentation   +289 added lines, -289 removed lines patch added patch discarded remove patch
@@ -102,10 +102,10 @@  discard block
 block discarded – undo
102 102
 
103 103
 	/**
104 104
 	 * ID of the current post. May also be ID of the current View.
105
-     *
106
-     * @since 2.0.13
107
-     * 
108
-     * @var int
105
+	 *
106
+	 * @since 2.0.13
107
+	 * 
108
+	 * @var int
109 109
 	 */
110 110
 	public $post_id;
111 111
 
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 	 */
177 177
 	public function prevent_maybe_process_form() {
178 178
 
179
-	    if( ! $this->is_edit_entry_submission() ) {
179
+		if( ! $this->is_edit_entry_submission() ) {
180 180
 			return;
181 181
 		}
182 182
 
@@ -210,14 +210,14 @@  discard block
 block discarded – undo
210 210
 	 * When Edit entry view is requested setup the vars
211 211
 	 */
212 212
 	private function setup_vars() {
213
-        global $post;
213
+		global $post;
214 214
 
215 215
 		$gravityview_view = GravityView_View::getInstance();
216 216
 
217 217
 
218 218
 		$entries = $gravityview_view->getEntries();
219
-	    self::$original_entry = $entries[0];
220
-	    $this->entry = $entries[0];
219
+		self::$original_entry = $entries[0];
220
+		$this->entry = $entries[0];
221 221
 
222 222
 		self::$original_form = $gravityview_view->getForm();
223 223
 		$this->form = $gravityview_view->getForm();
@@ -359,8 +359,8 @@  discard block
 block discarded – undo
359 359
 
360 360
 			GFFormsModel::save_lead( $form, $this->entry );
361 361
 
362
-	        // Delete the values for hidden inputs
363
-	        $this->unset_hidden_field_values();
362
+			// Delete the values for hidden inputs
363
+			$this->unset_hidden_field_values();
364 364
 			
365 365
 			$this->entry['date_created'] = $date_created;
366 366
 
@@ -370,7 +370,7 @@  discard block
 block discarded – undo
370 370
 			// Perform actions normally performed after updating a lead
371 371
 			$this->after_update();
372 372
 
373
-	        /**
373
+			/**
374 374
 			 * Must be AFTER after_update()!
375 375
 			 * @see https://github.com/gravityview/GravityView/issues/764
376 376
 			 */
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
 
379 379
 			/**
380 380
 			 * @action `gravityview/edit_entry/after_update` Perform an action after the entry has been updated using Edit Entry
381
-             * @since 2.1 Added $gv_data parameter
381
+			 * @since 2.1 Added $gv_data parameter
382 382
 			 * @param array $form Gravity Forms form array
383 383
 			 * @param string $entry_id Numeric ID of the entry that was updated
384 384
 			 * @param GravityView_Edit_Entry_Render $this This object
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
 	 * @return void
403 403
 	 */
404 404
 	private function unset_hidden_field_values() {
405
-	    global $wpdb;
405
+		global $wpdb;
406 406
 
407 407
 		/**
408 408
 		 * @filter `gravityview/edit_entry/unset_hidden_field_values` Whether to delete values of fields hidden by conditional logic
@@ -424,33 +424,33 @@  discard block
 block discarded – undo
424 424
 			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry['id'] ) );
425 425
 		}
426 426
 
427
-	    foreach ( $this->entry as $input_id => $field_value ) {
427
+		foreach ( $this->entry as $input_id => $field_value ) {
428 428
 
429 429
 			if ( ! is_numeric( $input_id ) ) {
430 430
 				continue;
431 431
 			}
432 432
 
433
-		    $field = RGFormsModel::get_field( $this->form, $input_id );
433
+			$field = RGFormsModel::get_field( $this->form, $input_id );
434 434
 
435
-		    // Reset fields that are hidden
436
-		    // Don't pass $entry as fourth parameter; force using $_POST values to calculate conditional logic
437
-		    if ( GFFormsModel::is_field_hidden( $this->form, $field, array(), NULL ) ) {
435
+			// Reset fields that are hidden
436
+			// Don't pass $entry as fourth parameter; force using $_POST values to calculate conditional logic
437
+			if ( GFFormsModel::is_field_hidden( $this->form, $field, array(), NULL ) ) {
438 438
 
439 439
 				$empty_value = $field->get_value_save_entry(
440 440
 					is_array( $field->get_entry_inputs() ) ? array() : '',
441 441
 					$this->form, '', $this->entry['id'], $this->entry
442 442
 				);
443 443
 
444
-			    $lead_detail_id = GFFormsModel::get_lead_detail_id( $current_fields, $input_id );
444
+				$lead_detail_id = GFFormsModel::get_lead_detail_id( $current_fields, $input_id );
445 445
 
446
-			    GFFormsModel::update_lead_field_value( $this->form, $this->entry, $field, $lead_detail_id, $input_id, $empty_value );
446
+				GFFormsModel::update_lead_field_value( $this->form, $this->entry, $field, $lead_detail_id, $input_id, $empty_value );
447 447
 
448
-			    // Prevent the $_POST values of hidden fields from being used as default values when rendering the form
448
+				// Prevent the $_POST values of hidden fields from being used as default values when rendering the form
449 449
 				// after submission
450
-			    $post_input_id = 'input_' . str_replace( '.', '_', $input_id );
451
-			    $_POST[ $post_input_id ] = '';
452
-		    }
453
-	    }
450
+				$post_input_id = 'input_' . str_replace( '.', '_', $input_id );
451
+				$_POST[ $post_input_id ] = '';
452
+			}
453
+		}
454 454
 	}
455 455
 
456 456
 	/**
@@ -544,7 +544,7 @@  discard block
 block discarded – undo
544 544
 
545 545
 		$form = $this->filter_conditional_logic( $this->form );
546 546
 
547
-	    /** @var GF_Field $field */
547
+		/** @var GF_Field $field */
548 548
 		foreach( $form['fields'] as $k => &$field ) {
549 549
 
550 550
 			/**
@@ -560,7 +560,7 @@  discard block
 block discarded – undo
560 560
 
561 561
 			if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
562 562
 				foreach( $field->inputs as $key => $input ) {
563
-				    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
563
+					$field->inputs[ $key ][ 'id' ] = (string)$input['id'];
564 564
 				}
565 565
 			}
566 566
 		}
@@ -595,7 +595,7 @@  discard block
 block discarded – undo
595 595
 			foreach ( $this->fields_with_calculation as $field ) {
596 596
 				$inputs = $field->get_entry_inputs();
597 597
 				if ( is_array( $inputs ) ) {
598
-				    foreach ( $inputs as $input ) {
598
+					foreach ( $inputs as $input ) {
599 599
 						list( $field_id, $input_id ) = rgexplode( '.', $input['id'], 2 );
600 600
 
601 601
 						if ( 'product' === $field->type ) {
@@ -614,7 +614,7 @@  discard block
 block discarded – undo
614 614
 						}
615 615
 
616 616
 						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input['id'] );
617
-				    }
617
+					}
618 618
 				} else {
619 619
 					// Set to what it previously was if it's not editable
620 620
 					if ( ! in_array( $field->id, $allowed_fields ) ) {
@@ -660,7 +660,7 @@  discard block
 block discarded – undo
660 660
 			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
661 661
 
662 662
 			$ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
663
-	        $ary = stripslashes_deep( $ary );
663
+			$ary = stripslashes_deep( $ary );
664 664
 			$img_url = \GV\Utils::get( $ary, 0 );
665 665
 
666 666
 			$img_title       = count( $ary ) > 1 ? $ary[1] : '';
@@ -733,7 +733,7 @@  discard block
 block discarded – undo
733 733
 	private function maybe_update_post_fields( $form ) {
734 734
 
735 735
 		if( empty( $this->entry['post_id'] ) ) {
736
-	        gravityview()->log->debug( 'This entry has no post fields. Continuing...' );
736
+			gravityview()->log->debug( 'This entry has no post fields. Continuing...' );
737 737
 			return;
738 738
 		}
739 739
 
@@ -768,49 +768,49 @@  discard block
 block discarded – undo
768 768
 
769 769
 				switch( $field->type ) {
770 770
 
771
-				    case 'post_title':
772
-				        $post_title = $value;
773
-				        if ( \GV\Utils::get( $form, 'postTitleTemplateEnabled' ) ) {
774
-				            $post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
775
-				        }
776
-				        $updated_post->post_title = $post_title;
777
-				        $updated_post->post_name  = $post_title;
778
-				        unset( $post_title );
779
-				        break;
780
-
781
-				    case 'post_content':
782
-				        $post_content = $value;
783
-				        if ( \GV\Utils::get( $form, 'postContentTemplateEnabled' ) ) {
784
-				            $post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
785
-				        }
786
-				        $updated_post->post_content = $post_content;
787
-				        unset( $post_content );
788
-				        break;
789
-				    case 'post_excerpt':
790
-				        $updated_post->post_excerpt = $value;
791
-				        break;
792
-				    case 'post_tags':
793
-				        wp_set_post_tags( $post_id, $value, false );
794
-				        break;
795
-				    case 'post_category':
796
-				        break;
797
-				    case 'post_custom_field':
771
+					case 'post_title':
772
+						$post_title = $value;
773
+						if ( \GV\Utils::get( $form, 'postTitleTemplateEnabled' ) ) {
774
+							$post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
775
+						}
776
+						$updated_post->post_title = $post_title;
777
+						$updated_post->post_name  = $post_title;
778
+						unset( $post_title );
779
+						break;
780
+
781
+					case 'post_content':
782
+						$post_content = $value;
783
+						if ( \GV\Utils::get( $form, 'postContentTemplateEnabled' ) ) {
784
+							$post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
785
+						}
786
+						$updated_post->post_content = $post_content;
787
+						unset( $post_content );
788
+						break;
789
+					case 'post_excerpt':
790
+						$updated_post->post_excerpt = $value;
791
+						break;
792
+					case 'post_tags':
793
+						wp_set_post_tags( $post_id, $value, false );
794
+						break;
795
+					case 'post_category':
796
+						break;
797
+					case 'post_custom_field':
798 798
 						if ( is_array( $value ) && ( floatval( $field_id ) !== floatval( $field->id ) ) ) {
799 799
 							$value = $value[ $field_id ];
800 800
 						}
801 801
 
802
-				        if( ! empty( $field->customFieldTemplateEnabled ) ) {
803
-				            $value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
804
-				        }
802
+						if( ! empty( $field->customFieldTemplateEnabled ) ) {
803
+							$value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
804
+						}
805 805
 
806 806
 						$value = $field->get_value_save_entry( $value, $form, '', $this->entry['id'], $this->entry );
807 807
 
808
-				        update_post_meta( $post_id, $field->postCustomFieldName, $value );
809
-				        break;
808
+						update_post_meta( $post_id, $field->postCustomFieldName, $value );
809
+						break;
810 810
 
811
-				    case 'post_image':
812
-				        $value = $this->update_post_image( $form, $field, $field_id, $value, $this->entry, $post_id );
813
-				        break;
811
+					case 'post_image':
812
+						$value = $this->update_post_image( $form, $field, $field_id, $value, $this->entry, $post_id );
813
+						break;
814 814
 
815 815
 				}
816 816
 
@@ -967,14 +967,14 @@  discard block
 block discarded – undo
967 967
 			?><h2 class="gv-edit-entry-title">
968 968
 				<span><?php
969 969
 
970
-				    /**
971
-				     * @filter `gravityview_edit_entry_title` Modify the edit entry title
972
-				     * @param string $edit_entry_title Modify the "Edit Entry" title
973
-				     * @param GravityView_Edit_Entry_Render $this This object
974
-				     */
975
-				    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
970
+					/**
971
+					 * @filter `gravityview_edit_entry_title` Modify the edit entry title
972
+					 * @param string $edit_entry_title Modify the "Edit Entry" title
973
+					 * @param GravityView_Edit_Entry_Render $this This object
974
+					 */
975
+					$edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
976 976
 
977
-				    echo esc_attr( $edit_entry_title );
977
+					echo esc_attr( $edit_entry_title );
978 978
 			?></span>
979 979
 			</h2>
980 980
 
@@ -1037,26 +1037,26 @@  discard block
 block discarded – undo
1037 1037
 
1038 1038
 				switch ( $edit_redirect ) {
1039 1039
 
1040
-                    case '0':
1041
-	                    $redirect_url = $back_link;
1042
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview'), '<a href="'. esc_url( $redirect_url ) .'">', '</a>' );
1043
-                        break;
1044
-
1045
-                    case '1':
1046
-	                    $redirect_url = $directory_link = GravityView_API::directory_link();
1047
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1048
-	                    break;
1049
-
1050
-                    case '2':
1051
-	                    $redirect_url = $edit_redirect_url;
1052
-	                    $redirect_url = GFCommon::replace_variables( $redirect_url, $this->form, $this->entry, false, false, false, 'text' );
1053
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1054
-                        break;
1055
-
1056
-                    case '':
1057
-                    default:
1058
-					    $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. esc_url( $back_link ) .'">', '</a>' );
1059
-                        break;
1040
+					case '0':
1041
+						$redirect_url = $back_link;
1042
+						$entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview'), '<a href="'. esc_url( $redirect_url ) .'">', '</a>' );
1043
+						break;
1044
+
1045
+					case '1':
1046
+						$redirect_url = $directory_link = GravityView_API::directory_link();
1047
+						$entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1048
+						break;
1049
+
1050
+					case '2':
1051
+						$redirect_url = $edit_redirect_url;
1052
+						$redirect_url = GFCommon::replace_variables( $redirect_url, $this->form, $this->entry, false, false, false, 'text' );
1053
+						$entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1054
+						break;
1055
+
1056
+					case '':
1057
+					default:
1058
+						$entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. esc_url( $back_link ) .'">', '</a>' );
1059
+						break;
1060 1060
 				}
1061 1061
 
1062 1062
 				if ( isset( $redirect_url ) ) {
@@ -1113,7 +1113,7 @@  discard block
 block discarded – undo
1113 1113
 
1114 1114
 		ob_get_clean();
1115 1115
 
1116
-	    remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
1116
+		remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
1117 1117
 		remove_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
1118 1118
 		remove_filter( 'gform_disable_view_counter', '__return_true' );
1119 1119
 		remove_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5 );
@@ -1167,7 +1167,7 @@  discard block
 block discarded – undo
1167 1167
 
1168 1168
 		// for now we don't support Save and Continue feature.
1169 1169
 		if( ! self::$supports_save_and_continue ) {
1170
-	        unset( $form['save'] );
1170
+			unset( $form['save'] );
1171 1171
 		}
1172 1172
 
1173 1173
 		$form = $this->unselect_default_values( $form );
@@ -1194,30 +1194,30 @@  discard block
 block discarded – undo
1194 1194
 			return $field_content;
1195 1195
 		}
1196 1196
 
1197
-        $message = null;
1197
+		$message = null;
1198 1198
 
1199
-        // First, make sure they have the capability to edit the post.
1200
-        if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1199
+		// First, make sure they have the capability to edit the post.
1200
+		if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1201 1201
 
1202
-            /**
1203
-             * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1204
-             * @param string $message The existing "You don't have permission..." text
1205
-             */
1206
-            $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1202
+			/**
1203
+			 * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1204
+			 * @param string $message The existing "You don't have permission..." text
1205
+			 */
1206
+			$message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1207 1207
 
1208
-        } elseif( null === get_post( $this->entry['post_id'] ) ) {
1209
-            /**
1210
-             * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1211
-             * @param string $message The existing "This field is not editable; the post no longer exists." text
1212
-             */
1213
-            $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1214
-        }
1208
+		} elseif( null === get_post( $this->entry['post_id'] ) ) {
1209
+			/**
1210
+			 * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1211
+			 * @param string $message The existing "This field is not editable; the post no longer exists." text
1212
+			 */
1213
+			$message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1214
+		}
1215 1215
 
1216
-        if( $message ) {
1217
-            $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1218
-        }
1216
+		if( $message ) {
1217
+			$field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1218
+		}
1219 1219
 
1220
-        return $field_content;
1220
+		return $field_content;
1221 1221
 	}
1222 1222
 
1223 1223
 	/**
@@ -1245,7 +1245,7 @@  discard block
 block discarded – undo
1245 1245
 			|| ! empty( $field_content )
1246 1246
 			|| in_array( $field->type, array( 'honeypot' ) )
1247 1247
 		) {
1248
-	        return $field_content;
1248
+			return $field_content;
1249 1249
 		}
1250 1250
 
1251 1251
 		// SET SOME FIELD DEFAULTS TO PREVENT ISSUES
@@ -1253,24 +1253,24 @@  discard block
 block discarded – undo
1253 1253
 
1254 1254
 		$field_value = $this->get_field_value( $field );
1255 1255
 
1256
-	    // Prevent any PHP warnings, like undefined index
1257
-	    ob_start();
1256
+		// Prevent any PHP warnings, like undefined index
1257
+		ob_start();
1258 1258
 
1259
-	    $return = null;
1259
+		$return = null;
1260 1260
 
1261 1261
 		/** @var GravityView_Field $gv_field */
1262 1262
 		if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1263 1263
 			$return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1264 1264
 		} else {
1265
-	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
1266
-	    }
1265
+			$return = $field->get_field_input( $this->form, $field_value, $this->entry );
1266
+		}
1267 1267
 
1268
-	    // If there was output, it's an error
1269
-	    $warnings = ob_get_clean();
1268
+		// If there was output, it's an error
1269
+		$warnings = ob_get_clean();
1270 1270
 
1271
-	    if( !empty( $warnings ) ) {
1272
-		    gravityview()->log->error( '{warning}', array( 'warning' => $warnings, 'data' => $field_value ) );
1273
-	    }
1271
+		if( !empty( $warnings ) ) {
1272
+			gravityview()->log->error( '{warning}', array( 'warning' => $warnings, 'data' => $field_value ) );
1273
+		}
1274 1274
 
1275 1275
 		return $return;
1276 1276
 	}
@@ -1305,8 +1305,8 @@  discard block
 block discarded – undo
1305 1305
 				$input_id = strval( $input['id'] );
1306 1306
 
1307 1307
 				if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1308
-				    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1309
-				    $allow_pre_populated = false;
1308
+					$field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1309
+					$allow_pre_populated = false;
1310 1310
 				}
1311 1311
 
1312 1312
 			}
@@ -1330,7 +1330,7 @@  discard block
 block discarded – undo
1330 1330
 			if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1331 1331
 				$categories = array();
1332 1332
 				foreach ( explode( ',', $field_value ) as $cat_string ) {
1333
-				    $categories[] = GFCommon::format_post_category( $cat_string, true );
1333
+					$categories[] = GFCommon::format_post_category( $cat_string, true );
1334 1334
 				}
1335 1335
 				$field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1336 1336
 			}
@@ -1340,25 +1340,25 @@  discard block
 block discarded – undo
1340 1340
 		// if value is empty get the default value if defined
1341 1341
 		$field_value = $field->get_value_default_if_empty( $field_value );
1342 1342
 
1343
-	    /**
1344
-	     * @filter `gravityview/edit_entry/field_value` Change the value of an Edit Entry field, if needed
1345
-	     * @since 1.11
1346
-	     * @since 1.20 Added third param
1347
-	     * @param mixed $field_value field value used to populate the input
1348
-	     * @param object $field Gravity Forms field object ( Class GF_Field )
1349
-	     * @param GravityView_Edit_Entry_Render $this Current object
1350
-	     */
1351
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value', $field_value, $field, $this );
1352
-
1353
-	    /**
1354
-	     * @filter `gravityview/edit_entry/field_value_{field_type}` Change the value of an Edit Entry field for a specific field type
1355
-	     * @since 1.17
1356
-	     * @since 1.20 Added third param
1357
-	     * @param mixed $field_value field value used to populate the input
1358
-	     * @param GF_Field $field Gravity Forms field object
1359
-	     * @param GravityView_Edit_Entry_Render $this Current object
1360
-	     */
1361
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1343
+		/**
1344
+		 * @filter `gravityview/edit_entry/field_value` Change the value of an Edit Entry field, if needed
1345
+		 * @since 1.11
1346
+		 * @since 1.20 Added third param
1347
+		 * @param mixed $field_value field value used to populate the input
1348
+		 * @param object $field Gravity Forms field object ( Class GF_Field )
1349
+		 * @param GravityView_Edit_Entry_Render $this Current object
1350
+		 */
1351
+		$field_value = apply_filters( 'gravityview/edit_entry/field_value', $field_value, $field, $this );
1352
+
1353
+		/**
1354
+		 * @filter `gravityview/edit_entry/field_value_{field_type}` Change the value of an Edit Entry field for a specific field type
1355
+		 * @since 1.17
1356
+		 * @since 1.20 Added third param
1357
+		 * @param mixed $field_value field value used to populate the input
1358
+		 * @param GF_Field $field Gravity Forms field object
1359
+		 * @param GravityView_Edit_Entry_Render $this Current object
1360
+		 */
1361
+		$field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1362 1362
 
1363 1363
 		return $field_value;
1364 1364
 	}
@@ -1385,7 +1385,7 @@  discard block
 block discarded – undo
1385 1385
 			// This is because we're doing admin form pretending to be front-end, so Gravity Forms
1386 1386
 			// expects certain field array items to be set.
1387 1387
 			foreach ( array( 'noDuplicates', 'adminOnly', 'inputType', 'isRequired', 'enablePrice', 'inputs', 'allowedExtensions' ) as $key ) {
1388
-	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1388
+				$field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1389 1389
 			}
1390 1390
 
1391 1391
 			switch( RGFormsModel::get_input_type( $field ) ) {
@@ -1399,61 +1399,61 @@  discard block
 block discarded – undo
1399 1399
 				 */
1400 1400
 				case 'fileupload':
1401 1401
 
1402
-				    // Set the previous value
1403
-				    $entry = $this->get_entry();
1402
+					// Set the previous value
1403
+					$entry = $this->get_entry();
1404 1404
 
1405
-				    $input_name = 'input_'.$field->id;
1406
-				    $form_id = $form['id'];
1405
+					$input_name = 'input_'.$field->id;
1406
+					$form_id = $form['id'];
1407 1407
 
1408
-				    $value = NULL;
1408
+					$value = NULL;
1409 1409
 
1410
-				    // Use the previous entry value as the default.
1411
-				    if( isset( $entry[ $field->id ] ) ) {
1412
-				        $value = $entry[ $field->id ];
1413
-				    }
1410
+					// Use the previous entry value as the default.
1411
+					if( isset( $entry[ $field->id ] ) ) {
1412
+						$value = $entry[ $field->id ];
1413
+					}
1414 1414
 
1415
-				    // If this is a single upload file
1416
-				    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1417
-				        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1418
-				        $value = $file_path['url'];
1415
+					// If this is a single upload file
1416
+					if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1417
+						$file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1418
+						$value = $file_path['url'];
1419 1419
 
1420
-				    } else {
1420
+					} else {
1421 1421
 
1422
-				        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1423
-				        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1424
-				        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1422
+						// Fix PHP warning on line 1498 of form_display.php for post_image fields
1423
+						// Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1424
+						$_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1425 1425
 
1426
-				    }
1426
+					}
1427 1427
 
1428
-				    if ( \GV\Utils::get( $field, "multipleFiles" ) ) {
1428
+					if ( \GV\Utils::get( $field, "multipleFiles" ) ) {
1429 1429
 
1430
-				        // If there are fresh uploads, process and merge them.
1431
-				        // Otherwise, use the passed values, which should be json-encoded array of URLs
1432
-				        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1433
-				            $value = empty( $value ) ? '[]' : $value;
1434
-				            $value = stripslashes_deep( $value );
1435
-				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1436
-				        }
1430
+						// If there are fresh uploads, process and merge them.
1431
+						// Otherwise, use the passed values, which should be json-encoded array of URLs
1432
+						if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1433
+							$value = empty( $value ) ? '[]' : $value;
1434
+							$value = stripslashes_deep( $value );
1435
+							$value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1436
+						}
1437 1437
 
1438
-				    } else {
1438
+					} else {
1439 1439
 
1440
-				        // A file already exists when editing an entry
1441
-				        // We set this to solve issue when file upload fields are required.
1442
-				        GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $value;
1440
+						// A file already exists when editing an entry
1441
+						// We set this to solve issue when file upload fields are required.
1442
+						GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $value;
1443 1443
 
1444
-				    }
1444
+					}
1445 1445
 
1446
-				    $this->entry[ $input_name ] = $value;
1447
-				    $_POST[ $input_name ] = $value;
1446
+					$this->entry[ $input_name ] = $value;
1447
+					$_POST[ $input_name ] = $value;
1448 1448
 
1449
-				    break;
1449
+					break;
1450 1450
 
1451 1451
 				case 'number':
1452
-				    // Fix "undefined index" issue at line 1286 in form_display.php
1453
-				    if( !isset( $_POST['input_'.$field->id ] ) ) {
1454
-				        $_POST['input_'.$field->id ] = NULL;
1455
-				    }
1456
-				    break;
1452
+					// Fix "undefined index" issue at line 1286 in form_display.php
1453
+					if( !isset( $_POST['input_'.$field->id ] ) ) {
1454
+						$_POST['input_'.$field->id ] = NULL;
1455
+					}
1456
+					break;
1457 1457
 			}
1458 1458
 
1459 1459
 		}
@@ -1538,43 +1538,43 @@  discard block
 block discarded – undo
1538 1538
 				case 'fileupload' :
1539 1539
 				case 'post_image':
1540 1540
 
1541
-				    // in case nothing is uploaded but there are already files saved
1542
-				    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1543
-				        $field->failed_validation = false;
1544
-				        unset( $field->validation_message );
1545
-				    }
1541
+					// in case nothing is uploaded but there are already files saved
1542
+					if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1543
+						$field->failed_validation = false;
1544
+						unset( $field->validation_message );
1545
+					}
1546 1546
 
1547
-				    // validate if multi file upload reached max number of files [maxFiles] => 2
1548
-				    if( \GV\Utils::get( $field, 'maxFiles') && \GV\Utils::get( $field, 'multipleFiles') ) {
1547
+					// validate if multi file upload reached max number of files [maxFiles] => 2
1548
+					if( \GV\Utils::get( $field, 'maxFiles') && \GV\Utils::get( $field, 'multipleFiles') ) {
1549 1549
 
1550
-				        $input_name = 'input_' . $field->id;
1551
-				        //uploaded
1552
-				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1550
+						$input_name = 'input_' . $field->id;
1551
+						//uploaded
1552
+						$file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1553 1553
 
1554
-				        //existent
1555
-				        $entry = $this->get_entry();
1556
-				        $value = NULL;
1557
-				        if( isset( $entry[ $field->id ] ) ) {
1558
-				            $value = json_decode( $entry[ $field->id ], true );
1559
-				        }
1554
+						//existent
1555
+						$entry = $this->get_entry();
1556
+						$value = NULL;
1557
+						if( isset( $entry[ $field->id ] ) ) {
1558
+							$value = json_decode( $entry[ $field->id ], true );
1559
+						}
1560 1560
 
1561
-				        // count uploaded files and existent entry files
1562
-				        $count_files = ( is_array( $file_names ) ? count( $file_names ) : 0 ) +
1563
-						               ( is_array( $value ) ? count( $value ) : 0 );
1561
+						// count uploaded files and existent entry files
1562
+						$count_files = ( is_array( $file_names ) ? count( $file_names ) : 0 ) +
1563
+									   ( is_array( $value ) ? count( $value ) : 0 );
1564 1564
 
1565
-				        if( $count_files > $field->maxFiles ) {
1566
-				            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1567
-				            $field->failed_validation = 1;
1568
-				            $gv_valid = false;
1565
+						if( $count_files > $field->maxFiles ) {
1566
+							$field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1567
+							$field->failed_validation = 1;
1568
+							$gv_valid = false;
1569 1569
 
1570
-				            // in case of error make sure the newest upload files are removed from the upload input
1571
-				            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1572
-				        }
1570
+							// in case of error make sure the newest upload files are removed from the upload input
1571
+							GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1572
+						}
1573 1573
 
1574
-				    }
1574
+					}
1575 1575
 
1576 1576
 
1577
-				    break;
1577
+					break;
1578 1578
 
1579 1579
 			}
1580 1580
 
@@ -1585,47 +1585,47 @@  discard block
 block discarded – undo
1585 1585
 
1586 1586
 				switch ( $field_type ) {
1587 1587
 
1588
-				    // Captchas don't need to be re-entered.
1589
-				    case 'captcha':
1588
+					// Captchas don't need to be re-entered.
1589
+					case 'captcha':
1590 1590
 
1591
-				        // Post Image fields aren't editable, so we un-fail them.
1592
-				    case 'post_image':
1593
-				        $field->failed_validation = false;
1594
-				        unset( $field->validation_message );
1595
-				        break;
1591
+						// Post Image fields aren't editable, so we un-fail them.
1592
+					case 'post_image':
1593
+						$field->failed_validation = false;
1594
+						unset( $field->validation_message );
1595
+						break;
1596 1596
 
1597 1597
 				}
1598 1598
 
1599 1599
 				// You can't continue inside a switch, so we do it after.
1600 1600
 				if( empty( $field->failed_validation ) ) {
1601
-				    continue;
1601
+					continue;
1602 1602
 				}
1603 1603
 
1604 1604
 				// checks if the No Duplicates option is not validating entry against itself, since
1605 1605
 				// we're editing a stored entry, it would also assume it's a duplicate.
1606 1606
 				if( !empty( $field->noDuplicates ) ) {
1607 1607
 
1608
-				    $entry = $this->get_entry();
1608
+					$entry = $this->get_entry();
1609 1609
 
1610
-				    // If the value of the entry is the same as the stored value
1611
-				    // Then we can assume it's not a duplicate, it's the same.
1612
-				    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1613
-				        //if value submitted was not changed, then don't validate
1614
-				        $field->failed_validation = false;
1610
+					// If the value of the entry is the same as the stored value
1611
+					// Then we can assume it's not a duplicate, it's the same.
1612
+					if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1613
+						//if value submitted was not changed, then don't validate
1614
+						$field->failed_validation = false;
1615 1615
 
1616
-				        unset( $field->validation_message );
1616
+						unset( $field->validation_message );
1617 1617
 
1618
-				        gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', array( 'data' => $entry ) );
1618
+						gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', array( 'data' => $entry ) );
1619 1619
 
1620
-				        continue;
1621
-				    }
1620
+						continue;
1621
+					}
1622 1622
 				}
1623 1623
 
1624 1624
 				// if here then probably we are facing the validation 'At least one field must be filled out'
1625 1625
 				if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1626
-				    unset( $field->validation_message );
1627
-	                $field->validation_message = false;
1628
-				    continue;
1626
+					unset( $field->validation_message );
1627
+					$field->validation_message = false;
1628
+					continue;
1629 1629
 				}
1630 1630
 
1631 1631
 				$gv_valid = false;
@@ -1689,8 +1689,8 @@  discard block
 block discarded – undo
1689 1689
 		// Hide fields depending on admin settings
1690 1690
 		$fields = $this->filter_fields( $form['fields'], $edit_fields );
1691 1691
 
1692
-	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1693
-	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
1692
+		// If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1693
+		$fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
1694 1694
 
1695 1695
 		/**
1696 1696
 		 * @filter `gravityview/edit_entry/form_fields` Modify the fields displayed in Edit Entry form
@@ -1765,11 +1765,11 @@  discard block
 block discarded – undo
1765 1765
 		// The edit tab has been configured, so we loop through to configured settings
1766 1766
 		foreach ( $configured_fields as $configured_field ) {
1767 1767
 
1768
-	        /** @var GF_Field $field */
1769
-	        foreach ( $fields as $field ) {
1768
+			/** @var GF_Field $field */
1769
+			foreach ( $fields as $field ) {
1770 1770
 				if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1771
-				    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1772
-				    break;
1771
+					$edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1772
+					break;
1773 1773
 				}
1774 1774
 
1775 1775
 			}
@@ -1825,28 +1825,28 @@  discard block
 block discarded – undo
1825 1825
 	 */
1826 1826
 	private function filter_admin_only_fields( $fields = array(), $edit_fields = null, $form = array(), $view_id = 0 ) {
1827 1827
 
1828
-	    /**
1828
+		/**
1829 1829
 		 * @filter `gravityview/edit_entry/use_gf_admin_only_setting` When Edit tab isn't configured, should the Gravity Forms "Admin Only" field settings be used to control field display to non-admins? Default: true
1830
-	     * If the Edit Entry tab is not configured, adminOnly fields will not be shown to non-administrators.
1831
-	     * If the Edit Entry tab *is* configured, adminOnly fields will be shown to non-administrators, using the configured GV permissions
1832
-	     * @since 1.9.1
1833
-	     * @param boolean $use_gf_adminonly_setting True: Hide field if set to Admin Only in GF and the user is not an admin. False: show field based on GV permissions, ignoring GF permissions.
1834
-	     * @param array $form GF Form array
1835
-	     * @param int $view_id View ID
1836
-	     */
1837
-	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1838
-
1839
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1830
+		 * If the Edit Entry tab is not configured, adminOnly fields will not be shown to non-administrators.
1831
+		 * If the Edit Entry tab *is* configured, adminOnly fields will be shown to non-administrators, using the configured GV permissions
1832
+		 * @since 1.9.1
1833
+		 * @param boolean $use_gf_adminonly_setting True: Hide field if set to Admin Only in GF and the user is not an admin. False: show field based on GV permissions, ignoring GF permissions.
1834
+		 * @param array $form GF Form array
1835
+		 * @param int $view_id View ID
1836
+		 */
1837
+		$use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1838
+
1839
+		if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1840 1840
 			foreach( $fields as $k => $field ) {
1841 1841
 				if( $field->adminOnly ) {
1842
-				    unset( $fields[ $k ] );
1842
+					unset( $fields[ $k ] );
1843 1843
 				}
1844 1844
 			}
1845 1845
 			return array_values( $fields );
1846 1846
 		}
1847 1847
 
1848
-	    foreach( $fields as &$field ) {
1849
-		    $field->adminOnly = false;
1848
+		foreach( $fields as &$field ) {
1849
+			$field->adminOnly = false;
1850 1850
 		}
1851 1851
 
1852 1852
 		return $fields;
@@ -1866,13 +1866,13 @@  discard block
 block discarded – undo
1866 1866
 	 */
1867 1867
 	private function unselect_default_values( $form ) {
1868 1868
 
1869
-	    foreach ( $form['fields'] as &$field ) {
1869
+		foreach ( $form['fields'] as &$field ) {
1870 1870
 
1871 1871
 			if ( empty( $field->choices ) ) {
1872
-                continue;
1872
+				continue;
1873 1873
 			}
1874 1874
 
1875
-            foreach ( $field->choices as &$choice ) {
1875
+			foreach ( $field->choices as &$choice ) {
1876 1876
 				if ( \GV\Utils::get( $choice, 'isSelected' ) ) {
1877 1877
 					$choice['isSelected'] = false;
1878 1878
 				}
@@ -1909,36 +1909,36 @@  discard block
 block discarded – undo
1909 1909
 
1910 1910
 			if( 'checkbox' === $field->type ) {
1911 1911
 				foreach ( $field->get_entry_inputs() as $key => $input ) {
1912
-				    $input_id = $input['id'];
1913
-				    $choice = $field->choices[ $key ];
1914
-				    $value = \GV\Utils::get( $this->entry, $input_id );
1915
-				    $match = RGFormsModel::choice_value_match( $field, $choice, $value );
1916
-				    if( $match ) {
1917
-				        $field->choices[ $key ]['isSelected'] = true;
1918
-				    }
1912
+					$input_id = $input['id'];
1913
+					$choice = $field->choices[ $key ];
1914
+					$value = \GV\Utils::get( $this->entry, $input_id );
1915
+					$match = RGFormsModel::choice_value_match( $field, $choice, $value );
1916
+					if( $match ) {
1917
+						$field->choices[ $key ]['isSelected'] = true;
1918
+					}
1919 1919
 				}
1920 1920
 			} else {
1921 1921
 
1922 1922
 				// We need to run through each field to set the default values
1923 1923
 				foreach ( $this->entry as $field_id => $field_value ) {
1924 1924
 
1925
-				    if( floatval( $field_id ) === floatval( $field->id ) ) {
1925
+					if( floatval( $field_id ) === floatval( $field->id ) ) {
1926 1926
 
1927
-				        if( 'list' === $field->type ) {
1928
-				            $list_rows = maybe_unserialize( $field_value );
1927
+						if( 'list' === $field->type ) {
1928
+							$list_rows = maybe_unserialize( $field_value );
1929 1929
 
1930
-				            $list_field_value = array();
1931
-				            foreach ( (array) $list_rows as $row ) {
1932
-				                foreach ( (array) $row as $column ) {
1933
-				                    $list_field_value[] = $column;
1934
-				                }
1935
-				            }
1930
+							$list_field_value = array();
1931
+							foreach ( (array) $list_rows as $row ) {
1932
+								foreach ( (array) $row as $column ) {
1933
+									$list_field_value[] = $column;
1934
+								}
1935
+							}
1936 1936
 
1937
-				            $field->defaultValue = serialize( $list_field_value );
1938
-				        } else {
1939
-				            $field->defaultValue = $field_value;
1940
-				        }
1941
-				    }
1937
+							$field->defaultValue = serialize( $list_field_value );
1938
+						} else {
1939
+							$field->defaultValue = $field_value;
1940
+						}
1941
+					}
1942 1942
 				}
1943 1943
 			}
1944 1944
 		}
@@ -1999,7 +1999,7 @@  discard block
 block discarded – undo
1999 1999
 			foreach ( $form['fields'] as &$field ) {
2000 2000
 				foreach ( $remove_conditions_rule as $_remove_conditions_r ) {
2001 2001
 
2002
-				    list( $rule_field_id, $rule_i ) = $_remove_conditions_r;
2002
+					list( $rule_field_id, $rule_i ) = $_remove_conditions_r;
2003 2003
 
2004 2004
 					if ( $field['id'] == $rule_field_id ) {
2005 2005
 						unset( $field->conditionalLogic['rules'][ $rule_i ] );
@@ -2050,7 +2050,7 @@  discard block
 block discarded – undo
2050 2050
 			return $has_conditional_logic;
2051 2051
 		}
2052 2052
 
2053
-	    /** @see GravityView_Edit_Entry_Render::filter_conditional_logic for filter documentation */
2053
+		/** @see GravityView_Edit_Entry_Render::filter_conditional_logic for filter documentation */
2054 2054
 		return apply_filters( 'gravityview/edit_entry/conditional_logic', $has_conditional_logic, $form );
2055 2055
 	}
2056 2056
 
@@ -2117,14 +2117,14 @@  discard block
 block discarded – undo
2117 2117
 
2118 2118
 		if( $echo && $error !== true ) {
2119 2119
 
2120
-	        $error = esc_html( $error );
2120
+			$error = esc_html( $error );
2121 2121
 
2122
-	        /**
2123
-	         * @since 1.9
2124
-	         */
2125
-	        if ( ! empty( $this->entry ) ) {
2126
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2127
-	        }
2122
+			/**
2123
+			 * @since 1.9
2124
+			 */
2125
+			if ( ! empty( $this->entry ) ) {
2126
+				$error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2127
+			}
2128 2128
 
2129 2129
 			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
2130 2130
 		}
Please login to merge, or discard this patch.
includes/class-gravityview-shortcode.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -48,8 +48,8 @@  discard block
 block discarded – undo
48 48
 		gravityview()->log->debug( '$passed_atts: ', array( 'data' => $passed_atts ) );
49 49
 
50 50
 		// Get details about the current View
51
-		if( !empty( $passed_atts['detail'] ) ) {
52
-			return $this->get_view_detail( $passed_atts['detail'] );
51
+		if ( ! empty( $passed_atts[ 'detail' ] ) ) {
52
+			return $this->get_view_detail( $passed_atts[ 'detail' ] );
53 53
 		}
54 54
 
55 55
 		$atts = $this->parse_and_sanitize_atts( $passed_atts );
@@ -85,16 +85,16 @@  discard block
 block discarded – undo
85 85
 		$filtered_atts = shortcode_atts( $supported_atts, $passed_atts, 'gravityview' );
86 86
 
87 87
 		// Only keep the passed attributes after making sure that they're valid pairs
88
-		$filtered_atts = array_intersect_key( (array) $passed_atts, $filtered_atts );
88
+		$filtered_atts = array_intersect_key( (array)$passed_atts, $filtered_atts );
89 89
 
90 90
 		$atts = array();
91 91
 
92
-		foreach( $filtered_atts as $key => $passed_value ) {
92
+		foreach ( $filtered_atts as $key => $passed_value ) {
93 93
 
94 94
 			// Allow using GravityView merge tags in shortcode attributes, like {get} and {created_by}
95 95
 			$passed_value = GravityView_Merge_Tags::replace_variables( $passed_value );
96 96
 
97
-			switch( $defaults[ $key ]['type'] ) {
97
+			switch ( $defaults[ $key ][ 'type' ] ) {
98 98
 
99 99
 				/**
100 100
 				 * Make sure number fields are numeric.
@@ -102,14 +102,14 @@  discard block
 block discarded – undo
102 102
 				 * @see http://php.net/manual/en/function.is-numeric.php#107326
103 103
 				 */
104 104
 				case 'number':
105
-					if( is_numeric( $passed_value ) ) {
105
+					if ( is_numeric( $passed_value ) ) {
106 106
 						$atts[ $key ] = ( $passed_value + 0 );
107 107
 					}
108 108
 					break;
109 109
 
110 110
 				/** @since 2.1 */
111 111
 				case 'operator':
112
-					if( GFFormsModel::is_valid_operator( $passed_value ) ) {
112
+					if ( GFFormsModel::is_valid_operator( $passed_value ) ) {
113 113
 						$atts[ $key ] = $passed_value;
114 114
 					}
115 115
 					break;
@@ -124,8 +124,8 @@  discard block
 block discarded – undo
124 124
 				 */
125 125
 				case 'select':
126 126
 				case 'radio':
127
-					$options = isset( $defaults[ $key ]['choices'] ) ? $defaults[ $key ]['choices'] : $defaults[ $key ]['options'];
128
-					if( in_array( $passed_value, array_keys( $options ) ) ) {
127
+					$options = isset( $defaults[ $key ][ 'choices' ] ) ? $defaults[ $key ][ 'choices' ] : $defaults[ $key ][ 'options' ];
128
+					if ( in_array( $passed_value, array_keys( $options ) ) ) {
129 129
 						$atts[ $key ] = $passed_value;
130 130
 					}
131 131
 					break;
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
 		$gravityview_view = GravityView_View::getInstance();
155 155
 		$return = '';
156 156
 
157
-		switch( $detail ) {
157
+		switch ( $detail ) {
158 158
 			case 'total_entries':
159 159
 				$return = number_format_i18n( $gravityview_view->getTotalEntries() );
160 160
 				break;
Please login to merge, or discard this patch.